[INFO] crate harvey-holt 0.1.0 is already in cache
[INFO] extracting crate harvey-holt 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/harvey-holt/0.1.0
[INFO] extracting crate harvey-holt 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/harvey-holt/0.1.0
[INFO] validating manifest of harvey-holt-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of harvey-holt-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing harvey-holt-0.1.0
[INFO] finished frobbing harvey-holt-0.1.0
[INFO] frobbed toml for harvey-holt-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/harvey-holt/0.1.0/Cargo.toml
[INFO] started frobbing harvey-holt-0.1.0
[INFO] finished frobbing harvey-holt-0.1.0
[INFO] frobbed toml for harvey-holt-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/harvey-holt/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting harvey-holt-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/harvey-holt/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cb974c0fbd3fd0d46d3c7c2a1d4fe18f437e0ea51d06082c18d8d7400d3dac9c
[INFO] running `"docker" "start" "-a" "cb974c0fbd3fd0d46d3c7c2a1d4fe18f437e0ea51d06082c18d8d7400d3dac9c"`
[INFO] [stderr]     Checking assert_approx_eq v1.1.0
[INFO] [stderr]     Checking harvey-holt v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:194:20
[INFO] [stderr]     |
[INFO] [stderr] 194 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 195 | |                 if city.longitude < 0.0 {
[INFO] [stderr] 196 | |                    Either::Right(city)
[INFO] [stderr] 197 | |                 } else {
[INFO] [stderr] 198 | |                     Either::Left(city)
[INFO] [stderr] 199 | |                 }
[INFO] [stderr] 200 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 194 |             } else if city.longitude < 0.0 {
[INFO] [stderr] 195 |    Either::Right(city)
[INFO] [stderr] 196 | } else {
[INFO] [stderr] 197 |     Either::Left(city)
[INFO] [stderr] 198 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:228:5
[INFO] [stderr]     |
[INFO] [stderr] 228 |     cities
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:227:18
[INFO] [stderr]     |
[INFO] [stderr] 227 |     let cities = sort_easterly(cities, longitude);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:240:5
[INFO] [stderr]     |
[INFO] [stderr] 240 |     cities
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:239:18
[INFO] [stderr]     |
[INFO] [stderr] 239 |     let cities = sort_northerly(cities, latitude, longitude);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter
[INFO] [stderr]   --> src/lib.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | use rand::{thread_rng, sample};
[INFO] [stderr]    |                        ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter
[INFO] [stderr]    --> src/lib.rs:101:18
[INFO] [stderr]     |
[INFO] [stderr] 101 |     let sample = sample(&mut rng, DATA.iter(), 1);
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:194:20
[INFO] [stderr]     |
[INFO] [stderr] 194 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 195 | |                 if city.longitude < 0.0 {
[INFO] [stderr] 196 | |                    Either::Right(city)
[INFO] [stderr] 197 | |                 } else {
[INFO] [stderr] 198 | |                     Either::Left(city)
[INFO] [stderr] 199 | |                 }
[INFO] [stderr] 200 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 194 |             } else if city.longitude < 0.0 {
[INFO] [stderr] 195 |    Either::Right(city)
[INFO] [stderr] 196 | } else {
[INFO] [stderr] 197 |     Either::Left(city)
[INFO] [stderr] 198 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:228:5
[INFO] [stderr]     |
[INFO] [stderr] 228 |     cities
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:227:18
[INFO] [stderr]     |
[INFO] [stderr] 227 |     let cities = sort_easterly(cities, longitude);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:240:5
[INFO] [stderr]     |
[INFO] [stderr] 240 |     cities
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:239:18
[INFO] [stderr]     |
[INFO] [stderr] 239 |     let cities = sort_northerly(cities, latitude, longitude);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:273:19
[INFO] [stderr]     |
[INFO] [stderr] 273 |         let lat = 40.4299986;
[INFO] [stderr]     |                   ^^^^^^^^^^ help: consider: `40.429_998_6`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:285:19
[INFO] [stderr]     |
[INFO] [stderr] 285 |         let lat = 40.4299986;
[INFO] [stderr]     |                   ^^^^^^^^^^ help: consider: `40.429_998_6`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:300:19
[INFO] [stderr]     |
[INFO] [stderr] 300 |         let lat = 40.4299986;
[INFO] [stderr]     |                   ^^^^^^^^^^ help: consider: `40.429_998_6`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:301:21
[INFO] [stderr]     |
[INFO] [stderr] 301 |         let long = -79.99998539;
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider: `79.999_985_39`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:319:23
[INFO] [stderr]     |
[INFO] [stderr] 319 |             latitude: 40.4299986,
[INFO] [stderr]     |                       ^^^^^^^^^^ help: consider: `40.429_998_6`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:320:25
[INFO] [stderr]     |
[INFO] [stderr] 320 |             longitude: -79.99998539,
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: consider: `79.999_985_39`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:338:23
[INFO] [stderr]     |
[INFO] [stderr] 338 |             latitude: 7.518958353,
[INFO] [stderr]     |                       ^^^^^^^^^^^ help: consider: `7.518_958_353`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:339:25
[INFO] [stderr]     |
[INFO] [stderr] 339 |             longitude: -78.16601465,
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: consider: `78.166_014_65`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:355:21
[INFO] [stderr]     |
[INFO] [stderr] 355 |         let long = -79.99998539;
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider: `79.999_985_39`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:358:13
[INFO] [stderr]     |
[INFO] [stderr] 358 |             100.00001461
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: consider: `100.000_014_61`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:364:14
[INFO] [stderr]     |
[INFO] [stderr] 364 |             -100.00001461
[INFO] [stderr]     |              ^^^^^^^^^^^^ help: consider: `100.000_014_61`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:370:21
[INFO] [stderr]     |
[INFO] [stderr] 370 |         let long = -79.99998539;
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider: `79.999_985_39`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:382:21
[INFO] [stderr]     |
[INFO] [stderr] 382 |         let long = -79.99998539;
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider: `79.999_985_39`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:397:19
[INFO] [stderr]     |
[INFO] [stderr] 397 |         let lat = 40.4299986;
[INFO] [stderr]     |                   ^^^^^^^^^^ help: consider: `40.429_998_6`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:398:21
[INFO] [stderr]     |
[INFO] [stderr] 398 |         let long = -79.99998539;
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider: `79.999_985_39`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:416:23
[INFO] [stderr]     |
[INFO] [stderr] 416 |             latitude: 40.4299986,
[INFO] [stderr]     |                       ^^^^^^^^^^ help: consider: `40.429_998_6`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:417:25
[INFO] [stderr]     |
[INFO] [stderr] 417 |             longitude: -79.99998539,
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: consider: `79.999_985_39`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:435:23
[INFO] [stderr]     |
[INFO] [stderr] 435 |             latitude: 7.518958353,
[INFO] [stderr]     |                       ^^^^^^^^^^^ help: consider: `7.518_958_353`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:436:25
[INFO] [stderr]     |
[INFO] [stderr] 436 |             longitude: -78.16601465,
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: consider: `78.166_014_65`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:454:23
[INFO] [stderr]     |
[INFO] [stderr] 454 |             latitude: 40.4299986,
[INFO] [stderr]     |                       ^^^^^^^^^^ help: consider: `40.429_998_6`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:455:25
[INFO] [stderr]     |
[INFO] [stderr] 455 |             longitude: -79.99998539,
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: consider: `79.999_985_39`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:478:23
[INFO] [stderr]     |
[INFO] [stderr] 478 |             latitude: 7.518958353,
[INFO] [stderr]     |                       ^^^^^^^^^^^ help: consider: `7.518_958_353`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:479:25
[INFO] [stderr]     |
[INFO] [stderr] 479 |             longitude: -78.16601465,
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: consider: `78.166_014_65`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter
[INFO] [stderr]   --> src/lib.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | use rand::{thread_rng, sample};
[INFO] [stderr]    |                        ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter
[INFO] [stderr]    --> src/lib.rs:101:18
[INFO] [stderr]     |
[INFO] [stderr] 101 |     let sample = sample(&mut rng, DATA.iter(), 1);
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.30s
[INFO] running `"docker" "inspect" "cb974c0fbd3fd0d46d3c7c2a1d4fe18f437e0ea51d06082c18d8d7400d3dac9c"`
[INFO] running `"docker" "rm" "-f" "cb974c0fbd3fd0d46d3c7c2a1d4fe18f437e0ea51d06082c18d8d7400d3dac9c"`
[INFO] [stdout] cb974c0fbd3fd0d46d3c7c2a1d4fe18f437e0ea51d06082c18d8d7400d3dac9c