[INFO] crate harsh 0.1.5 is already in cache [INFO] extracting crate harsh 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/harsh/0.1.5 [INFO] extracting crate harsh 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/harsh/0.1.5 [INFO] validating manifest of harsh-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of harsh-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing harsh-0.1.5 [INFO] finished frobbing harsh-0.1.5 [INFO] frobbed toml for harsh-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/harsh/0.1.5/Cargo.toml [INFO] started frobbing harsh-0.1.5 [INFO] finished frobbing harsh-0.1.5 [INFO] frobbed toml for harsh-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/harsh/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting harsh-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/harsh/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ebebf0df4aa2364af61cb9de88b5b26166228af8d71f577cc2af764e4e19a5de [INFO] running `"docker" "start" "-a" "ebebf0df4aa2364af61cb9de88b5b26166228af8d71f577cc2af764e4e19a5de"` [INFO] [stderr] Checking harsh v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/custom_params.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | const TEST_CASES: [(&'static str, &'static [u64]); 14] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/custom_params.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | const TEST_CASES: [(&'static str, &'static [u64]); 14] = [ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:6:42 [INFO] [stderr] | [INFO] [stderr] 6 | ("onqr0bk58p642wldq14djmw21ygl39", &[928728]), [INFO] [stderr] | ^^^^^^ help: consider: `928_728` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:11:42 [INFO] [stderr] | [INFO] [stderr] 11 | ("m3d5a6yn875rae8y81a94gr9kbwpqo", &[1000000000000]), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:12:42 [INFO] [stderr] | [INFO] [stderr] 12 | ("1q3y98ln48w96kpo0wgk314w5mak2d", &[9007199254740991]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | &[10000000000, 0, 0, 0, 999999999999999], [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | &[10000000000, 0, 0, 0, 999999999999999], [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `999_999_999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:23:11 [INFO] [stderr] | [INFO] [stderr] 23 | &[9007199254740991, 9007199254740991, 9007199254740991], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | &[9007199254740991, 9007199254740991, 9007199254740991], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:23:47 [INFO] [stderr] | [INFO] [stderr] 23 | &[9007199254740991, 9007199254740991, 9007199254740991], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:27:11 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:27:47 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/custom_params.rs:27:59 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/custom_params_hex.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | const TEST_CASES: [(&'static str, &'static str); 8] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/custom_params_hex.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | const TEST_CASES: [(&'static str, &'static str); 8] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/default_params.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | const TEST_CASES: [(&'static str, &'static [u64]); 14] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/default_params.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | const TEST_CASES: [(&'static str, &'static [u64]); 14] = [ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | ("R8ZN0", &[928728]), [INFO] [stderr] | ^^^^^^ help: consider: `928_728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | ("gLpmopgO6", &[1000000000000]), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | ("lEW77X7g527", &[9007199254740991]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | &[10000000000, 0, 0, 0, 999999999999999], [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | &[10000000000, 0, 0, 0, 999999999999999], [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `999_999_999_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:23:11 [INFO] [stderr] | [INFO] [stderr] 23 | &[9007199254740991, 9007199254740991, 9007199254740991], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | &[9007199254740991, 9007199254740991, 9007199254740991], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:23:47 [INFO] [stderr] | [INFO] [stderr] 23 | &[9007199254740991, 9007199254740991, 9007199254740991], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:27:11 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:27:47 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/default_params.rs:27:59 [INFO] [stderr] | [INFO] [stderr] 27 | &[1000000001, 1000000002, 1000000003, 1000000004, 1000000005], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/default_params_hex.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | const TEST_CASES: [(&'static str, &'static str); 8] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/default_params_hex.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | const TEST_CASES: [(&'static str, &'static str); 8] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/min_length.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | const NUMBERS: &'static [u64] = &[1, 2, 3]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/harsh.rs:427:28 [INFO] [stderr] | [INFO] [stderr] 427 | harsh.encode(&[1226198605112]).expect("failed to encode"), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_226_198_605_112` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/harsh.rs:472:15 [INFO] [stderr] | [INFO] [stderr] 472 | &[1226198605112], [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_226_198_605_112` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.48s [INFO] running `"docker" "inspect" "ebebf0df4aa2364af61cb9de88b5b26166228af8d71f577cc2af764e4e19a5de"` [INFO] running `"docker" "rm" "-f" "ebebf0df4aa2364af61cb9de88b5b26166228af8d71f577cc2af764e4e19a5de"` [INFO] [stdout] ebebf0df4aa2364af61cb9de88b5b26166228af8d71f577cc2af764e4e19a5de