[INFO] crate handoff_counter 0.8.5 is already in cache
[INFO] extracting crate handoff_counter 0.8.5 into work/ex/clippy-test-run/sources/stable/reg/handoff_counter/0.8.5
[INFO] extracting crate handoff_counter 0.8.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/handoff_counter/0.8.5
[INFO] validating manifest of handoff_counter-0.8.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of handoff_counter-0.8.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing handoff_counter-0.8.5
[INFO] finished frobbing handoff_counter-0.8.5
[INFO] frobbed toml for handoff_counter-0.8.5 written to work/ex/clippy-test-run/sources/stable/reg/handoff_counter/0.8.5/Cargo.toml
[INFO] started frobbing handoff_counter-0.8.5
[INFO] finished frobbing handoff_counter-0.8.5
[INFO] frobbed toml for handoff_counter-0.8.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/handoff_counter/0.8.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting handoff_counter-0.8.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/handoff_counter/0.8.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 36ab61db4c5d92ff97f8c42a993bbb78e3a5221b4df078e2e31effecf07d648d
[INFO] running `"docker" "start" "-a" "36ab61db4c5d92ff97f8c42a993bbb78e3a5221b4df078e2e31effecf07d648d"`
[INFO] [stderr]     Checking handoff_counter v0.8.5 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handoff_counter.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handoff_counter.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             tier: tier,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `tier`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handoff_counter.rs:77:13
[INFO] [stderr]    |
[INFO] [stderr] 77 |             slots: slots,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `slots`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handoff_counter.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handoff_counter.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             tier: tier,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `tier`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handoff_counter.rs:77:13
[INFO] [stderr]    |
[INFO] [stderr] 77 |             slots: slots,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `slots`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/handoff_counter.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let mut v = self.vals.get_mut(&self.id).unwrap();
[INFO] [stderr]    |             ----^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/handoff_counter.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 | /             match self.slots.get(&id) {
[INFO] [stderr] 63 | |                 Some(&v) => { slots.insert(id, v); }
[INFO] [stderr] 64 | |                 None => {}
[INFO] [stderr] 65 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(&v) = self.slots.get(&id) { slots.insert(id, v); }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/handoff_counter.rs:148:31
[INFO] [stderr]     |
[INFO] [stderr] 148 |             self.vals.values().fold(0, |s,&v| s+v)
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/bin/simulate.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |         let i = rng.gen::<usize>() % nodes.len();
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/bin/simulate.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 |             let mut j;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/bin/simulate.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |         let i = rng.gen::<usize>() % nodes.len();
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/bin/simulate.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 |             let mut j;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/handoff_counter.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let mut v = self.vals.get_mut(&self.id).unwrap();
[INFO] [stderr]    |             ----^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/handoff_counter.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 | /             match self.slots.get(&id) {
[INFO] [stderr] 63 | |                 Some(&v) => { slots.insert(id, v); }
[INFO] [stderr] 64 | |                 None => {}
[INFO] [stderr] 65 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(&v) = self.slots.get(&id) { slots.insert(id, v); }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/handoff_counter.rs:148:31
[INFO] [stderr]     |
[INFO] [stderr] 148 |             self.vals.values().fold(0, |s,&v| s+v)
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `Env`
[INFO] [stderr]   --> src/bin/simulate.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | type Env<'a> = HashMap<&'a str, Cnt<'a>>;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/simulate.rs:50:22
[INFO] [stderr]    |
[INFO] [stderr] 50 |             c1.merge(env.get(&id2).unwrap());
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&env[&id2]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/bin/simulate.rs:78:28
[INFO] [stderr]    |
[INFO] [stderr] 78 |         assert!(rand_trace(100000, 30, 20, 20) == 0);
[INFO] [stderr]    |                            ^^^^^^ help: consider: `100_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `Env`
[INFO] [stderr]   --> src/bin/simulate.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | type Env<'a> = HashMap<&'a str, Cnt<'a>>;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/simulate.rs:50:22
[INFO] [stderr]    |
[INFO] [stderr] 50 |             c1.merge(env.get(&id2).unwrap());
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&env[&id2]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.91s
[INFO] running `"docker" "inspect" "36ab61db4c5d92ff97f8c42a993bbb78e3a5221b4df078e2e31effecf07d648d"`
[INFO] running `"docker" "rm" "-f" "36ab61db4c5d92ff97f8c42a993bbb78e3a5221b4df078e2e31effecf07d648d"`
[INFO] [stdout] 36ab61db4c5d92ff97f8c42a993bbb78e3a5221b4df078e2e31effecf07d648d