[INFO] crate hamcrest2 0.2.3 is already in cache [INFO] extracting crate hamcrest2 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/hamcrest2/0.2.3 [INFO] extracting crate hamcrest2 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hamcrest2/0.2.3 [INFO] validating manifest of hamcrest2-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hamcrest2-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hamcrest2-0.2.3 [INFO] finished frobbing hamcrest2-0.2.3 [INFO] frobbed toml for hamcrest2-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/hamcrest2/0.2.3/Cargo.toml [INFO] started frobbing hamcrest2-0.2.3 [INFO] finished frobbing hamcrest2-0.2.3 [INFO] frobbed toml for hamcrest2-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hamcrest2/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hamcrest2-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hamcrest2/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd8080a0d9cccbd0282259c508c1adcbc10a7e618e35450edfa2184c4ed00712 [INFO] running `"docker" "start" "-a" "bd8080a0d9cccbd0282259c508c1adcbc10a7e618e35450edfa2184c4ed00712"` [INFO] [stderr] Checking hamcrest2 v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/empty.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | assert_that!(&vec![1, 2, 3], not(empty())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/empty.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | let slice: &[i32] = &vec![1, 2, 3]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/contain.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | assert_that!(&vec![1, 2, 3], contains(vec![1, 2])); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/contain.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | assert_that!(&vec![1, 2, 3], not(contains(vec![4]))); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/contain.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | let slice: &[i32] = &vec![1, 2, 3]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/contain.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | assert_that!(&vec![1, 2, 3], contains(vec![1, 2, 3]).exactly()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/contain.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | assert_that!(&vec![1, 2, 3], not(contains(vec![1, 2]).exactly())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/contain.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | assert_that!(&vec![1, 2, 3], contains(vec![1, 2]).in_order()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/contain.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | assert_that!(&vec![1, 2, 3], not(contains(vec![1, 3]).in_order())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/contain.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | assert_that!(&vec![1, 2, 3], contains(vec![1, 3]).in_order()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/contain.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | assert_that!(&vec![1, 2, 3], not(contains(vec![2, 3]).in_order())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/all.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | &vec![1, 2, 3], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/close_to.rs:20:46 [INFO] [stderr] | [INFO] [stderr] 20 | assert_that!(1e-40f32, not(close_to(0.0, 0.000001))); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> tests/path_exists.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | Path::new(&path.unwrap_or(default.to_string())).to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| default.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/len.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | assert_that!(&vec![1, 2, 3], len(3)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/len.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | assert_that!(&vec![1, 2, 3], is(len(3))); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/len.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | let slice: &[i32] = &vec![1, 2, 3]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/any.rs:23:7 [INFO] [stderr] | [INFO] [stderr] 23 | &vec![1, 2, 3], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.46s [INFO] running `"docker" "inspect" "bd8080a0d9cccbd0282259c508c1adcbc10a7e618e35450edfa2184c4ed00712"` [INFO] running `"docker" "rm" "-f" "bd8080a0d9cccbd0282259c508c1adcbc10a7e618e35450edfa2184c4ed00712"` [INFO] [stdout] bd8080a0d9cccbd0282259c508c1adcbc10a7e618e35450edfa2184c4ed00712