[INFO] crate half_edge_mesh 1.1.8 is already in cache [INFO] extracting crate half_edge_mesh 1.1.8 into work/ex/clippy-test-run/sources/stable/reg/half_edge_mesh/1.1.8 [INFO] extracting crate half_edge_mesh 1.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/half_edge_mesh/1.1.8 [INFO] validating manifest of half_edge_mesh-1.1.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of half_edge_mesh-1.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing half_edge_mesh-1.1.8 [INFO] finished frobbing half_edge_mesh-1.1.8 [INFO] frobbed toml for half_edge_mesh-1.1.8 written to work/ex/clippy-test-run/sources/stable/reg/half_edge_mesh/1.1.8/Cargo.toml [INFO] started frobbing half_edge_mesh-1.1.8 [INFO] finished frobbing half_edge_mesh-1.1.8 [INFO] frobbed toml for half_edge_mesh-1.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/half_edge_mesh/1.1.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting half_edge_mesh-1.1.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/half_edge_mesh/1.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d592ee3b41dc3837f2060ddde91a99ec1506d8ff1484080c783c943d3e1ab0a3 [INFO] running `"docker" "start" "-a" "d592ee3b41dc3837f2060ddde91a99ec1506d8ff1484080c783c943d3e1ab0a3"` [INFO] [stderr] Checking half_edge_mesh v1.1.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/edge.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/edge.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/edge.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/face.rs:21:7 [INFO] [stderr] | [INFO] [stderr] 21 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/face.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/face.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iterators.rs:109:7 [INFO] [stderr] | [INFO] [stderr] 109 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/edge.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/edge.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/edge.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vert.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/face.rs:21:7 [INFO] [stderr] | [INFO] [stderr] 21 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/face.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/face.rs:34:7 [INFO] [stderr] | [INFO] [stderr] 34 | edge: edge, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iterators.rs:109:7 [INFO] [stderr] | [INFO] [stderr] 109 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/mesh.rs:337:7 [INFO] [stderr] | [INFO] [stderr] 337 | base_edge.borrow().origin.upgrade().map(|o| o.borrow_mut().take_edge(Ptr::new(base_edge))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(o) = base_edge.borrow().origin.upgrade() { o.borrow_mut().take_edge(Ptr::new(base_edge)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/mesh.rs:420:11 [INFO] [stderr] | [INFO] [stderr] 420 | face_edge.borrow().get_origin().map(|o| o.borrow_mut().set_edge_rc(& face_edge)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(o) = face_edge.borrow().get_origin() { o.borrow_mut().set_edge_rc(& face_edge) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/mesh.rs:589:7 [INFO] [stderr] | [INFO] [stderr] 589 | edge_b.next.upgrade() [INFO] [stderr] | _______^ [INFO] [stderr] | |_______| [INFO] [stderr] | || [INFO] [stderr] 590 | || .map(|next: EdgeRc| { [INFO] [stderr] 591 | || let mut next_bm = next.borrow_mut(); [INFO] [stderr] 592 | || next_bm.set_face_rc(& new_face); // e.n.f = n_f [INFO] [stderr] ... || [INFO] [stderr] 596 | || .map(|o: VertRc| o.borrow_mut().set_edge_rc(& next)); // e.n.o.e = e.n [INFO] [stderr] 597 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(next) = edge_b.next.upgrade() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/mesh.rs:595:11 [INFO] [stderr] | [INFO] [stderr] 595 | next_bm.origin.upgrade() [INFO] [stderr] | ___________^ [INFO] [stderr] | |___________| [INFO] [stderr] | || [INFO] [stderr] 596 | || .map(|o: VertRc| o.borrow_mut().set_edge_rc(& next)); // e.n.o.e = e.n [INFO] [stderr] | ||________________________________________________________________^- help: try this: `if let Some(o) = next_bm.origin.upgrade() { o.borrow_mut().set_edge_rc(& next) }` [INFO] [stderr] | |_________________________________________________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/util.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | for ref edge in mesh.edges.values() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let edge = &mesh.edges.values();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/util.rs:40:7 [INFO] [stderr] | [INFO] [stderr] 40 | for ref edge in mesh.edges.values() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let edge = &mesh.edges.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/util.rs:77:7 [INFO] [stderr] | [INFO] [stderr] 77 | for ref edge in mesh.edges.values() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let edge = &mesh.edges.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/util.rs:87:7 [INFO] [stderr] | [INFO] [stderr] 87 | for ref edge in mesh.edges.values() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let edge = &mesh.edges.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/mesh.rs:337:7 [INFO] [stderr] | [INFO] [stderr] 337 | base_edge.borrow().origin.upgrade().map(|o| o.borrow_mut().take_edge(Ptr::new(base_edge))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(o) = base_edge.borrow().origin.upgrade() { o.borrow_mut().take_edge(Ptr::new(base_edge)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/mesh.rs:420:11 [INFO] [stderr] | [INFO] [stderr] 420 | face_edge.borrow().get_origin().map(|o| o.borrow_mut().set_edge_rc(& face_edge)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(o) = face_edge.borrow().get_origin() { o.borrow_mut().set_edge_rc(& face_edge) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/mesh.rs:589:7 [INFO] [stderr] | [INFO] [stderr] 589 | edge_b.next.upgrade() [INFO] [stderr] | _______^ [INFO] [stderr] | |_______| [INFO] [stderr] | || [INFO] [stderr] 590 | || .map(|next: EdgeRc| { [INFO] [stderr] 591 | || let mut next_bm = next.borrow_mut(); [INFO] [stderr] 592 | || next_bm.set_face_rc(& new_face); // e.n.f = n_f [INFO] [stderr] ... || [INFO] [stderr] 596 | || .map(|o: VertRc| o.borrow_mut().set_edge_rc(& next)); // e.n.o.e = e.n [INFO] [stderr] 597 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(next) = edge_b.next.upgrade() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/mesh.rs:595:11 [INFO] [stderr] | [INFO] [stderr] 595 | next_bm.origin.upgrade() [INFO] [stderr] | ___________^ [INFO] [stderr] | |___________| [INFO] [stderr] | || [INFO] [stderr] 596 | || .map(|o: VertRc| o.borrow_mut().set_edge_rc(& next)); // e.n.o.e = e.n [INFO] [stderr] | ||________________________________________________________________^- help: try this: `if let Some(o) = next_bm.origin.upgrade() { o.borrow_mut().set_edge_rc(& next) }` [INFO] [stderr] | |_________________________________________________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/util.rs:30:7 [INFO] [stderr] | [INFO] [stderr] 30 | for ref edge in mesh.edges.values() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let edge = &mesh.edges.values();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/util.rs:40:7 [INFO] [stderr] | [INFO] [stderr] 40 | for ref edge in mesh.edges.values() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let edge = &mesh.edges.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/util.rs:77:7 [INFO] [stderr] | [INFO] [stderr] 77 | for ref edge in mesh.edges.values() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let edge = &mesh.edges.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/util.rs:87:7 [INFO] [stderr] | [INFO] [stderr] 87 | for ref edge in mesh.edges.values() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let edge = &mesh.edges.values();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.32s [INFO] running `"docker" "inspect" "d592ee3b41dc3837f2060ddde91a99ec1506d8ff1484080c783c943d3e1ab0a3"` [INFO] running `"docker" "rm" "-f" "d592ee3b41dc3837f2060ddde91a99ec1506d8ff1484080c783c943d3e1ab0a3"` [INFO] [stdout] d592ee3b41dc3837f2060ddde91a99ec1506d8ff1484080c783c943d3e1ab0a3