[INFO] crate hal 0.0.6 is already in cache [INFO] extracting crate hal 0.0.6 into work/ex/clippy-test-run/sources/stable/reg/hal/0.0.6 [INFO] extracting crate hal 0.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hal/0.0.6 [INFO] validating manifest of hal-0.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hal-0.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hal-0.0.6 [INFO] finished frobbing hal-0.0.6 [INFO] frobbed toml for hal-0.0.6 written to work/ex/clippy-test-run/sources/stable/reg/hal/0.0.6/Cargo.toml [INFO] started frobbing hal-0.0.6 [INFO] finished frobbing hal-0.0.6 [INFO] frobbed toml for hal-0.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hal/0.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hal-0.0.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hal/0.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c8a850aa419ad730a59c1f4c0ab814883b7c35cb7467ec0e69a8d1b337c7584 [INFO] running `"docker" "start" "-a" "9c8a850aa419ad730a59c1f4c0ab814883b7c35cb7467ec0e69a8d1b337c7584"` [INFO] [stderr] Checking hal v0.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:33:64 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_hal_state(&self) -> HalState { HalState::I64(*self as i64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 38 | to_hal_state_impl_i64! { isize, i8, i16, i32, i64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:33:64 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_hal_state(&self) -> HalState { HalState::I64(*self as i64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 38 | to_hal_state_impl_i64! { isize, i8, i16, i32, i64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:33:64 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_hal_state(&self) -> HalState { HalState::I64(*self as i64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 38 | to_hal_state_impl_i64! { isize, i8, i16, i32, i64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:43:64 [INFO] [stderr] | [INFO] [stderr] 43 | fn to_hal_state(&self) -> HalState { HalState::U64(*self as u64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 48 | to_hal_state_impl_u64! { usize, u8, u16, u32, u64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:43:64 [INFO] [stderr] | [INFO] [stderr] 43 | fn to_hal_state(&self) -> HalState { HalState::U64(*self as u64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 48 | to_hal_state_impl_u64! { usize, u8, u16, u32, u64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:43:64 [INFO] [stderr] | [INFO] [stderr] 43 | fn to_hal_state(&self) -> HalState { HalState::U64(*self as u64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 48 | to_hal_state_impl_u64! { usize, u8, u16, u32, u64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/state.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | impl ToHalState for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 88 | impl ToHalState for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/link.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let ref url = json["href"]; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let url = &json["href"];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `resource::Resource` [INFO] [stderr] --> src/resource.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Resource { [INFO] [stderr] 18 | | Resource { state: BTreeMap::new(), links: BTreeMap::new(), resources: BTreeMap::new() } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resource.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if self.links.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.links.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resource.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | if self.resources.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.resources.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:33:64 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_hal_state(&self) -> HalState { HalState::I64(*self as i64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 38 | to_hal_state_impl_i64! { isize, i8, i16, i32, i64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:33:64 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_hal_state(&self) -> HalState { HalState::I64(*self as i64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 38 | to_hal_state_impl_i64! { isize, i8, i16, i32, i64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:33:64 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_hal_state(&self) -> HalState { HalState::I64(*self as i64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 38 | to_hal_state_impl_i64! { isize, i8, i16, i32, i64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:43:64 [INFO] [stderr] | [INFO] [stderr] 43 | fn to_hal_state(&self) -> HalState { HalState::U64(*self as u64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 48 | to_hal_state_impl_u64! { usize, u8, u16, u32, u64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:43:64 [INFO] [stderr] | [INFO] [stderr] 43 | fn to_hal_state(&self) -> HalState { HalState::U64(*self as u64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 48 | to_hal_state_impl_u64! { usize, u8, u16, u32, u64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/state.rs:43:64 [INFO] [stderr] | [INFO] [stderr] 43 | fn to_hal_state(&self) -> HalState { HalState::U64(*self as u64) } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 48 | to_hal_state_impl_u64! { usize, u8, u16, u32, u64 } [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/state.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | impl ToHalState for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 88 | impl ToHalState for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/link.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let ref url = json["href"]; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let url = &json["href"];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `resource::Resource` [INFO] [stderr] --> src/resource.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Resource { [INFO] [stderr] 18 | | Resource { state: BTreeMap::new(), links: BTreeMap::new(), resources: BTreeMap::new() } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resource.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if self.links.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.links.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resource.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | if self.resources.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.resources.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> tests/lib.rs:157:37 [INFO] [stderr] | [INFO] [stderr] 157 | .add_state("total", (30.00 as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> tests/lib.rs:165:37 [INFO] [stderr] | [INFO] [stderr] 165 | .add_state("total", (20.00 as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.43s [INFO] running `"docker" "inspect" "9c8a850aa419ad730a59c1f4c0ab814883b7c35cb7467ec0e69a8d1b337c7584"` [INFO] running `"docker" "rm" "-f" "9c8a850aa419ad730a59c1f4c0ab814883b7c35cb7467ec0e69a8d1b337c7584"` [INFO] [stdout] 9c8a850aa419ad730a59c1f4c0ab814883b7c35cb7467ec0e69a8d1b337c7584