[INFO] crate gumdrop_derive 0.5.0 is already in cache [INFO] extracting crate gumdrop_derive 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/gumdrop_derive/0.5.0 [INFO] extracting crate gumdrop_derive 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gumdrop_derive/0.5.0 [INFO] validating manifest of gumdrop_derive-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gumdrop_derive-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gumdrop_derive-0.5.0 [INFO] finished frobbing gumdrop_derive-0.5.0 [INFO] frobbed toml for gumdrop_derive-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/gumdrop_derive/0.5.0/Cargo.toml [INFO] started frobbing gumdrop_derive-0.5.0 [INFO] finished frobbing gumdrop_derive-0.5.0 [INFO] frobbed toml for gumdrop_derive-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gumdrop_derive/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gumdrop_derive-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gumdrop_derive/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 22188bbee70518fcbd96ac24ef37e30101021cb3d60ec0df9d999498d7b3c769 [INFO] running `"docker" "start" "-a" "22188bbee70518fcbd96ac24ef37e30101021cb3d60ec0df9d999498d7b3c769"` [INFO] [stderr] Checking gumdrop_derive v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:795:9 [INFO] [stderr] | [INFO] [stderr] 795 | / if self.parse.is_some() { [INFO] [stderr] 796 | | if self.count { panic!("`count` and `parse` are mutually exclusive"); } [INFO] [stderr] 797 | | } [INFO] [stderr] | |_________^ help: try: `if self.parse.is_some() && self.count { panic!("`count` and `parse` are mutually exclusive"); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:1208:9 [INFO] [stderr] | [INFO] [stderr] 1208 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:1189:19 [INFO] [stderr] | [INFO] [stderr] 1189 | let res = match *self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1190 | | ParseFn::Default => quote!{ [INFO] [stderr] 1191 | | ::std::str::FromStr::from_str(_arg) [INFO] [stderr] 1192 | | .map_err(|e| ::gumdrop::Error::failed_parse(_opt, [INFO] [stderr] ... | [INFO] [stderr] 1205 | | } [INFO] [stderr] 1206 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:1233:9 [INFO] [stderr] | [INFO] [stderr] 1233 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:1212:19 [INFO] [stderr] | [INFO] [stderr] 1212 | let res = match *self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1213 | | ParseFn::Default => quote!{ [INFO] [stderr] 1214 | | ::std::str::FromStr::from_str(#expr) [INFO] [stderr] 1215 | | .map_err(|e| ::gumdrop::Error::failed_parse_default( [INFO] [stderr] ... | [INFO] [stderr] 1230 | | } [INFO] [stderr] 1231 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:795:9 [INFO] [stderr] | [INFO] [stderr] 795 | / if self.parse.is_some() { [INFO] [stderr] 796 | | if self.count { panic!("`count` and `parse` are mutually exclusive"); } [INFO] [stderr] 797 | | } [INFO] [stderr] | |_________^ help: try: `if self.parse.is_some() && self.count { panic!("`count` and `parse` are mutually exclusive"); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:1208:9 [INFO] [stderr] | [INFO] [stderr] 1208 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:1189:19 [INFO] [stderr] | [INFO] [stderr] 1189 | let res = match *self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1190 | | ParseFn::Default => quote!{ [INFO] [stderr] 1191 | | ::std::str::FromStr::from_str(_arg) [INFO] [stderr] 1192 | | .map_err(|e| ::gumdrop::Error::failed_parse(_opt, [INFO] [stderr] ... | [INFO] [stderr] 1205 | | } [INFO] [stderr] 1206 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:1233:9 [INFO] [stderr] | [INFO] [stderr] 1233 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:1212:19 [INFO] [stderr] | [INFO] [stderr] 1212 | let res = match *self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 1213 | | ParseFn::Default => quote!{ [INFO] [stderr] 1214 | | ::std::str::FromStr::from_str(#expr) [INFO] [stderr] 1215 | | .map_err(|e| ::gumdrop::Error::failed_parse_default( [INFO] [stderr] ... | [INFO] [stderr] 1230 | | } [INFO] [stderr] 1231 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 45 [INFO] [stderr] --> src/lib.rs:210:1 [INFO] [stderr] | [INFO] [stderr] 210 | / fn derive_options_struct(ast: &DeriveInput, fields: &Fields) -> TokenStream { [INFO] [stderr] 211 | | let mut pattern = Vec::new(); [INFO] [stderr] 212 | | let mut handle_opt = Vec::new(); [INFO] [stderr] 213 | | let mut short_names = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 591 | | expr.to_string().parse().expect("parse quote!") [INFO] [stderr] 592 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lib.rs:752:5 [INFO] [stderr] | [INFO] [stderr] 752 | / fn check(&self) { [INFO] [stderr] 753 | | if self.command { [INFO] [stderr] 754 | | if self.free { panic!("`command` and `free` are mutually exclusive"); } [INFO] [stderr] 755 | | if self.default.is_some() { panic!("`command` and `default` are mutually exclusive"); } [INFO] [stderr] ... | [INFO] [stderr] 797 | | } [INFO] [stderr] 798 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1294:55 [INFO] [stderr] | [INFO] [stderr] 1294 | data.args.iter().filter_map(|arg| match arg { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 1295 | | &GenericArgument::Type(ref ty) => Some(ty), [INFO] [stderr] 1296 | | _ => None [INFO] [stderr] 1297 | | }).next(), [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1294 | data.args.iter().filter_map(|arg| match *arg { [INFO] [stderr] 1295 | GenericArgument::Type(ref ty) => Some(ty), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 45 [INFO] [stderr] --> src/lib.rs:210:1 [INFO] [stderr] | [INFO] [stderr] 210 | / fn derive_options_struct(ast: &DeriveInput, fields: &Fields) -> TokenStream { [INFO] [stderr] 211 | | let mut pattern = Vec::new(); [INFO] [stderr] 212 | | let mut handle_opt = Vec::new(); [INFO] [stderr] 213 | | let mut short_names = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 591 | | expr.to_string().parse().expect("parse quote!") [INFO] [stderr] 592 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lib.rs:752:5 [INFO] [stderr] | [INFO] [stderr] 752 | / fn check(&self) { [INFO] [stderr] 753 | | if self.command { [INFO] [stderr] 754 | | if self.free { panic!("`command` and `free` are mutually exclusive"); } [INFO] [stderr] 755 | | if self.default.is_some() { panic!("`command` and `default` are mutually exclusive"); } [INFO] [stderr] ... | [INFO] [stderr] 797 | | } [INFO] [stderr] 798 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1294:55 [INFO] [stderr] | [INFO] [stderr] 1294 | data.args.iter().filter_map(|arg| match arg { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 1295 | | &GenericArgument::Type(ref ty) => Some(ty), [INFO] [stderr] 1296 | | _ => None [INFO] [stderr] 1297 | | }).next(), [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1294 | data.args.iter().filter_map(|arg| match *arg { [INFO] [stderr] 1295 | GenericArgument::Type(ref ty) => Some(ty), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.52s [INFO] running `"docker" "inspect" "22188bbee70518fcbd96ac24ef37e30101021cb3d60ec0df9d999498d7b3c769"` [INFO] running `"docker" "rm" "-f" "22188bbee70518fcbd96ac24ef37e30101021cb3d60ec0df9d999498d7b3c769"` [INFO] [stdout] 22188bbee70518fcbd96ac24ef37e30101021cb3d60ec0df9d999498d7b3c769