[INFO] crate guifast 0.1.0 is already in cache [INFO] extracting crate guifast 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/guifast/0.1.0 [INFO] extracting crate guifast 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/guifast/0.1.0 [INFO] validating manifest of guifast-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of guifast-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing guifast-0.1.0 [INFO] removed path dependency libflo from guifast-0.1.0 [INFO] removed path dependency libflo_error from guifast-0.1.0 [INFO] removed path dependency libflo_module from guifast-0.1.0 [INFO] removed path dependency mut_static from guifast-0.1.0 [INFO] finished frobbing guifast-0.1.0 [INFO] frobbed toml for guifast-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/guifast/0.1.0/Cargo.toml [INFO] started frobbing guifast-0.1.0 [INFO] removed path dependency libflo from guifast-0.1.0 [INFO] removed path dependency libflo_error from guifast-0.1.0 [INFO] removed path dependency libflo_module from guifast-0.1.0 [INFO] removed path dependency mut_static from guifast-0.1.0 [INFO] finished frobbing guifast-0.1.0 [INFO] frobbed toml for guifast-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/guifast/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting guifast-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/guifast/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c038c85ed92988bbe2152b95042a265ba91f44e68d1d7129c163ebb81df45c95 [INFO] running `"docker" "start" "-a" "c038c85ed92988bbe2152b95042a265ba91f44e68d1d7129c163ebb81df45c95"` [INFO] [stderr] Compiling sharedlib v6.0.0 [INFO] [stderr] Checking libflo_error v0.1.2 [INFO] [stderr] Checking mut_static v0.1.0 [INFO] [stderr] Compiling libflo_func v0.1.2 [INFO] [stderr] Compiling libflo_dynamic_event v0.1.2 [INFO] [stderr] Compiling libflo_event v0.1.2 [INFO] [stderr] Compiling guifast v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking libflo v0.1.2 [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:194:50 [INFO] [stderr] | [INFO] [stderr] 194 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:464:40 [INFO] [stderr] | [INFO] [stderr] 464 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:464:50 [INFO] [stderr] | [INFO] [stderr] 464 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:654:40 [INFO] [stderr] | [INFO] [stderr] 654 | const FIELDS: &'static [&'static str] = &["modules"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:654:50 [INFO] [stderr] | [INFO] [stderr] 654 | const FIELDS: &'static [&'static str] = &["modules"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:194:50 [INFO] [stderr] | [INFO] [stderr] 194 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:464:40 [INFO] [stderr] | [INFO] [stderr] 464 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:464:50 [INFO] [stderr] | [INFO] [stderr] 464 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:654:40 [INFO] [stderr] | [INFO] [stderr] 654 | const FIELDS: &'static [&'static str] = &["modules"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:654:50 [INFO] [stderr] | [INFO] [stderr] 654 | const FIELDS: &'static [&'static str] = &["modules"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:22:60 [INFO] [stderr] | [INFO] [stderr] 22 | "GuifastComponentSerde" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:241:57 [INFO] [stderr] | [INFO] [stderr] 241 | "GuifastModuleSerde" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:520:51 [INFO] [stderr] | [INFO] [stderr] 520 | "GuifastSerde" , 0 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/func/get.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | for (_, module_id) in module_map { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 16 | for module_id in module_map.values() { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:22:60 [INFO] [stderr] | [INFO] [stderr] 22 | "GuifastComponentSerde" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:241:57 [INFO] [stderr] | [INFO] [stderr] 241 | "GuifastModuleSerde" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/guifast-323530d01b3e992b/out/serde_types.rs:520:51 [INFO] [stderr] | [INFO] [stderr] 520 | "GuifastSerde" , 0 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/func/get.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | for (_, module_id) in module_map { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 16 | for module_id in module_map.values() { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.27s [INFO] running `"docker" "inspect" "c038c85ed92988bbe2152b95042a265ba91f44e68d1d7129c163ebb81df45c95"` [INFO] running `"docker" "rm" "-f" "c038c85ed92988bbe2152b95042a265ba91f44e68d1d7129c163ebb81df45c95"` [INFO] [stdout] c038c85ed92988bbe2152b95042a265ba91f44e68d1d7129c163ebb81df45c95