[INFO] crate guid-macro-impl 0.1.0 is already in cache [INFO] extracting crate guid-macro-impl 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/guid-macro-impl/0.1.0 [INFO] extracting crate guid-macro-impl 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/guid-macro-impl/0.1.0 [INFO] validating manifest of guid-macro-impl-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of guid-macro-impl-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing guid-macro-impl-0.1.0 [INFO] finished frobbing guid-macro-impl-0.1.0 [INFO] frobbed toml for guid-macro-impl-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/guid-macro-impl/0.1.0/Cargo.toml [INFO] started frobbing guid-macro-impl-0.1.0 [INFO] finished frobbing guid-macro-impl-0.1.0 [INFO] frobbed toml for guid-macro-impl-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/guid-macro-impl/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting guid-macro-impl-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/guid-macro-impl/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33c23c6947194ddf2be2ced569cd09e8c19e93d0da8c27de92834b9a61f6f525 [INFO] running `"docker" "start" "-a" "33c23c6947194ddf2be2ced569cd09e8c19e93d0da8c27de92834b9a61f6f525"` [INFO] [stderr] Checking debug-builders v0.1.0 [INFO] [stderr] Compiling debugtrace v0.1.0 [INFO] [stderr] Checking either v0.1.7 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Checking backtrace v0.1.8 [INFO] [stderr] Checking chomp v0.3.1 [INFO] [stderr] Checking guid-parser v0.1.0 [INFO] [stderr] Checking guid-macro-impl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / if let &Expr::Lit(ExprLit { lit: Lit::Str(ref lit), .. }) = &expr { [INFO] [stderr] 19 | | let parts = parse_only(chunks, lit.value().as_bytes()).unwrap().to_parts(); [INFO] [stderr] 20 | | [INFO] [stderr] 21 | | let data1: u32 = parts.0; [INFO] [stderr] ... | [INFO] [stderr] 48 | | panic!("illegal guid expr (expected string literal)"); [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | if let Expr::Lit(ExprLit { lit: Lit::Str(ref lit), .. }) = expr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / if let &Expr::Lit(ExprLit { lit: Lit::Str(ref lit), .. }) = &expr { [INFO] [stderr] 19 | | let parts = parse_only(chunks, lit.value().as_bytes()).unwrap().to_parts(); [INFO] [stderr] 20 | | [INFO] [stderr] 21 | | let data1: u32 = parts.0; [INFO] [stderr] ... | [INFO] [stderr] 48 | | panic!("illegal guid expr (expected string literal)"); [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | if let Expr::Lit(ExprLit { lit: Lit::Str(ref lit), .. }) = expr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.07s [INFO] running `"docker" "inspect" "33c23c6947194ddf2be2ced569cd09e8c19e93d0da8c27de92834b9a61f6f525"` [INFO] running `"docker" "rm" "-f" "33c23c6947194ddf2be2ced569cd09e8c19e93d0da8c27de92834b9a61f6f525"` [INFO] [stdout] 33c23c6947194ddf2be2ced569cd09e8c19e93d0da8c27de92834b9a61f6f525