[INFO] crate guid-create 0.1.1 is already in cache [INFO] extracting crate guid-create 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/guid-create/0.1.1 [INFO] extracting crate guid-create 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/guid-create/0.1.1 [INFO] validating manifest of guid-create-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of guid-create-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing guid-create-0.1.1 [INFO] finished frobbing guid-create-0.1.1 [INFO] frobbed toml for guid-create-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/guid-create/0.1.1/Cargo.toml [INFO] started frobbing guid-create-0.1.1 [INFO] finished frobbing guid-create-0.1.1 [INFO] frobbed toml for guid-create-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/guid-create/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting guid-create-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/guid-create/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 501c7fd484a6f0c38183b3214c9b55a142f4d811edd4def5f5151a504bfd95c0 [INFO] running `"docker" "start" "-a" "501c7fd484a6f0c38183b3214c9b55a142f4d811edd4def5f5151a504bfd95c0"` [INFO] [stderr] Compiling debugtrace v0.1.0 [INFO] [stderr] Checking either v0.1.7 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking chomp v0.3.1 [INFO] [stderr] Checking guid-parser v0.1.0 [INFO] [stderr] Checking guid v0.1.0 [INFO] [stderr] Checking guid-create v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:81:62 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn build_from_components(d1: u32, d2: u16, d3: u16, d4: &[u8; 8]) -> Self { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | for i in 0..4 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d[..4].clone_from_slice(&buf[..4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d[4..(2 + 4)].clone_from_slice(&buf[..2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d[6..(2 + 6)].clone_from_slice(&buf[..2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d[8..(8 + 8)].clone_from_slice(&d4[..8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `d[..16].clone_from_slice(&data[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:163:15 [INFO] [stderr] | [INFO] [stderr] 163 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d4[..2].clone_from_slice(&buf[..2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:171:15 [INFO] [stderr] | [INFO] [stderr] 171 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d4[2..(2 + 2)].clone_from_slice(&buf[..2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:179:15 [INFO] [stderr] | [INFO] [stderr] 179 | for i in 0..4 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d4[4..(4 + 4)].clone_from_slice(&buf[..4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `d`. [INFO] [stderr] --> src/lib.rs:194:12 [INFO] [stderr] | [INFO] [stderr] 194 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 194 | for in &mut d { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `arr` [INFO] [stderr] --> src/lib.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 270 | for (i, ) in arr.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `arr[..8].clone_from_slice(&self.data[8..(8 + 8)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:386:4 [INFO] [stderr] | [INFO] [stderr] 386 | 0x87935CDE, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8793_5CDE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:392:28 [INFO] [stderr] | [INFO] [stderr] 392 | assert_eq!(guid.data1(), 0x87935CDE); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8793_5CDE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:411:28 [INFO] [stderr] | [INFO] [stderr] 411 | assert_eq!(guid.data1(), 0x87935CDE); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8793_5CDE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:81:62 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn build_from_components(d1: u32, d2: u16, d3: u16, d4: &[u8; 8]) -> Self { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | for i in 0..4 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d[..4].clone_from_slice(&buf[..4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d[4..(2 + 4)].clone_from_slice(&buf[..2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d[6..(2 + 6)].clone_from_slice(&buf[..2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d[8..(8 + 8)].clone_from_slice(&d4[..8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `d[..16].clone_from_slice(&data[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:163:15 [INFO] [stderr] | [INFO] [stderr] 163 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d4[..2].clone_from_slice(&buf[..2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:171:15 [INFO] [stderr] | [INFO] [stderr] 171 | for i in 0..2 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d4[2..(2 + 2)].clone_from_slice(&buf[..2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:179:15 [INFO] [stderr] | [INFO] [stderr] 179 | for i in 0..4 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `d4[4..(4 + 4)].clone_from_slice(&buf[..4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `d`. [INFO] [stderr] --> src/lib.rs:194:12 [INFO] [stderr] | [INFO] [stderr] 194 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 194 | for in &mut d { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `arr` [INFO] [stderr] --> src/lib.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 270 | for (i, ) in arr.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `arr[..8].clone_from_slice(&self.data[8..(8 + 8)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.54s [INFO] running `"docker" "inspect" "501c7fd484a6f0c38183b3214c9b55a142f4d811edd4def5f5151a504bfd95c0"` [INFO] running `"docker" "rm" "-f" "501c7fd484a6f0c38183b3214c9b55a142f4d811edd4def5f5151a504bfd95c0"` [INFO] [stdout] 501c7fd484a6f0c38183b3214c9b55a142f4d811edd4def5f5151a504bfd95c0