[INFO] crate gtp-parser-generator 0.1.0 is already in cache [INFO] extracting crate gtp-parser-generator 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/gtp-parser-generator/0.1.0 [INFO] extracting crate gtp-parser-generator 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtp-parser-generator/0.1.0 [INFO] validating manifest of gtp-parser-generator-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gtp-parser-generator-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gtp-parser-generator-0.1.0 [INFO] finished frobbing gtp-parser-generator-0.1.0 [INFO] frobbed toml for gtp-parser-generator-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/gtp-parser-generator/0.1.0/Cargo.toml [INFO] started frobbing gtp-parser-generator-0.1.0 [INFO] finished frobbing gtp-parser-generator-0.1.0 [INFO] frobbed toml for gtp-parser-generator-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtp-parser-generator/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gtp-parser-generator-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gtp-parser-generator/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 68f4e777b3a778b7f6492520d1e361762ba61fec35beba7e9fdedb14052c2c38 [INFO] running `"docker" "start" "-a" "68f4e777b3a778b7f6492520d1e361762ba61fec35beba7e9fdedb14052c2c38"` [INFO] [stderr] Checking pom v1.1.0 [INFO] [stderr] Checking gtp-parser-generator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:39 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Command { name: first.clone(), id: id, args: rest }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:39 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Command { name: first.clone(), id: id, args: rest }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / macro_rules! first { [INFO] [stderr] 5 | | ( $a:tt $(, $rest:tt)* ) => ( $a ) [INFO] [stderr] 6 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / macro_rules! replace_expr { [INFO] [stderr] 9 | | ($_t:tt $sub:expr) => {$sub}; [INFO] [stderr] 10 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / macro_rules! commands { [INFO] [stderr] 13 | | [INFO] [stderr] 14 | | ( $(#[$attr:meta])* enum $enumer:ident { $($i:ident => $e:tt $( ( $($m:ident),* ) )* ; )* } ) => { [INFO] [stderr] 15 | | $( [INFO] [stderr] ... | [INFO] [stderr] 52 | | }; [INFO] [stderr] 53 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lexer.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let integer = one_of(b"123456789") - one_of(b"0123456789").repeat(0..) | sym(b'0'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(one_of(b"123456789") - one_of(b"0123456789").repeat(0..)) | sym(b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lexer.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let integer = one_of(b"123456789") - one_of(b"0123456789").repeat(0..) | sym(b'0'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(one_of(b"123456789") - one_of(b"0123456789").repeat(0..)) | sym(b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let ref first = parse[0]; [INFO] [stderr] | ----^^^^^^^^^------------ help: try: `let first = &parse[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let ref first = parse[0]; [INFO] [stderr] | ----^^^^^^^^^------------ help: try: `let first = &parse[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.51s [INFO] running `"docker" "inspect" "68f4e777b3a778b7f6492520d1e361762ba61fec35beba7e9fdedb14052c2c38"` [INFO] running `"docker" "rm" "-f" "68f4e777b3a778b7f6492520d1e361762ba61fec35beba7e9fdedb14052c2c38"` [INFO] [stdout] 68f4e777b3a778b7f6492520d1e361762ba61fec35beba7e9fdedb14052c2c38