[INFO] crate gtmpl 0.5.6 is already in cache [INFO] extracting crate gtmpl 0.5.6 into work/ex/clippy-test-run/sources/stable/reg/gtmpl/0.5.6 [INFO] extracting crate gtmpl 0.5.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtmpl/0.5.6 [INFO] validating manifest of gtmpl-0.5.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gtmpl-0.5.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gtmpl-0.5.6 [INFO] finished frobbing gtmpl-0.5.6 [INFO] frobbed toml for gtmpl-0.5.6 written to work/ex/clippy-test-run/sources/stable/reg/gtmpl/0.5.6/Cargo.toml [INFO] started frobbing gtmpl-0.5.6 [INFO] finished frobbing gtmpl-0.5.6 [INFO] frobbed toml for gtmpl-0.5.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtmpl/0.5.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gtmpl-0.5.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gtmpl/0.5.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ecb5dd16b8ed4692293f6d63cb927f71741a0f108a1fd6bcc77e04569ad753ac [INFO] running `"docker" "start" "-a" "ecb5dd16b8ed4692293f6d63cb927f71741a0f108a1fd6bcc77e04569ad753ac"` [INFO] [stderr] Compiling gtmpl_value v0.3.3 [INFO] [stderr] Compiling gtmpl_derive v0.3.3 [INFO] [stderr] Checking gtmpl v0.5.6 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/node.rs:492:48 [INFO] [stderr] | [INFO] [stderr] 492 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/node.rs:492:48 [INFO] [stderr] | [INFO] [stderr] 492 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/funcs.rs:143:10 [INFO] [stderr] | [INFO] [stderr] 143 | args.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/funcs.rs:166:10 [INFO] [stderr] | [INFO] [stderr] 166 | args.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/node.rs:492:48 [INFO] [stderr] | [INFO] [stderr] 492 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/node.rs:492:48 [INFO] [stderr] | [INFO] [stderr] 492 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/exec.rs:523:13 [INFO] [stderr] | [INFO] [stderr] 523 | let foo = Foo { foo: 1 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/exec.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | let foo = Foo { foo: 1 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/exec.rs:642:13 [INFO] [stderr] | [INFO] [stderr] 642 | let foo = Foo { foo: 1 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/exec.rs:654:13 [INFO] [stderr] | [INFO] [stderr] 654 | let foo = Foo { foo: 0 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/exec.rs:666:13 [INFO] [stderr] | [INFO] [stderr] 666 | let bar = Bar { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/exec.rs:680:13 [INFO] [stderr] | [INFO] [stderr] 680 | let bar = Bar { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/exec.rs:701:13 [INFO] [stderr] | [INFO] [stderr] 701 | let foo = Foo { foo: 1000 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/exec.rs:794:13 [INFO] [stderr] | [INFO] [stderr] 794 | let foo = Foo { foo: map }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/funcs.rs:143:10 [INFO] [stderr] | [INFO] [stderr] 143 | args.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/funcs.rs:166:10 [INFO] [stderr] | [INFO] [stderr] 166 | args.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/parse.rs:812:21 [INFO] [stderr] | [INFO] [stderr] 812 | assert_eq!(p.collect::>().len(), 12); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:224:38 [INFO] [stderr] | [INFO] [stderr] 224 | let s = sprintf("foo%v2000", &vec!["bar".into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["bar".into()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:229:33 [INFO] [stderr] | [INFO] [stderr] 229 | let s = sprintf("%+0v", &vec![1.into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1.into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:237:36 [INFO] [stderr] | [INFO] [stderr] 237 | let s = sprintf("%+-#10c", &vec![10000.into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[10000.into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:242:36 [INFO] [stderr] | [INFO] [stderr] 242 | let s = sprintf("%+-#10q", &vec![10000.into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[10000.into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:250:31 [INFO] [stderr] | [INFO] [stderr] 250 | let s = sprintf("%x", &vec!["foobar2000".into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["foobar2000".into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:255:31 [INFO] [stderr] | [INFO] [stderr] 255 | let s = sprintf("%X", &vec!["foobar2000".into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["foobar2000".into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:263:33 [INFO] [stderr] | [INFO] [stderr] 263 | let s = sprintf("%.6s", &vec!["foobar2000".into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["foobar2000".into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:271:37 [INFO] [stderr] | [INFO] [stderr] 271 | let s = sprintf("%[1]v %v", &vec!["foo".into(), "bar".into(), 2000.into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["foo".into(), "bar".into(), 2000.into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | &vec!["!".into(), "wtf".into(), "golang".into()], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["!".into(), "wtf".into(), "golang".into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:287:37 [INFO] [stderr] | [INFO] [stderr] 287 | let s = sprintf("foobar%d", &vec![2000.into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[2000.into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:292:33 [INFO] [stderr] | [INFO] [stderr] 292 | let s = sprintf("%+0d", &vec![1.into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1.into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/printf.rs:297:33 [INFO] [stderr] | [INFO] [stderr] 297 | let s = sprintf("%+0b", &vec![5.into()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[5.into()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.63s [INFO] running `"docker" "inspect" "ecb5dd16b8ed4692293f6d63cb927f71741a0f108a1fd6bcc77e04569ad753ac"` [INFO] running `"docker" "rm" "-f" "ecb5dd16b8ed4692293f6d63cb927f71741a0f108a1fd6bcc77e04569ad753ac"` [INFO] [stdout] ecb5dd16b8ed4692293f6d63cb927f71741a0f108a1fd6bcc77e04569ad753ac