[INFO] crate gtk-icon-cache 0.2.2 is already in cache [INFO] extracting crate gtk-icon-cache 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/gtk-icon-cache/0.2.2 [INFO] extracting crate gtk-icon-cache 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtk-icon-cache/0.2.2 [INFO] validating manifest of gtk-icon-cache-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gtk-icon-cache-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gtk-icon-cache-0.2.2 [INFO] finished frobbing gtk-icon-cache-0.2.2 [INFO] frobbed toml for gtk-icon-cache-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/gtk-icon-cache/0.2.2/Cargo.toml [INFO] started frobbing gtk-icon-cache-0.2.2 [INFO] finished frobbing gtk-icon-cache-0.2.2 [INFO] frobbed toml for gtk-icon-cache-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtk-icon-cache/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gtk-icon-cache-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gtk-icon-cache/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc3fa0f2002df970de9c918923b7e53c90393865f05231b266c42d6b470056c4 [INFO] running `"docker" "start" "-a" "cc3fa0f2002df970de9c918923b7e53c90393865f05231b266c42d6b470056c4"` [INFO] [stderr] Checking gtk-icon-cache v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:203:31 [INFO] [stderr] | [INFO] [stderr] 203 | assert_eq!(icon_hash, 2769241519); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_769_241_519` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:227:60 [INFO] [stderr] | [INFO] [stderr] 227 | assert_eq!(icon_name_hash("deepin-deb-installer"), 1927089920); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_927_089_920` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:166:25 [INFO] [stderr] | [INFO] [stderr] 166 | let ref dir_names = self.dir_names; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------ help: try: `let dir_names = &self.dir_names;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:166:25 [INFO] [stderr] | [INFO] [stderr] 166 | let ref dir_names = self.dir_names; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------ help: try: `let dir_names = &self.dir_names;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:63 [INFO] [stderr] | [INFO] [stderr] 185 | .fold(Wrapping(0u32), |r, &c| (r << 5) - r + Wrapping(c as u32)).0 [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:63 [INFO] [stderr] | [INFO] [stderr] 185 | .fold(Wrapping(0u32), |r, &c| (r << 5) - r + Wrapping(c as u32)).0 [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.09s [INFO] running `"docker" "inspect" "cc3fa0f2002df970de9c918923b7e53c90393865f05231b266c42d6b470056c4"` [INFO] running `"docker" "rm" "-f" "cc3fa0f2002df970de9c918923b7e53c90393865f05231b266c42d6b470056c4"` [INFO] [stdout] cc3fa0f2002df970de9c918923b7e53c90393865f05231b266c42d6b470056c4