[INFO] crate gtin-validate 1.2.0 is already in cache [INFO] extracting crate gtin-validate 1.2.0 into work/ex/clippy-test-run/sources/stable/reg/gtin-validate/1.2.0 [INFO] extracting crate gtin-validate 1.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtin-validate/1.2.0 [INFO] validating manifest of gtin-validate-1.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gtin-validate-1.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gtin-validate-1.2.0 [INFO] finished frobbing gtin-validate-1.2.0 [INFO] frobbed toml for gtin-validate-1.2.0 written to work/ex/clippy-test-run/sources/stable/reg/gtin-validate/1.2.0/Cargo.toml [INFO] started frobbing gtin-validate-1.2.0 [INFO] finished frobbing gtin-validate-1.2.0 [INFO] frobbed toml for gtin-validate-1.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtin-validate/1.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gtin-validate-1.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gtin-validate/1.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1a1fb523db76daca168daf6d3d3c493a59072eb24b2903bd6e3d798e8b0e3a7 [INFO] running `"docker" "start" "-a" "d1a1fb523db76daca168daf6d3d3c493a59072eb24b2903bd6e3d798e8b0e3a7"` [INFO] [stderr] Checking gtin-validate v1.2.0 (/opt/crater/workdir) [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking rusty-fork v0.2.1 [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utils/mod.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | for i in 2..bytes.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `2..=bytes.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Checking proptest v0.7.2 [INFO] [stderr] warning: unused import: `proptest::prelude::*` [INFO] [stderr] --> src/utils/mod.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | use proptest::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utils/mod.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | for i in 2..bytes.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `2..=bytes.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:62:40 [INFO] [stderr] | [INFO] [stderr] 62 | assert_eq!(compute_check_digit("000000000000".as_bytes()), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000000000000"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:63:40 [INFO] [stderr] | [INFO] [stderr] 63 | assert_eq!(compute_check_digit("123456789012".as_bytes()), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123456789012"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:64:40 [INFO] [stderr] | [INFO] [stderr] 64 | assert_eq!(compute_check_digit("123456789081".as_bytes()), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123456789081"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:65:40 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(compute_check_digit("036000291452".as_bytes()), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"036000291452"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:66:40 [INFO] [stderr] | [INFO] [stderr] 66 | assert_eq!(compute_check_digit("999999999993".as_bytes()), 3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"999999999993"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:67:40 [INFO] [stderr] | [INFO] [stderr] 67 | assert_eq!(compute_check_digit("0000000000000".as_bytes()), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"0000000000000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | assert_eq!(compute_check_digit("1234123412344".as_bytes()), 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1234123412344"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:69:40 [INFO] [stderr] | [INFO] [stderr] 69 | assert_eq!(compute_check_digit("9249874313545".as_bytes()), 5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"9249874313545"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:70:40 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(compute_check_digit("00000000000000".as_bytes()), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"00000000000000"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:71:40 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(compute_check_digit("01010101010104".as_bytes()), 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"01010101010104"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/utils/mod.rs:72:40 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(compute_check_digit("92498743135447".as_bytes()), 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"92498743135447"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.73s [INFO] running `"docker" "inspect" "d1a1fb523db76daca168daf6d3d3c493a59072eb24b2903bd6e3d798e8b0e3a7"` [INFO] running `"docker" "rm" "-f" "d1a1fb523db76daca168daf6d3d3c493a59072eb24b2903bd6e3d798e8b0e3a7"` [INFO] [stdout] d1a1fb523db76daca168daf6d3d3c493a59072eb24b2903bd6e3d798e8b0e3a7