[INFO] crate gtfs-structures 0.8.0 is already in cache [INFO] extracting crate gtfs-structures 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/gtfs-structures/0.8.0 [INFO] extracting crate gtfs-structures 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtfs-structures/0.8.0 [INFO] validating manifest of gtfs-structures-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gtfs-structures-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gtfs-structures-0.8.0 [INFO] finished frobbing gtfs-structures-0.8.0 [INFO] frobbed toml for gtfs-structures-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/gtfs-structures/0.8.0/Cargo.toml [INFO] started frobbing gtfs-structures-0.8.0 [INFO] finished frobbing gtfs-structures-0.8.0 [INFO] frobbed toml for gtfs-structures-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtfs-structures/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gtfs-structures-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gtfs-structures/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c943753bd1e3d657816dc840712fd9b3d5d7125e272d493b8c3fced0bc3479c [INFO] running `"docker" "start" "-a" "9c943753bd1e3d657816dc840712fd9b3d5d7125e272d493b8c3fced0bc3479c"` [INFO] [stderr] Checking zip v0.5.0 [INFO] [stderr] Checking gtfs-structures v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:253:8 [INFO] [stderr] | [INFO] [stderr] 253 | Ok(&v[0].parse()? * 3600u32 + &v[1].parse()? * 60u32 + &v[2].parse()?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `v[2].parse()?` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:624:27 [INFO] [stderr] | [INFO] [stderr] 624 | let stop_times = >fs.trips.get("trip1").unwrap().stop_times; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `>fs.trips["trip1"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:253:8 [INFO] [stderr] | [INFO] [stderr] 253 | Ok(&v[0].parse()? * 3600u32 + &v[1].parse()? * 60u32 + &v[2].parse()?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `v[2].parse()?` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.35s [INFO] running `"docker" "inspect" "9c943753bd1e3d657816dc840712fd9b3d5d7125e272d493b8c3fced0bc3479c"` [INFO] running `"docker" "rm" "-f" "9c943753bd1e3d657816dc840712fd9b3d5d7125e272d493b8c3fced0bc3479c"` [INFO] [stdout] 9c943753bd1e3d657816dc840712fd9b3d5d7125e272d493b8c3fced0bc3479c