[INFO] crate gtag 0.3.0 is already in cache
[INFO] extracting crate gtag 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/gtag/0.3.0
[INFO] extracting crate gtag 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtag/0.3.0
[INFO] validating manifest of gtag-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gtag-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gtag-0.3.0
[INFO] finished frobbing gtag-0.3.0
[INFO] frobbed toml for gtag-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/gtag/0.3.0/Cargo.toml
[INFO] started frobbing gtag-0.3.0
[INFO] finished frobbing gtag-0.3.0
[INFO] frobbed toml for gtag-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtag/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gtag-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gtag/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d397ed5303790a6d9d70492cb1deb997e9d7f496ebdd47a2ad9a1b17de2aa551
[INFO] running `"docker" "start" "-a" "d397ed5303790a6d9d70492cb1deb997e9d7f496ebdd47a2ad9a1b17de2aa551"`
[INFO] [stderr]     Checking gtag v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/main.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 |     tag_name
[INFO] [stderr]     |     ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/main.rs:106:20
[INFO] [stderr]     |
[INFO] [stderr] 106 |       let tag_name = pattern
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 107 | |                     .replace("##ii", &format!("{}",idx + 1))
[INFO] [stderr] 108 | |                     .replace("##i", &format!("{}",idx));
[INFO] [stderr]     | |_______________________________________________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     match delete {
[INFO] [stderr] 36 | |         false => tag_commits(get_commits(range), pattern, dry_run),
[INFO] [stderr] 37 | |         true => untag_commits(get_commits(range), pattern, dry_run)
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if delete { untag_commits(get_commits(range), pattern, dry_run) } else { tag_commits(get_commits(range), pattern, dry_run) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:59:45
[INFO] [stderr]    |
[INFO] [stderr] 59 |                               .filter(|sha| sha.len() > 0)
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sha.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/main.rs:109:5
[INFO] [stderr]     |
[INFO] [stderr] 109 |     tag_name
[INFO] [stderr]     |     ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/main.rs:106:20
[INFO] [stderr]     |
[INFO] [stderr] 106 |       let tag_name = pattern
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 107 | |                     .replace("##ii", &format!("{}",idx + 1))
[INFO] [stderr] 108 | |                     .replace("##i", &format!("{}",idx));
[INFO] [stderr]     | |_______________________________________________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     match delete {
[INFO] [stderr] 36 | |         false => tag_commits(get_commits(range), pattern, dry_run),
[INFO] [stderr] 37 | |         true => untag_commits(get_commits(range), pattern, dry_run)
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if delete { untag_commits(get_commits(range), pattern, dry_run) } else { tag_commits(get_commits(range), pattern, dry_run) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:59:45
[INFO] [stderr]    |
[INFO] [stderr] 59 |                               .filter(|sha| sha.len() > 0)
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sha.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.55s
[INFO] running `"docker" "inspect" "d397ed5303790a6d9d70492cb1deb997e9d7f496ebdd47a2ad9a1b17de2aa551"`
[INFO] running `"docker" "rm" "-f" "d397ed5303790a6d9d70492cb1deb997e9d7f496ebdd47a2ad9a1b17de2aa551"`
[INFO] [stdout] d397ed5303790a6d9d70492cb1deb997e9d7f496ebdd47a2ad9a1b17de2aa551