[INFO] crate grust 0.3.2 is already in cache [INFO] extracting crate grust 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/grust/0.3.2 [INFO] extracting crate grust 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grust/0.3.2 [INFO] validating manifest of grust-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grust-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grust-0.3.2 [INFO] finished frobbing grust-0.3.2 [INFO] frobbed toml for grust-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/grust/0.3.2/Cargo.toml [INFO] started frobbing grust-0.3.2 [INFO] finished frobbing grust-0.3.2 [INFO] frobbed toml for grust-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grust/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grust-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grust/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9fe813dfaa04c1c09eca29f193c7646d137dd60fb54e9e93931aaaefa3cf010a [INFO] running `"docker" "start" "-a" "9fe813dfaa04c1c09eca29f193c7646d137dd60fb54e9e93931aaaefa3cf010a"` [INFO] [stderr] Compiling glib-2-0-sys v0.46.4 [INFO] [stderr] Compiling gobject-2-0-sys v0.46.4 [INFO] [stderr] Checking gtypes v0.2.0 [INFO] [stderr] Checking grust v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | Error { ptr: ptr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flags.rs:42:39 [INFO] [stderr] | [INFO] [stderr] 42 | UnknownFlags { actual: flags, known_mask: known_mask } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `known_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gstr.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | OwnedGStr { ptr: ptr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mainloop.rs:290:26 [INFO] [stderr] | [INFO] [stderr] 290 | LoopRunner { mainloop: mainloop } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mainloop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | Error { ptr: ptr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/flags.rs:42:39 [INFO] [stderr] | [INFO] [stderr] 42 | UnknownFlags { actual: flags, known_mask: known_mask } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `known_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gstr.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | OwnedGStr { ptr: ptr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mainloop.rs:290:26 [INFO] [stderr] | [INFO] [stderr] 290 | LoopRunner { mainloop: mainloop } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mainloop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/util.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/util.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/util.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/util.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/flags.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn actual(&self) -> guint { self.actual } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/flags.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn unknown(&self) -> guint { self.actual & !self.known_mask } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/flags.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn known(&self) -> guint { self.actual & self.known_mask } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gstr.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | assert!(s.ends_with("\0"), [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/gstr.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | mem::transmute(CStr::from_ptr(ptr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(CStr::from_ptr(ptr) as *const std::ffi::CStr as *const gstr::Utf8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gtype.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn to_raw(&self) -> raw::GType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mainloop::LoopRunner` [INFO] [stderr] --> src/mainloop.rs:284:5 [INFO] [stderr] | [INFO] [stderr] 284 | / pub fn new() -> LoopRunner { [INFO] [stderr] 285 | | unsafe { [INFO] [stderr] 286 | | let ctx = ffi::g_main_context_new(); [INFO] [stderr] 287 | | let mainloop = ffi::g_main_loop_new(ctx, FALSE); [INFO] [stderr] ... | [INFO] [stderr] 291 | | } [INFO] [stderr] 292 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 283 | impl Default for mainloop::LoopRunner { [INFO] [stderr] 284 | fn default() -> Self { [INFO] [stderr] 285 | Self::new() [INFO] [stderr] 286 | } [INFO] [stderr] 287 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/object.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | unsafe { transmute(source) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&*(source as *const T as *const U)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/quark.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | if !s.ends_with("\0") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/quark.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn to_c_str(&self) -> &'static CStr { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/quark.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn to_bytes(&self) -> &'static [u8] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/quark.rs:76:19 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn to_raw(&self) -> ffi::GQuark { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn escape_bytestring<'a>(s: &'a [u8]) -> Cow<'a, str> { [INFO] [stderr] 36 | | if s.is_ascii() { [INFO] [stderr] 37 | | let s = unsafe { str::from_utf8_unchecked(s) }; [INFO] [stderr] 38 | | return s.into(); [INFO] [stderr] ... | [INFO] [stderr] 43 | | string.into() [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/flags.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn actual(&self) -> guint { self.actual } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/flags.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn unknown(&self) -> guint { self.actual & !self.known_mask } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/flags.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn known(&self) -> guint { self.actual & self.known_mask } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/gstr.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | assert!(s.ends_with("\0"), [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/gstr.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | mem::transmute(CStr::from_ptr(ptr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(CStr::from_ptr(ptr) as *const std::ffi::CStr as *const gstr::Utf8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gtype.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn to_raw(&self) -> raw::GType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mainloop::LoopRunner` [INFO] [stderr] --> src/mainloop.rs:284:5 [INFO] [stderr] | [INFO] [stderr] 284 | / pub fn new() -> LoopRunner { [INFO] [stderr] 285 | | unsafe { [INFO] [stderr] 286 | | let ctx = ffi::g_main_context_new(); [INFO] [stderr] 287 | | let mainloop = ffi::g_main_loop_new(ctx, FALSE); [INFO] [stderr] ... | [INFO] [stderr] 291 | | } [INFO] [stderr] 292 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 283 | impl Default for mainloop::LoopRunner { [INFO] [stderr] 284 | fn default() -> Self { [INFO] [stderr] 285 | Self::new() [INFO] [stderr] 286 | } [INFO] [stderr] 287 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/object.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | unsafe { transmute(source) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&*(source as *const T as *const U)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/quark.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | if !s.ends_with("\0") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/quark.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn to_c_str(&self) -> &'static CStr { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/quark.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn to_bytes(&self) -> &'static [u8] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/quark.rs:76:19 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn to_raw(&self) -> ffi::GQuark { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn escape_bytestring<'a>(s: &'a [u8]) -> Cow<'a, str> { [INFO] [stderr] 36 | | if s.is_ascii() { [INFO] [stderr] 37 | | let s = unsafe { str::from_utf8_unchecked(s) }; [INFO] [stderr] 38 | | return s.into(); [INFO] [stderr] ... | [INFO] [stderr] 43 | | string.into() [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test-error.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | const NON_UTF8: &'static [u8] = b"U can't parse this.\x9c Hammer time!"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test-error.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | const NON_UTF8_LOSSY: &'static str = "U can't parse this.\u{FFFD} Hammer time!"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test-error.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | const NON_UTF8_ESCAPED: &'static str = r#"U can\'t parse this.\x9c Hammer time!"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test-mainloop.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | const THREAD_NAME: &'static str = "invoker"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test-mainloop.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | const THREAD_NAME: &'static str = "invoker"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test-gstr.rs:38:30 [INFO] [stderr] | [INFO] [stderr] 38 | assert!(source.ends_with("\0")); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.53s [INFO] running `"docker" "inspect" "9fe813dfaa04c1c09eca29f193c7646d137dd60fb54e9e93931aaaefa3cf010a"` [INFO] running `"docker" "rm" "-f" "9fe813dfaa04c1c09eca29f193c7646d137dd60fb54e9e93931aaaefa3cf010a"` [INFO] [stdout] 9fe813dfaa04c1c09eca29f193c7646d137dd60fb54e9e93931aaaefa3cf010a