[INFO] crate grpc-compiler 0.6.1 is already in cache [INFO] extracting crate grpc-compiler 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/grpc-compiler/0.6.1 [INFO] extracting crate grpc-compiler 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grpc-compiler/0.6.1 [INFO] validating manifest of grpc-compiler-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grpc-compiler-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grpc-compiler-0.6.1 [INFO] finished frobbing grpc-compiler-0.6.1 [INFO] frobbed toml for grpc-compiler-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/grpc-compiler/0.6.1/Cargo.toml [INFO] started frobbing grpc-compiler-0.6.1 [INFO] finished frobbing grpc-compiler-0.6.1 [INFO] frobbed toml for grpc-compiler-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grpc-compiler/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grpc-compiler-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grpc-compiler/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53a1f8fdb69aeb99755fd4a1e84b144fad1abb98855b5b681c3a8cb7c8aeea63 [INFO] running `"docker" "start" "-a" "53a1f8fdb69aeb99755fd4a1e84b144fad1abb98855b5b681c3a8cb7c8aeea63"` [INFO] [stderr] Checking protobuf-codegen v2.2.5 [INFO] [stderr] Checking grpc-compiler v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | proto: proto, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proto` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | proto: proto, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proto` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | service_path: service_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `service_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | root_scope: root_scope, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_scope` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | service_path: service_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `service_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | root_scope: root_scope, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_scope` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | proto: proto, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proto` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | service_path: service_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `service_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | file_descriptors: file_descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | proto: proto, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proto` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | service_path: service_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `service_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codegen.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | file_descriptors: file_descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/codegen.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self.proto.get_client_streaming() { [INFO] [stderr] 92 | | false => self.input_message(), [INFO] [stderr] 93 | | true => format!("::grpc::StreamingRequest<{}>", self.input_message()), [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.proto.get_client_streaming() { format!("::grpc::StreamingRequest<{}>", self.input_message()) } else { self.input_message() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/codegen.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / match self.proto.get_server_streaming() { [INFO] [stderr] 99 | | false => format!("::grpc::SingleResponse<{}>", self.output_message()), [INFO] [stderr] 100 | | true => format!("::grpc::StreamingResponse<{}>", self.output_message()), [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.proto.get_server_streaming() { format!("::grpc::StreamingResponse<{}>", self.output_message()) } else { format!("::grpc::SingleResponse<{}>", self.output_message()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/codegen.rs:214:14 [INFO] [stderr] | [INFO] [stderr] 214 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/codegen.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self.proto.get_client_streaming() { [INFO] [stderr] 92 | | false => self.input_message(), [INFO] [stderr] 93 | | true => format!("::grpc::StreamingRequest<{}>", self.input_message()), [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.proto.get_client_streaming() { format!("::grpc::StreamingRequest<{}>", self.input_message()) } else { self.input_message() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/codegen.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / match self.proto.get_server_streaming() { [INFO] [stderr] 99 | | false => format!("::grpc::SingleResponse<{}>", self.output_message()), [INFO] [stderr] 100 | | true => format!("::grpc::StreamingResponse<{}>", self.output_message()), [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.proto.get_server_streaming() { format!("::grpc::StreamingResponse<{}>", self.output_message()) } else { format!("::grpc::SingleResponse<{}>", self.output_message()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/codegen.rs:214:14 [INFO] [stderr] | [INFO] [stderr] 214 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.42s [INFO] running `"docker" "inspect" "53a1f8fdb69aeb99755fd4a1e84b144fad1abb98855b5b681c3a8cb7c8aeea63"` [INFO] running `"docker" "rm" "-f" "53a1f8fdb69aeb99755fd4a1e84b144fad1abb98855b5b681c3a8cb7c8aeea63"` [INFO] [stdout] 53a1f8fdb69aeb99755fd4a1e84b144fad1abb98855b5b681c3a8cb7c8aeea63