[INFO] crate grpc 0.6.1 is already in cache
[INFO] extracting crate grpc 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/grpc/0.6.1
[INFO] extracting crate grpc 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grpc/0.6.1
[INFO] validating manifest of grpc-0.6.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of grpc-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing grpc-0.6.1
[INFO] finished frobbing grpc-0.6.1
[INFO] frobbed toml for grpc-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/grpc/0.6.1/Cargo.toml
[INFO] started frobbing grpc-0.6.1
[INFO] finished frobbing grpc-0.6.1
[INFO] frobbed toml for grpc-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grpc/0.6.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting grpc-0.6.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grpc/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2805625f397caa9b1d4260eb0511d2d9f323f2a511494c512a0a1343145dfd37
[INFO] running `"docker" "start" "-a" "2805625f397caa9b1d4260eb0511d2d9f323f2a511494c512a0a1343145dfd37"`
[INFO] [stderr] Checking tokio-uds v0.1.7
[INFO] [stderr] Checking tokio-tls-api v0.1.20
[INFO] [stderr] Checking httpbis v0.7.0
[INFO] [stderr] Checking grpc v0.6.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/futures_misc/stream_single.rs:29:9
[INFO] [stderr] |
[INFO] [stderr] 29 | stream: stream,
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/client.rs:123:17
[INFO] [stderr] |
[INFO] [stderr] 123 | http_scheme: http_scheme,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_scheme`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/server.rs:40:13
[INFO] [stderr] |
[INFO] [stderr] 40 | methods: methods,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/server.rs:168:48
[INFO] [stderr] |
[INFO] [stderr] 168 | let request_options = RequestOptions { metadata: metadata };
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/grpc_http_to_response.rs:45:17
[INFO] [stderr] |
[INFO] [stderr] 45 | grpc_status: grpc_status,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `grpc_status`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/metadata.rs:81:13
[INFO] [stderr] |
[INFO] [stderr] 81 | key: key,
[INFO] [stderr] | ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/metadata.rs:82:13
[INFO] [stderr] |
[INFO] [stderr] 82 | value: value,
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/metadata.rs:132:13
[INFO] [stderr] |
[INFO] [stderr] 132 | key: key,
[INFO] [stderr] | ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/metadata.rs:133:13
[INFO] [stderr] |
[INFO] [stderr] 133 | value: value,
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/futures_misc/stream_single.rs:29:9
[INFO] [stderr] |
[INFO] [stderr] 29 | stream: stream,
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/client.rs:123:17
[INFO] [stderr] |
[INFO] [stderr] 123 | http_scheme: http_scheme,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_scheme`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/server.rs:40:13
[INFO] [stderr] |
[INFO] [stderr] 40 | methods: methods,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/server.rs:168:48
[INFO] [stderr] |
[INFO] [stderr] 168 | let request_options = RequestOptions { metadata: metadata };
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/grpc_http_to_response.rs:45:17
[INFO] [stderr] |
[INFO] [stderr] 45 | grpc_status: grpc_status,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `grpc_status`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/metadata.rs:81:13
[INFO] [stderr] |
[INFO] [stderr] 81 | key: key,
[INFO] [stderr] | ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/metadata.rs:82:13
[INFO] [stderr] |
[INFO] [stderr] 82 | value: value,
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/metadata.rs:132:13
[INFO] [stderr] |
[INFO] [stderr] 132 | key: key,
[INFO] [stderr] | ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/metadata.rs:133:13
[INFO] [stderr] |
[INFO] [stderr] 133 | value: value,
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr] --> src/server.rs:45:9
[INFO] [stderr] |
[INFO] [stderr] 45 | self.methods.iter().filter(|m| m.name == name).next()
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr] = note: replace `filter(|m| m.name == name).next()` with `find(|m| m.name == name)`
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr]
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `server::ServerBuilder`
[INFO] [stderr] --> src/server.rs:87:5
[INFO] [stderr] |
[INFO] [stderr] 87 | / pub fn new() -> ServerBuilder {
[INFO] [stderr] 88 | | ServerBuilder {
[INFO] [stderr] 89 | | http: httpbis::ServerBuilder::new(),
[INFO] [stderr] 90 | | conf: ServerConf::new(),
[INFO] [stderr] 91 | | }
[INFO] [stderr] 92 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 86 | impl Default for server::ServerBuilder {
[INFO] [stderr] 87 | fn default() -> Self {
[INFO] [stderr] 88 | Self::new()
[INFO] [stderr] 89 | }
[INFO] [stderr] 90 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((bytes[0] as u32) << 24)`
[INFO] [stderr] --> src/grpc_frame.rs:16:5
[INFO] [stderr] |
[INFO] [stderr] 16 | 0 | ((bytes[0] as u32) << 24)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/grpc_frame.rs:16:10
[INFO] [stderr] |
[INFO] [stderr] 16 | 0 | ((bytes[0] as u32) << 24)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/grpc_frame.rs:17:12
[INFO] [stderr] |
[INFO] [stderr] 17 | | ((bytes[1] as u32) << 16)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/grpc_frame.rs:18:12
[INFO] [stderr] |
[INFO] [stderr] 18 | | ((bytes[2] as u32) << 8)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[3] as u32)`
[INFO] [stderr] --> src/grpc_frame.rs:19:11
[INFO] [stderr] |
[INFO] [stderr] 19 | | ((bytes[3] as u32) << 0)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/grpc_frame.rs:19:12
[INFO] [stderr] |
[INFO] [stderr] 19 | | ((bytes[3] as u32) << 0)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[3])`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `v`
[INFO] [stderr] --> src/grpc_frame.rs:27:9
[INFO] [stderr] |
[INFO] [stderr] 27 | (v >> 0) as u8,
[INFO] [stderr] | ^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr]
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr] --> src/grpc_frame.rs:227:35
[INFO] [stderr] |
[INFO] [stderr] 227 | let r: Vec = r.into_iter().map(|&s| Bytes::from(s)).collect();
[INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr]
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr] --> src/grpc_http_to_response.rs:58:22
[INFO] [stderr] |
[INFO] [stderr] 58 | .map_err(|e| Error::from(e))
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr] --> src/error.rs:41:9
[INFO] [stderr] |
[INFO] [stderr] 41 | / match self {
[INFO] [stderr] 42 | | &Error::Io(ref err) => err.description(),
[INFO] [stderr] 43 | | &Error::Http(ref err) => err.description(),
[INFO] [stderr] 44 | | &Error::GrpcMessage(ref err) => &err.grpc_message,
[INFO] [stderr] ... |
[INFO] [stderr] 49 | | &Error::Other(ref message) => message,
[INFO] [stderr] 50 | | }
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr] |
[INFO] [stderr] 41 | match *self {
[INFO] [stderr] 42 | Error::Io(ref err) => err.description(),
[INFO] [stderr] 43 | Error::Http(ref err) => err.description(),
[INFO] [stderr] 44 | Error::GrpcMessage(ref err) => &err.grpc_message,
[INFO] [stderr] 45 | Error::MetadataDecode(..) => "metadata decode error",
[INFO] [stderr] 46 | Error::Protobuf(ref err) => err.description(),
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr] --> src/error.rs:56:9
[INFO] [stderr] |
[INFO] [stderr] 56 | / match self {
[INFO] [stderr] 57 | | &Error::Io(ref err) => write!(f, "io error: {}", err.description()),
[INFO] [stderr] 58 | | &Error::Http(ref err) => write!(f, "http error: {}", err.description()),
[INFO] [stderr] 59 | | &Error::GrpcMessage(ref err) => write!(f, "grpc message error: {}", err.grpc_message),
[INFO] [stderr] ... |
[INFO] [stderr] 64 | | &Error::Other(ref message) => write!(f, "other error: {}", message),
[INFO] [stderr] 65 | | }
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr] |
[INFO] [stderr] 56 | match *self {
[INFO] [stderr] 57 | Error::Io(ref err) => write!(f, "io error: {}", err.description()),
[INFO] [stderr] 58 | Error::Http(ref err) => write!(f, "http error: {}", err.description()),
[INFO] [stderr] 59 | Error::GrpcMessage(ref err) => write!(f, "grpc message error: {}", err.grpc_message),
[INFO] [stderr] 60 | Error::MetadataDecode(..) => write!(f, "metadata decode error"),
[INFO] [stderr] 61 | Error::Protobuf(ref err) => write!(f, "protobuf error: {}", err.description()),
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr] --> src/metadata.rs:58:21
[INFO] [stderr] |
[INFO] [stderr] 58 | let value = match is_bin {
[INFO] [stderr] | _____________________^
[INFO] [stderr] 59 | | true => Bytes::from(base64::encode(&self.value)),
[INFO] [stderr] 60 | | false => self.value,
[INFO] [stderr] 61 | | };
[INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_bin { Bytes::from(base64::encode(&self.value)) } else { self.value }`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr] --> src/metadata.rs:76:21
[INFO] [stderr] |
[INFO] [stderr] 76 | let value = match key.is_bin() {
[INFO] [stderr] | _____________________^
[INFO] [stderr] 77 | | true => Bytes::from(base64::decode(&header.value)?),
[INFO] [stderr] 78 | | false => header.value,
[INFO] [stderr] 79 | | };
[INFO] [stderr] | |_________^ help: consider using an if/else expression: `if key.is_bin() { Bytes::from(base64::decode(&header.value)?) } else { header.value }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr]
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr] --> src/server.rs:45:9
[INFO] [stderr] |
[INFO] [stderr] 45 | self.methods.iter().filter(|m| m.name == name).next()
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr] = note: replace `filter(|m| m.name == name).next()` with `find(|m| m.name == name)`
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr]
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `server::ServerBuilder`
[INFO] [stderr] --> src/server.rs:87:5
[INFO] [stderr] |
[INFO] [stderr] 87 | / pub fn new() -> ServerBuilder {
[INFO] [stderr] 88 | | ServerBuilder {
[INFO] [stderr] 89 | | http: httpbis::ServerBuilder::new(),
[INFO] [stderr] 90 | | conf: ServerConf::new(),
[INFO] [stderr] 91 | | }
[INFO] [stderr] 92 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 86 | impl Default for server::ServerBuilder {
[INFO] [stderr] 87 | fn default() -> Self {
[INFO] [stderr] 88 | Self::new()
[INFO] [stderr] 89 | }
[INFO] [stderr] 90 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((bytes[0] as u32) << 24)`
[INFO] [stderr] --> src/grpc_frame.rs:16:5
[INFO] [stderr] |
[INFO] [stderr] 16 | 0 | ((bytes[0] as u32) << 24)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/grpc_frame.rs:16:10
[INFO] [stderr] |
[INFO] [stderr] 16 | 0 | ((bytes[0] as u32) << 24)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/grpc_frame.rs:17:12
[INFO] [stderr] |
[INFO] [stderr] 17 | | ((bytes[1] as u32) << 16)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/grpc_frame.rs:18:12
[INFO] [stderr] |
[INFO] [stderr] 18 | | ((bytes[2] as u32) << 8)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bytes[3] as u32)`
[INFO] [stderr] --> src/grpc_frame.rs:19:11
[INFO] [stderr] |
[INFO] [stderr] 19 | | ((bytes[3] as u32) << 0)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr]
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr] --> src/grpc_frame.rs:19:12
[INFO] [stderr] |
[INFO] [stderr] 19 | | ((bytes[3] as u32) << 0)
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[3])`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `v`
[INFO] [stderr] --> src/grpc_frame.rs:27:9
[INFO] [stderr] |
[INFO] [stderr] 27 | (v >> 0) as u8,
[INFO] [stderr] | ^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr]
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr] --> src/grpc_http_to_response.rs:58:22
[INFO] [stderr] |
[INFO] [stderr] 58 | .map_err(|e| Error::from(e))
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr] --> src/error.rs:41:9
[INFO] [stderr] |
[INFO] [stderr] 41 | / match self {
[INFO] [stderr] 42 | | &Error::Io(ref err) => err.description(),
[INFO] [stderr] 43 | | &Error::Http(ref err) => err.description(),
[INFO] [stderr] 44 | | &Error::GrpcMessage(ref err) => &err.grpc_message,
[INFO] [stderr] ... |
[INFO] [stderr] 49 | | &Error::Other(ref message) => message,
[INFO] [stderr] 50 | | }
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr] |
[INFO] [stderr] 41 | match *self {
[INFO] [stderr] 42 | Error::Io(ref err) => err.description(),
[INFO] [stderr] 43 | Error::Http(ref err) => err.description(),
[INFO] [stderr] 44 | Error::GrpcMessage(ref err) => &err.grpc_message,
[INFO] [stderr] 45 | Error::MetadataDecode(..) => "metadata decode error",
[INFO] [stderr] 46 | Error::Protobuf(ref err) => err.description(),
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr] --> src/error.rs:56:9
[INFO] [stderr] |
[INFO] [stderr] 56 | / match self {
[INFO] [stderr] 57 | | &Error::Io(ref err) => write!(f, "io error: {}", err.description()),
[INFO] [stderr] 58 | | &Error::Http(ref err) => write!(f, "http error: {}", err.description()),
[INFO] [stderr] 59 | | &Error::GrpcMessage(ref err) => write!(f, "grpc message error: {}", err.grpc_message),
[INFO] [stderr] ... |
[INFO] [stderr] 64 | | &Error::Other(ref message) => write!(f, "other error: {}", message),
[INFO] [stderr] 65 | | }
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr] |
[INFO] [stderr] 56 | match *self {
[INFO] [stderr] 57 | Error::Io(ref err) => write!(f, "io error: {}", err.description()),
[INFO] [stderr] 58 | Error::Http(ref err) => write!(f, "http error: {}", err.description()),
[INFO] [stderr] 59 | Error::GrpcMessage(ref err) => write!(f, "grpc message error: {}", err.grpc_message),
[INFO] [stderr] 60 | Error::MetadataDecode(..) => write!(f, "metadata decode error"),
[INFO] [stderr] 61 | Error::Protobuf(ref err) => write!(f, "protobuf error: {}", err.description()),
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr] --> src/metadata.rs:58:21
[INFO] [stderr] |
[INFO] [stderr] 58 | let value = match is_bin {
[INFO] [stderr] | _____________________^
[INFO] [stderr] 59 | | true => Bytes::from(base64::encode(&self.value)),
[INFO] [stderr] 60 | | false => self.value,
[INFO] [stderr] 61 | | };
[INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_bin { Bytes::from(base64::encode(&self.value)) } else { self.value }`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr] --> src/metadata.rs:76:21
[INFO] [stderr] |
[INFO] [stderr] 76 | let value = match key.is_bin() {
[INFO] [stderr] | _____________________^
[INFO] [stderr] 77 | | true => Bytes::from(base64::decode(&header.value)?),
[INFO] [stderr] 78 | | false => header.value,
[INFO] [stderr] 79 | | };
[INFO] [stderr] | |_________^ help: consider using an if/else expression: `if key.is_bin() { Bytes::from(base64::decode(&header.value)?) } else { header.value }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> tests/test_misc/mod.rs:18:9
[INFO] [stderr] |
[INFO] [stderr] 18 | streaming: streaming,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `streaming`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> tests/test_misc/mod.rs:18:9
[INFO] [stderr] |
[INFO] [stderr] 18 | streaming: streaming,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `streaming`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> tests/test_misc/mod.rs:18:9
[INFO] [stderr] |
[INFO] [stderr] 18 | streaming: streaming,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `streaming`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: function is never used: `panic_in_handler`
[INFO] [stderr] --> tests/simple.rs:212:1
[INFO] [stderr] |
[INFO] [stderr] 212 | fn panic_in_handler() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(dead_code)] on by default
[INFO] [stderr]
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr] --> tests/simple.rs:107:43
[INFO] [stderr] |
[INFO] [stderr] 107 | self.call_expect_error(param, |e| match e {
[INFO] [stderr] | ___________________________________________^
[INFO] [stderr] 108 | | &Error::GrpcMessage(GrpcMessageError {
[INFO] [stderr] 109 | | ref grpc_message, ..
[INFO] [stderr] 110 | | })
[INFO] [stderr] ... |
[INFO] [stderr] 115 | | _ => false,
[INFO] [stderr] 116 | | });
[INFO] [stderr] | |_________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr] |
[INFO] [stderr] 107 | self.call_expect_error(param, |e| match *e {
[INFO] [stderr] 108 | Error::GrpcMessage(GrpcMessageError {
[INFO] [stderr] 109 | ref grpc_message, ..
[INFO] [stderr] 110 | })
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr] --> tests/simple.rs:256:14
[INFO] [stderr] |
[INFO] [stderr] 256 | let tx = tx.send("aa".to_owned()).wait().ok().expect("aa");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr]
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr] --> tests/simple.rs:257:14
[INFO] [stderr] |
[INFO] [stderr] 257 | let tx = tx.send("bb".to_owned()).wait().ok().expect("bb");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr]
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr] --> tests/simple.rs:258:14
[INFO] [stderr] |
[INFO] [stderr] 258 | let tx = tx.send("cc".to_owned()).wait().ok().expect("cc");
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr]
[INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.58s
[INFO] running `"docker" "inspect" "2805625f397caa9b1d4260eb0511d2d9f323f2a511494c512a0a1343145dfd37"`
[INFO] running `"docker" "rm" "-f" "2805625f397caa9b1d4260eb0511d2d9f323f2a511494c512a0a1343145dfd37"`
[INFO] [stdout] 2805625f397caa9b1d4260eb0511d2d9f323f2a511494c512a0a1343145dfd37