[INFO] crate groupable 0.2.0 is already in cache [INFO] extracting crate groupable 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/groupable/0.2.0 [INFO] extracting crate groupable 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/groupable/0.2.0 [INFO] validating manifest of groupable-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of groupable-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing groupable-0.2.0 [INFO] finished frobbing groupable-0.2.0 [INFO] frobbed toml for groupable-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/groupable/0.2.0/Cargo.toml [INFO] started frobbing groupable-0.2.0 [INFO] finished frobbing groupable-0.2.0 [INFO] frobbed toml for groupable-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/groupable/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting groupable-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/groupable/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6de23dcadd4bc76e14d3c54889a31a85bf2973ad7e743001f2cdc77950ad22ac [INFO] running `"docker" "start" "-a" "6de23dcadd4bc76e14d3c54889a31a85bf2973ad7e743001f2cdc77950ad22ac"` [INFO] [stderr] Checking groupable v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | / macro_rules! impl_uint_keyed_iter { [INFO] [stderr] 70 | | ($name:ident) => ( [INFO] [stderr] 71 | | impl + FromIterator> FromKeyedIterator for $name { [INFO] [stderr] 72 | | fn from_keyed_iter>(iter: T) -> $name { [INFO] [stderr] ... | [INFO] [stderr] 78 | | ) [INFO] [stderr] 79 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | / macro_rules! impl_uint_keyed_iter { [INFO] [stderr] 70 | | ($name:ident) => ( [INFO] [stderr] 71 | | impl + FromIterator> FromKeyedIterator for $name { [INFO] [stderr] 72 | | fn from_keyed_iter>(iter: T) -> $name { [INFO] [stderr] ... | [INFO] [stderr] 78 | | ) [INFO] [stderr] 79 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:59:105 [INFO] [stderr] | [INFO] [stderr] 59 | impl + FromIterator> FromKeyedIterator for $name { [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 81 | impl_keyed_iter!(HashMap: Ord, Hash); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 59 | impl + FromIterator, S: ::std::hash::BuildHasher + Default> FromKeyedIterator for $name { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 61 | let mut map = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match $map.get_mut(&key) { [INFO] [stderr] 45 | | Some(collection) => { [INFO] [stderr] 46 | | collection.extend(val_iter); [INFO] [stderr] 47 | | continue [INFO] [stderr] 48 | | }, [INFO] [stderr] 49 | | None => {} // insert below [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 81 | impl_keyed_iter!(HashMap: Ord, Hash); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(collection) = $map.get_mut(&key) { [INFO] [stderr] 45 | Some(collection) => { [INFO] [stderr] 46 | collection.extend(val_iter); [INFO] [stderr] 47 | continue [INFO] [stderr] 48 | }, [INFO] [stderr] 49 | None => {} // insert below [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match $map.get_mut(&key) { [INFO] [stderr] 45 | | Some(collection) => { [INFO] [stderr] 46 | | collection.extend(val_iter); [INFO] [stderr] 47 | | continue [INFO] [stderr] 48 | | }, [INFO] [stderr] 49 | | None => {} // insert below [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 82 | impl_keyed_iter!(BTreeMap: Ord); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(collection) = $map.get_mut(&key) { [INFO] [stderr] 45 | Some(collection) => { [INFO] [stderr] 46 | collection.extend(val_iter); [INFO] [stderr] 47 | continue [INFO] [stderr] 48 | }, [INFO] [stderr] 49 | None => {} // insert below [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:59:105 [INFO] [stderr] | [INFO] [stderr] 59 | impl + FromIterator> FromKeyedIterator for $name { [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 81 | impl_keyed_iter!(HashMap: Ord, Hash); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 59 | impl + FromIterator, S: ::std::hash::BuildHasher + Default> FromKeyedIterator for $name { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 61 | let mut map = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match $map.get_mut(&key) { [INFO] [stderr] 45 | | Some(collection) => { [INFO] [stderr] 46 | | collection.extend(val_iter); [INFO] [stderr] 47 | | continue [INFO] [stderr] 48 | | }, [INFO] [stderr] 49 | | None => {} // insert below [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 81 | impl_keyed_iter!(HashMap: Ord, Hash); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(collection) = $map.get_mut(&key) { [INFO] [stderr] 45 | Some(collection) => { [INFO] [stderr] 46 | collection.extend(val_iter); [INFO] [stderr] 47 | continue [INFO] [stderr] 48 | }, [INFO] [stderr] 49 | None => {} // insert below [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match $map.get_mut(&key) { [INFO] [stderr] 45 | | Some(collection) => { [INFO] [stderr] 46 | | collection.extend(val_iter); [INFO] [stderr] 47 | | continue [INFO] [stderr] 48 | | }, [INFO] [stderr] 49 | | None => {} // insert below [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 82 | impl_keyed_iter!(BTreeMap: Ord); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(collection) = $map.get_mut(&key) { [INFO] [stderr] 45 | Some(collection) => { [INFO] [stderr] 46 | collection.extend(val_iter); [INFO] [stderr] 47 | continue [INFO] [stderr] 48 | }, [INFO] [stderr] 49 | None => {} // insert below [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.22s [INFO] running `"docker" "inspect" "6de23dcadd4bc76e14d3c54889a31a85bf2973ad7e743001f2cdc77950ad22ac"` [INFO] running `"docker" "rm" "-f" "6de23dcadd4bc76e14d3c54889a31a85bf2973ad7e743001f2cdc77950ad22ac"` [INFO] [stdout] 6de23dcadd4bc76e14d3c54889a31a85bf2973ad7e743001f2cdc77950ad22ac