[INFO] crate grin_util 0.4.2 is already in cache
[INFO] extracting crate grin_util 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/grin_util/0.4.2
[INFO] extracting crate grin_util 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_util/0.4.2
[INFO] validating manifest of grin_util-0.4.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of grin_util-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing grin_util-0.4.2
[INFO] finished frobbing grin_util-0.4.2
[INFO] frobbed toml for grin_util-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/grin_util/0.4.2/Cargo.toml
[INFO] started frobbing grin_util-0.4.2
[INFO] finished frobbing grin_util-0.4.2
[INFO] frobbed toml for grin_util-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_util/0.4.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting grin_util-0.4.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grin_util/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6fafab1ac0475a3f95b96a9bde2a544d7d6e0304c0c5e7f5fc0c02e8aecda1f1
[INFO] running `"docker" "start" "-a" "6fafab1ac0475a3f95b96a9bde2a544d7d6e0304c0c5e7f5fc0c02e8aecda1f1"`
[INFO] [stderr]    Compiling grin_secp256k1zkp v0.7.4
[INFO] [stderr]     Checking log4rs v0.8.1
[INFO] [stderr]     Checking grin_util v0.4.2 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/file.rs:58:2
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return files_vec;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `files_vec`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/file.rs:67:3
[INFO] [stderr]    |
[INFO] [stderr] 67 |           return Err(io::Error::new(
[INFO] [stderr]    |  _________^
[INFO] [stderr] 68 | |             io::ErrorKind::Other,
[INFO] [stderr] 69 | |             format!("Could not copy: {}", src.display()),
[INFO] [stderr] 70 | |         ));
[INFO] [stderr]    | |___________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 67 |         Err(io::Error::new(
[INFO] [stderr] 68 |             io::ErrorKind::Other,
[INFO] [stderr] 69 |             format!("Could not copy: {}", src.display()),
[INFO] [stderr] 70 |         ))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/file.rs:58:2
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return files_vec;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `files_vec`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/file.rs:67:3
[INFO] [stderr]    |
[INFO] [stderr] 67 |           return Err(io::Error::new(
[INFO] [stderr]    |  _________^
[INFO] [stderr] 68 | |             io::ErrorKind::Other,
[INFO] [stderr] 69 | |             format!("Could not copy: {}", src.display()),
[INFO] [stderr] 70 | |         ));
[INFO] [stderr]    | |___________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 67 |         Err(io::Error::new(
[INFO] [stderr] 68 |             io::ErrorKind::Other,
[INFO] [stderr] 69 |             format!("Could not copy: {}", src.display()),
[INFO] [stderr] 70 |         ))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/logger.rs:91:3
[INFO] [stderr]    |
[INFO] [stderr] 91 |           let level_minimum;
[INFO] [stderr]    |  _________^
[INFO] [stderr] 92 | |
[INFO] [stderr] 93 | |         // Determine minimum logging level for Root logger
[INFO] [stderr] 94 | |         if level_stdout > level_file {
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |             level_minimum = level_file;
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let level_minimum = if level_stdout > level_file { level_stdout } else { level_file };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/logger.rs:91:3
[INFO] [stderr]    |
[INFO] [stderr] 91 |           let level_minimum;
[INFO] [stderr]    |  _________^
[INFO] [stderr] 92 | |
[INFO] [stderr] 93 | |         // Determine minimum logging level for Root logger
[INFO] [stderr] 94 | |         if level_stdout > level_file {
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |             level_minimum = level_file;
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let level_minimum = if level_stdout > level_file { level_stdout } else { level_file };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/logger.rs:264:21
[INFO] [stderr]     |
[INFO] [stderr] 264 |         let tui_running = TUI_RUNNING.lock().clone();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `TUI_RUNNING.lock()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/logger.rs:264:21
[INFO] [stderr]     |
[INFO] [stderr] 264 |         let tui_running = TUI_RUNNING.lock().clone();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `TUI_RUNNING.lock()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/hex.rs:52:2
[INFO] [stderr]    |
[INFO] [stderr] 52 |     (0..(s.len() - n + 1) / 2 + 1)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=(s.len() - n + 1) / 2)`
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/hex.rs:52:2
[INFO] [stderr]    |
[INFO] [stderr] 52 |     (0..(s.len() - n + 1) / 2 + 1)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=(s.len() - n + 1) / 2)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/file.rs:61:34
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn copy_to(src: &Path, src_type: &fs::FileType, dst: &Path) -> io::Result<u64> {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^ help: consider passing by value instead: `fs::FileType`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rate_counter::RateCounter`
[INFO] [stderr]   --> src/rate_counter.rs:57:2
[INFO] [stderr]    |
[INFO] [stderr] 57 |       pub fn new() -> RateCounter {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 58 | |         RateCounter {
[INFO] [stderr] 59 | |             last_min_entries: vec![],
[INFO] [stderr] 60 | |         }
[INFO] [stderr] 61 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/file.rs:61:34
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn copy_to(src: &Path, src_type: &fs::FileType, dst: &Path) -> io::Result<u64> {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^ help: consider passing by value instead: `fs::FileType`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 51 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/rate_counter.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 |         while self.last_min_entries.len() > 0
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.last_min_entries.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/rate_counter.rs:108:4
[INFO] [stderr]     |
[INFO] [stderr] 108 |         .unwrap_or(Duration::new(0, 0));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Duration::new(0, 0))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/rate_counter.rs:109:33
[INFO] [stderr]     |
[INFO] [stderr] 109 |     since_epoch.as_secs() * 1000 + since_epoch.subsec_millis() as u64
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_epoch.subsec_millis())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `OneTime<T>`
[INFO] [stderr]   --> src/lib.rs:94:2
[INFO] [stderr]    |
[INFO] [stderr] 94 |       pub fn new() -> OneTime<T> {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 95 | |         OneTime {
[INFO] [stderr] 96 | |             inner: Arc::new(RwLock::new(None)),
[INFO] [stderr] 97 | |         }
[INFO] [stderr] 98 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 84 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rate_counter::RateCounter`
[INFO] [stderr]   --> src/rate_counter.rs:57:2
[INFO] [stderr]    |
[INFO] [stderr] 57 |       pub fn new() -> RateCounter {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 58 | |         RateCounter {
[INFO] [stderr] 59 | |             last_min_entries: vec![],
[INFO] [stderr] 60 | |         }
[INFO] [stderr] 61 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 51 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/rate_counter.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 |         while self.last_min_entries.len() > 0
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.last_min_entries.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/rate_counter.rs:108:4
[INFO] [stderr]     |
[INFO] [stderr] 108 |         .unwrap_or(Duration::new(0, 0));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Duration::new(0, 0))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/rate_counter.rs:109:33
[INFO] [stderr]     |
[INFO] [stderr] 109 |     since_epoch.as_secs() * 1000 + since_epoch.subsec_millis() as u64
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_epoch.subsec_millis())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `OneTime<T>`
[INFO] [stderr]   --> src/lib.rs:94:2
[INFO] [stderr]    |
[INFO] [stderr] 94 |       pub fn new() -> OneTime<T> {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 95 | |         OneTime {
[INFO] [stderr] 96 | |             inner: Arc::new(RwLock::new(None)),
[INFO] [stderr] 97 | |         }
[INFO] [stderr] 98 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 84 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 28.92s
[INFO] running `"docker" "inspect" "6fafab1ac0475a3f95b96a9bde2a544d7d6e0304c0c5e7f5fc0c02e8aecda1f1"`
[INFO] running `"docker" "rm" "-f" "6fafab1ac0475a3f95b96a9bde2a544d7d6e0304c0c5e7f5fc0c02e8aecda1f1"`
[INFO] [stdout] 6fafab1ac0475a3f95b96a9bde2a544d7d6e0304c0c5e7f5fc0c02e8aecda1f1