[INFO] crate grin_secp256k1zkp 0.7.2 is already in cache
[INFO] extracting crate grin_secp256k1zkp 0.7.2 into work/ex/clippy-test-run/sources/stable/reg/grin_secp256k1zkp/0.7.2
[INFO] extracting crate grin_secp256k1zkp 0.7.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_secp256k1zkp/0.7.2
[INFO] validating manifest of grin_secp256k1zkp-0.7.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of grin_secp256k1zkp-0.7.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing grin_secp256k1zkp-0.7.2
[INFO] finished frobbing grin_secp256k1zkp-0.7.2
[INFO] frobbed toml for grin_secp256k1zkp-0.7.2 written to work/ex/clippy-test-run/sources/stable/reg/grin_secp256k1zkp/0.7.2/Cargo.toml
[INFO] started frobbing grin_secp256k1zkp-0.7.2
[INFO] finished frobbing grin_secp256k1zkp-0.7.2
[INFO] frobbed toml for grin_secp256k1zkp-0.7.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_secp256k1zkp/0.7.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting grin_secp256k1zkp-0.7.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grin_secp256k1zkp/0.7.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 56b9cff5b39daa85957b1089eab7ddd1ed0b09c6184aa537dcf10619312e084a
[INFO] running `"docker" "start" "-a" "56b9cff5b39daa85957b1089eab7ddd1ed0b09c6184aa537dcf10619312e084a"`
[INFO] [stderr]    Compiling grin_secp256k1zkp v0.7.2 (/opt/crater/workdir)
[INFO] [stderr] warning: use of deprecated item 'gcc::Build': crate has been renamed to `cc`, the `gcc` name is not maintained
[INFO] [stderr]   --> build.rs:27:27
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let mut base_config = gcc::Build::new();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained
[INFO] [stderr]   --> build.rs:27:27
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let mut base_config = gcc::Build::new();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: In file included from depend/secp256k1-zkp/src/secp256k1.c:14:0:
[INFO] [stderr] warning: depend/secp256k1-zkp/src/ecmult_impl.h:930:12: warning: 'secp256k1_ecmult_pippenger_batch_single' defined but not used [-Wunused-function]
[INFO] [stderr] warning:  static int secp256k1_ecmult_pippenger_batch_single(const secp256k1_ecmult_context *actx, secp256k1_scratch *scratch, secp256k1_gej *r, const secp256k1_scalar *inp_g_sc, secp256k1_ecmult_multi_callback cb, void *cbdata, size_t n) {
[INFO] [stderr] warning:             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/ecmult_impl.h:557:12: warning: 'secp256k1_ecmult_strauss_batch_single' defined but not used [-Wunused-function]
[INFO] [stderr] warning:  static int secp256k1_ecmult_strauss_batch_single(const secp256k1_ecmult_context *actx, secp256k1_scratch *scratch, secp256k1_gej *r, const secp256k1_scalar *inp_g_sc, secp256k1_ecmult_multi_callback cb, void *cbdata, size_t n) {
[INFO] [stderr] warning:             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[INFO] [stderr] warning: In file included from depend/secp256k1-zkp/src/secp256k1.c:13:0:
[INFO] [stderr] warning: depend/secp256k1-zkp/src/group_impl.h:273:12: warning: 'secp256k1_gej_is_valid_var' defined but not used [-Wunused-function]
[INFO] [stderr] warning:  static int secp256k1_gej_is_valid_var(const secp256k1_gej *a) {
[INFO] [stderr] warning:             ^~~~~~~~~~~~~~~~~~~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/group_impl.h:203:13: warning: 'secp256k1_ge_set_infinity' defined but not used [-Wunused-function]
[INFO] [stderr] warning:  static void secp256k1_ge_set_infinity(secp256k1_ge *r) {
[INFO] [stderr] warning:              ^~~~~~~~~~~~~~~~~~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_pubkey_parse':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:184:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'input' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:186:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(input != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_pubkey_serialize':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'output' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:205:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(output != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'outputlen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:201:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(outputlen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:207:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_signature_parse_der':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:246:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'input' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:247:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(input != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_signature_parse_compact':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:264:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'input64' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:265:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(input64 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_signature_serialize_der':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'output' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:283:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(output != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'outputlen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:284:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(outputlen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:285:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_signature_serialize_compact':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'output64' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:295:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(output64 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:296:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_signature_normalize':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sigin' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:309:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sigin != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_verify':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:330:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:329:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(msg32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:331:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_sign':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'signature' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:386:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(signature != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:385:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(msg32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:387:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seckey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_seckey_verify':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:429:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seckey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_pubkey_create':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:444:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:447:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seckey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_privkey_negate':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:463:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seckey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_pubkey_negate':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:476:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_privkey_tweak_add':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:493:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seckey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'tweak' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:494:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(tweak != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_pubkey_tweak_add':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:517:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'tweak' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:518:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(tweak != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_privkey_tweak_mul':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:540:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seckey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'tweak' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:541:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(tweak != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_pubkey_tweak_mul':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:563:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'tweak' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:564:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(tweak != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ec_pubkey_combine':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubnonce' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:592:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubnonce != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubnonces' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:595:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubnonces != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdh':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'result' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/ecdh/main_impl.h:20:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(result != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'point' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/ecdh/main_impl.h:21:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(point != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'scalar' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/ecdh/main_impl.h:22:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(scalar != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_recoverable_signature_parse_compact':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:44:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'input64' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:45:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(input64 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_recoverable_signature_serialize_compact':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'output64' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:64:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(output64 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'recid' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:66:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(recid != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:65:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_recoverable_signature_convert':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:79:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sigin' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:80:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sigin != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_sign_recoverable':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'signature' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:132:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(signature != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:131:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(msg32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:133:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seckey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_ecdsa_recover':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:179:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'signature' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:178:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(signature != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/recovery/main_impl.h:177:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(msg32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_generator_parse':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/generator/main_impl.h:62:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'input' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/generator/main_impl.h:63:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(input != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_generator_serialize':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'output' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/generator/main_impl.h:81:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(output != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/generator/main_impl.h:82:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_generator_generate':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/generator/main_impl.h:233:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'key32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/generator/main_impl.h:234:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(key32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_generator_generate_blinded':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/generator/main_impl.h:240:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'key32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/generator/main_impl.h:241:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(key32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'blind32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/generator/main_impl.h:242:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(blind32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_pedersen_commitment_parse':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:49:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'input' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:50:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(input != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_pedersen_commitment_serialize':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'output' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:69:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(output != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:70:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_pedersen_commit':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:90:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'blind' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:91:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(blind != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'value_gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:92:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(value_gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'blind_gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:93:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(blind_gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_pedersen_blind_sum':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'blind_out' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:138:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(blind_out != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'blinds' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:139:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(blinds != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_pedersen_commit_sum':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit_out' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:169:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit_out != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: In file included from depend/secp256k1-zkp/src/secp256k1.c:9:0:
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:16: warning: nonnull argument 'commits' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning: 
[INFO] [stderr] warning: depend/secp256k1-zkp/src/util.h:42:22: note: in definition of macro 'EXPECT'
[INFO] [stderr] warning:  #define EXPECT(x,c) (x)
[INFO] [stderr] warning:                       ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:167:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(!pcnt || (commits != NULL));
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:16: warning: nonnull argument 'ncommits' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning: 
[INFO] [stderr] warning: depend/secp256k1-zkp/src/util.h:42:22: note: in definition of macro 'EXPECT'
[INFO] [stderr] warning:  #define EXPECT(x,c) (x)
[INFO] [stderr] warning:                       ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:168:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(!ncnt || (ncommits != NULL));
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_pedersen_verify_tally':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:16: warning: nonnull argument 'pos' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning: 
[INFO] [stderr] warning: depend/secp256k1-zkp/src/util.h:42:22: note: in definition of macro 'EXPECT'
[INFO] [stderr] warning:  #define EXPECT(x,c) (x)
[INFO] [stderr] warning:                       ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:196:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(!n_pos || (pos != NULL));
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:16: warning: nonnull argument 'neg' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning: 
[INFO] [stderr] warning: depend/secp256k1-zkp/src/util.h:42:22: note: in definition of macro 'EXPECT'
[INFO] [stderr] warning:  #define EXPECT(x,c) (x)
[INFO] [stderr] warning:                       ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/commitment/main_impl.h:197:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(!n_neg || (neg != NULL));
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_rangeproof_info':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'exp' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:21:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(exp != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'mantissa' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:22:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(mantissa != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'min_value' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:23:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(min_value != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'max_value' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:24:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(max_value != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_rangeproof_rewind':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'nonce' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:44:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(nonce != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'min_value' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:41:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(min_value != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'max_value' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:42:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(max_value != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:39:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'proof' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:40:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(proof != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:46:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_rangeproof_verify':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'min_value' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:62:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(min_value != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'max_value' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:63:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(max_value != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:60:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'proof' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:61:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(proof != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:65:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_rangeproof_sign':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'proof' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:79:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(proof != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'plen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:80:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(plen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:81:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'blind' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:82:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(blind != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'nonce' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:83:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(nonce != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/rangeproof/main_impl.h:86:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_bulletproof_rangeproof_verify':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'scratch' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:90:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(scratch != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gens' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:91:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gens != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:94:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'value_gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:98:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(value_gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_bulletproof_rangeproof_verify_multi':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'scratch' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:126:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(scratch != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gens' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:127:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gens != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'proof' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:130:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(proof != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:129:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_bulletproof_rangeproof_rewind':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gens' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:171:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gens != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'value' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:169:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(value != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'blind' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:170:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(blind != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'proof' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:172:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(proof != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'commit' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:173:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(commit != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'value_gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:174:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(value_gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_bulletproof_rangeproof_prove':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'scratch' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:204:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(scratch != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'gens' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:205:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(gens != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'value' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:213:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(value != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'blind' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:214:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(blind != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'value_gen' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:215:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(value_gen != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'nonce' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/bulletproofs/main_impl.h:216:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(nonce != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_aggsig_context_create':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkeys' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:112:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkeys != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seed' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:113:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seed != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_aggsig_export_secnonce_single':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'secnonce32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:160:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(secnonce32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_aggsig_generate_nonce':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'aggctx' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:177:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(aggctx != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_aggsig_sign_single':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:220:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig64 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:221:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(msg32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seckey32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:222:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seckey32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_aggsig_partial_sign':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'aggctx' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:303:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(aggctx != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'partial' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:304:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(partial != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'msghash32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:305:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(msghash32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'seckey32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:306:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(seckey32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_aggsig_combine_signatures':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'aggctx' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:354:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(aggctx != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:355:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig64 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'partial' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:356:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(partial != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_aggsig_add_signatures_single':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:402:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig64 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sigs' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:403:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sigs != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubnonce_total' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:404:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubnonce_total != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_aggsig_verify':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'scratch' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:460:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(scratch != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:461:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig64 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:462:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(msg32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkeys' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:463:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkeys != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c: In function 'secp256k1_aggsig_verify_single':
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:541:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(sig64 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:542:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(msg32 != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: depend/secp256k1-zkp/src/secp256k1.c:43:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare]
[INFO] [stderr] warning:      if (EXPECT(!(cond), 0)) { \
[INFO] [stderr] warning:         ^
[INFO] [stderr] warning: depend/secp256k1-zkp/src/modules/aggsig/main_impl.h:543:5: note: in expansion of macro 'ARG_CHECK'
[INFO] [stderr] warning:      ARG_CHECK(pubkey != NULL);
[INFO] [stderr] warning:      ^~~~~~~~~
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:577:4
[INFO] [stderr]     |
[INFO] [stderr] 577 |             proof: proof,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `proof`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:610:20
[INFO] [stderr]     |
[INFO] [stderr] 610 |             Ok(ProofRange { min: min, max: max })
[INFO] [stderr]     |                             ^^^^^^^^ help: replace it with: `min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:610:30
[INFO] [stderr]     |
[INFO] [stderr] 610 |             Ok(ProofRange { min: min, max: max })
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `max`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:655:4
[INFO] [stderr]     |
[INFO] [stderr] 655 |             success: success,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:656:4
[INFO] [stderr]     |
[INFO] [stderr] 656 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:659:4
[INFO] [stderr]     |
[INFO] [stderr] 659 |             mlen: mlen,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `mlen`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:660:4
[INFO] [stderr]     |
[INFO] [stderr] 660 |             min: min,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:661:4
[INFO] [stderr]     |
[INFO] [stderr] 661 |             max: max,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `max`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:687:4
[INFO] [stderr]     |
[INFO] [stderr] 687 |             success: success,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:692:4
[INFO] [stderr]     |
[INFO] [stderr] 692 |             min: min,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:693:4
[INFO] [stderr]     |
[INFO] [stderr] 693 |             max: max,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `max`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:694:4
[INFO] [stderr]     |
[INFO] [stderr] 694 |             exp: exp,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `exp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:695:4
[INFO] [stderr]     |
[INFO] [stderr] 695 |             mantissa: mantissa,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `mantissa`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:772:4
[INFO] [stderr]     |
[INFO] [stderr] 772 |             proof: proof,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `proof`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:886:5
[INFO] [stderr]     |
[INFO] [stderr] 886 |                 proof: proof,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `proof`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:576:74
[INFO] [stderr]     |
[INFO] [stderr] 576 |         Secp256k1 { ctx: unsafe { ffi::secp256k1_context_create(flag) }, caps: caps }
[INFO] [stderr]     |                                                                          ^^^^^^^^^^ help: replace it with: `caps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:577:4
[INFO] [stderr]     |
[INFO] [stderr] 577 |             proof: proof,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `proof`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:610:20
[INFO] [stderr]     |
[INFO] [stderr] 610 |             Ok(ProofRange { min: min, max: max })
[INFO] [stderr]     |                             ^^^^^^^^ help: replace it with: `min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:610:30
[INFO] [stderr]     |
[INFO] [stderr] 610 |             Ok(ProofRange { min: min, max: max })
[INFO] [stderr]     |                                       ^^^^^^^^ help: replace it with: `max`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:655:4
[INFO] [stderr]     |
[INFO] [stderr] 655 |             success: success,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:656:4
[INFO] [stderr]     |
[INFO] [stderr] 656 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:659:4
[INFO] [stderr]     |
[INFO] [stderr] 659 |             mlen: mlen,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `mlen`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:660:4
[INFO] [stderr]     |
[INFO] [stderr] 660 |             min: min,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:661:4
[INFO] [stderr]     |
[INFO] [stderr] 661 |             max: max,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `max`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:687:4
[INFO] [stderr]     |
[INFO] [stderr] 687 |             success: success,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `success`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:692:4
[INFO] [stderr]     |
[INFO] [stderr] 692 |             min: min,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `min`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:693:4
[INFO] [stderr]     |
[INFO] [stderr] 693 |             max: max,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `max`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:694:4
[INFO] [stderr]     |
[INFO] [stderr] 694 |             exp: exp,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `exp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:695:4
[INFO] [stderr]     |
[INFO] [stderr] 695 |             mantissa: mantissa,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `mantissa`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:772:4
[INFO] [stderr]     |
[INFO] [stderr] 772 |             proof: proof,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `proof`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pedersen.rs:886:5
[INFO] [stderr]     |
[INFO] [stderr] 886 |                 proof: proof,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `proof`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:576:74
[INFO] [stderr]     |
[INFO] [stderr] 576 |         Secp256k1 { ctx: unsafe { ffi::secp256k1_context_create(flag) }, caps: caps }
[INFO] [stderr]     |                                                                          ^^^^^^^^^^ help: replace it with: `caps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1299:15
[INFO] [stderr]      |
[INFO] [stderr] 1299 |         let value = 12345678;
[INFO] [stderr]      |                     ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1311:15
[INFO] [stderr]      |
[INFO] [stderr] 1311 |         let value = 12345678;
[INFO] [stderr]      |                     ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1312:34
[INFO] [stderr]      |
[INFO] [stderr] 1312 |         let wrong_commit = secp.commit(87654321, blinding).unwrap();
[INFO] [stderr]      |                                        ^^^^^^^^ help: consider: `87_654_321`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1322:15
[INFO] [stderr]      |
[INFO] [stderr] 1322 |         let value = 12345678;
[INFO] [stderr]      |                     ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1336:15
[INFO] [stderr]      |
[INFO] [stderr] 1336 |         let value = 12345678;
[INFO] [stderr]      |                     ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1362:15
[INFO] [stderr]      |
[INFO] [stderr] 1362 |         let value = 12345678;
[INFO] [stderr]      |                     ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/pedersen.rs:1538:5
[INFO] [stderr]      |
[INFO] [stderr] 1538 |                 return (bullet_proof, proof_range);
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(bullet_proof, proof_range)`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1542:20
[INFO] [stderr]      |
[INFO] [stderr] 1542 |         let value: u64 = 12345678;
[INFO] [stderr]      |                          ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1566:44
[INFO] [stderr]      |
[INFO] [stderr] 1566 |         let wrong_partial_commit_a = secp.commit(87654321, blinding_a).unwrap();
[INFO] [stderr]      |                                                  ^^^^^^^^ help: consider: `87_654_321`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1714:15
[INFO] [stderr]      |
[INFO] [stderr] 1714 |         let value = 12345678;
[INFO] [stderr]      |                     ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/pedersen.rs:1755:15
[INFO] [stderr]      |
[INFO] [stderr] 1755 |         let value = 12345678;
[INFO] [stderr]      |                     ^^^^^^^^ help: consider: `12_345_678`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 0)`
[INFO] [stderr]   --> src/ffi.rs:24:42
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:24:42
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:26:44
[INFO] [stderr]    |
[INFO] [stderr] 26 | pub const SECP256K1_START_VERIFY: c_uint = (1 << 0) | (1 << 8);
[INFO] [stderr]    |                                            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:28:42
[INFO] [stderr]    |
[INFO] [stderr] 28 | pub const SECP256K1_START_SIGN: c_uint = (1 << 0) | (1 << 9);
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 1)`
[INFO] [stderr]   --> src/ffi.rs:30:48
[INFO] [stderr]    |
[INFO] [stderr] 30 | pub const SECP256K1_SER_UNCOMPRESSED: c_uint = (1 << 1) | 0;
[INFO] [stderr]    |                                                ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::PublicKey`
[INFO] [stderr]   --> src/ffi.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 |     pub fn new() -> PublicKey { PublicKey([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 81 | impl Default for ffi::PublicKey {
[INFO] [stderr] 82 |     fn default() -> Self {
[INFO] [stderr] 83 |         Self::new()
[INFO] [stderr] 84 |     }
[INFO] [stderr] 85 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::Signature`
[INFO] [stderr]    --> src/ffi.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn new() -> Signature { Signature([0; 64]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 106 | impl Default for ffi::Signature {
[INFO] [stderr] 107 |     fn default() -> Self {
[INFO] [stderr] 108 |         Self::new()
[INFO] [stderr] 109 |     }
[INFO] [stderr] 110 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::RecoverableSignature`
[INFO] [stderr]    --> src/ffi.rs:117:5
[INFO] [stderr]     |
[INFO] [stderr] 117 |     pub fn new() -> RecoverableSignature { RecoverableSignature([0; 65]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 115 | impl Default for ffi::RecoverableSignature {
[INFO] [stderr] 116 |     fn default() -> Self {
[INFO] [stderr] 117 |         Self::new()
[INFO] [stderr] 118 |     }
[INFO] [stderr] 119 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::AggSigPartialSignature`
[INFO] [stderr]    --> src/ffi.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |     pub fn new() -> AggSigPartialSignature { AggSigPartialSignature([0; 32]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 102 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::SharedSecret`
[INFO] [stderr]    --> src/ffi.rs:137:5
[INFO] [stderr]     |
[INFO] [stderr] 137 |     pub fn new() -> SharedSecret { SharedSecret([0; 32]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 131 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `key::PublicKey`
[INFO] [stderr]    --> src/key.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 | /     pub fn new() -> PublicKey {
[INFO] [stderr] 127 | |         PublicKey(ffi::PublicKey::new())
[INFO] [stderr] 128 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 123 | impl Default for key::PublicKey {
[INFO] [stderr] 124 |     fn default() -> Self {
[INFO] [stderr] 125 |         Self::new()
[INFO] [stderr] 126 |     }
[INFO] [stderr] 127 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/key.rs:269:30
[INFO] [stderr]     |
[INFO] [stderr] 269 |                     for i in 0..len {
[INFO] [stderr]     |                              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 269 |                     for (i, <item>) in ret.iter_mut().enumerate().take(len) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/key.rs:278:30
[INFO] [stderr]     |
[INFO] [stderr] 278 |                     for i in 0..len {
[INFO] [stderr]     |                              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 278 |                     for (i, <item>) in ret.iter_mut().enumerate().take(len) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/pedersen.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         match SHARED_BULLETGENERATORS.clone() {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `SHARED_BULLETGENERATORS`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/pedersen.rs:85:12
[INFO] [stderr]    |
[INFO] [stderr] 85 |         for i in 0..min(v.len(), constants::PEDERSEN_COMMITMENT_SIZE) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `h[..min(v.len(), constants::PEDERSEN_COMMITMENT_SIZE)].clone_from_slice(&v[..min(v.len(), constants::PEDERSEN_COMMITMENT_SIZE)])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/pedersen.rs:100:35
[INFO] [stderr]     |
[INFO] [stderr] 100 |             let commit = secp.commit_parse(self.0.clone())?;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'aggsig::sign_single': All aggsig-related api functions need review and are subject to change.
[INFO] [stderr]    --> src/aggsig.rs:355:50
[INFO] [stderr]     |
[INFO] [stderr] 355 |         add_signatures_single, export_secnonce_single, sign_single, verify_single, AggSigContext,
[INFO] [stderr]     |                                                        ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: item `pedersen::RangeProof` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/pedersen.rs:221:1
[INFO] [stderr]     |
[INFO] [stderr] 221 | / impl RangeProof {
[INFO] [stderr] 222 | |     /// Create the zero range proof
[INFO] [stderr] 223 | |     pub fn zero() -> RangeProof {
[INFO] [stderr] 224 | |         RangeProof {
[INFO] [stderr] ...   |
[INFO] [stderr] 236 | |     }
[INFO] [stderr] 237 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr] warning: use of deprecated item 'aggsig::sign_single': All aggsig-related api functions need review and are subject to change.
[INFO] [stderr]    --> src/aggsig.rs:437:13
[INFO] [stderr]     |
[INFO] [stderr] 437 |         let sig = sign_single(&secp, &msg, &sk, None, None, None, None, None).unwrap();
[INFO] [stderr]     |                   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] warning: use of deprecated item 'aggsig::sign_single': All aggsig-related api functions need review and are subject to change.
[INFO] [stderr]    --> src/aggsig.rs:463:13
[INFO] [stderr]     |
[INFO] [stderr] 463 |         let sig = sign_single(&secp, &msg, &sk, None, Some(&sk_extra), None, None, None).unwrap();
[INFO] [stderr]     |                   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'aggsig::sign_single': All aggsig-related api functions need review and are subject to change.
[INFO] [stderr]    --> src/aggsig.rs:481:13
[INFO] [stderr]     |
[INFO] [stderr] 481 |         let sig = sign_single(&secp, &msg, &sk, None, None, None, None, None).unwrap();
[INFO] [stderr]     |                   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'aggsig::sign_single': All aggsig-related api functions need review and are subject to change.
[INFO] [stderr]    --> src/aggsig.rs:564:6
[INFO] [stderr]     |
[INFO] [stderr] 564 |         if sign_single(
[INFO] [stderr]     |            ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'aggsig::sign_single': All aggsig-related api functions need review and are subject to change.
[INFO] [stderr]    --> src/aggsig.rs:609:15
[INFO] [stderr]     |
[INFO] [stderr] 609 |             let sig1 = sign_single(
[INFO] [stderr]     |                        ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'aggsig::sign_single': All aggsig-related api functions need review and are subject to change.
[INFO] [stderr]    --> src/aggsig.rs:634:15
[INFO] [stderr]     |
[INFO] [stderr] 634 |             let sig2 = sign_single(
[INFO] [stderr]     |                        ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: item `pedersen::ProofMessage` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/pedersen.rs:245:1
[INFO] [stderr]     |
[INFO] [stderr] 245 | / impl ProofMessage {
[INFO] [stderr] 246 | |     /// Creates an empty message.
[INFO] [stderr] 247 | |     pub fn empty() -> ProofMessage {
[INFO] [stderr] 248 | |         ProofMessage(vec![])
[INFO] [stderr] ...   |
[INFO] [stderr] 286 | |     }
[INFO] [stderr] 287 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/pedersen.rs:364:16
[INFO] [stderr]     |
[INFO] [stderr] 364 |             Ok(x) => Ok(x),
[INFO] [stderr]     |                         ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 364 |             Ok(x) => Ok(()),
[INFO] [stderr]     |                         ^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/pedersen.rs:537:15
[INFO] [stderr]     |
[INFO] [stderr] 537 |         let nonce = blind.clone();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: try removing the `clone` call: `blind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (12/7)
[INFO] [stderr]    --> src/pedersen.rs:778:2
[INFO] [stderr]     |
[INFO] [stderr] 778 |       pub fn bullet_proof_multisig(
[INFO] [stderr]     |  _____^
[INFO] [stderr] 779 | |         &self,
[INFO] [stderr] 780 | |         value: u64,
[INFO] [stderr] 781 | |         blind: SecretKey,
[INFO] [stderr] ...   |
[INFO] [stderr] 891 | |         }
[INFO] [stderr] 892 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/pedersen.rs:792:19
[INFO] [stderr]     |
[INFO] [stderr] 792 |         let last_step = if 0 == step { true } else { false };
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `0 == step`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/pedersen.rs:793:20
[INFO] [stderr]     |
[INFO] [stderr] 793 |         let first_step = if 1 == step { true } else { false };
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `1 == step`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pedersen.rs:833:20
[INFO] [stderr]     |
[INFO] [stderr] 833 |         let commits = if commits.len() > 0 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commits.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pedersen.rs:950:23
[INFO] [stderr]     |
[INFO] [stderr] 950 |         let proof_size = if proofs.len() > 0 {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!proofs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pedersen.rs:963:21
[INFO] [stderr]     |
[INFO] [stderr] 963 |             let min_len = if proof_vec.len() > 0 {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!proof_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/aggsig.rs:89:1
[INFO] [stderr]     |
[INFO] [stderr] 89  | / pub fn sign_single(
[INFO] [stderr] 90  | |     secp: &Secp256k1,
[INFO] [stderr] 91  | |     msg: &Message,
[INFO] [stderr] 92  | |     seckey: &SecretKey,
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |     Ok(retsig)
[INFO] [stderr] 137 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/aggsig.rs:148:1
[INFO] [stderr]     |
[INFO] [stderr] 148 | / pub fn verify_single(
[INFO] [stderr] 149 | |     secp: &Secp256k1,
[INFO] [stderr] 150 | |     sig: &Signature,
[INFO] [stderr] 151 | |     msg: &Message,
[INFO] [stderr] ...   |
[INFO] [stderr] 189 | |     }
[INFO] [stderr] 190 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/aggsig.rs:164:19
[INFO] [stderr]     |
[INFO] [stderr] 164 |       let is_partial = match is_partial {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 165 | |         true => 1,
[INFO] [stderr] 166 | |         false => 0,
[INFO] [stderr] 167 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if is_partial { 1 } else { 0 }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/aggsig.rs:230:40
[INFO] [stderr]     |
[INFO] [stderr] 230 |     pub fn new(secp: &Secp256k1, pubkeys: &Vec<PublicKey>) -> AggSigContext {
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^ help: change this to: `&[PublicKey]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/aggsig.rs:233:53
[INFO] [stderr]     |
[INFO] [stderr] 233 |         let pubkeys: Vec<*const ffi::PublicKey> = pubkeys.into_iter().map(|p| p.as_ptr()).collect();
[INFO] [stderr]     |                                                           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/aggsig.rs:297:17
[INFO] [stderr]     |
[INFO] [stderr] 297 |         partial_sigs: &Vec<AggSigPartialSignature>,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AggSigPartialSignature]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/aggsig.rs:301:17
[INFO] [stderr]     |
[INFO] [stderr] 301 |             partial_sigs.into_iter().map(|p| p.as_ptr()).collect();
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/aggsig.rs:324:58
[INFO] [stderr]     |
[INFO] [stderr] 324 |     pub fn verify(&self, sig: Signature, msg: Message, pks: &Vec<PublicKey>) -> bool {
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^ help: change this to: `&[PublicKey]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/aggsig.rs:325:45
[INFO] [stderr]     |
[INFO] [stderr] 325 |         let pks: Vec<*const ffi::PublicKey> = pks.into_iter().map(|p| p.as_ptr()).collect();
[INFO] [stderr]     |                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:103:19
[INFO] [stderr]     |
[INFO] [stderr] 103 |     pub fn to_i32(&self) -> i32 {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:143:48
[INFO] [stderr]     |
[INFO] [stderr] 143 |         Ok(Signature(ffi::Signature::from_data(data.clone())))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^ help: try dereferencing it: `*data`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:229:9
[INFO] [stderr]     |
[INFO] [stderr] 229 |         (self.0).0.clone()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(self.0).0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/lib.rs:262:30
[INFO] [stderr]     |
[INFO] [stderr] 262 |                     for i in 0..constants::COMPACT_SIGNATURE_SIZE {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 262 |                     for (i, <item>) in ret.iter_mut().enumerate().take(constants::COMPACT_SIGNATURE_SIZE) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Secp256k1`
[INFO] [stderr]    --> src/lib.rs:562:5
[INFO] [stderr]     |
[INFO] [stderr] 562 | /     pub fn new() -> Secp256k1 {
[INFO] [stderr] 563 | |         Secp256k1::with_caps(ContextFlag::Full)
[INFO] [stderr] 564 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 559 | impl Default for Secp256k1 {
[INFO] [stderr] 560 |     fn default() -> Self {
[INFO] [stderr] 561 |         Self::new()
[INFO] [stderr] 562 |     }
[INFO] [stderr] 563 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 0)`
[INFO] [stderr]   --> src/ffi.rs:24:42
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:24:42
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:26:44
[INFO] [stderr]    |
[INFO] [stderr] 26 | pub const SECP256K1_START_VERIFY: c_uint = (1 << 0) | (1 << 8);
[INFO] [stderr]    |                                            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:28:42
[INFO] [stderr]    |
[INFO] [stderr] 28 | pub const SECP256K1_START_SIGN: c_uint = (1 << 0) | (1 << 9);
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 1)`
[INFO] [stderr]   --> src/ffi.rs:30:48
[INFO] [stderr]    |
[INFO] [stderr] 30 | pub const SECP256K1_SER_UNCOMPRESSED: c_uint = (1 << 1) | 0;
[INFO] [stderr]    |                                                ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::PublicKey`
[INFO] [stderr]   --> src/ffi.rs:83:5
[INFO] [stderr]    |
[INFO] [stderr] 83 |     pub fn new() -> PublicKey { PublicKey([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 81 | impl Default for ffi::PublicKey {
[INFO] [stderr] 82 |     fn default() -> Self {
[INFO] [stderr] 83 |         Self::new()
[INFO] [stderr] 84 |     }
[INFO] [stderr] 85 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::Signature`
[INFO] [stderr]    --> src/ffi.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn new() -> Signature { Signature([0; 64]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 106 | impl Default for ffi::Signature {
[INFO] [stderr] 107 |     fn default() -> Self {
[INFO] [stderr] 108 |         Self::new()
[INFO] [stderr] 109 |     }
[INFO] [stderr] 110 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::RecoverableSignature`
[INFO] [stderr]    --> src/ffi.rs:117:5
[INFO] [stderr]     |
[INFO] [stderr] 117 |     pub fn new() -> RecoverableSignature { RecoverableSignature([0; 65]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 115 | impl Default for ffi::RecoverableSignature {
[INFO] [stderr] 116 |     fn default() -> Self {
[INFO] [stderr] 117 |         Self::new()
[INFO] [stderr] 118 |     }
[INFO] [stderr] 119 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::AggSigPartialSignature`
[INFO] [stderr]    --> src/ffi.rs:124:5
[INFO] [stderr]     |
[INFO] [stderr] 124 |     pub fn new() -> AggSigPartialSignature { AggSigPartialSignature([0; 32]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 102 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::SharedSecret`
[INFO] [stderr]    --> src/ffi.rs:137:5
[INFO] [stderr]     |
[INFO] [stderr] 137 |     pub fn new() -> SharedSecret { SharedSecret([0; 32]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 131 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `key::PublicKey`
[INFO] [stderr]    --> src/key.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 | /     pub fn new() -> PublicKey {
[INFO] [stderr] 127 | |         PublicKey(ffi::PublicKey::new())
[INFO] [stderr] 128 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 123 | impl Default for key::PublicKey {
[INFO] [stderr] 124 |     fn default() -> Self {
[INFO] [stderr] 125 |         Self::new()
[INFO] [stderr] 126 |     }
[INFO] [stderr] 127 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/key.rs:269:30
[INFO] [stderr]     |
[INFO] [stderr] 269 |                     for i in 0..len {
[INFO] [stderr]     |                              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 269 |                     for (i, <item>) in ret.iter_mut().enumerate().take(len) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/key.rs:278:30
[INFO] [stderr]     |
[INFO] [stderr] 278 |                     for i in 0..len {
[INFO] [stderr]     |                              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 278 |                     for (i, <item>) in ret.iter_mut().enumerate().take(len) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/key.rs:478:22
[INFO] [stderr]     |
[INFO] [stderr] 478 |         let zero31 = "[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]".as_bytes();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/key.rs:480:22
[INFO] [stderr]     |
[INFO] [stderr] 480 |         let zero32 = "[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]".as_bytes();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/key.rs:482:22
[INFO] [stderr]     |
[INFO] [stderr] 482 |         let zero65 = "[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]".as_bytes();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/key.rs:623:20
[INFO] [stderr]     |
[INFO] [stderr] 623 |                 Ok(self.fill_bytes(dest))
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 623 |                 Ok(())
[INFO] [stderr]     |                    ^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/key.rs:660:17
[INFO] [stderr]     |
[INFO] [stderr] 660 |                 self.next_u32() as u64
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/key.rs:684:17
[INFO] [stderr]     |
[INFO] [stderr] 684 |                 self.next_u32() as u64
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/pedersen.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         match SHARED_BULLETGENERATORS.clone() {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `SHARED_BULLETGENERATORS`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/pedersen.rs:85:12
[INFO] [stderr]    |
[INFO] [stderr] 85 |         for i in 0..min(v.len(), constants::PEDERSEN_COMMITMENT_SIZE) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `h[..min(v.len(), constants::PEDERSEN_COMMITMENT_SIZE)].clone_from_slice(&v[..min(v.len(), constants::PEDERSEN_COMMITMENT_SIZE)])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/pedersen.rs:100:35
[INFO] [stderr]     |
[INFO] [stderr] 100 |             let commit = secp.commit_parse(self.0.clone())?;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: item `pedersen::RangeProof` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/pedersen.rs:221:1
[INFO] [stderr]     |
[INFO] [stderr] 221 | / impl RangeProof {
[INFO] [stderr] 222 | |     /// Create the zero range proof
[INFO] [stderr] 223 | |     pub fn zero() -> RangeProof {
[INFO] [stderr] 224 | |         RangeProof {
[INFO] [stderr] ...   |
[INFO] [stderr] 236 | |     }
[INFO] [stderr] 237 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: item `pedersen::ProofMessage` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/pedersen.rs:245:1
[INFO] [stderr]     |
[INFO] [stderr] 245 | / impl ProofMessage {
[INFO] [stderr] 246 | |     /// Creates an empty message.
[INFO] [stderr] 247 | |     pub fn empty() -> ProofMessage {
[INFO] [stderr] 248 | |         ProofMessage(vec![])
[INFO] [stderr] ...   |
[INFO] [stderr] 286 | |     }
[INFO] [stderr] 287 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/pedersen.rs:364:16
[INFO] [stderr]     |
[INFO] [stderr] 364 |             Ok(x) => Ok(x),
[INFO] [stderr]     |                         ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 364 |             Ok(x) => Ok(()),
[INFO] [stderr]     |                         ^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/pedersen.rs:537:15
[INFO] [stderr]     |
[INFO] [stderr] 537 |         let nonce = blind.clone();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: try removing the `clone` call: `blind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (12/7)
[INFO] [stderr]    --> src/pedersen.rs:778:2
[INFO] [stderr]     |
[INFO] [stderr] 778 |       pub fn bullet_proof_multisig(
[INFO] [stderr]     |  _____^
[INFO] [stderr] 779 | |         &self,
[INFO] [stderr] 780 | |         value: u64,
[INFO] [stderr] 781 | |         blind: SecretKey,
[INFO] [stderr] ...   |
[INFO] [stderr] 891 | |         }
[INFO] [stderr] 892 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/pedersen.rs:792:19
[INFO] [stderr]     |
[INFO] [stderr] 792 |         let last_step = if 0 == step { true } else { false };
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `0 == step`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/pedersen.rs:793:20
[INFO] [stderr]     |
[INFO] [stderr] 793 |         let first_step = if 1 == step { true } else { false };
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `1 == step`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pedersen.rs:833:20
[INFO] [stderr]     |
[INFO] [stderr] 833 |         let commits = if commits.len() > 0 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commits.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pedersen.rs:950:23
[INFO] [stderr]     |
[INFO] [stderr] 950 |         let proof_size = if proofs.len() > 0 {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!proofs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/pedersen.rs:963:21
[INFO] [stderr]     |
[INFO] [stderr] 963 |             let min_len = if proof_vec.len() > 0 {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!proof_vec.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]     --> src/pedersen.rs:1198:4
[INFO] [stderr]      |
[INFO] [stderr] 1198 |             Err(_) => {
[INFO] [stderr]      |             ^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]      = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]     --> src/pedersen.rs:1219:10
[INFO] [stderr]      |
[INFO] [stderr] 1219 |           if let Ok(_) = secp.verify(&msg, &sig, &pubkey) {
[INFO] [stderr]      |  _________-      ^^^^^
[INFO] [stderr] 1220 | |             // this is good
[INFO] [stderr] 1221 | |         } else {
[INFO] [stderr] 1222 | |             panic!("this is not good");
[INFO] [stderr] 1223 | |         }
[INFO] [stderr]      | |_________- help: try this: `if secp.verify(&msg, &sig, &pubkey).is_ok()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/pedersen.rs:1288:65
[INFO] [stderr]      |
[INFO] [stderr] 1288 |         let proof_info = secp.rewind_range_proof(commit, range_proof, blinding.clone());
[INFO] [stderr]      |                                                                       ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `blinding`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/pedersen.rs:1314:6
[INFO] [stderr]      |
[INFO] [stderr] 1314 |           if !secp
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1315 | |             .verify_bullet_proof(wrong_commit, bullet_proof, None)
[INFO] [stderr] 1316 | |             .is_err()
[INFO] [stderr]      | |_____________________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1314 |         if secp
[INFO] [stderr] 1315 |             .verify_bullet_proof(wrong_commit, bullet_proof, None).is_ok()
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/pedersen.rs:1326:6
[INFO] [stderr]      |
[INFO] [stderr] 1326 |           if !secp
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1327 | |             .verify_bullet_proof(commit, bullet_proof, None)
[INFO] [stderr] 1328 | |             .is_err()
[INFO] [stderr]      | |_____________________^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1326 |         if secp
[INFO] [stderr] 1327 |             .verify_bullet_proof(commit, bullet_proof, None).is_ok()
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/pedersen.rs:1354:6
[INFO] [stderr]      |
[INFO] [stderr] 1354 |         if !res.is_err() {
[INFO] [stderr]      |            ^^^^^^^^^^^^^ help: try: `res.is_ok()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/pedersen.rs:1381:6
[INFO] [stderr]      |
[INFO] [stderr] 1381 |         if !proof_info.is_err() {
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^ help: try: `proof_info.is_ok()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/pedersen.rs:1387:6
[INFO] [stderr]      |
[INFO] [stderr] 1387 |         if !proof_info.is_err() {
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^ help: try: `proof_info.is_ok()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/pedersen.rs:1352:9
[INFO] [stderr]      |
[INFO] [stderr] 1352 |             Some(malleated_extra_data.clone().to_vec()),
[INFO] [stderr]      |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `malleated_extra_data`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/pedersen.rs:1577:6
[INFO] [stderr]      |
[INFO] [stderr] 1577 |         if !proof_range.is_err() {
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^^ help: try: `proof_range.is_ok()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/pedersen.rs:1593:6
[INFO] [stderr]      |
[INFO] [stderr] 1593 |         if !proof_range.is_err() {
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^^ help: try: `proof_range.is_ok()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/pedersen.rs:1730:27
[INFO] [stderr]      |
[INFO] [stderr] 1730 |                     .verify_bullet_proof(commits[i].clone(), proofs[i].clone(), None)
[INFO] [stderr]      |                                          ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `commits[i]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/pedersen.rs:1730:47
[INFO] [stderr]      |
[INFO] [stderr] 1730 |                     .verify_bullet_proof(commits[i].clone(), proofs[i].clone(), None)
[INFO] [stderr]      |                                                              ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proofs[i]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/pedersen.rs:1774:6
[INFO] [stderr]      |
[INFO] [stderr] 1774 |           if !secp
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1775 | |             .verify_bullet_proof_multi(commits.clone(), proofs.clone(), None)
[INFO] [stderr] 1776 | |             .is_err()
[INFO] [stderr]      | |_____________________^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1774 |         if secp
[INFO] [stderr] 1775 |             .verify_bullet_proof_multi(commits.clone(), proofs.clone(), None).is_ok()
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/pedersen.rs:1828:6
[INFO] [stderr]      |
[INFO] [stderr] 1828 |           if !secp
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1829 | |             .verify_bullet_proof_multi(commits.clone(), proofs.clone(), Some(extra_data.clone()))
[INFO] [stderr] 1830 | |             .is_err()
[INFO] [stderr]      | |_____________________^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1828 |         if secp
[INFO] [stderr] 1829 |             .verify_bullet_proof_multi(commits.clone(), proofs.clone(), Some(extra_data.clone())).is_ok()
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/pedersen.rs:1762:25
[INFO] [stderr]      |
[INFO] [stderr] 1762 |             .verify_bullet_proof(commits[0].clone(), proofs[0].clone(), None)
[INFO] [stderr]      |                                  ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `commits[0]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/pedersen.rs:1762:45
[INFO] [stderr]      |
[INFO] [stderr] 1762 |             .verify_bullet_proof(commits[0].clone(), proofs[0].clone(), None)
[INFO] [stderr]      |                                                      ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `proofs[0]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]     --> src/pedersen.rs:1773:16
[INFO] [stderr]      |
[INFO] [stderr] 1773 |         commits[0] = wrong_commit.clone();
[INFO] [stderr]      |                      ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `wrong_commit`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/aggsig.rs:89:1
[INFO] [stderr]     |
[INFO] [stderr] 89  | / pub fn sign_single(
[INFO] [stderr] 90  | |     secp: &Secp256k1,
[INFO] [stderr] 91  | |     msg: &Message,
[INFO] [stderr] 92  | |     seckey: &SecretKey,
[INFO] [stderr] ...   |
[INFO] [stderr] 136 | |     Ok(retsig)
[INFO] [stderr] 137 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/aggsig.rs:148:1
[INFO] [stderr]     |
[INFO] [stderr] 148 | / pub fn verify_single(
[INFO] [stderr] 149 | |     secp: &Secp256k1,
[INFO] [stderr] 150 | |     sig: &Signature,
[INFO] [stderr] 151 | |     msg: &Message,
[INFO] [stderr] ...   |
[INFO] [stderr] 189 | |     }
[INFO] [stderr] 190 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/aggsig.rs:164:19
[INFO] [stderr]     |
[INFO] [stderr] 164 |       let is_partial = match is_partial {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 165 | |         true => 1,
[INFO] [stderr] 166 | |         false => 0,
[INFO] [stderr] 167 | |     };
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if is_partial { 1 } else { 0 }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/aggsig.rs:230:40
[INFO] [stderr]     |
[INFO] [stderr] 230 |     pub fn new(secp: &Secp256k1, pubkeys: &Vec<PublicKey>) -> AggSigContext {
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^ help: change this to: `&[PublicKey]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/aggsig.rs:233:53
[INFO] [stderr]     |
[INFO] [stderr] 233 |         let pubkeys: Vec<*const ffi::PublicKey> = pubkeys.into_iter().map(|p| p.as_ptr()).collect();
[INFO] [stderr]     |                                                           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/aggsig.rs:297:17
[INFO] [stderr]     |
[INFO] [stderr] 297 |         partial_sigs: &Vec<AggSigPartialSignature>,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AggSigPartialSignature]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/aggsig.rs:301:17
[INFO] [stderr]     |
[INFO] [stderr] 301 |             partial_sigs.into_iter().map(|p| p.as_ptr()).collect();
[INFO] [stderr]     |                          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/aggsig.rs:324:58
[INFO] [stderr]     |
[INFO] [stderr] 324 |     pub fn verify(&self, sig: Signature, msg: Message, pks: &Vec<PublicKey>) -> bool {
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^ help: change this to: `&[PublicKey]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/aggsig.rs:325:45
[INFO] [stderr]     |
[INFO] [stderr] 325 |         let pks: Vec<*const ffi::PublicKey> = pks.into_iter().map(|p| p.as_ptr()).collect();
[INFO] [stderr]     |                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/aggsig.rs:383:12
[INFO] [stderr]     |
[INFO] [stderr] 383 |             assert!(retval == true);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: try simplifying it as shown: `retval`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `keypairs`
[INFO] [stderr]    --> src/aggsig.rs:390:12
[INFO] [stderr]     |
[INFO] [stderr] 390 |         for i in 0..numkeys {
[INFO] [stderr]     |                  ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 390 |         for (i, <item>) in keypairs.iter().enumerate().take(numkeys) {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/aggsig.rs:445:11
[INFO] [stderr]     |
[INFO] [stderr] 445 |         assert!(result == true);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: try simplifying it as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/aggsig.rs:456:11
[INFO] [stderr]     |
[INFO] [stderr] 456 |         assert!(result == false);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/aggsig.rs:465:11
[INFO] [stderr]     |
[INFO] [stderr] 465 |         assert!(result == true);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: try simplifying it as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in corrupted[..32].iter_mut().enumerate()` or similar iterators
[INFO] [stderr]    --> src/aggsig.rs:486:15
[INFO] [stderr]     |
[INFO] [stderr] 486 |         for elem in corrupted[..32].iter_mut() {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/aggsig.rs:499:11
[INFO] [stderr]     |
[INFO] [stderr] 499 |         assert!(result == false);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/aggsig.rs:517:11
[INFO] [stderr]     |
[INFO] [stderr] 517 |         assert!(result == false);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/aggsig.rs:527:11
[INFO] [stderr]     |
[INFO] [stderr] 527 |         assert!(result == false);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/aggsig.rs:545:11
[INFO] [stderr]     |
[INFO] [stderr] 545 |         assert!(result == false);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/aggsig.rs:559:11
[INFO] [stderr]     |
[INFO] [stderr] 559 |         assert!(result == false);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/aggsig.rs:596:24
[INFO] [stderr]     |
[INFO] [stderr] 596 |             let mut nonce_sum = pubnonce_2.clone();
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pubnonce_2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/aggsig.rs:605:21
[INFO] [stderr]     |
[INFO] [stderr] 605 |             let mut pk_sum = pk2.clone();
[INFO] [stderr]     |                              ^^^^^^^^^^^ help: try removing the `clone` call: `pk2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/aggsig.rs:631:12
[INFO] [stderr]     |
[INFO] [stderr] 631 |             assert!(result == true);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: try simplifying it as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/aggsig.rs:656:12
[INFO] [stderr]     |
[INFO] [stderr] 656 |             assert!(result == true);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: try simplifying it as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/aggsig.rs:673:12
[INFO] [stderr]     |
[INFO] [stderr] 673 |             assert!(result == true);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: try simplifying it as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:103:19
[INFO] [stderr]     |
[INFO] [stderr] 103 |     pub fn to_i32(&self) -> i32 {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:143:48
[INFO] [stderr]     |
[INFO] [stderr] 143 |         Ok(Signature(ffi::Signature::from_data(data.clone())))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^ help: try dereferencing it: `*data`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:229:9
[INFO] [stderr]     |
[INFO] [stderr] 229 |         (self.0).0.clone()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(self.0).0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/lib.rs:262:30
[INFO] [stderr]     |
[INFO] [stderr] 262 |                     for i in 0..constants::COMPACT_SIGNATURE_SIZE {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 262 |                     for (i, <item>) in ret.iter_mut().enumerate().take(constants::COMPACT_SIGNATURE_SIZE) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Secp256k1`
[INFO] [stderr]    --> src/lib.rs:562:5
[INFO] [stderr]     |
[INFO] [stderr] 562 | /     pub fn new() -> Secp256k1 {
[INFO] [stderr] 563 | |         Secp256k1::with_caps(ContextFlag::Full)
[INFO] [stderr] 564 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 559 | impl Default for Secp256k1 {
[INFO] [stderr] 560 |     fn default() -> Self {
[INFO] [stderr] 561 |         Self::new()
[INFO] [stderr] 562 |     }
[INFO] [stderr] 563 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 27
[INFO] [stderr]    --> src/lib.rs:706:5
[INFO] [stderr]     |
[INFO] [stderr] 706 | /     fn capabilities() {
[INFO] [stderr] 707 | |         let none = Secp256k1::with_caps(ContextFlag::None);
[INFO] [stderr] 708 | |         let sign = Secp256k1::with_caps(ContextFlag::SignOnly);
[INFO] [stderr] 709 | |         let vrfy = Secp256k1::with_caps(ContextFlag::VerifyOnly);
[INFO] [stderr] ...   |
[INFO] [stderr] 758 | |         assert_eq!(pk, new_pk);
[INFO] [stderr] 759 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:764:25
[INFO] [stderr]     |
[INFO] [stderr] 764 |         assert_eq!(one, one.clone());
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: try removing the `clone` call: `one`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.49s
[INFO] running `"docker" "inspect" "56b9cff5b39daa85957b1089eab7ddd1ed0b09c6184aa537dcf10619312e084a"`
[INFO] running `"docker" "rm" "-f" "56b9cff5b39daa85957b1089eab7ddd1ed0b09c6184aa537dcf10619312e084a"`
[INFO] [stdout] 56b9cff5b39daa85957b1089eab7ddd1ed0b09c6184aa537dcf10619312e084a