[INFO] crate grin_pool 0.4.2 is already in cache [INFO] extracting crate grin_pool 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/grin_pool/0.4.2 [INFO] extracting crate grin_pool 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_pool/0.4.2 [INFO] validating manifest of grin_pool-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grin_pool-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grin_pool-0.4.2 [INFO] finished frobbing grin_pool-0.4.2 [INFO] frobbed toml for grin_pool-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/grin_pool/0.4.2/Cargo.toml [INFO] started frobbing grin_pool-0.4.2 [INFO] finished frobbing grin_pool-0.4.2 [INFO] frobbed toml for grin_pool-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_pool/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grin_pool-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grin_pool/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c4a7eb839eaf29b14a5633b0832c88f7a321b41ea44edaa141b482d9946bd4fd [INFO] running `"docker" "start" "-a" "c4a7eb839eaf29b14a5633b0832c88f7a321b41ea44edaa141b482d9946bd4fd"` [INFO] [stderr] Compiling grin_secp256k1zkp v0.7.4 [INFO] [stderr] Checking arrayvec v0.4.10 [INFO] [stderr] Checking lmdb-zero v0.4.4 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking ripemd160 v0.7.0 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Compiling bindgen v0.37.4 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking blake2-rfc v0.2.18 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking grin_util v0.4.2 [INFO] [stderr] Checking grin_keychain v0.4.2 [INFO] [stderr] Compiling croaring-sys v0.3.8 [INFO] [stderr] Checking croaring v0.3.8 [INFO] [stderr] Checking grin_core v0.4.2 [INFO] [stderr] Checking grin_store v0.4.2 [INFO] [stderr] Checking grin_chain v0.4.2 [INFO] [stderr] Checking grin_pool v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/transaction_pool.rs:243:3 [INFO] [stderr] | [INFO] [stderr] 243 | if stem { [INFO] [stderr] | _________^ [INFO] [stderr] 244 | | if self.stempool.size() > self.config.max_stempool_size { [INFO] [stderr] 245 | | // TODO evict old/large transactions instead [INFO] [stderr] 246 | | return Err(PoolError::OverCapacity); [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 243 | if stem && self.stempool.size() > self.config.max_stempool_size { [INFO] [stderr] 244 | // TODO evict old/large transactions instead [INFO] [stderr] 245 | return Err(PoolError::OverCapacity); [INFO] [stderr] 246 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pool.rs:107:6 [INFO] [stderr] | [INFO] [stderr] 107 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pool.rs:131:56 [INFO] [stderr] | [INFO] [stderr] 131 | flat_txs.sort_unstable_by_key(|tx| tx.fee() * 1000 / tx.tx_weight() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tx.tx_weight())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pool.rs:367:28 [INFO] [stderr] | [INFO] [stderr] 367 | let kernel_set = kernels.into_iter().collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/transaction_pool.rs:254:20 [INFO] [stderr] | [INFO] [stderr] 254 | let threshold = (tx.tx_weight() as u64) * self.config.accept_fee_base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tx.tx_weight())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/transaction_pool.rs:243:3 [INFO] [stderr] | [INFO] [stderr] 243 | if stem { [INFO] [stderr] | _________^ [INFO] [stderr] 244 | | if self.stempool.size() > self.config.max_stempool_size { [INFO] [stderr] 245 | | // TODO evict old/large transactions instead [INFO] [stderr] 246 | | return Err(PoolError::OverCapacity); [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 243 | if stem && self.stempool.size() > self.config.max_stempool_size { [INFO] [stderr] 244 | // TODO evict old/large transactions instead [INFO] [stderr] 245 | return Err(PoolError::OverCapacity); [INFO] [stderr] 246 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pool.rs:107:6 [INFO] [stderr] | [INFO] [stderr] 107 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pool.rs:131:56 [INFO] [stderr] | [INFO] [stderr] 131 | flat_txs.sort_unstable_by_key(|tx| tx.fee() * 1000 / tx.tx_weight() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tx.tx_weight())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pool.rs:367:28 [INFO] [stderr] | [INFO] [stderr] 367 | let kernel_set = kernels.into_iter().collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/transaction_pool.rs:254:20 [INFO] [stderr] | [INFO] [stderr] 254 | let threshold = (tx.tx_weight() as u64) * self.config.accept_fee_base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tx.tx_weight())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error[E0463]: can't find crate for `wallet` [INFO] [stderr] --> tests/coinbase_maturity.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | extern crate grin_wallet as wallet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `grin_pool`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0463]: can't find crate for `wallet` [INFO] [stderr] --> tests/block_building.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | extern crate grin_wallet as wallet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `grin_pool`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0463]: can't find crate for `wallet` [INFO] [stderr] --> tests/block_reconciliation.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | extern crate grin_wallet as wallet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `grin_pool`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0463]: can't find crate for `wallet` [INFO] [stderr] --> tests/transaction_pool.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | extern crate grin_wallet as wallet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `grin_pool`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c4a7eb839eaf29b14a5633b0832c88f7a321b41ea44edaa141b482d9946bd4fd"` [INFO] running `"docker" "rm" "-f" "c4a7eb839eaf29b14a5633b0832c88f7a321b41ea44edaa141b482d9946bd4fd"` [INFO] [stdout] c4a7eb839eaf29b14a5633b0832c88f7a321b41ea44edaa141b482d9946bd4fd