[INFO] crate grin_p2p 0.4.2 is already in cache [INFO] extracting crate grin_p2p 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/grin_p2p/0.4.2 [INFO] extracting crate grin_p2p 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_p2p/0.4.2 [INFO] validating manifest of grin_p2p-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grin_p2p-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grin_p2p-0.4.2 [INFO] finished frobbing grin_p2p-0.4.2 [INFO] frobbed toml for grin_p2p-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/grin_p2p/0.4.2/Cargo.toml [INFO] started frobbing grin_p2p-0.4.2 [INFO] finished frobbing grin_p2p-0.4.2 [INFO] frobbed toml for grin_p2p-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_p2p/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grin_p2p-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grin_p2p/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2b894c2f2ad9736f8314888f51303dd9e426e5bab0030f77401d4591c796ce8 [INFO] running `"docker" "start" "-a" "b2b894c2f2ad9736f8314888f51303dd9e426e5bab0030f77401d4591c796ce8"` [INFO] [stderr] Compiling log v0.4.6 [INFO] [stderr] Checking liblmdb-sys v0.2.2 [INFO] [stderr] Checking blake2-rfc v0.2.18 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking ripemd160 v0.7.0 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking lmdb-zero v0.4.4 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Compiling bindgen v0.37.4 [INFO] [stderr] Checking grin_util v0.4.2 [INFO] [stderr] Checking grin_keychain v0.4.2 [INFO] [stderr] Compiling croaring-sys v0.3.8 [INFO] [stderr] Checking croaring v0.3.8 [INFO] [stderr] Checking grin_core v0.4.2 [INFO] [stderr] Checking grin_store v0.4.2 [INFO] [stderr] Checking grin_p2p v0.4.2 (/opt/crater/workdir) [INFO] [stderr] Checking grin_pool v0.4.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handshake.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | nonce: nonce, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handshake.rs:73:4 [INFO] [stderr] | [INFO] [stderr] 73 | total_difficulty: total_difficulty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_difficulty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handshake.rs:179:4 [INFO] [stderr] | [INFO] [stderr] 179 | total_difficulty: total_difficulty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_difficulty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:189:4 [INFO] [stderr] | [INFO] [stderr] 189 | msg_type: msg_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:278:4 [INFO] [stderr] | [INFO] [stderr] 278 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:279:4 [INFO] [stderr] | [INFO] [stderr] 279 | capabilities: capabilities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `capabilities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:280:4 [INFO] [stderr] | [INFO] [stderr] 280 | nonce: nonce, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:281:4 [INFO] [stderr] | [INFO] [stderr] 281 | genesis: genesis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `genesis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:283:4 [INFO] [stderr] | [INFO] [stderr] 283 | sender_addr: sender_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sender_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:284:4 [INFO] [stderr] | [INFO] [stderr] 284 | receiver_addr: receiver_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:285:4 [INFO] [stderr] | [INFO] [stderr] 285 | user_agent: user_agent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_agent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:329:4 [INFO] [stderr] | [INFO] [stderr] 329 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:330:4 [INFO] [stderr] | [INFO] [stderr] 330 | capabilities: capabilities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `capabilities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:331:4 [INFO] [stderr] | [INFO] [stderr] 331 | genesis: genesis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `genesis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:333:4 [INFO] [stderr] | [INFO] [stderr] 333 | user_agent: user_agent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_agent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:388:18 [INFO] [stderr] | [INFO] [stderr] 388 | Ok(PeerAddrs { peers: peers }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `peers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:414:4 [INFO] [stderr] | [INFO] [stderr] 414 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:415:4 [INFO] [stderr] | [INFO] [stderr] 415 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:498:16 [INFO] [stderr] | [INFO] [stderr] 498 | Ok(Locator { hashes: hashes }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hashes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer.rs:484:4 [INFO] [stderr] | [INFO] [stderr] 484 | adapter: adapter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `adapter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | Ok(PeerStore { db: db }) [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handshake.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | nonce: nonce, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handshake.rs:73:4 [INFO] [stderr] | [INFO] [stderr] 73 | total_difficulty: total_difficulty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_difficulty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handshake.rs:179:4 [INFO] [stderr] | [INFO] [stderr] 179 | total_difficulty: total_difficulty, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_difficulty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:189:4 [INFO] [stderr] | [INFO] [stderr] 189 | msg_type: msg_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:278:4 [INFO] [stderr] | [INFO] [stderr] 278 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:279:4 [INFO] [stderr] | [INFO] [stderr] 279 | capabilities: capabilities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `capabilities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:280:4 [INFO] [stderr] | [INFO] [stderr] 280 | nonce: nonce, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nonce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:281:4 [INFO] [stderr] | [INFO] [stderr] 281 | genesis: genesis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `genesis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:283:4 [INFO] [stderr] | [INFO] [stderr] 283 | sender_addr: sender_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sender_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:284:4 [INFO] [stderr] | [INFO] [stderr] 284 | receiver_addr: receiver_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:285:4 [INFO] [stderr] | [INFO] [stderr] 285 | user_agent: user_agent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_agent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:329:4 [INFO] [stderr] | [INFO] [stderr] 329 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:330:4 [INFO] [stderr] | [INFO] [stderr] 330 | capabilities: capabilities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `capabilities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:331:4 [INFO] [stderr] | [INFO] [stderr] 331 | genesis: genesis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `genesis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:333:4 [INFO] [stderr] | [INFO] [stderr] 333 | user_agent: user_agent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_agent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:388:18 [INFO] [stderr] | [INFO] [stderr] 388 | Ok(PeerAddrs { peers: peers }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `peers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:414:4 [INFO] [stderr] | [INFO] [stderr] 414 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:415:4 [INFO] [stderr] | [INFO] [stderr] 415 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msg.rs:498:16 [INFO] [stderr] | [INFO] [stderr] 498 | Ok(Locator { hashes: hashes }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hashes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer.rs:484:4 [INFO] [stderr] | [INFO] [stderr] 484 | adapter: adapter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `adapter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | Ok(PeerStore { db: db }) [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/msg.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | pub const USER_AGENT: &'static str = concat!("MW/Grin ", env!("CARGO_PKG_VERSION")); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/peers.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/peers.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | let res = peers [INFO] [stderr] | ___________________^ [INFO] [stderr] 129 | | .into_iter() [INFO] [stderr] 130 | | .filter(|x| x.info.direction == Direction::Outbound) [INFO] [stderr] 131 | | .collect::>(); [INFO] [stderr] | |________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/store.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | const STORE_SUBPATH: &'static str = "peers"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:201:19 [INFO] [stderr] | [INFO] [stderr] 201 | const UNKNOWN = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:204:23 [INFO] [stderr] | [INFO] [stderr] 204 | const HEADER_HIST = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:207:26 [INFO] [stderr] | [INFO] [stderr] 207 | const TXHASHSET_HIST = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | const PEER_LIST = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:211:26 [INFO] [stderr] | [INFO] [stderr] 211 | const TX_KERNEL_HASH = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/conn.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | writer.write_all(&mut buf)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/conn.rs:283:12 [INFO] [stderr] | [INFO] [stderr] 283 | if let Ok(_) = close_rx.try_recv() { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 284 | | debug!( [INFO] [stderr] 285 | | "Connection close with {} initiated by us", [INFO] [stderr] 286 | | conn.peer_addr() [INFO] [stderr] ... | [INFO] [stderr] 290 | | break; [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________________- help: try this: `if close_rx.try_recv().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/conn.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | .unwrap_or("?".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "?".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handshake.rs:208:2 [INFO] [stderr] | [INFO] [stderr] 208 | match advertised { [INFO] [stderr] | _____^ [INFO] [stderr] 209 | | &SocketAddr::V4(v4sock) => { [INFO] [stderr] 210 | | let ip = v4sock.ip(); [INFO] [stderr] 211 | | if ip.is_loopback() || ip.is_unspecified() { [INFO] [stderr] ... | [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 208 | match *advertised { [INFO] [stderr] 209 | SocketAddr::V4(v4sock) => { [INFO] [stderr] 210 | let ip = v4sock.ip(); [INFO] [stderr] 211 | if ip.is_loopback() || ip.is_unspecified() { [INFO] [stderr] 212 | if let Ok(addr) = conn.peer_addr() { [INFO] [stderr] 213 | return SocketAddr::new(addr.ip(), advertised.port()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/handshake.rs:226:2 [INFO] [stderr] | [INFO] [stderr] 226 | advertised.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*advertised` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/msg.rs:82:41 [INFO] [stderr] | [INFO] [stderr] 82 | Type::PeerAddrs => 4 + (1 + 16 + 2) * MAX_PEER_ADDRS as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(MAX_PEER_ADDRS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/msg.rs:83:32 [INFO] [stderr] | [INFO] [stderr] 83 | Type::GetHeaders => 1 + 32 * MAX_LOCATORS as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(MAX_LOCATORS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/msg.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | Type::Headers => 2 + 365 * MAX_BLOCK_HEADERS as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(MAX_BLOCK_HEADERS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:71:11 [INFO] [stderr] | [INFO] [stderr] 71 | addr = peer.info.addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/peers.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | self.peers.read().get(addr).map(|p| p.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.peers.read().get(addr).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/peers.rs:153:6 [INFO] [stderr] | [INFO] [stderr] 153 | if peers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `peers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/peers.rs:177:6 [INFO] [stderr] | [INFO] [stderr] 177 | if peers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `peers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | rm.push(peer.info.addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | rm.push(peer.info.addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | rm.push(peer.info.addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:406:14 [INFO] [stderr] | [INFO] [stderr] 406 | rm.push(peer.info.addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:419:14 [INFO] [stderr] | [INFO] [stderr] 419 | .map(|x| x.info.addr.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `x.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/protocol.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | if adapter.is_banned(self.addr.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/store.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | const PEER_PREFIX: u8 = 'p' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'p' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/store.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | let last_connected = if let Err(_) = lc { [INFO] [stderr] | ______________________________- ^^^^^^ [INFO] [stderr] 91 | | Utc::now().timestamp() [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | lc.unwrap() [INFO] [stderr] 94 | | }; [INFO] [stderr] | |_________- help: try this: `if lc.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:310:18 [INFO] [stderr] | [INFO] [stderr] 310 | capabilities: info.capabilities.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `info.capabilities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | version: info.version.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `info.version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:313:10 [INFO] [stderr] | [INFO] [stderr] 313 | addr: info.addr.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:314:15 [INFO] [stderr] | [INFO] [stderr] 314 | direction: info.direction.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `info.direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/msg.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | pub const USER_AGENT: &'static str = concat!("MW/Grin ", env!("CARGO_PKG_VERSION")); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/peers.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/peers.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | let res = peers [INFO] [stderr] | ___________________^ [INFO] [stderr] 129 | | .into_iter() [INFO] [stderr] 130 | | .filter(|x| x.info.direction == Direction::Outbound) [INFO] [stderr] 131 | | .collect::>(); [INFO] [stderr] | |________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/store.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | const STORE_SUBPATH: &'static str = "peers"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:201:19 [INFO] [stderr] | [INFO] [stderr] 201 | const UNKNOWN = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:204:23 [INFO] [stderr] | [INFO] [stderr] 204 | const HEADER_HIST = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:207:26 [INFO] [stderr] | [INFO] [stderr] 207 | const TXHASHSET_HIST = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | const PEER_LIST = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:211:26 [INFO] [stderr] | [INFO] [stderr] 211 | const TX_KERNEL_HASH = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/conn.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | writer.write_all(&mut buf)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/conn.rs:283:12 [INFO] [stderr] | [INFO] [stderr] 283 | if let Ok(_) = close_rx.try_recv() { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 284 | | debug!( [INFO] [stderr] 285 | | "Connection close with {} initiated by us", [INFO] [stderr] 286 | | conn.peer_addr() [INFO] [stderr] ... | [INFO] [stderr] 290 | | break; [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________________- help: try this: `if close_rx.try_recv().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/conn.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | .unwrap_or("?".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "?".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/handshake.rs:208:2 [INFO] [stderr] | [INFO] [stderr] 208 | match advertised { [INFO] [stderr] | _____^ [INFO] [stderr] 209 | | &SocketAddr::V4(v4sock) => { [INFO] [stderr] 210 | | let ip = v4sock.ip(); [INFO] [stderr] 211 | | if ip.is_loopback() || ip.is_unspecified() { [INFO] [stderr] ... | [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 208 | match *advertised { [INFO] [stderr] 209 | SocketAddr::V4(v4sock) => { [INFO] [stderr] 210 | let ip = v4sock.ip(); [INFO] [stderr] 211 | if ip.is_loopback() || ip.is_unspecified() { [INFO] [stderr] 212 | if let Ok(addr) = conn.peer_addr() { [INFO] [stderr] 213 | return SocketAddr::new(addr.ip(), advertised.port()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/handshake.rs:226:2 [INFO] [stderr] | [INFO] [stderr] 226 | advertised.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*advertised` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/msg.rs:82:41 [INFO] [stderr] | [INFO] [stderr] 82 | Type::PeerAddrs => 4 + (1 + 16 + 2) * MAX_PEER_ADDRS as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(MAX_PEER_ADDRS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/msg.rs:83:32 [INFO] [stderr] | [INFO] [stderr] 83 | Type::GetHeaders => 1 + 32 * MAX_LOCATORS as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(MAX_LOCATORS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/msg.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | Type::Headers => 2 + 365 * MAX_BLOCK_HEADERS as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(MAX_BLOCK_HEADERS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:71:11 [INFO] [stderr] | [INFO] [stderr] 71 | addr = peer.info.addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/peers.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | self.peers.read().get(addr).map(|p| p.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.peers.read().get(addr).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/peers.rs:153:6 [INFO] [stderr] | [INFO] [stderr] 153 | if peers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `peers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/peers.rs:177:6 [INFO] [stderr] | [INFO] [stderr] 177 | if peers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `peers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | rm.push(peer.info.addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | rm.push(peer.info.addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | rm.push(peer.info.addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:406:14 [INFO] [stderr] | [INFO] [stderr] 406 | rm.push(peer.info.addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `peer.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peers.rs:419:14 [INFO] [stderr] | [INFO] [stderr] 419 | .map(|x| x.info.addr.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `x.info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/protocol.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | if adapter.is_banned(self.addr.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/store.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | const PEER_PREFIX: u8 = 'p' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'p' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/store.rs:90:31 [INFO] [stderr] | [INFO] [stderr] 90 | let last_connected = if let Err(_) = lc { [INFO] [stderr] | ______________________________- ^^^^^^ [INFO] [stderr] 91 | | Utc::now().timestamp() [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | lc.unwrap() [INFO] [stderr] 94 | | }; [INFO] [stderr] | |_________- help: try this: `if lc.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:310:18 [INFO] [stderr] | [INFO] [stderr] 310 | capabilities: info.capabilities.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `info.capabilities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | version: info.version.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `info.version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:313:10 [INFO] [stderr] | [INFO] [stderr] 313 | addr: info.addr.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `info.addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:314:15 [INFO] [stderr] | [INFO] [stderr] 314 | direction: info.direction.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `info.direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/ser_deser.rs:49:48 [INFO] [stderr] | [INFO] [stderr] 49 | p2p::types::Capabilities::from_bits_truncate(0b00000000 as u32), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/ser_deser.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | p2p::types::Capabilities::from_bits_truncate(0b10000000 as u32), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/ser_deser.rs:62:48 [INFO] [stderr] | [INFO] [stderr] 62 | p2p::types::Capabilities::from_bits_truncate(0b00001111 as u32), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/ser_deser.rs:66:48 [INFO] [stderr] | [INFO] [stderr] 66 | p2p::types::Capabilities::from_bits_truncate(0b11111111 as u32), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/ser_deser.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | p2p::types::Capabilities::from_bits_truncate(0b00101111 as u32), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/ser_deser.rs:75:48 [INFO] [stderr] | [INFO] [stderr] 75 | p2p::types::Capabilities::from_bits_truncate(0b00101111 as u32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/ser_deser.rs:80:48 [INFO] [stderr] | [INFO] [stderr] 80 | p2p::types::Capabilities::from_bits_truncate(0b00101111 as u32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/peer_handshake.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | Hash::from_vec(&vec![]), [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/peer_handshake.rs:79:50 [INFO] [stderr] | [INFO] [stderr] 79 | &p2p::handshake::Handshake::new(Hash::from_vec(&vec![]), p2p_config.clone()), [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 37s [INFO] running `"docker" "inspect" "b2b894c2f2ad9736f8314888f51303dd9e426e5bab0030f77401d4591c796ce8"` [INFO] running `"docker" "rm" "-f" "b2b894c2f2ad9736f8314888f51303dd9e426e5bab0030f77401d4591c796ce8"` [INFO] [stdout] b2b894c2f2ad9736f8314888f51303dd9e426e5bab0030f77401d4591c796ce8