[INFO] crate grin_keychain 0.4.2 is already in cache [INFO] extracting crate grin_keychain 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/grin_keychain/0.4.2 [INFO] extracting crate grin_keychain 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_keychain/0.4.2 [INFO] validating manifest of grin_keychain-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grin_keychain-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grin_keychain-0.4.2 [INFO] finished frobbing grin_keychain-0.4.2 [INFO] frobbed toml for grin_keychain-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/grin_keychain/0.4.2/Cargo.toml [INFO] started frobbing grin_keychain-0.4.2 [INFO] finished frobbing grin_keychain-0.4.2 [INFO] frobbed toml for grin_keychain-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grin_keychain/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grin_keychain-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grin_keychain/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1f588c25211dd57881f6698c257531994b07a10e3cba14c834c67c57cd74fe1 [INFO] running `"docker" "start" "-a" "c1f588c25211dd57881f6698c257531994b07a10e3cba14c834c67c57cd74fe1"` [INFO] [stderr] Compiling grin_secp256k1zkp v0.7.4 [INFO] [stderr] Checking arrayvec v0.4.10 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking ripemd160 v0.7.0 [INFO] [stderr] Checking pbkdf2 v0.2.3 [INFO] [stderr] Checking blake2-rfc v0.2.18 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking grin_util v0.4.2 [INFO] [stderr] Checking grin_keychain v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:205:25 [INFO] [stderr] | [INFO] [stderr] 205 | ChildNumber::Normal { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | ChildNumber::Hardened { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:550:4 [INFO] [stderr] | [INFO] [stderr] 550 | chain_code: chain_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chain_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:610:4 [INFO] [stderr] | [INFO] [stderr] 610 | network: network, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:613:4 [INFO] [stderr] | [INFO] [stderr] 613 | child_number: child_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:655:4 [INFO] [stderr] | [INFO] [stderr] 655 | network: network, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:658:4 [INFO] [stderr] | [INFO] [stderr] 658 | child_number: child_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:382:4 [INFO] [stderr] | [INFO] [stderr] 382 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keychain.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | secp: secp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `secp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keychain.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | master: master, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `master` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keychain.rs:50:4 [INFO] [stderr] | [INFO] [stderr] 50 | secp: secp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `secp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keychain.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | master: master, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `master` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:205:25 [INFO] [stderr] | [INFO] [stderr] 205 | ChildNumber::Normal { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | ChildNumber::Hardened { index: index } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:550:4 [INFO] [stderr] | [INFO] [stderr] 550 | chain_code: chain_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chain_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:610:4 [INFO] [stderr] | [INFO] [stderr] 610 | network: network, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:613:4 [INFO] [stderr] | [INFO] [stderr] 613 | child_number: child_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:655:4 [INFO] [stderr] | [INFO] [stderr] 655 | network: network, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extkey_bip32.rs:658:4 [INFO] [stderr] | [INFO] [stderr] 658 | child_number: child_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `child_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:382:4 [INFO] [stderr] | [INFO] [stderr] 382 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keychain.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | secp: secp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `secp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keychain.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | master: master, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `master` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keychain.rs:50:4 [INFO] [stderr] | [INFO] [stderr] 50 | secp: secp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `secp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keychain.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | master: master, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `master` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extkey_bip32.rs:457:3 [INFO] [stderr] | [INFO] [stderr] 457 | ripemd_res [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extkey_bip32.rs:455:20 [INFO] [stderr] | [INFO] [stderr] 455 | let ripemd_res = hasher.ripemd_160(&sha2_res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extkey_bip32.rs:564:3 [INFO] [stderr] | [INFO] [stderr] 564 | ripemd_res [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extkey_bip32.rs:562:20 [INFO] [stderr] | [INFO] [stderr] 562 | let ripemd_res = hasher.ripemd_160(&sha2_res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:92:34 [INFO] [stderr] | [INFO] [stderr] 92 | entropy[datalen - loc / 8] |= (bit as u8) << loc % 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(bit as u8) << (loc % 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | let actual = (hash[0] >> 8 - checksum_bits) & mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `hash[0] >> (8 - checksum_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:127:18 [INFO] [stderr] | [INFO] [stderr] 127 | let checksum = (hash[0] >> 8 - checksum_bits) & mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `hash[0] >> (8 - checksum_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:137:25 [INFO] [stderr] | [INFO] [stderr] 137 | indexes[loc / 11] |= (bit as u16) << 10 - (loc % 11); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(bit as u16) << (10 - (loc % 11))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | indexes[loc / 11] |= (bit as u16) << 10 - (loc % 11); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(bit as u16) << (10 - (loc % 11))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extkey_bip32.rs:457:3 [INFO] [stderr] | [INFO] [stderr] 457 | ripemd_res [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extkey_bip32.rs:455:20 [INFO] [stderr] | [INFO] [stderr] 455 | let ripemd_res = hasher.ripemd_160(&sha2_res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/extkey_bip32.rs:564:3 [INFO] [stderr] | [INFO] [stderr] 564 | ripemd_res [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/extkey_bip32.rs:562:20 [INFO] [stderr] | [INFO] [stderr] 562 | let ripemd_res = hasher.ripemd_160(&sha2_res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/extkey_bip32.rs:827:194 [INFO] [stderr] | [INFO] [stderr] 827 | test_path(&secp, &seed, &[ChildNumber::from_hardened_idx(0), ChildNumber::from_normal_idx(1), ChildNumber::from_hardened_idx(2), ChildNumber::from_normal_idx(2), ChildNumber::from_normal_idx(1000000000)], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/extkey_bip32.rs:848:93 [INFO] [stderr] | [INFO] [stderr] 848 | test_path(&secp, &seed, &[ChildNumber::from_normal_idx(0), ChildNumber::from_hardened_idx(2147483647)], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/extkey_bip32.rs:853:93 [INFO] [stderr] | [INFO] [stderr] 853 | test_path(&secp, &seed, &[ChildNumber::from_normal_idx(0), ChildNumber::from_hardened_idx(2147483647), ChildNumber::from_normal_idx(1)], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/extkey_bip32.rs:858:93 [INFO] [stderr] | [INFO] [stderr] 858 | test_path(&secp, &seed, &[ChildNumber::from_normal_idx(0), ChildNumber::from_hardened_idx(2147483647), ChildNumber::from_normal_idx(1), ChildNumber::from_hardened_idx(2147483646)], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/extkey_bip32.rs:858:170 [INFO] [stderr] | [INFO] [stderr] 858 | test_path(&secp, &seed, &[ChildNumber::from_normal_idx(0), ChildNumber::from_hardened_idx(2147483647), ChildNumber::from_normal_idx(1), ChildNumber::from_hardened_idx(2147483646)], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_646` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/extkey_bip32.rs:863:93 [INFO] [stderr] | [INFO] [stderr] 863 | test_path(&secp, &seed, &[ChildNumber::from_normal_idx(0), ChildNumber::from_hardened_idx(2147483647), ChildNumber::from_normal_idx(1), ChildNumber::from_hardened_idx(2147483646), ChildNumber::from_normal_idx(2)], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/extkey_bip32.rs:863:170 [INFO] [stderr] | [INFO] [stderr] 863 | test_path(&secp, &seed, &[ChildNumber::from_normal_idx(0), ChildNumber::from_hardened_idx(2147483647), ChildNumber::from_normal_idx(1), ChildNumber::from_hardened_idx(2147483646), ChildNumber::from_normal_idx(2)], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_646` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:92:34 [INFO] [stderr] | [INFO] [stderr] 92 | entropy[datalen - loc / 8] |= (bit as u8) << loc % 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(bit as u8) << (loc % 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | let actual = (hash[0] >> 8 - checksum_bits) & mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `hash[0] >> (8 - checksum_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:127:18 [INFO] [stderr] | [INFO] [stderr] 127 | let checksum = (hash[0] >> 8 - checksum_bits) & mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `hash[0] >> (8 - checksum_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:137:25 [INFO] [stderr] | [INFO] [stderr] 137 | indexes[loc / 11] |= (bit as u16) << 10 - (loc % 11); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(bit as u16) << (10 - (loc % 11))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mnemonic.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | indexes[loc / 11] |= (bit as u16) << 10 - (loc % 11); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(bit as u16) << (10 - (loc % 11))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/base58.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | Some(d58) => d58 as u32, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(d58)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/base58.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | carry += *d256 as u32 * 58; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*d256)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `extkey_bip32::BIP32GrinHasher` [INFO] [stderr] --> src/extkey_bip32.rs:98:2 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn new() -> BIP32GrinHasher { [INFO] [stderr] | _____^ [INFO] [stderr] 99 | | BIP32GrinHasher { [INFO] [stderr] 100 | | hmac_sha512: HmacSha512::new(GenericArray::from_slice(&[0u8; 128])), [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | impl Default for extkey_bip32::BIP32GrinHasher { [INFO] [stderr] 97 | fn default() -> Self { [INFO] [stderr] 98 | Self::new() [INFO] [stderr] 99 | } [INFO] [stderr] 100 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/extkey_bip32.rs:225:19 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn is_normal(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/extkey_bip32.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn is_hardened(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/extkey_bip32.rs:541:16 [INFO] [stderr] | [INFO] [stderr] 541 | let mut pk = self.public_key.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.public_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mnemonic.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn from_entropy(entropy: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/types.rs:142:12 [INFO] [stderr] | [INFO] [stderr] 142 | for i in 1..IDENTIFIER_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `id[1..IDENTIFIER_SIZE].clone_from_slice(&p[0..(IDENTIFIER_SIZE - 1)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/types.rs:153:4 [INFO] [stderr] | [INFO] [stderr] 153 | p.depth = p.depth - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `p.depth -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/types.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | for i in 0..min(IDENTIFIER_SIZE, bytes.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `identifier[..min(IDENTIFIER_SIZE, bytes.len())].clone_from_slice(&bytes[..min(IDENTIFIER_SIZE, bytes.len())])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:166:3 [INFO] [stderr] | [INFO] [stderr] 166 | self.0.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/types.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | for i in 0..min(SECRET_KEY_SIZE, data.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `blind[..min(SECRET_KEY_SIZE, data.len())].clone_from_slice(&data[..min(SECRET_KEY_SIZE, data.len())])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/types.rs:296:60 [INFO] [stderr] | [INFO] [stderr] 296 | secp::key::SecretKey::from_slice(secp, &self.0).map_err(|e| Error::Secp(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Secp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::BlindSum` [INFO] [stderr] --> src/types.rs:338:2 [INFO] [stderr] | [INFO] [stderr] 338 | pub fn new() -> BlindSum { [INFO] [stderr] | _____^ [INFO] [stderr] 339 | | BlindSum { [INFO] [stderr] 340 | | positive_key_ids: vec![], [INFO] [stderr] 341 | | negative_key_ids: vec![], [INFO] [stderr] ... | [INFO] [stderr] 344 | | } [INFO] [stderr] 345 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 329 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/base58.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | Some(d58) => d58 as u32, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(d58)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/base58.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | carry += *d256 as u32 * 58; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*d256)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `extkey_bip32::BIP32GrinHasher` [INFO] [stderr] --> src/extkey_bip32.rs:98:2 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn new() -> BIP32GrinHasher { [INFO] [stderr] | _____^ [INFO] [stderr] 99 | | BIP32GrinHasher { [INFO] [stderr] 100 | | hmac_sha512: HmacSha512::new(GenericArray::from_slice(&[0u8; 128])), [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | impl Default for extkey_bip32::BIP32GrinHasher { [INFO] [stderr] 97 | fn default() -> Self { [INFO] [stderr] 98 | Self::new() [INFO] [stderr] 99 | } [INFO] [stderr] 100 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/extkey_bip32.rs:225:19 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn is_normal(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/extkey_bip32.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn is_hardened(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/extkey_bip32.rs:541:16 [INFO] [stderr] | [INFO] [stderr] 541 | let mut pk = self.public_key.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.public_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mnemonic.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn from_entropy(entropy: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/types.rs:142:12 [INFO] [stderr] | [INFO] [stderr] 142 | for i in 1..IDENTIFIER_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `id[1..IDENTIFIER_SIZE].clone_from_slice(&p[0..(IDENTIFIER_SIZE - 1)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/types.rs:153:4 [INFO] [stderr] | [INFO] [stderr] 153 | p.depth = p.depth - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `p.depth -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/types.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | for i in 0..min(IDENTIFIER_SIZE, bytes.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `identifier[..min(IDENTIFIER_SIZE, bytes.len())].clone_from_slice(&bytes[..min(IDENTIFIER_SIZE, bytes.len())])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:166:3 [INFO] [stderr] | [INFO] [stderr] 166 | self.0.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/types.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | for i in 0..min(SECRET_KEY_SIZE, data.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `blind[..min(SECRET_KEY_SIZE, data.len())].clone_from_slice(&data[..min(SECRET_KEY_SIZE, data.len())])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/types.rs:296:60 [INFO] [stderr] | [INFO] [stderr] 296 | secp::key::SecretKey::from_slice(secp, &self.0).map_err(|e| Error::Secp(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Secp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::BlindSum` [INFO] [stderr] --> src/types.rs:338:2 [INFO] [stderr] | [INFO] [stderr] 338 | pub fn new() -> BlindSum { [INFO] [stderr] | _____^ [INFO] [stderr] 339 | | BlindSum { [INFO] [stderr] 340 | | positive_key_ids: vec![], [INFO] [stderr] 341 | | negative_key_ids: vec![], [INFO] [stderr] ... | [INFO] [stderr] 344 | | } [INFO] [stderr] 345 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 329 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/types.rs:465:3 [INFO] [stderr] | [INFO] [stderr] 465 | let _ = skey_sum.add_assign(&secp, &skey_2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:477:22 [INFO] [stderr] | [INFO] [stderr] 477 | let mut skey_out = skey_in.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `skey_in` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/types.rs:478:3 [INFO] [stderr] | [INFO] [stderr] 478 | let _ = skey_out.add_assign(&secp, &skey_zero).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keychain.rs:205:19 [INFO] [stderr] | [INFO] [stderr] 205 | let mut skey3 = skey1.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `skey1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/keychain.rs:206:3 [INFO] [stderr] | [INFO] [stderr] 206 | let _ = skey3.add_assign(&keychain.secp, &skey2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keychain.rs:217:21 [INFO] [stderr] | [INFO] [stderr] 217 | .commit_sum(vec![commit_1.clone(), commit_2.clone()], vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `commit_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keychain.rs:217:39 [INFO] [stderr] | [INFO] [stderr] 217 | .commit_sum(vec![commit_1.clone(), commit_2.clone()], vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `commit_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.70s [INFO] running `"docker" "inspect" "c1f588c25211dd57881f6698c257531994b07a10e3cba14c834c67c57cd74fe1"` [INFO] running `"docker" "rm" "-f" "c1f588c25211dd57881f6698c257531994b07a10e3cba14c834c67c57cd74fe1"` [INFO] [stdout] c1f588c25211dd57881f6698c257531994b07a10e3cba14c834c67c57cd74fe1