[INFO] crate grid_search 0.14.0 is already in cache
[INFO] extracting crate grid_search 0.14.0 into work/ex/clippy-test-run/sources/stable/reg/grid_search/0.14.0
[INFO] extracting crate grid_search 0.14.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grid_search/0.14.0
[INFO] validating manifest of grid_search-0.14.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of grid_search-0.14.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing grid_search-0.14.0
[INFO] finished frobbing grid_search-0.14.0
[INFO] frobbed toml for grid_search-0.14.0 written to work/ex/clippy-test-run/sources/stable/reg/grid_search/0.14.0/Cargo.toml
[INFO] started frobbing grid_search-0.14.0
[INFO] finished frobbing grid_search-0.14.0
[INFO] frobbed toml for grid_search-0.14.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grid_search/0.14.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting grid_search-0.14.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grid_search/0.14.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 065bdc35b7860d55fa32a070a8e8741bc2b2fa28acc47356bd1ddee9e9f9bc0b
[INFO] running `"docker" "start" "-a" "065bdc35b7860d55fa32a070a8e8741bc2b2fa28acc47356bd1ddee9e9f9bc0b"`
[INFO] [stderr]     Checking best v0.6.0
[INFO] [stderr]     Checking direction v0.15.1
[INFO] [stderr]     Checking grid_search v0.14.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/bfs.rs:80:5
[INFO] [stderr]     |
[INFO] [stderr] 80  | /     pub fn bfs_best<G, V, D, S, F>(
[INFO] [stderr] 81  | |         &mut self,
[INFO] [stderr] 82  | |         grid: &G,
[INFO] [stderr] 83  | |         start: Coord,
[INFO] [stderr] ...   |
[INFO] [stderr] 175 | |         }
[INFO] [stderr] 176 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/search.rs:153:5
[INFO] [stderr]     |
[INFO] [stderr] 153 | /     pub(crate) fn search_general<G, V, D, H>(
[INFO] [stderr] 154 | |         &mut self,
[INFO] [stderr] 155 | |         grid: &G,
[INFO] [stderr] 156 | |         start: Coord,
[INFO] [stderr] ...   |
[INFO] [stderr] 226 | |         Err(Error::NoPath)
[INFO] [stderr] 227 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/grid.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 | /         if let &CostCell::Solid = self {
[INFO] [stderr] 20 | |             true
[INFO] [stderr] 21 | |         } else {
[INFO] [stderr] 22 | |             false
[INFO] [stderr] 23 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 19 |         if let CostCell::Solid = *self {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/path.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 | /     loop {
[INFO] [stderr] 39 | |         let from_parent = if let Some(from_parent) = node.from_parent() {
[INFO] [stderr] 40 | |             from_parent
[INFO] [stderr] 41 | |         } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |         }
[INFO] [stderr] 59 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(from_parent) = node.from_parent() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/path.rs:70:36
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn new(start: Coord, path: &'a Vec<Direction>) -> Self {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Direction]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/path.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             self.current_coord = self.current_coord + offset;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current_coord += offset`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/distance_map.rs:53:22
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn is_origin(self) -> bool {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/distance_map.rs:59:25
[INFO] [stderr]    |
[INFO] [stderr] 59 |     pub fn is_unvisited(self) -> bool {
[INFO] [stderr]    |                         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/distance_map.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |     pub fn is_outside(self) -> bool {
[INFO] [stderr]    |                       ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/bfs.rs:80:5
[INFO] [stderr]     |
[INFO] [stderr] 80  | /     pub fn bfs_best<G, V, D, S, F>(
[INFO] [stderr] 81  | |         &mut self,
[INFO] [stderr] 82  | |         grid: &G,
[INFO] [stderr] 83  | |         start: Coord,
[INFO] [stderr] ...   |
[INFO] [stderr] 175 | |         }
[INFO] [stderr] 176 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/search.rs:153:5
[INFO] [stderr]     |
[INFO] [stderr] 153 | /     pub(crate) fn search_general<G, V, D, H>(
[INFO] [stderr] 154 | |         &mut self,
[INFO] [stderr] 155 | |         grid: &G,
[INFO] [stderr] 156 | |         start: Coord,
[INFO] [stderr] ...   |
[INFO] [stderr] 226 | |         Err(Error::NoPath)
[INFO] [stderr] 227 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/grid.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 | /         if let &CostCell::Solid = self {
[INFO] [stderr] 20 | |             true
[INFO] [stderr] 21 | |         } else {
[INFO] [stderr] 22 | |             false
[INFO] [stderr] 23 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 19 |         if let CostCell::Solid = *self {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/path.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 | /     loop {
[INFO] [stderr] 39 | |         let from_parent = if let Some(from_parent) = node.from_parent() {
[INFO] [stderr] 40 | |             from_parent
[INFO] [stderr] 41 | |         } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |         }
[INFO] [stderr] 59 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(from_parent) = node.from_parent() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/path.rs:70:36
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn new(start: Coord, path: &'a Vec<Direction>) -> Self {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Direction]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/path.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             self.current_coord = self.current_coord + offset;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current_coord += offset`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/distance_map.rs:53:22
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn is_origin(self) -> bool {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/distance_map.rs:59:25
[INFO] [stderr]    |
[INFO] [stderr] 59 |     pub fn is_unvisited(self) -> bool {
[INFO] [stderr]    |                         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/distance_map.rs:65:23
[INFO] [stderr]    |
[INFO] [stderr] 65 |     pub fn is_outside(self) -> bool {
[INFO] [stderr]    |                       ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/tests/bfs.rs:10:31
[INFO] [stderr]    |
[INFO] [stderr] 10 | fn grid_from_strings(strings: &Vec<&str>) -> (Grid<bool>, Coord, Coord) {
[INFO] [stderr]    |                               ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/tests/bfs.rs:17:30
[INFO] [stderr]    |
[INFO] [stderr] 17 |     for (i, line) in strings.into_iter().enumerate() {
[INFO] [stderr]    |                              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/tests/bfs.rs:51:31
[INFO] [stderr]    |
[INFO] [stderr] 51 | fn common_test<V, D>(strings: &Vec<&str>, directions: D, length: usize)
[INFO] [stderr]    |                               ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/tests/search.rs:46:31
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn grid_from_strings(strings: &Vec<&str>, ordinal_multiplier: u32) -> (TestGrid, Coord, Coord) {
[INFO] [stderr]    |                               ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/tests/search.rs:53:30
[INFO] [stderr]    |
[INFO] [stderr] 53 |     for (i, line) in strings.into_iter().enumerate() {
[INFO] [stderr]    |                              ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/tests/search.rs:103:14
[INFO] [stderr]     |
[INFO] [stderr] 103 |     strings: &Vec<&str>,
[INFO] [stderr]     |              ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.11s
[INFO] running `"docker" "inspect" "065bdc35b7860d55fa32a070a8e8741bc2b2fa28acc47356bd1ddee9e9f9bc0b"`
[INFO] running `"docker" "rm" "-f" "065bdc35b7860d55fa32a070a8e8741bc2b2fa28acc47356bd1ddee9e9f9bc0b"`
[INFO] [stdout] 065bdc35b7860d55fa32a070a8e8741bc2b2fa28acc47356bd1ddee9e9f9bc0b