[INFO] crate grid-sim 0.3.0 is already in cache [INFO] extracting crate grid-sim 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/grid-sim/0.3.0 [INFO] extracting crate grid-sim 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grid-sim/0.3.0 [INFO] validating manifest of grid-sim-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grid-sim-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grid-sim-0.3.0 [INFO] finished frobbing grid-sim-0.3.0 [INFO] frobbed toml for grid-sim-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/grid-sim/0.3.0/Cargo.toml [INFO] started frobbing grid-sim-0.3.0 [INFO] finished frobbing grid-sim-0.3.0 [INFO] frobbed toml for grid-sim-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grid-sim/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grid-sim-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grid-sim/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf336a384e5931802be9dcb0f9883f5b05aace44523a0656f9a80e543aa93bbc [INFO] running `"docker" "start" "-a" "cf336a384e5931802be9dcb0f9883f5b05aace44523a0656f9a80e543aa93bbc"` [INFO] [stderr] Checking grid-sim v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/cell.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | Cell { xy: xy, state: init } [INFO] [stderr] | ^^^^^^ help: replace it with: `xy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/builder/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/builder/mod.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/builder/mod.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | init: init, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `init` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/mod.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/mod.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | rules: rules, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/cell.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | Cell { xy: xy, state: init } [INFO] [stderr] | ^^^^^^ help: replace it with: `xy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/builder/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/builder/mod.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/builder/mod.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | init: init, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `init` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/mod.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/mod.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | rules: rules, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/world/builder/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / match rng.gen() { [INFO] [stderr] 83 | | true => cell.set_state(CellState::Live), [INFO] [stderr] 84 | | false => cell.set_state(CellState::Dead), [INFO] [stderr] 85 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if rng.gen() { cell.set_state(CellState::Live) } else { cell.set_state(CellState::Dead) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world/builder/mod.rs:88:66 [INFO] [stderr] | [INFO] [stderr] 88 | fn populate_ordered(&self, grid_ref: &mut Vec, coords: &Vec<(u64, u64)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(u64, u64)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `world::rules::DSLRuleset` [INFO] [stderr] --> src/world/rules/mod.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn new() -> Self { [INFO] [stderr] 90 | | DSLRuleset { [INFO] [stderr] 91 | | data: HashMap::new(), [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world/rules/mod.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match self.data.get(&key) { [INFO] [stderr] 117 | | Some(vec) => { [INFO] [stderr] 118 | | for &(ref trigger_amt, ref result_state) in vec { [INFO] [stderr] 119 | | if trigger_amt == amt { [INFO] [stderr] ... | [INFO] [stderr] 124 | | None => (), [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | if let Some(vec) = self.data.get(&key) { [INFO] [stderr] 117 | for &(ref trigger_amt, ref result_state) in vec { [INFO] [stderr] 118 | if trigger_amt == amt { [INFO] [stderr] 119 | return_state = result_state.clone(); [INFO] [stderr] 120 | } [INFO] [stderr] 121 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::WorldOptions` [INFO] [stderr] --> src/world/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | WorldOptions { [INFO] [stderr] 22 | | width: 0, [INFO] [stderr] 23 | | height: 0, [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for world::WorldOptions { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/world/mod.rs:83:32 [INFO] [stderr] | [INFO] [stderr] 83 | let x = x as i64 + rule.0 as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(rule.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/world/mod.rs:84:32 [INFO] [stderr] | [INFO] [stderr] 84 | let y = y as i64 + rule.1 as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(rule.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/world/mod.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | self.time = self.time + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.time += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/world/builder/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / match rng.gen() { [INFO] [stderr] 83 | | true => cell.set_state(CellState::Live), [INFO] [stderr] 84 | | false => cell.set_state(CellState::Dead), [INFO] [stderr] 85 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if rng.gen() { cell.set_state(CellState::Live) } else { cell.set_state(CellState::Dead) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world/builder/mod.rs:88:66 [INFO] [stderr] | [INFO] [stderr] 88 | fn populate_ordered(&self, grid_ref: &mut Vec, coords: &Vec<(u64, u64)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(u64, u64)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `world::rules::DSLRuleset` [INFO] [stderr] --> src/world/rules/mod.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn new() -> Self { [INFO] [stderr] 90 | | DSLRuleset { [INFO] [stderr] 91 | | data: HashMap::new(), [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world/rules/mod.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match self.data.get(&key) { [INFO] [stderr] 117 | | Some(vec) => { [INFO] [stderr] 118 | | for &(ref trigger_amt, ref result_state) in vec { [INFO] [stderr] 119 | | if trigger_amt == amt { [INFO] [stderr] ... | [INFO] [stderr] 124 | | None => (), [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | if let Some(vec) = self.data.get(&key) { [INFO] [stderr] 117 | for &(ref trigger_amt, ref result_state) in vec { [INFO] [stderr] 118 | if trigger_amt == amt { [INFO] [stderr] 119 | return_state = result_state.clone(); [INFO] [stderr] 120 | } [INFO] [stderr] 121 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `world::WorldOptions` [INFO] [stderr] --> src/world/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | WorldOptions { [INFO] [stderr] 22 | | width: 0, [INFO] [stderr] 23 | | height: 0, [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for world::WorldOptions { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/world/mod.rs:83:32 [INFO] [stderr] | [INFO] [stderr] 83 | let x = x as i64 + rule.0 as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(rule.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/world/mod.rs:84:32 [INFO] [stderr] | [INFO] [stderr] 84 | let y = y as i64 + rule.1 as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(rule.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/world/mod.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | self.time = self.time + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.time += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.38s [INFO] running `"docker" "inspect" "cf336a384e5931802be9dcb0f9883f5b05aace44523a0656f9a80e543aa93bbc"` [INFO] running `"docker" "rm" "-f" "cf336a384e5931802be9dcb0f9883f5b05aace44523a0656f9a80e543aa93bbc"` [INFO] [stdout] cf336a384e5931802be9dcb0f9883f5b05aace44523a0656f9a80e543aa93bbc