[INFO] crate grep-searcher 0.1.1 is already in cache [INFO] extracting crate grep-searcher 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/grep-searcher/0.1.1 [INFO] extracting crate grep-searcher 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grep-searcher/0.1.1 [INFO] validating manifest of grep-searcher-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grep-searcher-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grep-searcher-0.1.1 [INFO] finished frobbing grep-searcher-0.1.1 [INFO] frobbed toml for grep-searcher-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/grep-searcher/0.1.1/Cargo.toml [INFO] started frobbing grep-searcher-0.1.1 [INFO] finished frobbing grep-searcher-0.1.1 [INFO] frobbed toml for grep-searcher-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grep-searcher/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grep-searcher-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grep-searcher/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9881f135e1bbec2ed731f302f50d6ec35d5e97eb5f0d14ec7e9c17b981e4847 [INFO] running `"docker" "start" "-a" "f9881f135e1bbec2ed731f302f50d6ec35d5e97eb5f0d14ec7e9c17b981e4847"` [INFO] [stderr] Checking grep-searcher v0.1.1 (/opt/crater/workdir) [INFO] [stderr] Checking grep-regex v0.1.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lines.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lines.rs:65:43 [INFO] [stderr] | [INFO] [stderr] 65 | LineStep { line_term, pos: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | searcher: searcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `searcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | sink: sink, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | binary: binary, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `binary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/glue.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/glue.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/mod.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/mod.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | decode_builder: decode_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `decode_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/searcher/core.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | consumed [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/searcher/core.rs:133:32 [INFO] [stderr] | [INFO] [stderr] 133 | let consumed = cmp::max(context_start, self.last_line_visited); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/searcher/core.rs:275:20 [INFO] [stderr] | [INFO] [stderr] 275 | } else if self.config.passthru { [INFO] [stderr] | ____________________^ [INFO] [stderr] 276 | | if !self.sink_other_context(buf, &line)? { [INFO] [stderr] 277 | | return Ok(false); [INFO] [stderr] 278 | | } [INFO] [stderr] 279 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 275 | } else if self.config.passthru && !self.sink_other_context(buf, &line)? { [INFO] [stderr] 276 | return Ok(false); [INFO] [stderr] 277 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/line_buffer.rs:77:16 [INFO] [stderr] | [INFO] [stderr] 77 | fn is_quit(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `searcher::Searcher` [INFO] [stderr] --> src/searcher/mod.rs:567:5 [INFO] [stderr] | [INFO] [stderr] 567 | / pub fn new() -> Searcher { [INFO] [stderr] 568 | | SearcherBuilder::new().build() [INFO] [stderr] 569 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 561 | impl Default for searcher::Searcher { [INFO] [stderr] 562 | fn default() -> Self { [INFO] [stderr] 563 | Self::new() [INFO] [stderr] 564 | } [INFO] [stderr] 565 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lines.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lines.rs:65:43 [INFO] [stderr] | [INFO] [stderr] 65 | LineStep { line_term, pos: start, end: end } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | searcher: searcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `searcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | sink: sink, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | binary: binary, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `binary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/core.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/glue.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/glue.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | slice: slice, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/mod.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/searcher/mod.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | decode_builder: decode_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `decode_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/testutil.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | regex: regex, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `regex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.0, "")` [INFO] [stderr] --> src/testutil.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | writeln!(self.0, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/line_buffer.rs:565:22 [INFO] [stderr] | [INFO] [stderr] 565 | const SHERLOCK: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lines.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | const SHERLOCK: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/searcher/core.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | consumed [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/searcher/core.rs:133:32 [INFO] [stderr] | [INFO] [stderr] 133 | let consumed = cmp::max(context_start, self.last_line_visited); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/searcher/core.rs:275:20 [INFO] [stderr] | [INFO] [stderr] 275 | } else if self.config.passthru { [INFO] [stderr] | ____________________^ [INFO] [stderr] 276 | | if !self.sink_other_context(buf, &line)? { [INFO] [stderr] 277 | | return Ok(false); [INFO] [stderr] 278 | | } [INFO] [stderr] 279 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 275 | } else if self.config.passthru && !self.sink_other_context(buf, &line)? { [INFO] [stderr] 276 | return Ok(false); [INFO] [stderr] 277 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/searcher/glue.rs:343:22 [INFO] [stderr] | [INFO] [stderr] 343 | const SHERLOCK: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/searcher/glue.rs:352:18 [INFO] [stderr] | [INFO] [stderr] 352 | const CODE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/searcher/glue.rs:1487:26 [INFO] [stderr] | [INFO] [stderr] 1487 | const SHERLOCK: &'static [u8] = b"\ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/search-stdin.rs:23:39 [INFO] [stderr] | [INFO] [stderr] 23 | None => return Err(From::from(format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 24 | | "Usage: search-stdin " [INFO] [stderr] 25 | | ))), [INFO] [stderr] | |_________^ help: consider using .to_string(): `"Usage: search-stdin ".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/line_buffer.rs:77:16 [INFO] [stderr] | [INFO] [stderr] 77 | fn is_quit(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/lines.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | / fn preceding_lines_short() { [INFO] [stderr] 380 | | let t = "a\nb\nc\nd\ne\nf\n"; [INFO] [stderr] 381 | | let lines = line_ranges(t); [INFO] [stderr] 382 | | assert_eq!(12, t.len()); [INFO] [stderr] ... | [INFO] [stderr] 420 | | assert_eq!(lines[0].start, prev(t, lines[0].start, 1)); [INFO] [stderr] 421 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `searcher::Searcher` [INFO] [stderr] --> src/searcher/mod.rs:567:5 [INFO] [stderr] | [INFO] [stderr] 567 | / pub fn new() -> Searcher { [INFO] [stderr] 568 | | SearcherBuilder::new().build() [INFO] [stderr] 569 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 561 | impl Default for searcher::Searcher { [INFO] [stderr] 562 | fn default() -> Self { [INFO] [stderr] 563 | Self::new() [INFO] [stderr] 564 | } [INFO] [stderr] 565 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.58s [INFO] running `"docker" "inspect" "f9881f135e1bbec2ed731f302f50d6ec35d5e97eb5f0d14ec7e9c17b981e4847"` [INFO] running `"docker" "rm" "-f" "f9881f135e1bbec2ed731f302f50d6ec35d5e97eb5f0d14ec7e9c17b981e4847"` [INFO] [stdout] f9881f135e1bbec2ed731f302f50d6ec35d5e97eb5f0d14ec7e9c17b981e4847