[INFO] crate grep-regex 0.1.1 is already in cache [INFO] extracting crate grep-regex 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/grep-regex/0.1.1 [INFO] extracting crate grep-regex 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grep-regex/0.1.1 [INFO] validating manifest of grep-regex-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grep-regex-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grep-regex-0.1.1 [INFO] finished frobbing grep-regex-0.1.1 [INFO] frobbed toml for grep-regex-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/grep-regex/0.1.1/Cargo.toml [INFO] started frobbing grep-regex-0.1.1 [INFO] finished frobbing grep-regex-0.1.1 [INFO] frobbed toml for grep-regex-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grep-regex/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grep-regex-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grep-regex/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c4b129d7a34db1b5be66161a69d5c4d6fbabf39e5ffe003648ab32d5d31cbad [INFO] running `"docker" "start" "-a" "5c4b129d7a34db1b5be66161a69d5c4d6fbabf39e5ffe003648ab32d5d31cbad"` [INFO] [stderr] Checking grep-matcher v0.1.1 [INFO] [stderr] Checking grep-regex v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | analysis: analysis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `analysis` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | expr: expr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/literal.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | required: required, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `required` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | fast_line_regex: fast_line_regex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fast_line_regex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | non_matching_bytes: non_matching_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `non_matching_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | analysis: analysis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `analysis` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | expr: expr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/literal.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | required: required, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `required` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | fast_line_regex: fast_line_regex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fast_line_regex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matcher.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | non_matching_bytes: non_matching_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `non_matching_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/ast.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | fn from_ast_impl(&mut self, ast: &Ast) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/ast.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | fn from_ast_class_set(&mut self, ast: &ast::ClassSet) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/ast.rs:136:32 [INFO] [stderr] | [INFO] [stderr] 136 | fn from_ast_class_set_item(&mut self, ast: &ast::ClassSetItem) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/ast.rs:163:25 [INFO] [stderr] | [INFO] [stderr] 163 | fn from_ast_literal(&mut self, ast: &ast::Literal) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/literal.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/literal.rs:260:29 [INFO] [stderr] | [INFO] [stderr] 260 | cls.iter().map(|r| 1 + (r.end() as u32 - r.start() as u32)).sum() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(r.end())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/literal.rs:260:46 [INFO] [stderr] | [INFO] [stderr] 260 | cls.iter().map(|r| 1 + (r.end() as u32 - r.start() as u32)).sum() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(r.start())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/matcher.rs:648:9 [INFO] [stderr] | [INFO] [stderr] 648 | self.names.get(name).map(|i| *i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.names.get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/ast.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | fn from_ast_impl(&mut self, ast: &Ast) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/ast.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | fn from_ast_class_set(&mut self, ast: &ast::ClassSet) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/ast.rs:136:32 [INFO] [stderr] | [INFO] [stderr] 136 | fn from_ast_class_set_item(&mut self, ast: &ast::ClassSetItem) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/ast.rs:163:25 [INFO] [stderr] | [INFO] [stderr] 163 | fn from_ast_literal(&mut self, ast: &ast::Literal) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/ast.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | / fn various() { [INFO] [stderr] 188 | | let x = analysis(""); [INFO] [stderr] 189 | | assert!(!x.any_uppercase); [INFO] [stderr] 190 | | assert!(!x.any_literal); [INFO] [stderr] ... | [INFO] [stderr] 261 | | assert!(!x.all_verbatim_literal); [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/word.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.names.get(name).map(|i| *i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.names.get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/literal.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/literal.rs:260:29 [INFO] [stderr] | [INFO] [stderr] 260 | cls.iter().map(|r| 1 + (r.end() as u32 - r.start() as u32)).sum() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(r.end())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/literal.rs:260:46 [INFO] [stderr] | [INFO] [stderr] 260 | cls.iter().map(|r| 1 + (r.end() as u32 - r.start() as u32)).sum() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(r.start())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/matcher.rs:648:9 [INFO] [stderr] | [INFO] [stderr] 648 | self.names.get(name).map(|i| *i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.names.get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/word.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.names.get(name).map(|i| *i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.names.get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.76s [INFO] running `"docker" "inspect" "5c4b129d7a34db1b5be66161a69d5c4d6fbabf39e5ffe003648ab32d5d31cbad"` [INFO] running `"docker" "rm" "-f" "5c4b129d7a34db1b5be66161a69d5c4d6fbabf39e5ffe003648ab32d5d31cbad"` [INFO] [stdout] 5c4b129d7a34db1b5be66161a69d5c4d6fbabf39e5ffe003648ab32d5d31cbad