[INFO] crate grep-matcher 0.1.1 is already in cache [INFO] extracting crate grep-matcher 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/grep-matcher/0.1.1 [INFO] extracting crate grep-matcher 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grep-matcher/0.1.1 [INFO] validating manifest of grep-matcher-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grep-matcher-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grep-matcher-0.1.1 [INFO] removed 0 missing tests [INFO] finished frobbing grep-matcher-0.1.1 [INFO] frobbed toml for grep-matcher-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/grep-matcher/0.1.1/Cargo.toml [INFO] started frobbing grep-matcher-0.1.1 [INFO] removed 0 missing tests [INFO] finished frobbing grep-matcher-0.1.1 [INFO] frobbed toml for grep-matcher-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grep-matcher/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grep-matcher-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grep-matcher/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0306cc5f467c39e9e5110f9f9e125e60080b0be3e127d9da5f21e8b20af6145e [INFO] running `"docker" "start" "-a" "0306cc5f467c39e9e5110f9f9e125e60080b0be3e127d9da5f21e8b20af6145e"` [INFO] [stderr] Checking grep-matcher v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpolate.rs:135:27 [INFO] [stderr] | [INFO] [stderr] 135 | fn is_valid_cap_letter(b: &u8) -> bool { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:239:20 [INFO] [stderr] | [INFO] [stderr] 239 | pub fn is_crlf(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:249:20 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn as_byte(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:276:22 [INFO] [stderr] | [INFO] [stderr] 276 | pub fn is_suffix(&self, slice: &[u8]) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:341:18 [INFO] [stderr] | [INFO] [stderr] 341 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start as u64..=end as u64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:19 [INFO] [stderr] | [INFO] [stderr] 341 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:357:18 [INFO] [stderr] | [INFO] [stderr] 357 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start as u64..=end as u64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:357:19 [INFO] [stderr] | [INFO] [stderr] 357 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:357:33 [INFO] [stderr] | [INFO] [stderr] 357 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `NoCaptures` [INFO] [stderr] --> src/lib.rs:466:5 [INFO] [stderr] | [INFO] [stderr] 466 | pub fn new() -> NoCaptures { NoCaptures(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 462 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/util.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | re: re, [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/util.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | names: names, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpolate.rs:135:27 [INFO] [stderr] | [INFO] [stderr] 135 | fn is_valid_cap_letter(b: &u8) -> bool { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:156:56 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(Some($capref), find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"$foo"` [INFO] [stderr] ... [INFO] [stderr] 167 | find!(find_cap_ref1, "$foo", c!("foo", 4)); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:156:56 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(Some($capref), find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"${foo}"` [INFO] [stderr] ... [INFO] [stderr] 168 | find!(find_cap_ref2, "${foo}", c!("foo", 6)); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:156:56 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(Some($capref), find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"$0"` [INFO] [stderr] ... [INFO] [stderr] 169 | find!(find_cap_ref3, "$0", c!(0, 2)); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:156:56 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(Some($capref), find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"$5"` [INFO] [stderr] ... [INFO] [stderr] 170 | find!(find_cap_ref4, "$5", c!(5, 2)); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:156:56 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(Some($capref), find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"$10"` [INFO] [stderr] ... [INFO] [stderr] 171 | find!(find_cap_ref5, "$10", c!(10, 3)); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:156:56 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(Some($capref), find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"$42a"` [INFO] [stderr] ... [INFO] [stderr] 172 | find!(find_cap_ref6, "$42a", c!("42a", 4)); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:156:56 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(Some($capref), find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"${42}a"` [INFO] [stderr] ... [INFO] [stderr] 173 | find!(find_cap_ref7, "${42}a", c!(42, 5)); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:150:47 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(None, find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"${42"` [INFO] [stderr] ... [INFO] [stderr] 174 | find!(find_cap_ref8, "${42"); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:150:47 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(None, find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"${42 "` [INFO] [stderr] ... [INFO] [stderr] 175 | find!(find_cap_ref9, "${42 "); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:150:47 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(None, find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" $0 "` [INFO] [stderr] ... [INFO] [stderr] 176 | find!(find_cap_ref10, " $0 "); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:150:47 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(None, find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"$"` [INFO] [stderr] ... [INFO] [stderr] 177 | find!(find_cap_ref11, "$"); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:150:47 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(None, find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "` [INFO] [stderr] ... [INFO] [stderr] 178 | find!(find_cap_ref12, " "); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/interpolate.rs:150:47 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(None, find_cap_ref($text.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] ... [INFO] [stderr] 179 | find!(find_cap_ref13, ""); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:239:20 [INFO] [stderr] | [INFO] [stderr] 239 | pub fn is_crlf(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:249:20 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn as_byte(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:276:22 [INFO] [stderr] | [INFO] [stderr] 276 | pub fn is_suffix(&self, slice: &[u8]) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:341:18 [INFO] [stderr] | [INFO] [stderr] 341 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start as u64..=end as u64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:19 [INFO] [stderr] | [INFO] [stderr] 341 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:33 [INFO] [stderr] | [INFO] [stderr] 341 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:357:18 [INFO] [stderr] | [INFO] [stderr] 357 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start as u64..=end as u64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:357:19 [INFO] [stderr] | [INFO] [stderr] 357 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:357:33 [INFO] [stderr] | [INFO] [stderr] 357 | for b in (start as u64..end as u64 + 1).map(|b| b as u8) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `NoCaptures` [INFO] [stderr] --> src/lib.rs:466:5 [INFO] [stderr] | [INFO] [stderr] 466 | pub fn new() -> NoCaptures { NoCaptures(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 462 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/util.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | self.names.get(name).map(|i| *i) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.names.get(name).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.08s [INFO] running `"docker" "inspect" "0306cc5f467c39e9e5110f9f9e125e60080b0be3e127d9da5f21e8b20af6145e"` [INFO] running `"docker" "rm" "-f" "0306cc5f467c39e9e5110f9f9e125e60080b0be3e127d9da5f21e8b20af6145e"` [INFO] [stdout] 0306cc5f467c39e9e5110f9f9e125e60080b0be3e127d9da5f21e8b20af6145e