[INFO] crate grep-cli 0.1.1 is already in cache [INFO] extracting crate grep-cli 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/grep-cli/0.1.1 [INFO] extracting crate grep-cli 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grep-cli/0.1.1 [INFO] validating manifest of grep-cli-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of grep-cli-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing grep-cli-0.1.1 [INFO] finished frobbing grep-cli-0.1.1 [INFO] frobbed toml for grep-cli-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/grep-cli/0.1.1/Cargo.toml [INFO] started frobbing grep-cli-0.1.1 [INFO] finished frobbing grep-cli-0.1.1 [INFO] frobbed toml for grep-cli-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/grep-cli/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting grep-cli-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/grep-cli/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcb1581ab0d83af0a3d45c7b9de60843f3cab05f60ab9c460885315cbd267cc6 [INFO] running `"docker" "start" "-a" "fcb1581ab0d83af0a3d45c7b9de60843f3cab05f60ab9c460885315cbd267cc6"` [INFO] [stderr] Checking grep-cli v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pattern.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | valid_up_to: valid_up_to, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `valid_up_to` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | child: child, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | stderr: stderr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stderr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pattern.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | valid_up_to: valid_up_to, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `valid_up_to` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | child: child, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/process.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | stderr: stderr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stderr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/escape.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | } else if byte <= 0b110_11111 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1101_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/escape.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | } else if byte <= 0b110_11111 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1101_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/decompress.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | / for i in self.globs.matches(path).into_iter().rev() { [INFO] [stderr] 148 | | let decomp_cmd = &self.commands[i]; [INFO] [stderr] 149 | | let mut cmd = Command::new(&decomp_cmd.bin); [INFO] [stderr] 150 | | cmd.args(&decomp_cmd.args); [INFO] [stderr] 151 | | return Some(cmd); [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `grep-cli`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/decompress.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | / for i in self.globs.matches(path).into_iter().rev() { [INFO] [stderr] 148 | | let decomp_cmd = &self.commands[i]; [INFO] [stderr] 149 | | let mut cmd = Command::new(&decomp_cmd.bin); [INFO] [stderr] 150 | | cmd.args(&decomp_cmd.args); [INFO] [stderr] 151 | | return Some(cmd); [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `grep-cli`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fcb1581ab0d83af0a3d45c7b9de60843f3cab05f60ab9c460885315cbd267cc6"` [INFO] running `"docker" "rm" "-f" "fcb1581ab0d83af0a3d45c7b9de60843f3cab05f60ab9c460885315cbd267cc6"` [INFO] [stdout] fcb1581ab0d83af0a3d45c7b9de60843f3cab05f60ab9c460885315cbd267cc6