[INFO] crate greenglas 0.2.0 is already in cache [INFO] extracting crate greenglas 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/greenglas/0.2.0 [INFO] extracting crate greenglas 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/greenglas/0.2.0 [INFO] validating manifest of greenglas-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of greenglas-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing greenglas-0.2.0 [INFO] removed path dependency coaster from greenglas-0.2.0 [INFO] finished frobbing greenglas-0.2.0 [INFO] frobbed toml for greenglas-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/greenglas/0.2.0/Cargo.toml [INFO] started frobbing greenglas-0.2.0 [INFO] removed path dependency coaster from greenglas-0.2.0 [INFO] finished frobbing greenglas-0.2.0 [INFO] frobbed toml for greenglas-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/greenglas/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting greenglas-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/greenglas/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e620beb1a06713f0b75a2762c672a52696e27fa9a87d5f148f043b972e421487 [INFO] running `"docker" "start" "-a" "e620beb1a06713f0b75a2762c672a52696e27fa9a87d5f148f043b972e421487"` [INFO] [stderr] Checking murmurhash3 v0.0.5 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking coaster v0.1.0 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking greenglas v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `self::modifiers::*` [INFO] [stderr] --> src/word/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use self::modifiers::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/transformer.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut mem_buffer = mem.as_mut_slice::(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/image/mod.rs:21:49 [INFO] [stderr] | [INFO] [stderr] 21 | self.value.raw_pixels().iter().map(|&e| e as f32).collect() [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::modifiers::*` [INFO] [stderr] --> src/word/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use self::modifiers::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/transformer.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut mem_buffer = mem.as_mut_slice::(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/image/mod.rs:21:49 [INFO] [stderr] | [INFO] [stderr] 21 | self.value.raw_pixels().iter().map(|&e| e as f32).collect() [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/word_spec.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | vec![3127628307.0] [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `3_127_628_307.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/transformer_spec.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | match img.transform(&vec![2, 2, 3]) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[2, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/transformer_spec.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | match img.transform(&vec![2, 2, 3]) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[2, 2, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/transformer_spec.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | match img.transform(&vec![3, 3, 3]) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[3, 3, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/transformer_spec.rs:56:39 [INFO] [stderr] | [INFO] [stderr] 56 | match img.set(crop).transform(&vec![1, 1, 3]) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 1, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.02s [INFO] running `"docker" "inspect" "e620beb1a06713f0b75a2762c672a52696e27fa9a87d5f148f043b972e421487"` [INFO] running `"docker" "rm" "-f" "e620beb1a06713f0b75a2762c672a52696e27fa9a87d5f148f043b972e421487"` [INFO] [stdout] e620beb1a06713f0b75a2762c672a52696e27fa9a87d5f148f043b972e421487