[INFO] crate graphql_client_codegen 0.5.1 is already in cache [INFO] extracting crate graphql_client_codegen 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/graphql_client_codegen/0.5.1 [INFO] extracting crate graphql_client_codegen 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphql_client_codegen/0.5.1 [INFO] validating manifest of graphql_client_codegen-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of graphql_client_codegen-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing graphql_client_codegen-0.5.1 [INFO] finished frobbing graphql_client_codegen-0.5.1 [INFO] frobbed toml for graphql_client_codegen-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/graphql_client_codegen/0.5.1/Cargo.toml [INFO] started frobbing graphql_client_codegen-0.5.1 [INFO] finished frobbing graphql_client_codegen-0.5.1 [INFO] frobbed toml for graphql_client_codegen-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphql_client_codegen/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting graphql_client_codegen-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/graphql_client_codegen/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6190ce672428b677b2d2047046ec18827a2b22b9d9fb586a409f3a36bf882766 [INFO] running `"docker" "start" "-a" "6190ce672428b677b2d2047046ec18827a2b22b9d9fb586a409f3a36bf882766"` [INFO] [stderr] Checking combine v3.0.0-beta.1 [INFO] [stderr] Checking graphql-parser v0.2.0 [INFO] [stderr] Checking graphql_client_codegen v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/github.rs:6:21 [INFO] [stderr] | [INFO] [stderr] 6 | const SCHEMA_JSON: &'static str = include_str!("github_schema.json"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests/github.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | const SCHEMA_GRAPHQL: &'static str = include_str!("github_schema.graphql"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/codegen.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match definition { [INFO] [stderr] 17 | | query::Definition::Operation(op) => { [INFO] [stderr] 18 | | operations.push(op.into()); [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | _ => (), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | if let query::Definition::Operation(op) = definition { [INFO] [stderr] 17 | operations.push(op.into()); [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/codegen.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match definition { [INFO] [stderr] 17 | | query::Definition::Operation(op) => { [INFO] [stderr] 18 | | operations.push(op.into()); [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | _ => (), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | if let query::Definition::Operation(op) = definition { [INFO] [stderr] 17 | operations.push(op.into()); [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/query.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / self.fragments [INFO] [stderr] 35 | | .get(typename_) [INFO] [stderr] 36 | | .map(|fragment| fragment.is_required.set(true)); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Some(fragment) = self.fragments [INFO] [stderr] 35 | .get(typename_) { fragment.is_required.set(true) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/query.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if enum_derives.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!enum_derives.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/schema.rs:238:46 [INFO] [stderr] | [INFO] [stderr] 238 | description: ty.description.as_ref().map(|d| d.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ty.description.as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/schema.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | .unwrap_or_else(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/unions.rs:32:6 [INFO] [stderr] | [INFO] [stderr] 32 | ) -> Result<(Vec, Vec, Vec), failure::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/lib.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | let deprecation_strategy = options [INFO] [stderr] | ________________________________^ [INFO] [stderr] 88 | | .deprecation_strategy [INFO] [stderr] 89 | | .unwrap_or(deprecation::DeprecationStrategy::default()); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | let deprecation_strategy = options [INFO] [stderr] 88 | .deprecation_strategy.unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/query.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / self.fragments [INFO] [stderr] 35 | | .get(typename_) [INFO] [stderr] 36 | | .map(|fragment| fragment.is_required.set(true)); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Some(fragment) = self.fragments [INFO] [stderr] 35 | .get(typename_) { fragment.is_required.set(true) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/query.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if enum_derives.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!enum_derives.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/schema.rs:238:46 [INFO] [stderr] | [INFO] [stderr] 238 | description: ty.description.as_ref().map(|d| d.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ty.description.as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/schema.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | .unwrap_or_else(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/inputs.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | / context [INFO] [stderr] 175 | | .schema [INFO] [stderr] 176 | | .inputs [INFO] [stderr] 177 | | .get("Cat") [INFO] [stderr] 178 | | .unwrap() [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 174 | &context [INFO] [stderr] 175 | .schema [INFO] [stderr] 176 | .inputs["Cat"] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/unions.rs:32:6 [INFO] [stderr] | [INFO] [stderr] 32 | ) -> Result<(Vec, Vec, Vec), failure::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/lib.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | let deprecation_strategy = options [INFO] [stderr] | ________________________________^ [INFO] [stderr] 88 | | .deprecation_strategy [INFO] [stderr] 89 | | .unwrap_or(deprecation::DeprecationStrategy::default()); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | let deprecation_strategy = options [INFO] [stderr] 88 | .deprecation_strategy.unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.23s [INFO] running `"docker" "inspect" "6190ce672428b677b2d2047046ec18827a2b22b9d9fb586a409f3a36bf882766"` [INFO] running `"docker" "rm" "-f" "6190ce672428b677b2d2047046ec18827a2b22b9d9fb586a409f3a36bf882766"` [INFO] [stdout] 6190ce672428b677b2d2047046ec18827a2b22b9d9fb586a409f3a36bf882766