[INFO] crate graphql-id 0.1.2 is already in cache [INFO] extracting crate graphql-id 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/graphql-id/0.1.2 [INFO] extracting crate graphql-id 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphql-id/0.1.2 [INFO] validating manifest of graphql-id-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of graphql-id-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing graphql-id-0.1.2 [INFO] finished frobbing graphql-id-0.1.2 [INFO] frobbed toml for graphql-id-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/graphql-id/0.1.2/Cargo.toml [INFO] started frobbing graphql-id-0.1.2 [INFO] finished frobbing graphql-id-0.1.2 [INFO] frobbed toml for graphql-id-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphql-id/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting graphql-id-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/graphql-id/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97c6dde24a26efd7aae849871b6e7bf2fb9569071e7abb9d38393880f44357ba [INFO] running `"docker" "start" "-a" "97c6dde24a26efd7aae849871b6e7bf2fb9569071e7abb9d38393880f44357ba"` [INFO] [stderr] Checking combine v3.6.6 [INFO] [stderr] Checking graphql-parser v0.2.2 [INFO] [stderr] Checking graphql-id v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/traverse.rs:212:41 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn handle_name(&mut self, name: &Name) -> Result<(), GraphQLError> { [INFO] [stderr] | ^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/visitor.rs:82:42 [INFO] [stderr] | [INFO] [stderr] 82 | fn visit_name_enter(&mut self, name: &Name) -> Result<(), GraphQLError> { [INFO] [stderr] | ^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/visitor.rs:85:41 [INFO] [stderr] | [INFO] [stderr] 85 | fn visit_name_exit(&mut self, name: &Name) -> Result<(), GraphQLError> { [INFO] [stderr] | ^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/wrappers.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / fn ne(&self, other: &FragmentDefinitionContainer) -> bool { [INFO] [stderr] 13 | | self.0.name.ne(&other.0.name) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | .find(|visited| &visited.name == &fragment.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 51 | .find(|visited| visited.name == fragment.name); [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/traverse.rs:212:41 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn handle_name(&mut self, name: &Name) -> Result<(), GraphQLError> { [INFO] [stderr] | ^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/visitor.rs:82:42 [INFO] [stderr] | [INFO] [stderr] 82 | fn visit_name_enter(&mut self, name: &Name) -> Result<(), GraphQLError> { [INFO] [stderr] | ^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/visitor.rs:85:41 [INFO] [stderr] | [INFO] [stderr] 85 | fn visit_name_exit(&mut self, name: &Name) -> Result<(), GraphQLError> { [INFO] [stderr] | ^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/wrappers.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / fn ne(&self, other: &FragmentDefinitionContainer) -> bool { [INFO] [stderr] 13 | | self.0.name.ne(&other.0.name) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | .find(|visited| &visited.name == &fragment.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 51 | .find(|visited| visited.name == fragment.name); [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | let mut f = File::open(file).expect(format!("File NOT FOUND: {}", file).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("File NOT FOUND: {}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | .expect(format!("Error reading file: {}", file).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error reading file: {}", file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | let mut f = File::open(file).expect(format!("File NOT FOUND: {}", file).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("File NOT FOUND: {}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/bin.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | .expect(format!("Error reading file: {}", file).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error reading file: {}", file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.64s [INFO] running `"docker" "inspect" "97c6dde24a26efd7aae849871b6e7bf2fb9569071e7abb9d38393880f44357ba"` [INFO] running `"docker" "rm" "-f" "97c6dde24a26efd7aae849871b6e7bf2fb9569071e7abb9d38393880f44357ba"` [INFO] [stdout] 97c6dde24a26efd7aae849871b6e7bf2fb9569071e7abb9d38393880f44357ba