[INFO] crate graphene 0.1.5 is already in cache [INFO] extracting crate graphene 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/graphene/0.1.5 [INFO] extracting crate graphene 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphene/0.1.5 [INFO] validating manifest of graphene-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of graphene-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing graphene-0.1.5 [INFO] finished frobbing graphene-0.1.5 [INFO] frobbed toml for graphene-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/graphene/0.1.5/Cargo.toml [INFO] started frobbing graphene-0.1.5 [INFO] finished frobbing graphene-0.1.5 [INFO] frobbed toml for graphene-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphene/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting graphene-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/graphene/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d52f5e1aec40933a271299032072e87694c26dd12f9c1d0a1983ea8233aa76c1 [INFO] running `"docker" "start" "-a" "d52f5e1aec40933a271299032072e87694c26dd12f9c1d0a1983ea8233aa76c1"` [INFO] [stderr] Checking graphene v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/adjacency_list/mod.rs:30:48 [INFO] [stderr] | [INFO] [stderr] 30 | let mut g = AdjListGraph{ edges: Vec::new(), values: values }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/adjacency_list/mod.rs:30:48 [INFO] [stderr] | [INFO] [stderr] 30 | let mut g = AdjListGraph{ edges: Vec::new(), values: values }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | let ref operations = self.operations; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let operations = &self.operations;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | let ref mut graph = self.graph; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let graph = &mut self.graph;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:134:7 [INFO] [stderr] | [INFO] [stderr] 134 | let ref operations = self.operations; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let operations = &self.operations;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:135:7 [INFO] [stderr] | [INFO] [stderr] 135 | let ref mut graph = self.graph; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let graph = &mut self.graph;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core/constrained_graph.rs:261:2 [INFO] [stderr] | [INFO] [stderr] 261 | fn unconstrained<'a>(&'a mut self) -> Unconstrainer< [INFO] [stderr] | _____^ [INFO] [stderr] 262 | | Self::Vertex, Self::Weight, Self::VertexIter, Self::EdgeIter, Self>{ [INFO] [stderr] 263 | | Unconstrainer::new(self) [INFO] [stderr] 264 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/core/constraint/unique.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | if let Some(_) = self.all_edges().into_iter().position( [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if self.all_edges().into_iter().position( [INFO] [stderr] 63 | |edge| edge.source == e.source && edge.sink == e.sink ).is_some() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/core/constraint/unique.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if let Some(_) = v1_to_v2.next(){ [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 98 | | // Invariant doesn't hold [INFO] [stderr] 99 | | return false; [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________________- help: try this: `if v1_to_v2.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let ref mut t_v_out = self.edges[t_v_i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------- help: try: `let t_v_out = &mut self.edges[t_v_i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t_v_out` [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | for i in 0..t_v_out.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for (i, ) in t_v_out.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | let ref mut t_v_out = self.edges[t_v_i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------- help: try: `let t_v_out = &mut self.edges[t_v_i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `edge_i` is only used to index `t_v_out`. [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | for edge_i in 0..t_v_out.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for in &mut t_v_out{ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/common/adjacency_list/mod.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | Some(self.values[i].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.values[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | let ref operations = self.operations; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let operations = &self.operations;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | let ref mut graph = self.graph; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let graph = &mut self.graph;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:134:7 [INFO] [stderr] | [INFO] [stderr] 134 | let ref operations = self.operations; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let operations = &self.operations;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:135:7 [INFO] [stderr] | [INFO] [stderr] 135 | let ref mut graph = self.graph; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let graph = &mut self.graph;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core/constrained_graph.rs:261:2 [INFO] [stderr] | [INFO] [stderr] 261 | fn unconstrained<'a>(&'a mut self) -> Unconstrainer< [INFO] [stderr] | _____^ [INFO] [stderr] 262 | | Self::Vertex, Self::Weight, Self::VertexIter, Self::EdgeIter, Self>{ [INFO] [stderr] 263 | | Unconstrainer::new(self) [INFO] [stderr] 264 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/core/constraint/unique.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | if let Some(_) = self.all_edges().into_iter().position( [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if self.all_edges().into_iter().position( [INFO] [stderr] 63 | |edge| edge.source == e.source && edge.sink == e.sink ).is_some() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/core/constraint/unique.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if let Some(_) = v1_to_v2.next(){ [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 98 | | // Invariant doesn't hold [INFO] [stderr] 99 | | return false; [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________________- help: try this: `if v1_to_v2.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let ref mut t_v_out = self.edges[t_v_i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------- help: try: `let t_v_out = &mut self.edges[t_v_i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t_v_out` [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | for i in 0..t_v_out.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for (i, ) in t_v_out.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | let ref mut t_v_out = self.edges[t_v_i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------- help: try: `let t_v_out = &mut self.edges[t_v_i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `edge_i` is only used to index `t_v_out`. [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | for edge_i in 0..t_v_out.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for in &mut t_v_out{ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/common/adjacency_list/mod.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | Some(self.values[i].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.values[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/arbitraries/utilities.rs:31:41 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn unordered_sublist(sublist:&Vec, superlist:&Vec

, equal: F) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&[B]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/arbitraries/utilities.rs:31:60 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn unordered_sublist(sublist:&Vec, superlist:&Vec

, equal: F) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&[P]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/arbitraries/utilities.rs:64:43 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn unordered_sublist_equal(sublist:&Vec, superlist:&Vec) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/arbitraries/utilities.rs:64:62 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn unordered_sublist_equal(sublist:&Vec, superlist:&Vec) -> bool [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/arbitraries/utilities.rs:197:44 [INFO] [stderr] | [INFO] [stderr] 197 | pub fn edges_sublistof_graph(edges: &Vec<(V, V, W)>, g: &G) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(V, V, W)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/arbitraries/utilities.rs:221:51 [INFO] [stderr] | [INFO] [stderr] 221 | pub fn graph_sublistof_edges(g: &G, edges: &Vec<(V, V, W)>) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(V, V, W)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/arbitraries/arbitrary_graph_description.rs:82:6 [INFO] [stderr] | [INFO] [stderr] 82 | if self.values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/_impl/new.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | holds_if!(desc.values.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/add_edge.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | holds_if!(desc.values.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/add_edge.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | holds_if!(desc.values.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/add_edge.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | holds_if!(desc.values.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/add_edge.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | holds_if!(desc.values.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/remove_edge.rs:6:12 [INFO] [stderr] | [INFO] [stderr] 6 | holds_if!(desc.edges.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.edges.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/remove_edge.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | holds_if!(desc.edges.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.edges.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/remove_edge.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | holds_if!(desc.edges.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.edges.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/remove_edge.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | holds_if!(desc.values.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/add_vertex.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | holds_if!(g.all_vertices().len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `g.all_vertices().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/remove_vertex.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | holds_if!{desc.values.len() == 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/remove_vertex.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | holds_if!{desc.values.len() == 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/remove_vertex.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | holds_if!{desc.values.len() == 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/remove_vertex.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | holds_if!{desc.values.len() == 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/common/adjacency_list/impl_base_graph/remove_vertex.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | holds_if!{desc.values.len() == 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/core/base_graph/edges_between.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | if desc.values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/core/base_graph/edges_between.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | return g.edges_between(v1_cand,v2_cand).len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `g.edges_between(v1_cand,v2_cand).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/core/base_graph/edges_between.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | holds_if!(desc.values.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> tests/core/base_graph/edges_between.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | (so == v1 && si == v2) || [INFO] [stderr] | _____________^ [INFO] [stderr] 45 | | (so == v2 && si == v2) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | !(so != v1 && so != v2 || si != v2) [INFO] [stderr] | [INFO] [stderr] 44 | (so == v1 || so == v2) && si == v2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/core/base_graph/edges_sourced_or_sinked_in.rs:15:6 [INFO] [stderr] | [INFO] [stderr] 15 | if desc.values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/core/base_graph/edges_sourced_or_sinked_in.rs:19:4 [INFO] [stderr] | [INFO] [stderr] 19 | g.edges_sourced_in(v_cand).len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `g.edges_sourced_in(v_cand).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/core/base_graph/edges_sourced_or_sinked_in.rs:47:6 [INFO] [stderr] | [INFO] [stderr] 47 | if desc.values.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `desc.values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/core/base_graph/edges_sourced_or_sinked_in.rs:51:4 [INFO] [stderr] | [INFO] [stderr] 51 | g.edges_sinked_in(v_cand).len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `g.edges_sinked_in(v_cand).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.46s [INFO] running `"docker" "inspect" "d52f5e1aec40933a271299032072e87694c26dd12f9c1d0a1983ea8233aa76c1"` [INFO] running `"docker" "rm" "-f" "d52f5e1aec40933a271299032072e87694c26dd12f9c1d0a1983ea8233aa76c1"` [INFO] [stdout] d52f5e1aec40933a271299032072e87694c26dd12f9c1d0a1983ea8233aa76c1