[INFO] crate graphannis 0.13.0 is already in cache
[INFO] extracting crate graphannis 0.13.0 into work/ex/clippy-test-run/sources/stable/reg/graphannis/0.13.0
[INFO] extracting crate graphannis 0.13.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphannis/0.13.0
[INFO] validating manifest of graphannis-0.13.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of graphannis-0.13.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing graphannis-0.13.0
[INFO] finished frobbing graphannis-0.13.0
[INFO] frobbed toml for graphannis-0.13.0 written to work/ex/clippy-test-run/sources/stable/reg/graphannis/0.13.0/Cargo.toml
[INFO] started frobbing graphannis-0.13.0
[INFO] finished frobbing graphannis-0.13.0
[INFO] frobbed toml for graphannis-0.13.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphannis/0.13.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting graphannis-0.13.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/graphannis/0.13.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] faa3ec5399de5d4deabcaf3ebe5099c5543f350986cfad7e2e59c3109ac3a4ab
[INFO] running `"docker" "start" "-a" "faa3ec5399de5d4deabcaf3ebe5099c5543f350986cfad7e2e59c3109ac3a4ab"`
[INFO] [stderr]     Checking graphannis-malloc_size_of v1.0.0
[INFO] [stderr]    Compiling ena v0.11.0
[INFO] [stderr]    Compiling serde v1.0.85
[INFO] [stderr]    Compiling syn v0.13.11
[INFO] [stderr]     Checking multimap v0.4.0
[INFO] [stderr]     Checking chrono v0.4.6
[INFO] [stderr]     Checking csv v1.0.5
[INFO] [stderr]    Compiling indoc-impl v0.2.8
[INFO] [stderr]    Compiling strum_macros v0.11.0
[INFO] [stderr]     Checking indoc v0.2.8
[INFO] [stderr]     Checking simplelog v0.5.3
[INFO] [stderr]     Checking boolean_expression v0.3.8
[INFO] [stderr]    Compiling string_cache v0.7.3
[INFO] [stderr]    Compiling docopt v1.0.2
[INFO] [stderr]    Compiling synstructure v0.8.1
[INFO] [stderr]    Compiling lalrpop v0.16.3
[INFO] [stderr]    Compiling graphannis-malloc_size_of_derive v1.0.0
[INFO] [stderr]    Compiling graphannis v0.13.0 (/opt/crater/workdir)
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/annis/db/aql/mod.rs:5:13
[INFO] [stderr]   |
[INFO] [stderr] 5 |     #[allow(clippy)]
[INFO] [stderr]   |             ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/annis/db/corpusstorage.rs:257:52
[INFO] [stderr]     |
[INFO] [stderr] 257 |         #[cfg_attr(feature = "cargo-clippy", allow(clippy))]
[INFO] [stderr]     |                                                    ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/annis/db/corpusstorage.rs:284:52
[INFO] [stderr]     |
[INFO] [stderr] 284 |         #[cfg_attr(feature = "cargo-clippy", allow(clippy))]
[INFO] [stderr]     |                                                    ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/annis/db/exec/indexjoin.rs:220:76
[INFO] [stderr]     |
[INFO] [stderr] 220 |                                 #[cfg_attr(feature = "cargo-clippy", allow(clippy))]
[INFO] [stderr]     |                                                                            ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/annis/db/exec/parallel/indexjoin.rs:155:76
[INFO] [stderr]     |
[INFO] [stderr] 155 |                                 #[cfg_attr(feature = "cargo-clippy", allow(clippy))]
[INFO] [stderr]     |                                                                            ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/annis/db/aql/mod.rs:5:13
[INFO] [stderr]   |
[INFO] [stderr] 5 |     #[allow(clippy)]
[INFO] [stderr]   |             ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/annis/db/corpusstorage.rs:257:52
[INFO] [stderr]     |
[INFO] [stderr] 257 |         #[cfg_attr(feature = "cargo-clippy", allow(clippy))]
[INFO] [stderr]     |                                                    ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/annis/db/corpusstorage.rs:284:52
[INFO] [stderr]     |
[INFO] [stderr] 284 |         #[cfg_attr(feature = "cargo-clippy", allow(clippy))]
[INFO] [stderr]     |                                                    ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/annis/db/exec/indexjoin.rs:220:76
[INFO] [stderr]     |
[INFO] [stderr] 220 |                                 #[cfg_attr(feature = "cargo-clippy", allow(clippy))]
[INFO] [stderr]     |                                                                            ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]    --> src/annis/db/exec/parallel/indexjoin.rs:155:76
[INFO] [stderr]     |
[INFO] [stderr] 155 |                                 #[cfg_attr(feature = "cargo-clippy", allow(clippy))]
[INFO] [stderr]     |                                                                            ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map`
[INFO] [stderr]    --> src/annis/db/annostorage/mod.rs:656:13
[INFO] [stderr]     |
[INFO] [stderr] 656 | /             self.matching_items(namespace, name, value)
[INFO] [stderr] 657 | |                 .filter_map(move |(node, anno_key_id)| {
[INFO] [stderr] 658 | |                     Some(Match {
[INFO] [stderr] 659 | |                         node: *node,
[INFO] [stderr] 660 | |                         anno_key: anno_key_id,
[INFO] [stderr] 661 | |                     })
[INFO] [stderr] 662 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_filter_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map`
[INFO] [stderr]    --> src/annis/db/annostorage/mod.rs:675:22
[INFO] [stderr]     |
[INFO] [stderr] 675 |               let it = self
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 676 | |                 .matching_items(namespace, name, None)
[INFO] [stderr] 677 | |                 .filter(move |(node, anno_key_id)| {
[INFO] [stderr] 678 | |                     if let Some(val) = self.get_value_for_item_by_id(node, *anno_key_id) {
[INFO] [stderr] ...   |
[INFO] [stderr] 687 | |                     })
[INFO] [stderr] 688 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map`
[INFO] [stderr]    --> src/annis/db/annostorage/mod.rs:746:13
[INFO] [stderr]     |
[INFO] [stderr] 746 | /             self.matching_items(namespace, name, value)
[INFO] [stderr] 747 | |                 .filter_map(move |(edge, anno_key_id)| {
[INFO] [stderr] 748 | |                     Some(Match {
[INFO] [stderr] 749 | |                         node: edge.source,
[INFO] [stderr] 750 | |                         anno_key: anno_key_id,
[INFO] [stderr] 751 | |                     })
[INFO] [stderr] 752 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map`
[INFO] [stderr]    --> src/annis/db/annostorage/mod.rs:765:22
[INFO] [stderr]     |
[INFO] [stderr] 765 |               let it = self
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 766 | |                 .matching_items(namespace, name, None)
[INFO] [stderr] 767 | |                 .filter(move |(node, anno_key_id)| {
[INFO] [stderr] 768 | |                     if let Some(val) = self.get_value_for_item_by_id(node, *anno_key_id) {
[INFO] [stderr] ...   |
[INFO] [stderr] 777 | |                     })
[INFO] [stderr] 778 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/aql/operators/inclusion.rs:114:29
[INFO] [stderr]     |
[INFO] [stderr] 114 | /                             self.gs_left
[INFO] [stderr] 115 | |                                 .get_outgoing_edges(t)
[INFO] [stderr] 116 | |                                 .into_iter()
[INFO] [stderr]     | |____________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]     |
[INFO] [stderr] 114 |                             self.gs_left
[INFO] [stderr] 115 |                                 .get_outgoing_edges(t)
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/annis/db/aql/mod.rs:365:16
[INFO] [stderr]     |
[INFO] [stderr] 365 |         .range(..pos + 1)
[INFO] [stderr]     |                ^^^^^^^^^ help: use: `..=pos`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `component_nr` is used as a loop counter. Consider using `for (component_nr, item) in q.alternatives.enumerate()` or similar iterators
[INFO] [stderr]     --> src/annis/db/corpusstorage.rs:1420:20
[INFO] [stderr]      |
[INFO] [stderr] 1420 |         for alt in q.alternatives {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/exec/indexjoin.rs:183:22
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 Some(rhs.into_iter().peekable())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/exec/indexjoin.rs:243:22
[INFO] [stderr]     |
[INFO] [stderr] 243 |                 Some(rhs.into_iter().peekable())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map`
[INFO] [stderr]    --> src/annis/db/annostorage/mod.rs:656:13
[INFO] [stderr]     |
[INFO] [stderr] 656 | /             self.matching_items(namespace, name, value)
[INFO] [stderr] 657 | |                 .filter_map(move |(node, anno_key_id)| {
[INFO] [stderr] 658 | |                     Some(Match {
[INFO] [stderr] 659 | |                         node: *node,
[INFO] [stderr] 660 | |                         anno_key: anno_key_id,
[INFO] [stderr] 661 | |                     })
[INFO] [stderr] 662 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_filter_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map`
[INFO] [stderr]    --> src/annis/db/annostorage/mod.rs:675:22
[INFO] [stderr]     |
[INFO] [stderr] 675 |               let it = self
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 676 | |                 .matching_items(namespace, name, None)
[INFO] [stderr] 677 | |                 .filter(move |(node, anno_key_id)| {
[INFO] [stderr] 678 | |                     if let Some(val) = self.get_value_for_item_by_id(node, *anno_key_id) {
[INFO] [stderr] ...   |
[INFO] [stderr] 687 | |                     })
[INFO] [stderr] 688 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map`
[INFO] [stderr]    --> src/annis/db/annostorage/mod.rs:746:13
[INFO] [stderr]     |
[INFO] [stderr] 746 | /             self.matching_items(namespace, name, value)
[INFO] [stderr] 747 | |                 .filter_map(move |(edge, anno_key_id)| {
[INFO] [stderr] 748 | |                     Some(Match {
[INFO] [stderr] 749 | |                         node: edge.source,
[INFO] [stderr] 750 | |                         anno_key: anno_key_id,
[INFO] [stderr] 751 | |                     })
[INFO] [stderr] 752 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map`
[INFO] [stderr]    --> src/annis/db/annostorage/mod.rs:765:22
[INFO] [stderr]     |
[INFO] [stderr] 765 |               let it = self
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 766 | |                 .matching_items(namespace, name, None)
[INFO] [stderr] 767 | |                 .filter(move |(node, anno_key_id)| {
[INFO] [stderr] 768 | |                     if let Some(val) = self.get_value_for_item_by_id(node, *anno_key_id) {
[INFO] [stderr] ...   |
[INFO] [stderr] 777 | |                     })
[INFO] [stderr] 778 | |                 });
[INFO] [stderr]     | |__________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/annis/db/exec/nodesearch.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 | /         if let &NodeSearchSpec::AnyToken = &self {
[INFO] [stderr] 68 | |             return tokensearch::AnyTokenSearch::necessary_components();
[INFO] [stderr] 69 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 67 |         if let NodeSearchSpec::AnyToken = self {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/annis/db/annostorage/tests.rs:91:20
[INFO] [stderr]    |
[INFO] [stderr] 91 |     assert_eq!(&1, a.anno_key_sizes.get(&test_anno.key).unwrap());
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&a.anno_key_sizes[&test_anno.key]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/annis/db/graphstorage/mod.rs:73:32
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn distance(&self, source: &NodeID, target: &NodeID) -> Option<usize>;
[INFO] [stderr]    |                                ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/annis/db/graphstorage/mod.rs:73:49
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn distance(&self, source: &NodeID, target: &NodeID) -> Option<usize>;
[INFO] [stderr]    |                                                 ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/annis/db/graphstorage/mod.rs:78:17
[INFO] [stderr]    |
[INFO] [stderr] 78 |         source: &NodeID,
[INFO] [stderr]    |                 ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/annis/db/graphstorage/mod.rs:79:17
[INFO] [stderr]    |
[INFO] [stderr] 79 |         target: &NodeID,
[INFO] [stderr]    |                 ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/annis/db/graphstorage/mod.rs:131:37
[INFO] [stderr]     |
[INFO] [stderr] 131 |     fn delete_node(&mut self, node: &NodeID);
[INFO] [stderr]     |                                     ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/aql/operators/inclusion.rs:114:29
[INFO] [stderr]     |
[INFO] [stderr] 114 | /                             self.gs_left
[INFO] [stderr] 115 | |                                 .get_outgoing_edges(t)
[INFO] [stderr] 116 | |                                 .into_iter()
[INFO] [stderr]     | |____________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]     |
[INFO] [stderr] 114 |                             self.gs_left
[INFO] [stderr] 115 |                                 .get_outgoing_edges(t)
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/annis/db/graphstorage/linear.rs:193:39
[INFO] [stderr]     |
[INFO] [stderr] 193 |                                 chain[max_distance..(min_distance + 1)].iter().cloned(),
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `max_distance..=min_distance`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/annis/db/graphstorage/prepost.rs:196:18
[INFO] [stderr]     |
[INFO] [stderr] 196 |                 .into_iter()
[INFO] [stderr]     |                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/annis/db/graphstorage/prepost.rs:253:18
[INFO] [stderr]     |
[INFO] [stderr] 253 |                 .into_iter()
[INFO] [stderr]     |                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/annis/db/aql/mod.rs:365:16
[INFO] [stderr]     |
[INFO] [stderr] 365 |         .range(..pos + 1)
[INFO] [stderr]     |                ^^^^^^^^^ help: use: `..=pos`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/query/conjunction.rs:278:21
[INFO] [stderr]     |
[INFO] [stderr] 278 |                     format!("Operand '#{}' not found", var_right).into(),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Operand '#{}' not found", var_right)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/query/conjunction.rs:284:17
[INFO] [stderr]     |
[INFO] [stderr] 284 |                 format!("Operand '#{}' not found", var_left).into(),
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Operand '#{}' not found", var_left)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `component_nr` is used as a loop counter. Consider using `for (component_nr, item) in q.alternatives.enumerate()` or similar iterators
[INFO] [stderr]     --> src/annis/db/corpusstorage.rs:1420:20
[INFO] [stderr]      |
[INFO] [stderr] 1420 |         for alt in q.alternatives {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/exec/indexjoin.rs:183:22
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 Some(rhs.into_iter().peekable())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/exec/indexjoin.rs:243:22
[INFO] [stderr]     |
[INFO] [stderr] 243 |                 Some(rhs.into_iter().peekable())
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/annis/db/exec/nodesearch.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 | /         if let &NodeSearchSpec::AnyToken = &self {
[INFO] [stderr] 68 | |             return tokensearch::AnyTokenSearch::necessary_components();
[INFO] [stderr] 69 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 67 |         if let NodeSearchSpec::AnyToken = self {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/annis/db/graphstorage/mod.rs:73:32
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn distance(&self, source: &NodeID, target: &NodeID) -> Option<usize>;
[INFO] [stderr]    |                                ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/annis/db/graphstorage/mod.rs:73:49
[INFO] [stderr]    |
[INFO] [stderr] 73 |     fn distance(&self, source: &NodeID, target: &NodeID) -> Option<usize>;
[INFO] [stderr]    |                                                 ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/annis/db/graphstorage/mod.rs:78:17
[INFO] [stderr]    |
[INFO] [stderr] 78 |         source: &NodeID,
[INFO] [stderr]    |                 ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/annis/db/graphstorage/mod.rs:79:17
[INFO] [stderr]    |
[INFO] [stderr] 79 |         target: &NodeID,
[INFO] [stderr]    |                 ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/annis/db/relannis.rs:467:30
[INFO] [stderr]     |
[INFO] [stderr] 467 |                     for i in left_tok_pos.val..(right_tok_pos.val + 1) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `left_tok_pos.val..=right_tok_pos.val`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/annis/db/graphstorage/mod.rs:131:37
[INFO] [stderr]     |
[INFO] [stderr] 131 |     fn delete_node(&mut self, node: &NodeID);
[INFO] [stderr]     |                                     ^^^^^^^ help: consider passing by value instead: `NodeID`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/annis/db/graphstorage/linear.rs:193:39
[INFO] [stderr]     |
[INFO] [stderr] 193 |                                 chain[max_distance..(min_distance + 1)].iter().cloned(),
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `max_distance..=min_distance`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/annis/db/graphstorage/prepost.rs:196:18
[INFO] [stderr]     |
[INFO] [stderr] 196 |                 .into_iter()
[INFO] [stderr]     |                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/annis/db/graphstorage/prepost.rs:253:18
[INFO] [stderr]     |
[INFO] [stderr] 253 |                 .into_iter()
[INFO] [stderr]     |                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/query/conjunction.rs:278:21
[INFO] [stderr]     |
[INFO] [stderr] 278 |                     format!("Operand '#{}' not found", var_right).into(),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Operand '#{}' not found", var_right)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/annis/db/query/conjunction.rs:284:17
[INFO] [stderr]     |
[INFO] [stderr] 284 |                 format!("Operand '#{}' not found", var_left).into(),
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Operand '#{}' not found", var_left)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/annis/db/relannis.rs:467:30
[INFO] [stderr]     |
[INFO] [stderr] 467 |                     for i in left_tok_pos.val..(right_tok_pos.val + 1) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `left_tok_pos.val..=right_tok_pos.val`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error[E0463]: can't find crate for `criterion`
[INFO] [stderr]  --> benches/graphannis.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | extern crate criterion;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] For more information about this error, try `rustc --explain E0463`.
[INFO] [stderr] error: Could not compile `graphannis`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/searchtest_parallel.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return RefCell::new(cs);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RefCell::new(cs)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> tests/searchtest_parallel.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     query_dir
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> tests/searchtest_parallel.rs:31:21
[INFO] [stderr]    |
[INFO] [stderr] 31 |       let query_dir = PathBuf::from(if let Ok(path) = std::env::var("ANNIS4_TEST_QUERIES") {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 32 | |         path
[INFO] [stderr] 33 | |     } else {
[INFO] [stderr] 34 | |         String::from("queries")
[INFO] [stderr] 35 | |     });
[INFO] [stderr]    | |______^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/searchtest.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return RefCell::new(cs);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `RefCell::new(cs)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> tests/searchtest.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     query_dir
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> tests/searchtest.rs:31:21
[INFO] [stderr]    |
[INFO] [stderr] 31 |       let query_dir = PathBuf::from(if let Ok(path) = std::env::var("ANNIS4_TEST_QUERIES") {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 32 | |         path
[INFO] [stderr] 33 | |     } else {
[INFO] [stderr] 34 | |         String::from("queries")
[INFO] [stderr] 35 | |     });
[INFO] [stderr]    | |______^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "faa3ec5399de5d4deabcaf3ebe5099c5543f350986cfad7e2e59c3109ac3a4ab"`
[INFO] running `"docker" "rm" "-f" "faa3ec5399de5d4deabcaf3ebe5099c5543f350986cfad7e2e59c3109ac3a4ab"`
[INFO] [stdout] faa3ec5399de5d4deabcaf3ebe5099c5543f350986cfad7e2e59c3109ac3a4ab