[INFO] crate graph_match 0.5.0 is already in cache [INFO] extracting crate graph_match 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/graph_match/0.5.0 [INFO] extracting crate graph_match 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graph_match/0.5.0 [INFO] validating manifest of graph_match-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of graph_match-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing graph_match-0.5.0 [INFO] finished frobbing graph_match-0.5.0 [INFO] frobbed toml for graph_match-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/graph_match/0.5.0/Cargo.toml [INFO] started frobbing graph_match-0.5.0 [INFO] finished frobbing graph_match-0.5.0 [INFO] frobbed toml for graph_match-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graph_match/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting graph_match-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/graph_match/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1cab4dbe5223e2b2d9fbb6d7afbdfa9680604a20fca632615ed3a0a1cda8a8dc [INFO] running `"docker" "start" "-a" "1cab4dbe5223e2b2d9fbb6d7afbdfa9680604a20fca632615ed3a0a1cda8a8dc"` [INFO] [stderr] Checking graph_match v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:15:42 [INFO] [stderr] | [INFO] [stderr] 15 | self.nodes.push(node::Node { identifier: identifier, first_outgoing_edge: None, attributes: attributes }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:15:93 [INFO] [stderr] | [INFO] [stderr] 15 | self.nodes.push(node::Node { identifier: identifier, first_outgoing_edge: None, attributes: attributes }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/graph.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | None => { print!("\n"); break }, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:15:42 [INFO] [stderr] | [INFO] [stderr] 15 | self.nodes.push(node::Node { identifier: identifier, first_outgoing_edge: None, attributes: attributes }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:15:93 [INFO] [stderr] | [INFO] [stderr] 15 | self.nodes.push(node::Node { identifier: identifier, first_outgoing_edge: None, attributes: attributes }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/graph.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | None => { print!("\n"); break }, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return edge_indexes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `edge_indexes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/edge.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | return value1 == value2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value1 == value2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | return value1.contains(value2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value1.contains(value2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return matched_components; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `matched_components` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return graph_roots.iter() [INFO] [stderr] 27 | | .map(|&root_index| matching::recusive_node_match(query_root_index, root_index, &query, &graph, None, &equality)) [INFO] [stderr] 28 | | .filter(|&ref matched_components| matched_components.list.len() == query.nodes.len()) [INFO] [stderr] 29 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | graph_roots.iter() [INFO] [stderr] 27 | .map(|&root_index| matching::recusive_node_match(query_root_index, root_index, &query, &graph, None, &equality)) [INFO] [stderr] 28 | .filter(|&ref matched_components| matched_components.list.len() == query.nodes.len()) [INFO] [stderr] 29 | .collect::>() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return node_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return edge_indexes; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `edge_indexes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/edge.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | return value1 == value2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value1 == value2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | return value1.contains(value2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value1.contains(value2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matching.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return matched_components; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `matched_components` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return graph_roots.iter() [INFO] [stderr] 27 | | .map(|&root_index| matching::recusive_node_match(query_root_index, root_index, &query, &graph, None, &equality)) [INFO] [stderr] 28 | | .filter(|&ref matched_components| matched_components.list.len() == query.nodes.len()) [INFO] [stderr] 29 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | graph_roots.iter() [INFO] [stderr] 27 | .map(|&root_index| matching::recusive_node_match(query_root_index, root_index, &query, &graph, None, &equality)) [INFO] [stderr] 28 | .filter(|&ref matched_components| matched_components.list.len() == query.nodes.len()) [INFO] [stderr] 29 | .collect::>() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return node_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/graph.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match self.nodes[node_index].first_outgoing_edge { [INFO] [stderr] 39 | | Some(edge_index) => { [INFO] [stderr] 40 | | let mut edge = &self.edges[edge_index]; [INFO] [stderr] 41 | | edge_indexes.push(edge_index); [INFO] [stderr] ... | [INFO] [stderr] 52 | | None => {} [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(edge_index) = self.nodes[node_index].first_outgoing_edge { [INFO] [stderr] 39 | let mut edge = &self.edges[edge_index]; [INFO] [stderr] 40 | edge_indexes.push(edge_index); [INFO] [stderr] 41 | loop { [INFO] [stderr] 42 | match edge.next_outgoing_edge { [INFO] [stderr] 43 | Some(edge_index) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/graph.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / loop { [INFO] [stderr] 43 | | match edge.next_outgoing_edge { [INFO] [stderr] 44 | | Some(edge_index) => { [INFO] [stderr] 45 | | edge = &self.edges[edge_index]; [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(edge_index) = edge.next_outgoing_edge { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/matching.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn values_match(value1: &String, value2: &String, equality: &EqualityRequirement) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/matching.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn values_match(value1: &String, value2: &String, equality: &EqualityRequirement) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/matching.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | if query.edges_for_node(query_root_index).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.edges_for_node(query_root_index).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/matching.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match query.nodes[query.edges[query_edge_index].target] [INFO] [stderr] 69 | | .matches(&graph.nodes[graph.edges[edge].target], &equality) { [INFO] [stderr] 70 | | true => { [INFO] [stderr] 71 | | let descendents = [INFO] [stderr] ... | [INFO] [stderr] 83 | | false => return MatchedComponents { list: vec![] }, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 68 | if query.nodes[query.edges[query_edge_index].target] [INFO] [stderr] 69 | .matches(&graph.nodes[graph.edges[edge].target], &equality) { [INFO] [stderr] 70 | let descendents = [INFO] [stderr] 71 | recusive_node_match(query.edges[query_edge_index].target, [INFO] [stderr] 72 | graph.edges[matching_edge_in_graph.unwrap()] [INFO] [stderr] 73 | .target, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/lib.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | .filter(|&ref matched_components| matched_components.list.len() == query.nodes.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `matched_components` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:33:72 [INFO] [stderr] | [INFO] [stderr] 33 | graph: &graph::Graph, root_index: node::Index, banned_identifiers: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/graph.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match self.nodes[node_index].first_outgoing_edge { [INFO] [stderr] 39 | | Some(edge_index) => { [INFO] [stderr] 40 | | let mut edge = &self.edges[edge_index]; [INFO] [stderr] 41 | | edge_indexes.push(edge_index); [INFO] [stderr] ... | [INFO] [stderr] 52 | | None => {} [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(edge_index) = self.nodes[node_index].first_outgoing_edge { [INFO] [stderr] 39 | let mut edge = &self.edges[edge_index]; [INFO] [stderr] 40 | edge_indexes.push(edge_index); [INFO] [stderr] 41 | loop { [INFO] [stderr] 42 | match edge.next_outgoing_edge { [INFO] [stderr] 43 | Some(edge_index) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/graph.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / loop { [INFO] [stderr] 43 | | match edge.next_outgoing_edge { [INFO] [stderr] 44 | | Some(edge_index) => { [INFO] [stderr] 45 | | edge = &self.edges[edge_index]; [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(edge_index) = edge.next_outgoing_edge { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/graph.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / loop { [INFO] [stderr] 138 | | match successors.next() { [INFO] [stderr] 139 | | Some(edge) => targets.push(edge), [INFO] [stderr] 140 | | None => break, [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(edge) = successors.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/matching.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn values_match(value1: &String, value2: &String, equality: &EqualityRequirement) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/matching.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn values_match(value1: &String, value2: &String, equality: &EqualityRequirement) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/matching.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | if query.edges_for_node(query_root_index).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.edges_for_node(query_root_index).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/matching.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match query.nodes[query.edges[query_edge_index].target] [INFO] [stderr] 69 | | .matches(&graph.nodes[graph.edges[edge].target], &equality) { [INFO] [stderr] 70 | | true => { [INFO] [stderr] 71 | | let descendents = [INFO] [stderr] ... | [INFO] [stderr] 83 | | false => return MatchedComponents { list: vec![] }, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 68 | if query.nodes[query.edges[query_edge_index].target] [INFO] [stderr] 69 | .matches(&graph.nodes[graph.edges[edge].target], &equality) { [INFO] [stderr] 70 | let descendents = [INFO] [stderr] 71 | recusive_node_match(query.edges[query_edge_index].target, [INFO] [stderr] 72 | graph.edges[matching_edge_in_graph.unwrap()] [INFO] [stderr] 73 | .target, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/lib.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | .filter(|&ref matched_components| matched_components.list.len() == query.nodes.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `&ref` part and just keep: `matched_components` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:33:72 [INFO] [stderr] | [INFO] [stderr] 33 | graph: &graph::Graph, root_index: node::Index, banned_identifiers: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.92s [INFO] running `"docker" "inspect" "1cab4dbe5223e2b2d9fbb6d7afbdfa9680604a20fca632615ed3a0a1cda8a8dc"` [INFO] running `"docker" "rm" "-f" "1cab4dbe5223e2b2d9fbb6d7afbdfa9680604a20fca632615ed3a0a1cda8a8dc"` [INFO] [stdout] 1cab4dbe5223e2b2d9fbb6d7afbdfa9680604a20fca632615ed3a0a1cda8a8dc