[INFO] crate graft 0.1.0 is already in cache [INFO] extracting crate graft 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/graft/0.1.0 [INFO] extracting crate graft 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graft/0.1.0 [INFO] validating manifest of graft-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of graft-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing graft-0.1.0 [INFO] finished frobbing graft-0.1.0 [INFO] frobbed toml for graft-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/graft/0.1.0/Cargo.toml [INFO] started frobbing graft-0.1.0 [INFO] finished frobbing graft-0.1.0 [INFO] frobbed toml for graft-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graft/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting graft-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/graft/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8d5a589f5a8d8a0823c0331acaa9a0dc8ce715fbcb09d20d3cf91e990c65e63 [INFO] running `"docker" "start" "-a" "e8d5a589f5a8d8a0823c0331acaa9a0dc8ce715fbcb09d20d3cf91e990c65e63"` [INFO] [stderr] Checking comrak v0.3.1 [INFO] [stderr] Checking graft v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/context.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self.cache.borrow().get(key) { [INFO] [stderr] 65 | | Some(v) => match v { [INFO] [stderr] 66 | | Some(v) => return Ok(v.to_string()), [INFO] [stderr] 67 | | None => return Err(failure::err_msg("not found")), [INFO] [stderr] 68 | | }, [INFO] [stderr] 69 | | None => {} [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | if let Some(v) = self.cache.borrow().get(key) { match v { [INFO] [stderr] 65 | Some(v) => return Ok(v.to_string()), [INFO] [stderr] 66 | None => return Err(failure::err_msg("not found")), [INFO] [stderr] 67 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/section.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | if part.starts_with("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/section.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | if part.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/section.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | if part.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/section.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | if part.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/context.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self.cache.borrow().get(key) { [INFO] [stderr] 65 | | Some(v) => match v { [INFO] [stderr] 66 | | Some(v) => return Ok(v.to_string()), [INFO] [stderr] 67 | | None => return Err(failure::err_msg("not found")), [INFO] [stderr] 68 | | }, [INFO] [stderr] 69 | | None => {} [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | if let Some(v) = self.cache.borrow().get(key) { match v { [INFO] [stderr] 65 | Some(v) => return Ok(v.to_string()), [INFO] [stderr] 66 | None => return Err(failure::err_msg("not found")), [INFO] [stderr] 67 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/section.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | if part.starts_with("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/section.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | if part.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/section.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | if part.starts_with("!") { [INFO] [stderr] | ^^^ help: try using a char instead: `'!'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/section.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | if part.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.31s [INFO] running `"docker" "inspect" "e8d5a589f5a8d8a0823c0331acaa9a0dc8ce715fbcb09d20d3cf91e990c65e63"` [INFO] running `"docker" "rm" "-f" "e8d5a589f5a8d8a0823c0331acaa9a0dc8ce715fbcb09d20d3cf91e990c65e63"` [INFO] [stdout] e8d5a589f5a8d8a0823c0331acaa9a0dc8ce715fbcb09d20d3cf91e990c65e63