[INFO] crate gradle-sync 0.2.0 is already in cache [INFO] extracting crate gradle-sync 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/gradle-sync/0.2.0 [INFO] extracting crate gradle-sync 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gradle-sync/0.2.0 [INFO] validating manifest of gradle-sync-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gradle-sync-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gradle-sync-0.2.0 [INFO] finished frobbing gradle-sync-0.2.0 [INFO] frobbed toml for gradle-sync-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/gradle-sync/0.2.0/Cargo.toml [INFO] started frobbing gradle-sync-0.2.0 [INFO] finished frobbing gradle-sync-0.2.0 [INFO] frobbed toml for gradle-sync-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gradle-sync/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gradle-sync-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gradle-sync/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 285ebea6cbae60e88b1e9c1b02652e60702dac6ca6e3dccbe121d0f23bc88696 [INFO] running `"docker" "start" "-a" "285ebea6cbae60e88b1e9c1b02652e60702dac6ca6e3dccbe121d0f23bc88696"` [INFO] [stderr] Checking gradle-sync v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/buildgradle.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | line [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/buildgradle.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | let line = replace_version_name(line, self.version.version()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/buildgradle.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | line [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/buildgradle.rs:63:24 [INFO] [stderr] | [INFO] [stderr] 63 | let line = replace_version_name(line, self.version.version()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/version.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if &self.version_name > new_version { [INFO] [stderr] | ------------------^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.version_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/version.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if &self.version_name < new_version { [INFO] [stderr] | ------------------^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.version_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/configfile.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | let fd = File::open(filename.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 18 | let fd = File::open(&(*filename).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 18 | let fd = File::open(&str::clone(filename)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gradle-sync`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/tests/buildgradle.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | let file_content =" [INFO] [stderr] | _______________________^ [INFO] [stderr] 135 | | android { [INFO] [stderr] 136 | | defaultConfig { [INFO] [stderr] 137 | | versionCode 2 [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | }".as_bytes(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 134 | let file_content =b" [INFO] [stderr] 135 | android { [INFO] [stderr] 136 | defaultConfig { [INFO] [stderr] 137 | versionCode 2 [INFO] [stderr] 138 | } [INFO] [stderr] 139 | }"; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/tests/properties.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | let file_content = " [INFO] [stderr] | ________________________^ [INFO] [stderr] 55 | | projectVersion=1.2.0 [INFO] [stderr] 56 | | ".as_bytes(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 54 | let file_content = b" [INFO] [stderr] 55 | projectVersion=1.2.0 [INFO] [stderr] 56 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/tests/properties.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | let file_content = " [INFO] [stderr] | ________________________^ [INFO] [stderr] 71 | | hello world=12.3.4 [INFO] [stderr] 72 | | lsadkfjasdlfj [INFO] [stderr] 73 | | ".as_bytes(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 70 | let file_content = b" [INFO] [stderr] 71 | hello world=12.3.4 [INFO] [stderr] 72 | lsadkfjasdlfj [INFO] [stderr] 73 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/tests/properties.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | let file_content = " [INFO] [stderr] | ________________________^ [INFO] [stderr] 82 | | projectVersion=1.2.0 [INFO] [stderr] 83 | | ".as_bytes(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 81 | let file_content = b" [INFO] [stderr] 82 | projectVersion=1.2.0 [INFO] [stderr] 83 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/version.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if &self.version_name > new_version { [INFO] [stderr] | ------------------^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.version_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/version.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | if &self.version_name < new_version { [INFO] [stderr] | ------------------^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.version_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/configfile.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | let fd = File::open(filename.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 18 | let fd = File::open(&(*filename).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 18 | let fd = File::open(&str::clone(filename)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gradle-sync`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "285ebea6cbae60e88b1e9c1b02652e60702dac6ca6e3dccbe121d0f23bc88696"` [INFO] running `"docker" "rm" "-f" "285ebea6cbae60e88b1e9c1b02652e60702dac6ca6e3dccbe121d0f23bc88696"` [INFO] [stdout] 285ebea6cbae60e88b1e9c1b02652e60702dac6ca6e3dccbe121d0f23bc88696