[INFO] crate gpx 0.6.0 is already in cache
[INFO] extracting crate gpx 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/gpx/0.6.0
[INFO] extracting crate gpx 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gpx/0.6.0
[INFO] validating manifest of gpx-0.6.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gpx-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gpx-0.6.0
[INFO] finished frobbing gpx-0.6.0
[INFO] frobbed toml for gpx-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/gpx/0.6.0/Cargo.toml
[INFO] started frobbing gpx-0.6.0
[INFO] finished frobbing gpx-0.6.0
[INFO] frobbed toml for gpx-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gpx/0.6.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gpx-0.6.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gpx/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ae546afd17ee12cf24cca5c904cf46e832b69d045db53ad5a25e0d003a8420e4
[INFO] running `"docker" "start" "-a" "ae546afd17ee12cf24cca5c904cf46e832b69d045db53ad5a25e0d003a8420e4"`
[INFO] [stderr] Checking alga v0.7.2
[INFO] [stderr] Checking nalgebra v0.16.13
[INFO] [stderr] Checking spade v1.6.0
[INFO] [stderr] Checking geo-types v0.2.2
[INFO] [stderr] Checking gpx v0.6.0 (/opt/crater/workdir)
[INFO] [stderr] Checking geo v0.10.3
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/parser/extensions.rs:36:5
[INFO] [stderr] |
[INFO] [stderr] 36 | return Err("no end tag for extensions".into());
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("no end tag for extensions".into())`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/parser/fix.rs:24:5
[INFO] [stderr] |
[INFO] [stderr] 24 | return Ok(fix);
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(fix)`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/parser/time.rs:20:5
[INFO] [stderr] |
[INFO] [stderr] 20 | return Ok(DateTime::from_utc(time.naive_utc(), Utc));
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DateTime::from_utc(time.naive_utc(), Utc))`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr] --> src/parser/string.rs:29:31
[INFO] [stderr] |
[INFO] [stderr] 29 | return string.ok_or("no content inside string".into());
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no content inside string".into())`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr] --> src/types.rs:181:29
[INFO] [stderr] |
[INFO] [stderr] 181 | GpxPoint(Point::new(0 as f64, 0 as f64))
[INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr] --> src/types.rs:181:39
[INFO] [stderr] |
[INFO] [stderr] 181 | GpxPoint(Point::new(0 as f64, 0 as f64))
[INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/writer.rs:157:37
[INFO] [stderr] |
[INFO] [stderr] 157 | let mut parts = email.split("@");
[INFO] [stderr] | ^^^ help: try using a char instead: `'@'`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> tests/gpx_read.rs:105:51
[INFO] [stderr] |
[INFO] [stderr] 105 | assert_approx_eq!(mls.euclidean_length(), 0.12704048);
[INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.127_040_48`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/parser/bounds.rs:105:35
[INFO] [stderr] |
[INFO] [stderr] 105 | assert_eq!(bounds.min.x, -74.031837463);
[INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `74.031_837_463`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/parser/bounds.rs:106:34
[INFO] [stderr] |
[INFO] [stderr] 106 | assert_eq!(bounds.min.y, 45.487064362);
[INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `45.487_064_362`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/parser/bounds.rs:107:35
[INFO] [stderr] |
[INFO] [stderr] 107 | assert_eq!(bounds.max.x, -73.586273193);
[INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `73.586_273_193`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/parser/bounds.rs:108:34
[INFO] [stderr] |
[INFO] [stderr] 108 | assert_eq!(bounds.max.y, 45.701225281);
[INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `45.701_225_281`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/parser/extensions.rs:36:5
[INFO] [stderr] |
[INFO] [stderr] 36 | return Err("no end tag for extensions".into());
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("no end tag for extensions".into())`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/parser/fix.rs:24:5
[INFO] [stderr] |
[INFO] [stderr] 24 | return Ok(fix);
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(fix)`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/parser/time.rs:20:5
[INFO] [stderr] |
[INFO] [stderr] 20 | return Ok(DateTime::from_utc(time.naive_utc(), Utc));
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DateTime::from_utc(time.naive_utc(), Utc))`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr] --> src/parser/tracksegment.rs:86:58
[INFO] [stderr] |
[INFO] [stderr] 86 | assert_approx_eq!(linestring.euclidean_length(), 9.2377437);
[INFO] [stderr] | ^^^^^^^^^ help: consider: `9.237_743_7`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> tests/gpx_read.rs:176:9
[INFO] [stderr] |
[INFO] [stderr] 176 | assert_eq!(points[0].hdop.unwrap(), 5.);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> tests/gpx_read.rs:176:9
[INFO] [stderr] |
[INFO] [stderr] 176 | assert_eq!(points[0].hdop.unwrap(), 5.);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> tests/gpx_read.rs:177:9
[INFO] [stderr] |
[INFO] [stderr] 177 | assert_eq!(points[0].vdop.unwrap(), 6.2);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> tests/gpx_read.rs:177:9
[INFO] [stderr] |
[INFO] [stderr] 177 | assert_eq!(points[0].vdop.unwrap(), 6.2);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> tests/gpx_read.rs:178:9
[INFO] [stderr] |
[INFO] [stderr] 178 | assert_eq!(points[0].pdop.unwrap(), 728.);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> tests/gpx_read.rs:178:9
[INFO] [stderr] |
[INFO] [stderr] 178 | assert_eq!(points[0].pdop.unwrap(), 728.);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> tests/gpx_read.rs:179:9
[INFO] [stderr] |
[INFO] [stderr] 179 | assert_eq!(points[0].age.unwrap(), 1.);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> tests/gpx_read.rs:179:9
[INFO] [stderr] |
[INFO] [stderr] 179 | assert_eq!(points[0].age.unwrap(), 1.);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> tests/gpx_read.rs:184:9
[INFO] [stderr] |
[INFO] [stderr] 184 | assert_eq!(points[1].hdop.unwrap(), 3.6);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> tests/gpx_read.rs:184:9
[INFO] [stderr] |
[INFO] [stderr] 184 | assert_eq!(points[1].hdop.unwrap(), 3.6);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> tests/gpx_read.rs:185:9
[INFO] [stderr] |
[INFO] [stderr] 185 | assert_eq!(points[1].vdop.unwrap(), 5.);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> tests/gpx_read.rs:185:9
[INFO] [stderr] |
[INFO] [stderr] 185 | assert_eq!(points[1].vdop.unwrap(), 5.);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> tests/gpx_read.rs:186:9
[INFO] [stderr] |
[INFO] [stderr] 186 | assert_eq!(points[1].pdop.unwrap(), 619.1);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> tests/gpx_read.rs:186:9
[INFO] [stderr] |
[INFO] [stderr] 186 | assert_eq!(points[1].pdop.unwrap(), 619.1);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> tests/gpx_read.rs:187:9
[INFO] [stderr] |
[INFO] [stderr] 187 | assert_eq!(points[1].age.unwrap(), 2.01);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> tests/gpx_read.rs:187:9
[INFO] [stderr] |
[INFO] [stderr] 187 | assert_eq!(points[1].age.unwrap(), 2.01);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: aborting due to 8 previous errors
[INFO] [stderr]
[INFO] [stderr] error: Could not compile `gpx`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel
[INFO] [stderr] --> benches/read.rs:1:1
[INFO] [stderr] |
[INFO] [stderr] 1 | #![feature(test)]
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^
[INFO] [stderr]
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr]
[INFO] [stderr] For more information about this error, try `rustc --explain E0554`.
[INFO] [stderr] error: Could not compile `gpx`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> src/parser/bounds.rs:105:9
[INFO] [stderr] |
[INFO] [stderr] 105 | assert_eq!(bounds.min.x, -74.031837463);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> src/parser/bounds.rs:105:9
[INFO] [stderr] |
[INFO] [stderr] 105 | assert_eq!(bounds.min.x, -74.031837463);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> src/parser/bounds.rs:106:9
[INFO] [stderr] |
[INFO] [stderr] 106 | assert_eq!(bounds.min.y, 45.487064362);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> src/parser/bounds.rs:106:9
[INFO] [stderr] |
[INFO] [stderr] 106 | assert_eq!(bounds.min.y, 45.487064362);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> src/parser/bounds.rs:107:9
[INFO] [stderr] |
[INFO] [stderr] 107 | assert_eq!(bounds.max.x, -73.586273193);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> src/parser/bounds.rs:107:9
[INFO] [stderr] |
[INFO] [stderr] 107 | assert_eq!(bounds.max.x, -73.586273193);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> src/parser/bounds.rs:108:9
[INFO] [stderr] |
[INFO] [stderr] 108 | assert_eq!(bounds.max.y, 45.701225281);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> src/parser/bounds.rs:108:9
[INFO] [stderr] |
[INFO] [stderr] 108 | assert_eq!(bounds.max.y, 45.701225281);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/email.rs:91:19
[INFO] [stderr] |
[INFO] [stderr] 91 | let err = consume!("", GpxVersion::Gpx11).unwrap_err();
[INFO] [stderr] | ------------------------------------------------------------ in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dgps"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/fix.rs:38:22
[INFO] [stderr] |
[INFO] [stderr] 38 | let result = consume!("dgps", GpxVersion::Gpx11);
[INFO] [stderr] | ---------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"none"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/fix.rs:41:22
[INFO] [stderr] |
[INFO] [stderr] 41 | let result = consume!("none", GpxVersion::Gpx11);
[INFO] [stderr] | ---------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2d"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/fix.rs:44:22
[INFO] [stderr] |
[INFO] [stderr] 44 | let result = consume!("2d", GpxVersion::Gpx11);
[INFO] [stderr] | -------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"3d"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/fix.rs:47:22
[INFO] [stderr] |
[INFO] [stderr] 47 | let result = consume!("3d", GpxVersion::Gpx11);
[INFO] [stderr] | -------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dgps"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/fix.rs:50:22
[INFO] [stderr] |
[INFO] [stderr] 50 | let result = consume!("dgps", GpxVersion::Gpx11);
[INFO] [stderr] | ---------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"pps"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/fix.rs:53:22
[INFO] [stderr] |
[INFO] [stderr] 53 | let result = consume!("pps", GpxVersion::Gpx11);
[INFO] [stderr] | --------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"KF_4SV_OR_MORE"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/fix.rs:57:22
[INFO] [stderr] |
[INFO] [stderr] 57 | let result = consume!("KF_4SV_OR_MORE", GpxVersion::Gpx11);
[INFO] [stderr] | -------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/gpx.rs:162:19
[INFO] [stderr] |
[INFO] [stderr] 162 | let gpx = consume!("", GpxVersion::Unknown);
[INFO] [stderr] | -------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"helloworld"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/link.rs:71:20
[INFO] [stderr] |
[INFO] [stderr] 71 | let link = consume!(
[INFO] [stderr] | ____________________-
[INFO] [stderr] 72 | | "helloworld",
[INFO] [stderr] 73 | | GpxVersion::Gpx11
[INFO] [stderr] 74 | | );
[INFO] [stderr] | |_________- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/link.rs:91:20
[INFO] [stderr] |
[INFO] [stderr] 91 | let link = consume!(
[INFO] [stderr] | ____________________-
[INFO] [stderr] 92 | | "",
[INFO] [stderr] 93 | | GpxVersion::Gpx11
[INFO] [stderr] 94 | | );
[INFO] [stderr] | |_________- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/link.rs:108:20
[INFO] [stderr] |
[INFO] [stderr] 108 | let link = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | -------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/metadata.rs:87:22
[INFO] [stderr] |
[INFO] [stderr] 87 | let result = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | ---------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr] --> src/parser/string.rs:29:31
[INFO] [stderr] |
[INFO] [stderr] 29 | return string.ok_or("no content inside string".into());
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no content inside string".into())`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:17:48
[INFO] [stderr] |
[INFO] [stderr] 17 | &mut create_context(BufReader::new($xml.as_bytes()), $version),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello world"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/string.rs:46:22
[INFO] [stderr] |
[INFO] [stderr] 46 | let result = consume!("hello world", GpxVersion::Gpx11, "string");
[INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:17:48
[INFO] [stderr] |
[INFO] [stderr] 17 | &mut create_context(BufReader::new($xml.as_bytes()), $version),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bar"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/string.rs:55:22
[INFO] [stderr] |
[INFO] [stderr] 55 | let result = consume!("bar", GpxVersion::Gpx11, "foo");
[INFO] [stderr] | --------------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:17:48
[INFO] [stderr] |
[INFO] [stderr] 17 | &mut create_context(BufReader::new($xml.as_bytes()), $version),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bar"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/string.rs:63:22
[INFO] [stderr] |
[INFO] [stderr] 63 | let result = consume!("bar", GpxVersion::Gpx11, "foo");
[INFO] [stderr] | ----------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:17:48
[INFO] [stderr] |
[INFO] [stderr] 17 | &mut create_context(BufReader::new($xml.as_bytes()), $version),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bar"`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/string.rs:71:22
[INFO] [stderr] |
[INFO] [stderr] 71 | let result = consume!("bar", GpxVersion::Gpx11, "foo");
[INFO] [stderr] | ---------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:17:48
[INFO] [stderr] |
[INFO] [stderr] 17 | &mut create_context(BufReader::new($xml.as_bytes()), $version),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/string.rs:79:22
[INFO] [stderr] |
[INFO] [stderr] 79 | let result = consume!("", GpxVersion::Gpx11, "foo");
[INFO] [stderr] | ------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:17:48
[INFO] [stderr] |
[INFO] [stderr] 17 | &mut create_context(BufReader::new($xml.as_bytes()), $version),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/string.rs:87:22
[INFO] [stderr] |
[INFO] [stderr] 87 | let result = consume!("", GpxVersion::Gpx11, "foo");
[INFO] [stderr] | ---------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/time.rs:32:22
[INFO] [stderr] |
[INFO] [stderr] 32 | let result = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/time.rs:42:22
[INFO] [stderr] |
[INFO] [stderr] 42 | let result = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/time.rs:45:22
[INFO] [stderr] |
[INFO] [stderr] 45 | let result = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/time.rs:48:22
[INFO] [stderr] |
[INFO] [stderr] 48 | let result = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/time.rs:58:22
[INFO] [stderr] |
[INFO] [stderr] 58 | let result = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | ------------------------------------------------------ in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/time.rs:61:22
[INFO] [stderr] |
[INFO] [stderr] 61 | let result = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | ------------------------------------------------------------ in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/time.rs:64:22
[INFO] [stderr] |
[INFO] [stderr] 64 | let result = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/time.rs:67:22
[INFO] [stderr] |
[INFO] [stderr] 67 | let result = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | ---------------------------------------------------------- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/track.rs:78:21
[INFO] [stderr] |
[INFO] [stderr] 78 | let track = consume!(
[INFO] [stderr] | _____________________-
[INFO] [stderr] 79 | | "
[INFO] [stderr] 80 | |
[INFO] [stderr] 81 | | track name
[INFO] [stderr] ... |
[INFO] [stderr] 88 | | GpxVersion::Gpx11
[INFO] [stderr] 89 | | );
[INFO] [stderr] | |_________- in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new(b"
[INFO] [stderr] 11 |
[INFO] [stderr] 12 | track name
[INFO] [stderr] 13 | track comment
[INFO] [stderr] 14 | track description
[INFO] [stderr] 15 | track source
[INFO] [stderr] ...
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/track.rs:104:21
[INFO] [stderr] |
[INFO] [stderr] 104 | let track = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | ------------------------------------------ in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr] --> src/parser/mod.rs:10:28
[INFO] [stderr] |
[INFO] [stderr] 10 | BufReader::new($xml.as_bytes()),
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""`
[INFO] [stderr] |
[INFO] [stderr] ::: src/parser/tracksegment.rs:91:23
[INFO] [stderr] |
[INFO] [stderr] 91 | let segment = consume!("", GpxVersion::Gpx11);
[INFO] [stderr] | ------------------------------------------------ in this macro invocation
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> src/parser/waypoint.rs:212:9
[INFO] [stderr] |
[INFO] [stderr] 212 | assert_eq!(waypoint.elevation.unwrap(), 4608.12);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> src/parser/waypoint.rs:212:9
[INFO] [stderr] |
[INFO] [stderr] 212 | assert_eq!(waypoint.elevation.unwrap(), 4608.12);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> src/parser/waypoint.rs:215:9
[INFO] [stderr] |
[INFO] [stderr] 215 | assert_eq!(waypoint.hdop.unwrap(), 6.058);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> src/parser/waypoint.rs:215:9
[INFO] [stderr] |
[INFO] [stderr] 215 | assert_eq!(waypoint.hdop.unwrap(), 6.058);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> src/parser/waypoint.rs:230:9
[INFO] [stderr] |
[INFO] [stderr] 230 | assert_eq!(waypoint.point().lng(), 1.234);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> src/parser/waypoint.rs:230:9
[INFO] [stderr] |
[INFO] [stderr] 230 | assert_eq!(waypoint.point().lng(), 1.234);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr] --> src/parser/waypoint.rs:231:9
[INFO] [stderr] |
[INFO] [stderr] 231 | assert_eq!(waypoint.point().lat(), 2.345);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr] --> src/parser/waypoint.rs:231:9
[INFO] [stderr] |
[INFO] [stderr] 231 | assert_eq!(waypoint.point().lat(), 2.345);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr]
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr] --> src/types.rs:181:29
[INFO] [stderr] |
[INFO] [stderr] 181 | GpxPoint(Point::new(0 as f64, 0 as f64))
[INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr] --> src/types.rs:181:39
[INFO] [stderr] |
[INFO] [stderr] 181 | GpxPoint(Point::new(0 as f64, 0 as f64))
[INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr]
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr] --> tests/gpx_write.rs:65:9
[INFO] [stderr] |
[INFO] [stderr] 65 | written_gpx
[INFO] [stderr] | ^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr] --> tests/gpx_write.rs:64:27
[INFO] [stderr] |
[INFO] [stderr] 64 | let written_gpx = read(buffer.as_slice()).unwrap();
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/writer.rs:157:37
[INFO] [stderr] |
[INFO] [stderr] 157 | let mut parts = email.split("@");
[INFO] [stderr] | ^^^ help: try using a char instead: `'@'`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] error: aborting due to 8 previous errors
[INFO] [stderr]
[INFO] [stderr] error: Could not compile `gpx`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> tests/gpx_write.rs:84:37
[INFO] [stderr] |
[INFO] [stderr] 84 | fn check_links_equal(reference: &Vec, written: &Vec) {
[INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Link]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> tests/gpx_write.rs:84:58
[INFO] [stderr] |
[INFO] [stderr] 84 | fn check_links_equal(reference: &Vec, written: &Vec) {
[INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Link]`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> tests/gpx_write.rs:104:41
[INFO] [stderr] |
[INFO] [stderr] 104 | fn check_waypoints_equal(reference: &Vec, written: &Vec) {
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Waypoint]`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> tests/gpx_write.rs:104:66
[INFO] [stderr] |
[INFO] [stderr] 104 | fn check_waypoints_equal(reference: &Vec, written: &Vec) {
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Waypoint]`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "ae546afd17ee12cf24cca5c904cf46e832b69d045db53ad5a25e0d003a8420e4"`
[INFO] running `"docker" "rm" "-f" "ae546afd17ee12cf24cca5c904cf46e832b69d045db53ad5a25e0d003a8420e4"`
[INFO] [stdout] ae546afd17ee12cf24cca5c904cf46e832b69d045db53ad5a25e0d003a8420e4