[INFO] crate gotham_middleware_jwt 0.3.0 is already in cache [INFO] extracting crate gotham_middleware_jwt 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/gotham_middleware_jwt/0.3.0 [INFO] extracting crate gotham_middleware_jwt 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gotham_middleware_jwt/0.3.0 [INFO] validating manifest of gotham_middleware_jwt-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gotham_middleware_jwt-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gotham_middleware_jwt-0.3.0 [INFO] finished frobbing gotham_middleware_jwt-0.3.0 [INFO] frobbed toml for gotham_middleware_jwt-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/gotham_middleware_jwt/0.3.0/Cargo.toml [INFO] started frobbing gotham_middleware_jwt-0.3.0 [INFO] finished frobbing gotham_middleware_jwt-0.3.0 [INFO] frobbed toml for gotham_middleware_jwt-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gotham_middleware_jwt/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gotham_middleware_jwt-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gotham_middleware_jwt/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e41c6a9ab7e0b7c59f8b37a4652cb66e79db7bccc7edbd92e617071bb2a1406e [INFO] running `"docker" "start" "-a" "e41c6a9ab7e0b7c59f8b37a4652cb66e79db7bccc7edbd92e617071bb2a1406e"` [INFO] [stderr] Compiling gotham_derive v0.3.0 [INFO] [stderr] Checking jsonwebtoken v5.0.1 [INFO] [stderr] Compiling cargo_metadata v0.6.4 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Compiling skeptic v0.13.4 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Compiling borrow-bag v1.0.0 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking gotham v0.3.0 [INFO] [stderr] Checking gotham_middleware_jwt v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/middleware.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | const SECRET: &'static str = "some-secret"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/middleware.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | token [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/middleware.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | let token = match encode(&header, &claims, SECRET.as_ref()) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 161 | | Ok(t) => t, [INFO] [stderr] 162 | | Err(_) => panic!(), [INFO] [stderr] 163 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/middleware.rs:153:18 [INFO] [stderr] | [INFO] [stderr] 153 | exp: 10000000000, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `10_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/middleware.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/middleware.rs:183:55 [INFO] [stderr] | [INFO] [stderr] 183 | let middleware = JWTMiddleware::::new(SECRET.as_ref()).validation(valid); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `SECRET` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/middleware.rs:210:41 [INFO] [stderr] | [INFO] [stderr] 210 | .with_header(AUTHORIZATION, format!("").parse().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/middleware.rs:223:41 [INFO] [stderr] | [INFO] [stderr] 223 | .with_header(AUTHORIZATION, format!("Bearer ").parse().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Bearer ".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/middleware.rs:236:41 [INFO] [stderr] | [INFO] [stderr] 236 | .with_header(AUTHORIZATION, format!("Bearer xxxx").parse().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Bearer xxxx".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/middleware.rs:249:41 [INFO] [stderr] | [INFO] [stderr] 249 | .with_header(AUTHORIZATION, format!("Bearer").parse().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Bearer".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/middleware.rs:262:41 [INFO] [stderr] | [INFO] [stderr] 262 | .with_header(AUTHORIZATION, format!("Bearer: eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE1MzA0MDE1MjcsImlhdCI6MTUzMDM5OTcyN30.lhg7K9SK3DXsvimVb6o_h6VcsINtkT-qHR-tvDH1bGI").parse().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Bearer: eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJleHAiOjE1MzA0MDE1MjcsImlhdCI6MTUzMDM5OTcyN30.lhg7K9SK3DXsvimVb6o_h6VcsINtkT-qHR-tvDH1bGI".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `"docker" "inspect" "e41c6a9ab7e0b7c59f8b37a4652cb66e79db7bccc7edbd92e617071bb2a1406e"` [INFO] running `"docker" "rm" "-f" "e41c6a9ab7e0b7c59f8b37a4652cb66e79db7bccc7edbd92e617071bb2a1406e"` [INFO] [stdout] e41c6a9ab7e0b7c59f8b37a4652cb66e79db7bccc7edbd92e617071bb2a1406e