[INFO] crate google-videointelligence1 1.0.8+20180920 is already in cache [INFO] extracting crate google-videointelligence1 1.0.8+20180920 into work/ex/clippy-test-run/sources/stable/reg/google-videointelligence1/1.0.8+20180920 [INFO] extracting crate google-videointelligence1 1.0.8+20180920 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/google-videointelligence1/1.0.8+20180920 [INFO] validating manifest of google-videointelligence1-1.0.8+20180920 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of google-videointelligence1-1.0.8+20180920 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing google-videointelligence1-1.0.8+20180920 [INFO] finished frobbing google-videointelligence1-1.0.8+20180920 [INFO] frobbed toml for google-videointelligence1-1.0.8+20180920 written to work/ex/clippy-test-run/sources/stable/reg/google-videointelligence1/1.0.8+20180920/Cargo.toml [INFO] started frobbing google-videointelligence1-1.0.8+20180920 [INFO] finished frobbing google-videointelligence1-1.0.8+20180920 [INFO] frobbed toml for google-videointelligence1-1.0.8+20180920 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/google-videointelligence1/1.0.8+20180920/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting google-videointelligence1-1.0.8+20180920 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/google-videointelligence1/1.0.8+20180920:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1fb0e605b3f5c16e5126cb4cf73cfbaf35f7803939c142c609b70242cd0f11c [INFO] running `"docker" "start" "-a" "f1fb0e605b3f5c16e5126cb4cf73cfbaf35f7803939c142c609b70242cd0f11c"` [INFO] [stderr] Checking google-videointelligence1 v1.0.8+20180920 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmn.rs:360:18 [INFO] [stderr] | [INFO] [stderr] 360 | const BOUNDARY: &'static str = "MDuXWGyeE33QFXGchb2VFWc4Z7945d"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmn.rs:594:32 [INFO] [stderr] | [INFO] [stderr] 594 | const PREFIX: &'static str = "bytes "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmn.rs:360:18 [INFO] [stderr] | [INFO] [stderr] 360 | const BOUNDARY: &'static str = "MDuXWGyeE33QFXGchb2VFWc4Z7945d"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmn.rs:594:32 [INFO] [stderr] | [INFO] [stderr] 594 | const PREFIX: &'static str = "bytes "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cmn.rs:312:45 [INFO] [stderr] | [INFO] [stderr] 312 | / match &err.location { [INFO] [stderr] 313 | | &Some(ref loc) => format!("@{}", loc), [INFO] [stderr] 314 | | &None => String::new(), [INFO] [stderr] 315 | | })); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 312 | match err.location { [INFO] [stderr] 313 | Some(ref loc) => format!("@{}", loc), [INFO] [stderr] 314 | None => String::new(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmn.rs:411:9 [INFO] [stderr] | [INFO] [stderr] 411 | self.raw_parts.len() == 0 && self.current_part.is_none() && self.last_part_boundary.is_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.raw_parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmn.rs:416:9 [INFO] [stderr] | [INFO] [stderr] 416 | self.raw_parts.len() == 0 && self.current_part.is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.raw_parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/cmn.rs:492:5 [INFO] [stderr] | [INFO] [stderr] 492 | fn deref<'a>(&'a self) -> &'a Mime { &self.0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/cmn.rs:495:5 [INFO] [stderr] | [INFO] [stderr] 495 | fn deref_mut<'a>(&'a mut self) -> &'a mut Mime { &mut self.0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmn.rs:591:12 [INFO] [stderr] | [INFO] [stderr] 591 | if raw.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cmn.rs:735:5 [INFO] [stderr] | [INFO] [stderr] 735 | / match *value { [INFO] [stderr] 736 | | json::value::Value::Object(ref mut map) => { [INFO] [stderr] 737 | | let mut for_removal = Vec::new(); [INFO] [stderr] 738 | | [INFO] [stderr] ... | [INFO] [stderr] 751 | | _ => {} [INFO] [stderr] 752 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 735 | if let json::value::Value::Object(ref mut map) = *value { [INFO] [stderr] 736 | let mut for_removal = Vec::new(); [INFO] [stderr] 737 | [INFO] [stderr] 738 | for (key, mut value) in map.iter_mut() { [INFO] [stderr] 739 | if value.is_null() { [INFO] [stderr] 740 | for_removal.push(key.clone()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_AnnotateVideoRequest` should have a camel case name such as `Googlecloudvideointelligencev1Annotatevideorequest` [INFO] [stderr] --> src/lib.rs:389:1 [INFO] [stderr] | [INFO] [stderr] 389 | / pub struct GoogleCloudVideointelligenceV1_AnnotateVideoRequest { [INFO] [stderr] 390 | | /// Additional video context and/or feature-specific parameters. [INFO] [stderr] 391 | | #[serde(rename="videoContext")] [INFO] [stderr] 392 | | pub video_context: Option, [INFO] [stderr] ... | [INFO] [stderr] 424 | | pub output_uri: Option, [INFO] [stderr] 425 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `GoogleProtobuf_Empty` should have a camel case name such as `GoogleprotobufEmpty` [INFO] [stderr] --> src/lib.rs:449:1 [INFO] [stderr] | [INFO] [stderr] 449 | pub struct GoogleProtobuf_Empty { _never_set: Option } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleLongrunning_ListOperationsResponse` should have a camel case name such as `GooglelongrunningListoperationsresponse` [INFO] [stderr] --> src/lib.rs:464:1 [INFO] [stderr] | [INFO] [stderr] 464 | / pub struct GoogleLongrunning_ListOperationsResponse { [INFO] [stderr] 465 | | /// A list of operations that matches the specified filter in the request. [INFO] [stderr] 466 | | pub operations: Option>, [INFO] [stderr] 467 | | /// The standard List next-page token. [INFO] [stderr] 468 | | #[serde(rename="nextPageToken")] [INFO] [stderr] 469 | | pub next_page_token: Option, [INFO] [stderr] 470 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_VideoSegment` should have a camel case name such as `Googlecloudvideointelligencev1Videosegment` [INFO] [stderr] --> src/lib.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | / pub struct GoogleCloudVideointelligenceV1_VideoSegment { [INFO] [stderr] 481 | | /// Time-offset, relative to the beginning of the video, [INFO] [stderr] 482 | | /// corresponding to the end of the segment (inclusive). [INFO] [stderr] 483 | | #[serde(rename="endTimeOffset")] [INFO] [stderr] ... | [INFO] [stderr] 488 | | pub start_time_offset: Option, [INFO] [stderr] 489 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_VideoContext` should have a camel case name such as `Googlecloudvideointelligencev1Videocontext` [INFO] [stderr] --> src/lib.rs:499:1 [INFO] [stderr] | [INFO] [stderr] 499 | / pub struct GoogleCloudVideointelligenceV1_VideoContext { [INFO] [stderr] 500 | | /// Video segments to annotate. The segments may overlap and are not required [INFO] [stderr] 501 | | /// to be contiguous or span the whole video. If unspecified, each video is [INFO] [stderr] 502 | | /// treated as a single segment. [INFO] [stderr] ... | [INFO] [stderr] 512 | | pub shot_change_detection_config: Option, [INFO] [stderr] 513 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleLongrunning_Operation` should have a camel case name such as `GooglelongrunningOperation` [INFO] [stderr] --> src/lib.rs:530:1 [INFO] [stderr] | [INFO] [stderr] 530 | / pub struct GoogleLongrunning_Operation { [INFO] [stderr] 531 | | /// The error result of the operation in case of failure or cancellation. [INFO] [stderr] 532 | | pub error: Option, [INFO] [stderr] 533 | | /// If the value is `false`, it means the operation is still in progress. [INFO] [stderr] ... | [INFO] [stderr] 554 | | pub metadata: Option>, [INFO] [stderr] 555 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_LabelDetectionConfig` should have a camel case name such as `Googlecloudvideointelligencev1Labeldetectionconfig` [INFO] [stderr] --> src/lib.rs:565:1 [INFO] [stderr] | [INFO] [stderr] 565 | / pub struct GoogleCloudVideointelligenceV1_LabelDetectionConfig { [INFO] [stderr] 566 | | /// What labels should be detected with LABEL_DETECTION, in addition to [INFO] [stderr] 567 | | /// video-level labels or segment-level labels. [INFO] [stderr] 568 | | /// If unspecified, defaults to `SHOT_MODE`. [INFO] [stderr] ... | [INFO] [stderr] 579 | | pub stationary_camera: Option, [INFO] [stderr] 580 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleLongrunning_CancelOperationRequest` should have a camel case name such as `GooglelongrunningCanceloperationrequest` [INFO] [stderr] --> src/lib.rs:595:1 [INFO] [stderr] | [INFO] [stderr] 595 | pub struct GoogleLongrunning_CancelOperationRequest { _never_set: Option } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_ExplicitContentDetectionConfig` should have a camel case name such as `Googlecloudvideointelligencev1Explicitcontentdetectionconfig` [INFO] [stderr] --> src/lib.rs:605:1 [INFO] [stderr] | [INFO] [stderr] 605 | / pub struct GoogleCloudVideointelligenceV1_ExplicitContentDetectionConfig { [INFO] [stderr] 606 | | /// Model to use for explicit content detection. [INFO] [stderr] 607 | | /// Supported values: "builtin/stable" (the default if unset) and [INFO] [stderr] 608 | | /// "builtin/latest". [INFO] [stderr] 609 | | pub model: Option, [INFO] [stderr] 610 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleRpc_Status` should have a camel case name such as `GooglerpcStatus` [INFO] [stderr] --> src/lib.rs:671:1 [INFO] [stderr] | [INFO] [stderr] 671 | / pub struct GoogleRpc_Status { [INFO] [stderr] 672 | | /// A developer-facing error message, which should be in English. Any [INFO] [stderr] 673 | | /// user-facing error message should be localized and sent in the [INFO] [stderr] 674 | | /// google.rpc.Status.details field, or localized by the client. [INFO] [stderr] ... | [INFO] [stderr] 680 | | pub details: Option>>, [INFO] [stderr] 681 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_ShotChangeDetectionConfig` should have a camel case name such as `Googlecloudvideointelligencev1Shotchangedetectionconfig` [INFO] [stderr] --> src/lib.rs:691:1 [INFO] [stderr] | [INFO] [stderr] 691 | / pub struct GoogleCloudVideointelligenceV1_ShotChangeDetectionConfig { [INFO] [stderr] 692 | | /// Model to use for shot change detection. [INFO] [stderr] 693 | | /// Supported values: "builtin/stable" (the default if unset) and [INFO] [stderr] 694 | | /// "builtin/latest". [INFO] [stderr] 695 | | pub model: Option, [INFO] [stderr] 696 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:984:12 [INFO] [stderr] | [INFO] [stderr] 984 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:996:43 [INFO] [stderr] | [INFO] [stderr] 996 | if find_this.as_bytes()[1] == '+' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'+' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1013:12 [INFO] [stderr] | [INFO] [stderr] 1013 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1261:12 [INFO] [stderr] | [INFO] [stderr] 1261 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1266:12 [INFO] [stderr] | [INFO] [stderr] 1266 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1508:12 [INFO] [stderr] | [INFO] [stderr] 1508 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:1520:43 [INFO] [stderr] | [INFO] [stderr] 1520 | if find_this.as_bytes()[1] == '+' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'+' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1537:12 [INFO] [stderr] | [INFO] [stderr] 1537 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1775:12 [INFO] [stderr] | [INFO] [stderr] 1775 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:1787:43 [INFO] [stderr] | [INFO] [stderr] 1787 | if find_this.as_bytes()[1] == '+' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'+' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1804:12 [INFO] [stderr] | [INFO] [stderr] 1804 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2057:12 [INFO] [stderr] | [INFO] [stderr] 2057 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2062:12 [INFO] [stderr] | [INFO] [stderr] 2062 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cmn.rs:312:45 [INFO] [stderr] | [INFO] [stderr] 312 | / match &err.location { [INFO] [stderr] 313 | | &Some(ref loc) => format!("@{}", loc), [INFO] [stderr] 314 | | &None => String::new(), [INFO] [stderr] 315 | | })); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 312 | match err.location { [INFO] [stderr] 313 | Some(ref loc) => format!("@{}", loc), [INFO] [stderr] 314 | None => String::new(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmn.rs:411:9 [INFO] [stderr] | [INFO] [stderr] 411 | self.raw_parts.len() == 0 && self.current_part.is_none() && self.last_part_boundary.is_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.raw_parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmn.rs:416:9 [INFO] [stderr] | [INFO] [stderr] 416 | self.raw_parts.len() == 0 && self.current_part.is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.raw_parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/cmn.rs:492:5 [INFO] [stderr] | [INFO] [stderr] 492 | fn deref<'a>(&'a self) -> &'a Mime { &self.0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/cmn.rs:495:5 [INFO] [stderr] | [INFO] [stderr] 495 | fn deref_mut<'a>(&'a mut self) -> &'a mut Mime { &mut self.0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmn.rs:591:12 [INFO] [stderr] | [INFO] [stderr] 591 | if raw.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cmn.rs:735:5 [INFO] [stderr] | [INFO] [stderr] 735 | / match *value { [INFO] [stderr] 736 | | json::value::Value::Object(ref mut map) => { [INFO] [stderr] 737 | | let mut for_removal = Vec::new(); [INFO] [stderr] 738 | | [INFO] [stderr] ... | [INFO] [stderr] 751 | | _ => {} [INFO] [stderr] 752 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 735 | if let json::value::Value::Object(ref mut map) = *value { [INFO] [stderr] 736 | let mut for_removal = Vec::new(); [INFO] [stderr] 737 | [INFO] [stderr] 738 | for (key, mut value) in map.iter_mut() { [INFO] [stderr] 739 | if value.is_null() { [INFO] [stderr] 740 | for_removal.push(key.clone()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_AnnotateVideoRequest` should have a camel case name such as `Googlecloudvideointelligencev1Annotatevideorequest` [INFO] [stderr] --> src/lib.rs:389:1 [INFO] [stderr] | [INFO] [stderr] 389 | / pub struct GoogleCloudVideointelligenceV1_AnnotateVideoRequest { [INFO] [stderr] 390 | | /// Additional video context and/or feature-specific parameters. [INFO] [stderr] 391 | | #[serde(rename="videoContext")] [INFO] [stderr] 392 | | pub video_context: Option, [INFO] [stderr] ... | [INFO] [stderr] 424 | | pub output_uri: Option, [INFO] [stderr] 425 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `GoogleProtobuf_Empty` should have a camel case name such as `GoogleprotobufEmpty` [INFO] [stderr] --> src/lib.rs:449:1 [INFO] [stderr] | [INFO] [stderr] 449 | pub struct GoogleProtobuf_Empty { _never_set: Option } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleLongrunning_ListOperationsResponse` should have a camel case name such as `GooglelongrunningListoperationsresponse` [INFO] [stderr] --> src/lib.rs:464:1 [INFO] [stderr] | [INFO] [stderr] 464 | / pub struct GoogleLongrunning_ListOperationsResponse { [INFO] [stderr] 465 | | /// A list of operations that matches the specified filter in the request. [INFO] [stderr] 466 | | pub operations: Option>, [INFO] [stderr] 467 | | /// The standard List next-page token. [INFO] [stderr] 468 | | #[serde(rename="nextPageToken")] [INFO] [stderr] 469 | | pub next_page_token: Option, [INFO] [stderr] 470 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_VideoSegment` should have a camel case name such as `Googlecloudvideointelligencev1Videosegment` [INFO] [stderr] --> src/lib.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | / pub struct GoogleCloudVideointelligenceV1_VideoSegment { [INFO] [stderr] 481 | | /// Time-offset, relative to the beginning of the video, [INFO] [stderr] 482 | | /// corresponding to the end of the segment (inclusive). [INFO] [stderr] 483 | | #[serde(rename="endTimeOffset")] [INFO] [stderr] ... | [INFO] [stderr] 488 | | pub start_time_offset: Option, [INFO] [stderr] 489 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_VideoContext` should have a camel case name such as `Googlecloudvideointelligencev1Videocontext` [INFO] [stderr] --> src/lib.rs:499:1 [INFO] [stderr] | [INFO] [stderr] 499 | / pub struct GoogleCloudVideointelligenceV1_VideoContext { [INFO] [stderr] 500 | | /// Video segments to annotate. The segments may overlap and are not required [INFO] [stderr] 501 | | /// to be contiguous or span the whole video. If unspecified, each video is [INFO] [stderr] 502 | | /// treated as a single segment. [INFO] [stderr] ... | [INFO] [stderr] 512 | | pub shot_change_detection_config: Option, [INFO] [stderr] 513 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleLongrunning_Operation` should have a camel case name such as `GooglelongrunningOperation` [INFO] [stderr] --> src/lib.rs:530:1 [INFO] [stderr] | [INFO] [stderr] 530 | / pub struct GoogleLongrunning_Operation { [INFO] [stderr] 531 | | /// The error result of the operation in case of failure or cancellation. [INFO] [stderr] 532 | | pub error: Option, [INFO] [stderr] 533 | | /// If the value is `false`, it means the operation is still in progress. [INFO] [stderr] ... | [INFO] [stderr] 554 | | pub metadata: Option>, [INFO] [stderr] 555 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_LabelDetectionConfig` should have a camel case name such as `Googlecloudvideointelligencev1Labeldetectionconfig` [INFO] [stderr] --> src/lib.rs:565:1 [INFO] [stderr] | [INFO] [stderr] 565 | / pub struct GoogleCloudVideointelligenceV1_LabelDetectionConfig { [INFO] [stderr] 566 | | /// What labels should be detected with LABEL_DETECTION, in addition to [INFO] [stderr] 567 | | /// video-level labels or segment-level labels. [INFO] [stderr] 568 | | /// If unspecified, defaults to `SHOT_MODE`. [INFO] [stderr] ... | [INFO] [stderr] 579 | | pub stationary_camera: Option, [INFO] [stderr] 580 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleLongrunning_CancelOperationRequest` should have a camel case name such as `GooglelongrunningCanceloperationrequest` [INFO] [stderr] --> src/lib.rs:595:1 [INFO] [stderr] | [INFO] [stderr] 595 | pub struct GoogleLongrunning_CancelOperationRequest { _never_set: Option } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_ExplicitContentDetectionConfig` should have a camel case name such as `Googlecloudvideointelligencev1Explicitcontentdetectionconfig` [INFO] [stderr] --> src/lib.rs:605:1 [INFO] [stderr] | [INFO] [stderr] 605 | / pub struct GoogleCloudVideointelligenceV1_ExplicitContentDetectionConfig { [INFO] [stderr] 606 | | /// Model to use for explicit content detection. [INFO] [stderr] 607 | | /// Supported values: "builtin/stable" (the default if unset) and [INFO] [stderr] 608 | | /// "builtin/latest". [INFO] [stderr] 609 | | pub model: Option, [INFO] [stderr] 610 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleRpc_Status` should have a camel case name such as `GooglerpcStatus` [INFO] [stderr] --> src/lib.rs:671:1 [INFO] [stderr] | [INFO] [stderr] 671 | / pub struct GoogleRpc_Status { [INFO] [stderr] 672 | | /// A developer-facing error message, which should be in English. Any [INFO] [stderr] 673 | | /// user-facing error message should be localized and sent in the [INFO] [stderr] 674 | | /// google.rpc.Status.details field, or localized by the client. [INFO] [stderr] ... | [INFO] [stderr] 680 | | pub details: Option>>, [INFO] [stderr] 681 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: type `GoogleCloudVideointelligenceV1_ShotChangeDetectionConfig` should have a camel case name such as `Googlecloudvideointelligencev1Shotchangedetectionconfig` [INFO] [stderr] --> src/lib.rs:691:1 [INFO] [stderr] | [INFO] [stderr] 691 | / pub struct GoogleCloudVideointelligenceV1_ShotChangeDetectionConfig { [INFO] [stderr] 692 | | /// Model to use for shot change detection. [INFO] [stderr] 693 | | /// Supported values: "builtin/stable" (the default if unset) and [INFO] [stderr] 694 | | /// "builtin/latest". [INFO] [stderr] 695 | | pub model: Option, [INFO] [stderr] 696 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:984:12 [INFO] [stderr] | [INFO] [stderr] 984 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:996:43 [INFO] [stderr] | [INFO] [stderr] 996 | if find_this.as_bytes()[1] == '+' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'+' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1013:12 [INFO] [stderr] | [INFO] [stderr] 1013 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1261:12 [INFO] [stderr] | [INFO] [stderr] 1261 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1266:12 [INFO] [stderr] | [INFO] [stderr] 1266 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1508:12 [INFO] [stderr] | [INFO] [stderr] 1508 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:1520:43 [INFO] [stderr] | [INFO] [stderr] 1520 | if find_this.as_bytes()[1] == '+' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'+' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1537:12 [INFO] [stderr] | [INFO] [stderr] 1537 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1775:12 [INFO] [stderr] | [INFO] [stderr] 1775 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:1787:43 [INFO] [stderr] | [INFO] [stderr] 1787 | if find_this.as_bytes()[1] == '+' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'+' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1804:12 [INFO] [stderr] | [INFO] [stderr] 1804 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2057:12 [INFO] [stderr] | [INFO] [stderr] 2057 | if self._scopes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self._scopes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2062:12 [INFO] [stderr] | [INFO] [stderr] 2062 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.08s [INFO] running `"docker" "inspect" "f1fb0e605b3f5c16e5126cb4cf73cfbaf35f7803939c142c609b70242cd0f11c"` [INFO] running `"docker" "rm" "-f" "f1fb0e605b3f5c16e5126cb4cf73cfbaf35f7803939c142c609b70242cd0f11c"` [INFO] [stdout] f1fb0e605b3f5c16e5126cb4cf73cfbaf35f7803939c142c609b70242cd0f11c