[INFO] crate google-urlshortener1-cli 1.0.8+20150519 is already in cache
[INFO] extracting crate google-urlshortener1-cli 1.0.8+20150519 into work/ex/clippy-test-run/sources/stable/reg/google-urlshortener1-cli/1.0.8+20150519
[INFO] extracting crate google-urlshortener1-cli 1.0.8+20150519 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/google-urlshortener1-cli/1.0.8+20150519
[INFO] validating manifest of google-urlshortener1-cli-1.0.8+20150519 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of google-urlshortener1-cli-1.0.8+20150519 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing google-urlshortener1-cli-1.0.8+20150519
[INFO] finished frobbing google-urlshortener1-cli-1.0.8+20150519
[INFO] frobbed toml for google-urlshortener1-cli-1.0.8+20150519 written to work/ex/clippy-test-run/sources/stable/reg/google-urlshortener1-cli/1.0.8+20150519/Cargo.toml
[INFO] started frobbing google-urlshortener1-cli-1.0.8+20150519
[INFO] finished frobbing google-urlshortener1-cli-1.0.8+20150519
[INFO] frobbed toml for google-urlshortener1-cli-1.0.8+20150519 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/google-urlshortener1-cli/1.0.8+20150519/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting google-urlshortener1-cli-1.0.8+20150519 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/google-urlshortener1-cli/1.0.8+20150519:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cb20c586868966cda6f8be90737f1a5f91aa6f46962a07c085f4cf78c7d3f154
[INFO] running `"docker" "start" "-a" "cb20c586868966cda6f8be90737f1a5f91aa6f46962a07c085f4cf78c7d3f154"`
[INFO] [stderr]     Checking google-urlshortener1 v1.0.8+20150519
[INFO] [stderr]     Checking google-urlshortener1-cli v1.0.8+20150519 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/cmn.rs:661:17
[INFO] [stderr]     |
[INFO] [stderr] 661 |                 write!(f, "Parameter '{}' is unknown.{}\n", param_name, suffix)
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cmn.rs:702:13
[INFO] [stderr]     |
[INFO] [stderr] 702 |             exit_code: exit_code,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exit_code`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:338:13
[INFO] [stderr]     |
[INFO] [stderr] 338 |             opt: opt,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `opt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/cmn.rs:661:17
[INFO] [stderr]     |
[INFO] [stderr] 661 |                 write!(f, "Parameter '{}' is unknown.{}\n", param_name, suffix)
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cmn.rs:702:13
[INFO] [stderr]     |
[INFO] [stderr] 702 |             exit_code: exit_code,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exit_code`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:338:13
[INFO] [stderr]     |
[INFO] [stderr] 338 |             opt: opt,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `opt`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/cmn.rs:183:17
[INFO] [stderr]     |
[INFO] [stderr] 183 | /                 if cid == 1 {
[INFO] [stderr] 184 | |                     if first_is_field_sep {
[INFO] [stderr] 185 | |                         fields.truncate(0);
[INFO] [stderr] 186 | |                     }
[INFO] [stderr] 187 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 if cid == 1 && first_is_field_sep {
[INFO] [stderr] 184 |     fields.truncate(0);
[INFO] [stderr] 185 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cmn.rs:348:13
[INFO] [stderr]     |
[INFO] [stderr] 348 |             return (kv, None);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(kv, None)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/cmn.rs:183:17
[INFO] [stderr]     |
[INFO] [stderr] 183 | /                 if cid == 1 {
[INFO] [stderr] 184 | |                     if first_is_field_sep {
[INFO] [stderr] 185 | |                         fields.truncate(0);
[INFO] [stderr] 186 | |                     }
[INFO] [stderr] 187 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 if cid == 1 && first_is_field_sep {
[INFO] [stderr] 184 |     fields.truncate(0);
[INFO] [stderr] 185 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/cmn.rs:348:13
[INFO] [stderr]     |
[INFO] [stderr] 348 |             return (kv, None);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(kv, None)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/cmn.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     match *value {
[INFO] [stderr] 55 | |         Value::Object(ref mut map) => {
[INFO] [stderr] 56 | |             let mut for_removal = Vec::new();
[INFO] [stderr] 57 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |         _ => {}
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 54 |     if let Value::Object(ref mut map) = *value {
[INFO] [stderr] 55 |     let mut for_removal = Vec::new();
[INFO] [stderr] 56 | 
[INFO] [stderr] 57 |     for (key, mut value) in map.iter_mut() {
[INFO] [stderr] 58 |         if value.is_null() {
[INFO] [stderr] 59 |             for_removal.push(key.clone());
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cmn.rs:137:65
[INFO] [stderr]     |
[INFO] [stderr] 137 | fn assure_entry<'a, 'b>(m: &'a mut json::Map<String, Value>, k: &'b String) -> &'a mut Value {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:147:12
[INFO] [stderr]     |
[INFO] [stderr] 147 |         if value.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:160:16
[INFO] [stderr]     |
[INFO] [stderr] 160 |             if f.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!f.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:208:12
[INFO] [stderr]     |
[INFO] [stderr] 208 |         if value.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:218:16
[INFO] [stderr]     |
[INFO] [stderr] 218 |             if f.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!f.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/cmn.rs:242:12
[INFO] [stderr]     |
[INFO] [stderr] 242 |         if &output == value {
[INFO] [stderr]     |            -------^^^^^^^^^
[INFO] [stderr]     |            |
[INFO] [stderr]     |            help: use the left value directly: `output`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:255:17
[INFO] [stderr]     |
[INFO] [stderr] 255 |         assert!(self.0.len() > 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.0.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:716:8
[INFO] [stderr]     |
[INFO] [stderr] 716 |     if trdir.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trdir.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/cmn.rs:721:37
[INFO] [stderr]     |
[INFO] [stderr] 721 |         match env::var("HOME").ok().or(env::var("UserProfile").ok()) {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env::var("UserProfile").ok())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/main.rs:52:21
[INFO] [stderr]    |
[INFO] [stderr] 52 |         for parg in opt.values_of("v").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.values_of("v").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/main.rs:70:85
[INFO] [stderr]    |
[INFO] [stderr] 70 |                                                                            v.extend(self.gp.iter().map(|v|*v));
[INFO] [stderr]    |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.gp.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/main.rs:71:85
[INFO] [stderr]    |
[INFO] [stderr] 71 |                                                                            v.extend(["projection"].iter().map(|v|*v));
[INFO] [stderr]    |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `["projection"].iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:81:21
[INFO] [stderr]    |
[INFO] [stderr] 81 |             assert!(err.issues.len() == 0);
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `err.issues.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/main.rs:82:26
[INFO] [stderr]    |
[INFO] [stderr] 82 |             for scope in self.opt.values_of("url").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.opt.values_of("url").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:111:22
[INFO] [stderr]     |
[INFO] [stderr] 111 |         for kvarg in opt.values_of("kv").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.values_of("kv").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/main.rs:144:73
[INFO] [stderr]     |
[INFO] [stderr] 144 |                         let suggestion = FieldCursor::did_you_mean(key, &vec!["all-time", "analytics", "created", "day", "id", "kind", "long-url", "long-url-clicks", "month", "short-url-clicks", "status", "two-hours", "week"]);
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["all-time", "analytics", "created", "day", "id", "kind", "long-url", "long-url-clicks", "month", "short-url-clicks", "status", "two-hours", "week"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:155:21
[INFO] [stderr]     |
[INFO] [stderr] 155 |         for parg in opt.values_of("v").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.values_of("v").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:170:85
[INFO] [stderr]     |
[INFO] [stderr] 170 |                                                                            v.extend(self.gp.iter().map(|v|*v));
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.gp.iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:180:21
[INFO] [stderr]     |
[INFO] [stderr] 180 |             assert!(err.issues.len() == 0);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `err.issues.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:181:26
[INFO] [stderr]     |
[INFO] [stderr] 181 |             for scope in self.opt.values_of("url").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.opt.values_of("url").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:207:21
[INFO] [stderr]     |
[INFO] [stderr] 207 |         for parg in opt.values_of("v").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.values_of("v").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:228:85
[INFO] [stderr]     |
[INFO] [stderr] 228 |                                                                            v.extend(self.gp.iter().map(|v|*v));
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.gp.iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:229:85
[INFO] [stderr]     |
[INFO] [stderr] 229 |                                                                            v.extend(["start-token", "projection"].iter().map(|v|*v));
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `["start-token", "projection"].iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:239:21
[INFO] [stderr]     |
[INFO] [stderr] 239 |             assert!(err.issues.len() == 0);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `err.issues.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:240:26
[INFO] [stderr]     |
[INFO] [stderr] 240 |             for scope in self.opt.values_of("url").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.opt.values_of("url").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:292:16
[INFO] [stderr]     |
[INFO] [stderr] 292 |             if err.issues.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!err.issues.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:463:20
[INFO] [stderr]     |
[INFO] [stderr] 463 | /                    if let &Some(desc) = desc {
[INFO] [stderr] 464 | |                        scmd = scmd.about(desc);
[INFO] [stderr] 465 | |                    }
[INFO] [stderr]     | |____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 463 |                    if let Some(desc) = *desc {
[INFO] [stderr]     |                           ^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:477:24
[INFO] [stderr]     |
[INFO] [stderr] 477 | /                        if let &Some(short_flag) = flag {
[INFO] [stderr] 478 | |                            arg = arg.short(short_flag);
[INFO] [stderr] 479 | |                        }
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 477 |                        if let Some(short_flag) = *flag {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:480:24
[INFO] [stderr]     |
[INFO] [stderr] 480 | /                        if let &Some(desc) = desc {
[INFO] [stderr] 481 | |                            arg = arg.help(desc);
[INFO] [stderr] 482 | |                        }
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 480 |                        if let Some(desc) = *desc {
[INFO] [stderr]     |                               ^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:486:24
[INFO] [stderr]     |
[INFO] [stderr] 486 | /                        if let &Some(required) = required {
[INFO] [stderr] 487 | |                            arg = arg.required(required);
[INFO] [stderr] 488 | |                        }
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 486 |                        if let Some(required) = *required {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^   ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:489:24
[INFO] [stderr]     |
[INFO] [stderr] 489 | /                        if let &Some(multi) = multi {
[INFO] [stderr] 490 | |                            arg = arg.multiple(multi);
[INFO] [stderr] 491 | |                        }
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 489 |                        if let Some(multi) = *multi {
[INFO] [stderr]     |                               ^^^^^^^^^^^   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/cmn.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     match *value {
[INFO] [stderr] 55 | |         Value::Object(ref mut map) => {
[INFO] [stderr] 56 | |             let mut for_removal = Vec::new();
[INFO] [stderr] 57 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |         _ => {}
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 54 |     if let Value::Object(ref mut map) = *value {
[INFO] [stderr] 55 |     let mut for_removal = Vec::new();
[INFO] [stderr] 56 | 
[INFO] [stderr] 57 |     for (key, mut value) in map.iter_mut() {
[INFO] [stderr] 58 |         if value.is_null() {
[INFO] [stderr] 59 |             for_removal.push(key.clone());
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/cmn.rs:137:65
[INFO] [stderr]     |
[INFO] [stderr] 137 | fn assure_entry<'a, 'b>(m: &'a mut json::Map<String, Value>, k: &'b String) -> &'a mut Value {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:147:12
[INFO] [stderr]     |
[INFO] [stderr] 147 |         if value.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:160:16
[INFO] [stderr]     |
[INFO] [stderr] 160 |             if f.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!f.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:208:12
[INFO] [stderr]     |
[INFO] [stderr] 208 |         if value.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:218:16
[INFO] [stderr]     |
[INFO] [stderr] 218 |             if f.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!f.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/cmn.rs:242:12
[INFO] [stderr]     |
[INFO] [stderr] 242 |         if &output == value {
[INFO] [stderr]     |            -------^^^^^^^^^
[INFO] [stderr]     |            |
[INFO] [stderr]     |            help: use the left value directly: `output`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:255:17
[INFO] [stderr]     |
[INFO] [stderr] 255 |         assert!(self.0.len() > 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.0.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/cmn.rs:716:8
[INFO] [stderr]     |
[INFO] [stderr] 716 |     if trdir.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trdir.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/cmn.rs:721:37
[INFO] [stderr]     |
[INFO] [stderr] 721 |         match env::var("HOME").ok().or(env::var("UserProfile").ok()) {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env::var("UserProfile").ok())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/main.rs:52:21
[INFO] [stderr]    |
[INFO] [stderr] 52 |         for parg in opt.values_of("v").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.values_of("v").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/main.rs:70:85
[INFO] [stderr]    |
[INFO] [stderr] 70 |                                                                            v.extend(self.gp.iter().map(|v|*v));
[INFO] [stderr]    |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.gp.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/main.rs:71:85
[INFO] [stderr]    |
[INFO] [stderr] 71 |                                                                            v.extend(["projection"].iter().map(|v|*v));
[INFO] [stderr]    |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `["projection"].iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:81:21
[INFO] [stderr]    |
[INFO] [stderr] 81 |             assert!(err.issues.len() == 0);
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `err.issues.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/main.rs:82:26
[INFO] [stderr]    |
[INFO] [stderr] 82 |             for scope in self.opt.values_of("url").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.opt.values_of("url").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:111:22
[INFO] [stderr]     |
[INFO] [stderr] 111 |         for kvarg in opt.values_of("kv").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.values_of("kv").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/main.rs:144:73
[INFO] [stderr]     |
[INFO] [stderr] 144 |                         let suggestion = FieldCursor::did_you_mean(key, &vec!["all-time", "analytics", "created", "day", "id", "kind", "long-url", "long-url-clicks", "month", "short-url-clicks", "status", "two-hours", "week"]);
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["all-time", "analytics", "created", "day", "id", "kind", "long-url", "long-url-clicks", "month", "short-url-clicks", "status", "two-hours", "week"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:155:21
[INFO] [stderr]     |
[INFO] [stderr] 155 |         for parg in opt.values_of("v").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.values_of("v").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:170:85
[INFO] [stderr]     |
[INFO] [stderr] 170 |                                                                            v.extend(self.gp.iter().map(|v|*v));
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.gp.iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:180:21
[INFO] [stderr]     |
[INFO] [stderr] 180 |             assert!(err.issues.len() == 0);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `err.issues.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:181:26
[INFO] [stderr]     |
[INFO] [stderr] 181 |             for scope in self.opt.values_of("url").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.opt.values_of("url").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:207:21
[INFO] [stderr]     |
[INFO] [stderr] 207 |         for parg in opt.values_of("v").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `opt.values_of("v").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:228:85
[INFO] [stderr]     |
[INFO] [stderr] 228 |                                                                            v.extend(self.gp.iter().map(|v|*v));
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.gp.iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:229:85
[INFO] [stderr]     |
[INFO] [stderr] 229 |                                                                            v.extend(["start-token", "projection"].iter().map(|v|*v));
[INFO] [stderr]     |                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `["start-token", "projection"].iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:239:21
[INFO] [stderr]     |
[INFO] [stderr] 239 |             assert!(err.issues.len() == 0);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `err.issues.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:240:26
[INFO] [stderr]     |
[INFO] [stderr] 240 |             for scope in self.opt.values_of("url").map(|i|i.collect()).unwrap_or(Vec::new()).iter() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.opt.values_of("url").map(|i|i.collect()).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:292:16
[INFO] [stderr]     |
[INFO] [stderr] 292 |             if err.issues.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!err.issues.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:463:20
[INFO] [stderr]     |
[INFO] [stderr] 463 | /                    if let &Some(desc) = desc {
[INFO] [stderr] 464 | |                        scmd = scmd.about(desc);
[INFO] [stderr] 465 | |                    }
[INFO] [stderr]     | |____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 463 |                    if let Some(desc) = *desc {
[INFO] [stderr]     |                           ^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:477:24
[INFO] [stderr]     |
[INFO] [stderr] 477 | /                        if let &Some(short_flag) = flag {
[INFO] [stderr] 478 | |                            arg = arg.short(short_flag);
[INFO] [stderr] 479 | |                        }
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 477 |                        if let Some(short_flag) = *flag {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:480:24
[INFO] [stderr]     |
[INFO] [stderr] 480 | /                        if let &Some(desc) = desc {
[INFO] [stderr] 481 | |                            arg = arg.help(desc);
[INFO] [stderr] 482 | |                        }
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 480 |                        if let Some(desc) = *desc {
[INFO] [stderr]     |                               ^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:486:24
[INFO] [stderr]     |
[INFO] [stderr] 486 | /                        if let &Some(required) = required {
[INFO] [stderr] 487 | |                            arg = arg.required(required);
[INFO] [stderr] 488 | |                        }
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 486 |                        if let Some(required) = *required {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^   ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:489:24
[INFO] [stderr]     |
[INFO] [stderr] 489 | /                        if let &Some(multi) = multi {
[INFO] [stderr] 490 | |                            arg = arg.multiple(multi);
[INFO] [stderr] 491 | |                        }
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 489 |                        if let Some(multi) = *multi {
[INFO] [stderr]     |                               ^^^^^^^^^^^   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 14.05s
[INFO] running `"docker" "inspect" "cb20c586868966cda6f8be90737f1a5f91aa6f46962a07c085f4cf78c7d3f154"`
[INFO] running `"docker" "rm" "-f" "cb20c586868966cda6f8be90737f1a5f91aa6f46962a07c085f4cf78c7d3f154"`
[INFO] [stdout] cb20c586868966cda6f8be90737f1a5f91aa6f46962a07c085f4cf78c7d3f154