[INFO] crate google-signin 0.3.0 is already in cache [INFO] extracting crate google-signin 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/google-signin/0.3.0 [INFO] extracting crate google-signin 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/google-signin/0.3.0 [INFO] validating manifest of google-signin-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of google-signin-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing google-signin-0.3.0 [INFO] finished frobbing google-signin-0.3.0 [INFO] frobbed toml for google-signin-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/google-signin/0.3.0/Cargo.toml [INFO] started frobbing google-signin-0.3.0 [INFO] finished frobbing google-signin-0.3.0 [INFO] frobbed toml for google-signin-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/google-signin/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting google-signin-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/google-signin/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05c2b0ce7f3df4b0b4517567ca82d00aa5064465dfa30646df0a9dcea6c408e4 [INFO] running `"docker" "start" "-a" "05c2b0ce7f3df4b0b4517567ca82d00aa5064465dfa30646df0a9dcea6c408e4"` [INFO] [stderr] Checking google-signin v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::Client` [INFO] [stderr] --> src/client.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Client { [INFO] [stderr] 22 | | use hyper_rustls::TlsClient; [INFO] [stderr] 23 | | [INFO] [stderr] 24 | | let tls = TlsClient::new(); [INFO] [stderr] ... | [INFO] [stderr] 27 | | Client { client, audiences: vec![], hosted_domains: vec![] } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | serde_json::from_str(&body).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/token.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | if client.audiences.len() > 0 && !client.audiences.contains(&self.aud) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!client.audiences.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/token.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | if client.hosted_domains.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!client.hosted_domains.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::Client` [INFO] [stderr] --> src/client.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Client { [INFO] [stderr] 22 | | use hyper_rustls::TlsClient; [INFO] [stderr] 23 | | [INFO] [stderr] 24 | | let tls = TlsClient::new(); [INFO] [stderr] ... | [INFO] [stderr] 27 | | Client { client, audiences: vec![], hosted_domains: vec![] } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | serde_json::from_str(&body).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/token.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | if client.audiences.len() > 0 && !client.audiences.contains(&self.aud) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!client.audiences.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/token.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | if client.hosted_domains.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!client.hosted_domains.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.13s [INFO] running `"docker" "inspect" "05c2b0ce7f3df4b0b4517567ca82d00aa5064465dfa30646df0a9dcea6c408e4"` [INFO] running `"docker" "rm" "-f" "05c2b0ce7f3df4b0b4517567ca82d00aa5064465dfa30646df0a9dcea6c408e4"` [INFO] [stdout] 05c2b0ce7f3df4b0b4517567ca82d00aa5064465dfa30646df0a9dcea6c408e4