[INFO] crate gong 1.3.1 is already in cache
[INFO] extracting crate gong 1.3.1 into work/ex/clippy-test-run/sources/stable/reg/gong/1.3.1
[INFO] extracting crate gong 1.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gong/1.3.1
[INFO] validating manifest of gong-1.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gong-1.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gong-1.3.1
[INFO] finished frobbing gong-1.3.1
[INFO] frobbed toml for gong-1.3.1 written to work/ex/clippy-test-run/sources/stable/reg/gong/1.3.1/Cargo.toml
[INFO] started frobbing gong-1.3.1
[INFO] finished frobbing gong-1.3.1
[INFO] frobbed toml for gong-1.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gong/1.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gong-1.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gong/1.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] de3d7992c4a5f8dc30e96d8967eaaf35a51d5df9a06ed55010c127041b8d4ed1
[INFO] running `"docker" "start" "-a" "de3d7992c4a5f8dc30e96d8967eaaf35a51d5df9a06ed55010c127041b8d4ed1"`
[INFO] [stderr]     Checking gong v1.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/engine.rs:59:24
[INFO] [stderr]    |
[INFO] [stderr] 59 |           let arg_type = match early_terminator_encountered {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 60 | |             true => ArgTypeBasic::NonOption,
[INFO] [stderr] 61 | |             false => get_basic_arg_type_fn(arg_ref),
[INFO] [stderr] 62 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if early_terminator_encountered { ArgTypeBasic::NonOption } else { get_basic_arg_type_fn(arg_ref) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/engine.rs:227:31
[INFO] [stderr]     |
[INFO] [stderr] 227 |     arg.len() > prefix_len && &prefix.as_bytes()[..] == &arg.as_bytes()[..prefix_len]
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 227 |     arg.len() > prefix_len && prefix.as_bytes()[..] == arg.as_bytes()[..prefix_len]
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/engine.rs:231:1
[INFO] [stderr]     |
[INFO] [stderr] 231 | / fn get_basic_arg_type_standard<'a>(arg: &'a str) -> ArgTypeBasic<'a> {
[INFO] [stderr] 232 | |     if arg == EARLY_TERMINATOR {
[INFO] [stderr] 233 | |         ArgTypeBasic::EarlyTerminator
[INFO] [stderr] 234 | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 243 | |     }
[INFO] [stderr] 244 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/engine.rs:247:1
[INFO] [stderr]     |
[INFO] [stderr] 247 | / fn get_basic_arg_type_alternate<'a>(arg: &'a str) -> ArgTypeBasic<'a> {
[INFO] [stderr] 248 | |     if arg == EARLY_TERMINATOR {
[INFO] [stderr] 249 | |         ArgTypeBasic::EarlyTerminator
[INFO] [stderr] 250 | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 256 | |     }
[INFO] [stderr] 257 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/options.rs:238:19
[INFO] [stderr]     |
[INFO] [stderr] 238 |             long: self.long.iter().cloned().collect(),
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/options.rs:239:20
[INFO] [stderr]     |
[INFO] [stderr] 239 |             short: self.short.iter().cloned().collect(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/options.rs:292:23
[INFO] [stderr]     |
[INFO] [stderr] 292 |         debug_assert!(name.len() >= 1, "Long option name cannot be an empty string!");
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/options.rs:319:16
[INFO] [stderr]     |
[INFO] [stderr] 319 |             if candidate.name.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidate.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/options.rs:352:17
[INFO] [stderr]     |
[INFO] [stderr] 352 | /                 match checked.contains(&ch) {
[INFO] [stderr] 353 | |                     true => { duplicates.push(OptionFlaw::ShortDup(ch)); },
[INFO] [stderr] 354 | |                     false =>  { checked.push(ch); },
[INFO] [stderr] 355 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if checked.contains(&ch) { duplicates.push(OptionFlaw::ShortDup(ch)); } else { checked.push(ch); }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/options.rs:371:24
[INFO] [stderr]     |
[INFO] [stderr] 371 |             let name = long.name.clone();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 371 |             let name = &(*long.name).clone();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 371 |             let name = &str::clone(long.name);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/options.rs:373:17
[INFO] [stderr]     |
[INFO] [stderr] 373 | /                 match checked.contains(&name) {
[INFO] [stderr] 374 | |                     true => { duplicates.push(OptionFlaw::LongDup(name)); },
[INFO] [stderr] 375 | |                     false =>  { checked.push(name); },
[INFO] [stderr] 376 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if checked.contains(&name) { duplicates.push(OptionFlaw::LongDup(name)); } else { checked.push(name); }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `gong`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/engine.rs:59:24
[INFO] [stderr]    |
[INFO] [stderr] 59 |           let arg_type = match early_terminator_encountered {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 60 | |             true => ArgTypeBasic::NonOption,
[INFO] [stderr] 61 | |             false => get_basic_arg_type_fn(arg_ref),
[INFO] [stderr] 62 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if early_terminator_encountered { ArgTypeBasic::NonOption } else { get_basic_arg_type_fn(arg_ref) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/engine.rs:227:31
[INFO] [stderr]     |
[INFO] [stderr] 227 |     arg.len() > prefix_len && &prefix.as_bytes()[..] == &arg.as_bytes()[..prefix_len]
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 227 |     arg.len() > prefix_len && prefix.as_bytes()[..] == arg.as_bytes()[..prefix_len]
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/engine.rs:231:1
[INFO] [stderr]     |
[INFO] [stderr] 231 | / fn get_basic_arg_type_standard<'a>(arg: &'a str) -> ArgTypeBasic<'a> {
[INFO] [stderr] 232 | |     if arg == EARLY_TERMINATOR {
[INFO] [stderr] 233 | |         ArgTypeBasic::EarlyTerminator
[INFO] [stderr] 234 | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 243 | |     }
[INFO] [stderr] 244 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/engine.rs:247:1
[INFO] [stderr]     |
[INFO] [stderr] 247 | / fn get_basic_arg_type_alternate<'a>(arg: &'a str) -> ArgTypeBasic<'a> {
[INFO] [stderr] 248 | |     if arg == EARLY_TERMINATOR {
[INFO] [stderr] 249 | |         ArgTypeBasic::EarlyTerminator
[INFO] [stderr] 250 | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 256 | |     }
[INFO] [stderr] 257 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/options.rs:238:19
[INFO] [stderr]     |
[INFO] [stderr] 238 |             long: self.long.iter().cloned().collect(),
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/options.rs:239:20
[INFO] [stderr]     |
[INFO] [stderr] 239 |             short: self.short.iter().cloned().collect(),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/options.rs:292:23
[INFO] [stderr]     |
[INFO] [stderr] 292 |         debug_assert!(name.len() >= 1, "Long option name cannot be an empty string!");
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/options.rs:319:16
[INFO] [stderr]     |
[INFO] [stderr] 319 |             if candidate.name.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidate.name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/options.rs:352:17
[INFO] [stderr]     |
[INFO] [stderr] 352 | /                 match checked.contains(&ch) {
[INFO] [stderr] 353 | |                     true => { duplicates.push(OptionFlaw::ShortDup(ch)); },
[INFO] [stderr] 354 | |                     false =>  { checked.push(ch); },
[INFO] [stderr] 355 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if checked.contains(&ch) { duplicates.push(OptionFlaw::ShortDup(ch)); } else { checked.push(ch); }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/options.rs:371:24
[INFO] [stderr]     |
[INFO] [stderr] 371 |             let name = long.name.clone();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 371 |             let name = &(*long.name).clone();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 371 |             let name = &str::clone(long.name);
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/options.rs:373:17
[INFO] [stderr]     |
[INFO] [stderr] 373 | /                 match checked.contains(&name) {
[INFO] [stderr] 374 | |                     true => { duplicates.push(OptionFlaw::LongDup(name)); },
[INFO] [stderr] 375 | |                     false =>  { checked.push(name); },
[INFO] [stderr] 376 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if checked.contains(&name) { duplicates.push(OptionFlaw::LongDup(name)); } else { checked.push(name); }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `gong`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "de3d7992c4a5f8dc30e96d8967eaaf35a51d5df9a06ed55010c127041b8d4ed1"`
[INFO] running `"docker" "rm" "-f" "de3d7992c4a5f8dc30e96d8967eaaf35a51d5df9a06ed55010c127041b8d4ed1"`
[INFO] [stdout] de3d7992c4a5f8dc30e96d8967eaaf35a51d5df9a06ed55010c127041b8d4ed1