[INFO] crate goertzel-filter 0.2.0 is already in cache [INFO] extracting crate goertzel-filter 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/goertzel-filter/0.2.0 [INFO] extracting crate goertzel-filter 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/goertzel-filter/0.2.0 [INFO] validating manifest of goertzel-filter-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of goertzel-filter-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing goertzel-filter-0.2.0 [INFO] finished frobbing goertzel-filter-0.2.0 [INFO] frobbed toml for goertzel-filter-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/goertzel-filter/0.2.0/Cargo.toml [INFO] started frobbing goertzel-filter-0.2.0 [INFO] finished frobbing goertzel-filter-0.2.0 [INFO] frobbed toml for goertzel-filter-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/goertzel-filter/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting goertzel-filter-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/goertzel-filter/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 337436328fa6a45642c02bcd246960e99291860418d7fafc167bf007b6f0cfa6 [INFO] running `"docker" "start" "-a" "337436328fa6a45642c02bcd246960e99291860418d7fafc167bf007b6f0cfa6"` [INFO] [stderr] Checking goertzel-filter v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:7:31 [INFO] [stderr] | [INFO] [stderr] 7 | fn intermediate_filter(input: &Vec, angular_freq: &f64) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:7:56 [INFO] [stderr] | [INFO] [stderr] 7 | fn intermediate_filter(input: &Vec, angular_freq: &f64) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn filter_naive(input: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | let approx_bin_num = angular_freq * &signal_len / 2.0 / PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `signal_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | let bin_freq = bin_num as f64 / &signal_len * 2.0 * PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `signal_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:60:6 [INFO] [stderr] | [INFO] [stderr] 60 | if approx_bin_num != bin_num as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(approx_bin_num - bin_num as f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:60:6 [INFO] [stderr] | [INFO] [stderr] 60 | if approx_bin_num != bin_num as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:7:31 [INFO] [stderr] | [INFO] [stderr] 7 | fn intermediate_filter(input: &Vec, angular_freq: &f64) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn dft(input: &Vec, linear_freq: f64) -> Complex { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:7:56 [INFO] [stderr] | [INFO] [stderr] 7 | fn intermediate_filter(input: &Vec, angular_freq: &f64) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn dft_power(input: &Vec, linear_freq: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `goertzel-filter`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn filter_naive(input: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | let approx_bin_num = angular_freq * &signal_len / 2.0 / PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `signal_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | let bin_freq = bin_num as f64 / &signal_len * 2.0 * PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `signal_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:60:6 [INFO] [stderr] | [INFO] [stderr] 60 | if approx_bin_num != bin_num as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(approx_bin_num - bin_num as f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:60:6 [INFO] [stderr] | [INFO] [stderr] 60 | if approx_bin_num != bin_num as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn dft(input: &Vec, linear_freq: f64) -> Complex { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn dft_power(input: &Vec, linear_freq: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `goertzel-filter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "337436328fa6a45642c02bcd246960e99291860418d7fafc167bf007b6f0cfa6"` [INFO] running `"docker" "rm" "-f" "337436328fa6a45642c02bcd246960e99291860418d7fafc167bf007b6f0cfa6"` [INFO] [stdout] 337436328fa6a45642c02bcd246960e99291860418d7fafc167bf007b6f0cfa6