[INFO] crate goblin 0.0.19 is already in cache [INFO] extracting crate goblin 0.0.19 into work/ex/clippy-test-run/sources/stable/reg/goblin/0.0.19 [INFO] extracting crate goblin 0.0.19 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/goblin/0.0.19 [INFO] validating manifest of goblin-0.0.19 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of goblin-0.0.19 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing goblin-0.0.19 [INFO] finished frobbing goblin-0.0.19 [INFO] frobbed toml for goblin-0.0.19 written to work/ex/clippy-test-run/sources/stable/reg/goblin/0.0.19/Cargo.toml [INFO] started frobbing goblin-0.0.19 [INFO] finished frobbing goblin-0.0.19 [INFO] frobbed toml for goblin-0.0.19 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/goblin/0.0.19/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting goblin-0.0.19 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/goblin/0.0.19:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff96d7f306a850a85fbc393c470a979b232a9e80641260cfae03a6b64083a1b4 [INFO] running `"docker" "start" "-a" "ff96d7f306a850a85fbc393c470a979b232a9e80641260cfae03a6b64083a1b4"` [INFO] [stderr] Checking goblin v0.0.19 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/strtab.rs:30:56 [INFO] [stderr] | [INFO] [stderr] 30 | Strtab { delim: ctx::StrCtx::Delimiter(delim), bytes: bytes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:19 [INFO] [stderr] | [INFO] [stderr] 185 | Ctx { container: container, le: le } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:41 [INFO] [stderr] | [INFO] [stderr] 185 | Ctx { container: container, le: le } [INFO] [stderr] | ^^^^^^ help: replace it with: `le` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:19 [INFO] [stderr] | [INFO] [stderr] 199 | Ctx { container: container, le: scroll::Endian::default() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:205:41 [INFO] [stderr] | [INFO] [stderr] 205 | Ctx { container: CONTAINER, le: le } [INFO] [stderr] | ^^^^^^ help: replace it with: `le` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mach/fat.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | write!(f, "0x{:x} nfat_arch: {}\n", self.magic, self.nfat_arch) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/fat.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | magic: magic, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `magic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/fat.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | nfat_arch: nfat_arch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nfat_arch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/load_command.rs:529:13 [INFO] [stderr] | [INFO] [stderr] 529 | flavor: flavor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flavor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/load_command.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/load_command.rs:531:13 [INFO] [stderr] | [INFO] [stderr] 531 | thread_state: thread_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | nsyms: nsyms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nsyms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | strtab: strtab, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strtab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | nsyms: nsyms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nsyms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | strtab: strtab, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strtab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:384:121 [INFO] [stderr] | [INFO] [stderr] 384 | Ok(bytes.pread_with(symtab.symoff as usize, SymbolsCtx { nsyms: symtab.nsyms as usize, strtab: strtab as usize, ctx: ctx })?) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | flags: flags [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | lib: lib, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | lib_symbol_name: lib_symbol_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_symbol_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | flags: flags [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:114:25 [INFO] [stderr] | [INFO] [stderr] 114 | stub_offset: stub_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stub_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | resolver_offset: resolver_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolver_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | flags: flags [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:159:18 [INFO] [stderr] | [INFO] [stderr] 159 | Export { name: name, info: info, size: 0, offset: offset } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:159:30 [INFO] [stderr] | [INFO] [stderr] 159 | Export { name: name, info: info, size: 0, offset: offset } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:159:51 [INFO] [stderr] | [INFO] [stderr] 159 | Export { name: name, info: info, size: 0, offset: offset } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | lazy_location: lazy_location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lazy_location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:408:13 [INFO] [stderr] | [INFO] [stderr] 408 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:460:13 [INFO] [stderr] | [INFO] [stderr] 460 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:462:13 [INFO] [stderr] | [INFO] [stderr] 462 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | libs: libs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `libs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | export_trie: export_trie, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_trie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | bind_interpreter: bind_interpreter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_interpreter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | old_style_entry: old_style_entry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `old_style_entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | is_64: is_64, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `is_64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | little_endian: little_endian, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `little_endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | Ok (DosHeader { signature: signature, pe_pointer: pe_pointer }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:25:47 [INFO] [stderr] | [INFO] [stderr] 25 | Ok (DosHeader { signature: signature, pe_pointer: pe_pointer }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pe_pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | Ok( Header { dos_header: dos_header, coff_header: coff_header, optional_header: optional_header }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dos_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:91:46 [INFO] [stderr] | [INFO] [stderr] 91 | Ok( Header { dos_header: dos_header, coff_header: coff_header, optional_header: optional_header }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coff_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:91:72 [INFO] [stderr] | [INFO] [stderr] 91 | Ok( Header { dos_header: dos_header, coff_header: coff_header, optional_header: optional_header }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `optional_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/optional_header.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | standard_fields: standard_fields, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standard_fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/optional_header.rs:285:13 [INFO] [stderr] | [INFO] [stderr] 285 | windows_fields: windows_fields, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `windows_fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/optional_header.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | data_directories: data_directories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_directories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/data_directories.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | Ok (DataDirectories { data_directories: data_directories }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_directories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | export_directory_table: export_directory_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_directory_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | export_name_pointer_table: export_name_pointer_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_name_pointer_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | export_ordinal_table: export_ordinal_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_ordinal_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | export_address_table: export_address_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_address_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:180:60 [INFO] [stderr] | [INFO] [stderr] 180 | return Ok((Reexport::DLLName { export: export, lib: dll }, 0)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `export` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | Ok(HintNameTableEntry { hint: hint, name: name }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | Ok(HintNameTableEntry { hint: hint, name: name }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | import_directory_entry: import_directory_entry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_directory_entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | import_lookup_table: import_lookup_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_lookup_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | import_address_table: import_address_table [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_address_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | Ok(ImportData { import_data: import_data}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:241:29 [INFO] [stderr] | [INFO] [stderr] 241 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:242:29 [INFO] [stderr] | [INFO] [stderr] 242 | ordinal: ordinal, dll: dll, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ordinal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:242:47 [INFO] [stderr] | [INFO] [stderr] 242 | ordinal: ordinal, dll: dll, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:243:49 [INFO] [stderr] | [INFO] [stderr] 243 | size: T::size_of(), offset: offset, rva: rva as usize [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | image_debug_directory: image_debug_directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_debug_directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | codeview_pdb70_debug_info: codeview_pdb70_debug_info [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `codeview_pdb70_debug_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | codeview_signature: codeview_signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `codeview_signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | age: age, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `age` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | sections: sections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | is_lib: is_lib, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `is_lib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | is_64: is_64, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `is_64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | image_base: image_base, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | export_data: export_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | import_data: import_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | exports: exports, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `exports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | imports: imports, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | libraries: libraries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `libraries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | debug_data: debug_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `debug_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:104:35 [INFO] [stderr] | [INFO] [stderr] 104 | let mut header = Header { name: name, size: archive_header.size()? }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | bsd_name: bsd_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bsd_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | strtab: strtab [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strtab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:412:13 [INFO] [stderr] | [INFO] [stderr] 412 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | member_array: member_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `member_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | sysv_name_index: sysv_name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sysv_name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | members: members, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | symbol_index: symbol_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `symbol_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/strtab.rs:30:56 [INFO] [stderr] | [INFO] [stderr] 30 | Strtab { delim: ctx::StrCtx::Delimiter(delim), bytes: bytes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:19 [INFO] [stderr] | [INFO] [stderr] 185 | Ctx { container: container, le: le } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:41 [INFO] [stderr] | [INFO] [stderr] 185 | Ctx { container: container, le: le } [INFO] [stderr] | ^^^^^^ help: replace it with: `le` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:19 [INFO] [stderr] | [INFO] [stderr] 199 | Ctx { container: container, le: scroll::Endian::default() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `container` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:205:41 [INFO] [stderr] | [INFO] [stderr] 205 | Ctx { container: CONTAINER, le: le } [INFO] [stderr] | ^^^^^^ help: replace it with: `le` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mach/fat.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | write!(f, "0x{:x} nfat_arch: {}\n", self.magic, self.nfat_arch) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/fat.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | magic: magic, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `magic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/fat.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | nfat_arch: nfat_arch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nfat_arch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/load_command.rs:529:13 [INFO] [stderr] | [INFO] [stderr] 529 | flavor: flavor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flavor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/load_command.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/load_command.rs:531:13 [INFO] [stderr] | [INFO] [stderr] 531 | thread_state: thread_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:308:13 [INFO] [stderr] | [INFO] [stderr] 308 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | nsyms: nsyms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nsyms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | strtab: strtab, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strtab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:375:13 [INFO] [stderr] | [INFO] [stderr] 375 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | nsyms: nsyms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nsyms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | strtab: strtab, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strtab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/symbols.rs:384:121 [INFO] [stderr] | [INFO] [stderr] 384 | Ok(bytes.pread_with(symtab.symoff as usize, SymbolsCtx { nsyms: symtab.nsyms as usize, strtab: strtab as usize, ctx: ctx })?) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | flags: flags [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | lib: lib, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | lib_symbol_name: lib_symbol_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_symbol_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | flags: flags [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:114:25 [INFO] [stderr] | [INFO] [stderr] 114 | stub_offset: stub_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stub_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | resolver_offset: resolver_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolver_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | flags: flags [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:159:18 [INFO] [stderr] | [INFO] [stderr] 159 | Export { name: name, info: info, size: 0, offset: offset } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:159:30 [INFO] [stderr] | [INFO] [stderr] 159 | Export { name: name, info: info, size: 0, offset: offset } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/exports.rs:159:51 [INFO] [stderr] | [INFO] [stderr] 159 | Export { name: name, info: info, size: 0, offset: offset } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | location: location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/imports.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | lazy_location: lazy_location, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lazy_location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:408:13 [INFO] [stderr] | [INFO] [stderr] 408 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:460:13 [INFO] [stderr] | [INFO] [stderr] 460 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:462:13 [INFO] [stderr] | [INFO] [stderr] 462 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/segment.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | libs: libs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `libs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | export_trie: export_trie, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_trie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | bind_interpreter: bind_interpreter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_interpreter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | old_style_entry: old_style_entry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `old_style_entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | ctx: ctx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | is_64: is_64, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `is_64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mach/mod.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | little_endian: little_endian, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `little_endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | Ok (DosHeader { signature: signature, pe_pointer: pe_pointer }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:25:47 [INFO] [stderr] | [INFO] [stderr] 25 | Ok (DosHeader { signature: signature, pe_pointer: pe_pointer }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pe_pointer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | Ok( Header { dos_header: dos_header, coff_header: coff_header, optional_header: optional_header }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dos_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:91:46 [INFO] [stderr] | [INFO] [stderr] 91 | Ok( Header { dos_header: dos_header, coff_header: coff_header, optional_header: optional_header }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coff_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/header.rs:91:72 [INFO] [stderr] | [INFO] [stderr] 91 | Ok( Header { dos_header: dos_header, coff_header: coff_header, optional_header: optional_header }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `optional_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/optional_header.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | standard_fields: standard_fields, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `standard_fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/optional_header.rs:285:13 [INFO] [stderr] | [INFO] [stderr] 285 | windows_fields: windows_fields, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `windows_fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/optional_header.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | data_directories: data_directories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_directories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/data_directories.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | Ok (DataDirectories { data_directories: data_directories }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_directories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | export_directory_table: export_directory_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_directory_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | export_name_pointer_table: export_name_pointer_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_name_pointer_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | export_ordinal_table: export_ordinal_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_ordinal_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | export_address_table: export_address_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_address_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/export.rs:180:60 [INFO] [stderr] | [INFO] [stderr] 180 | return Ok((Reexport::DLLName { export: export, lib: dll }, 0)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `export` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | Ok(HintNameTableEntry { hint: hint, name: name }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | Ok(HintNameTableEntry { hint: hint, name: name }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | import_directory_entry: import_directory_entry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_directory_entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | import_lookup_table: import_lookup_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_lookup_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | import_address_table: import_address_table [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_address_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | Ok(ImportData { import_data: import_data}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:241:29 [INFO] [stderr] | [INFO] [stderr] 241 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:242:29 [INFO] [stderr] | [INFO] [stderr] 242 | ordinal: ordinal, dll: dll, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `ordinal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:242:47 [INFO] [stderr] | [INFO] [stderr] 242 | ordinal: ordinal, dll: dll, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/import.rs:243:49 [INFO] [stderr] | [INFO] [stderr] 243 | size: T::size_of(), offset: offset, rva: rva as usize [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | image_debug_directory: image_debug_directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_debug_directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | codeview_pdb70_debug_info: codeview_pdb70_debug_info [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `codeview_pdb70_debug_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | codeview_signature: codeview_signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `codeview_signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | age: age, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `age` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/debug.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | sections: sections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | is_lib: is_lib, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `is_lib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | is_64: is_64, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `is_64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | image_base: image_base, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | export_data: export_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `export_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | import_data: import_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `import_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | exports: exports, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `exports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | imports: imports, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | libraries: libraries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `libraries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pe/mod.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | debug_data: debug_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `debug_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:104:35 [INFO] [stderr] | [INFO] [stderr] 104 | let mut header = Header { name: name, size: archive_header.size()? }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | bsd_name: bsd_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bsd_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | strtab: strtab [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strtab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:412:13 [INFO] [stderr] | [INFO] [stderr] 412 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | member_array: member_array, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `member_array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | sysv_name_index: sysv_name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sysv_name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | members: members, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive/mod.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | symbol_index: symbol_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `symbol_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/elf/header.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | pub const ELFMAG: &'static [u8; 4] = b"\x7FELF"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/elf/header.rs:327:68 [INFO] [stderr] | [INFO] [stderr] 327 | fn into_ctx(self, bytes: &mut [u8], ctx: ::container::Ctx) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | pub const PT_LOOS: u32 = 0x60000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | pub const PT_GNU_EH_FRAME: u32 = 0x6474e550; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e550` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | pub const PT_GNU_STACK: u32 = 0x6474e551; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e551` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | pub const PT_GNU_RELRO: u32 = 0x6474e552; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e552` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub const PT_LOSUNW: u32 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | pub const PT_SUNWBSS: u32 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | pub const PT_SUNWSTACK: u32 = 0x6ffffffb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | pub const PT_HISUNW: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | pub const PT_HIOS: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | pub const PT_LOPROC: u32 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:40:31 [INFO] [stderr] | [INFO] [stderr] 40 | pub const PT_ARM_EXIDX: u32 = 0x70000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | pub const PT_HIPROC: u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | pub const SHT_LOOS: u32 = 0x60000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:121:37 [INFO] [stderr] | [INFO] [stderr] 121 | pub const SHT_GNU_ATTRIBUTES: u32 = 0x6ffffff5; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:123:31 [INFO] [stderr] | [INFO] [stderr] 123 | pub const SHT_GNU_HASH: u32 = 0x6ffffff6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:125:34 [INFO] [stderr] | [INFO] [stderr] 125 | pub const SHT_GNU_LIBLIST: u32 = 0x6ffffff7; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | pub const SHT_CHECKSUM: u32 = 0x6ffffff8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | pub const SHT_LOSUNW: u32 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:130:32 [INFO] [stderr] | [INFO] [stderr] 130 | pub const SHT_SUNW_MOVE: u32 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:131:34 [INFO] [stderr] | [INFO] [stderr] 131 | pub const SHT_SUNW_COMDAT: u32 = 0x6ffffffb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:132:35 [INFO] [stderr] | [INFO] [stderr] 132 | pub const SHT_SUNW_SYMINFO: u32 = 0x6ffffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:134:33 [INFO] [stderr] | [INFO] [stderr] 134 | pub const SHT_GNU_VERDEF: u32 = 0x6ffffffd; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:136:34 [INFO] [stderr] | [INFO] [stderr] 136 | pub const SHT_GNU_VERNEED: u32 = 0x6ffffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | pub const SHT_GNU_VERSYM: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | pub const SHT_HISUNW: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:142:27 [INFO] [stderr] | [INFO] [stderr] 142 | pub const SHT_HIOS: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:144:29 [INFO] [stderr] | [INFO] [stderr] 144 | pub const SHT_LOPROC: u32 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:146:29 [INFO] [stderr] | [INFO] [stderr] 146 | pub const SHT_HIPROC: u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:148:29 [INFO] [stderr] | [INFO] [stderr] 148 | pub const SHT_LOUSER: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:150:29 [INFO] [stderr] | [INFO] [stderr] 150 | pub const SHT_HIUSER: u32 = 0x8fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:176:29 [INFO] [stderr] | [INFO] [stderr] 176 | pub const SHF_MASKOS: u32 = 0x0ff00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0ff0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:178:31 [INFO] [stderr] | [INFO] [stderr] 178 | pub const SHF_MASKPROC: u32 = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/compression_header.rs:22:35 [INFO] [stderr] | [INFO] [stderr] 22 | pub const ELFCOMPRESS_LOOS: u32 = 0x60000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/compression_header.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | pub const ELFCOMPRESS_HIOS: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/compression_header.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | pub const ELFCOMPRESS_LOPROC: u32 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/compression_header.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | pub const ELFCOMPRESS_HIPROC: u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | pub const DT_LOOS: u64 = 0x6000000d; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_000d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | pub const DT_HIOS: u64 = 0x6ffff000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:101:28 [INFO] [stderr] | [INFO] [stderr] 101 | pub const DT_LOPROC: u64 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | pub const DT_HIPROC: u64 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | pub const DT_ADDRRNGLO: u64 = 0x6ffffe00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fe00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:114:30 [INFO] [stderr] | [INFO] [stderr] 114 | pub const DT_GNU_HASH: u64 = 0x6ffffef5; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:116:33 [INFO] [stderr] | [INFO] [stderr] 116 | pub const DT_TLSDESC_PLT: u64 = 0x6ffffef6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:118:33 [INFO] [stderr] | [INFO] [stderr] 118 | pub const DT_TLSDESC_GOT: u64 = 0x6ffffef7; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:120:34 [INFO] [stderr] | [INFO] [stderr] 120 | pub const DT_GNU_CONFLICT: u64 = 0x6ffffef8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:122:33 [INFO] [stderr] | [INFO] [stderr] 122 | pub const DT_GNU_LIBLIST: u64 = 0x6ffffef9; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | pub const DT_CONFIG: u64 = 0x6ffffefa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:126:30 [INFO] [stderr] | [INFO] [stderr] 126 | pub const DT_DEPAUDIT: u64 = 0x6ffffefb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:128:27 [INFO] [stderr] | [INFO] [stderr] 128 | pub const DT_AUDIT: u64 = 0x6ffffefc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | pub const DT_PLTPAD: u64 = 0x6ffffefd; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:132:29 [INFO] [stderr] | [INFO] [stderr] 132 | pub const DT_MOVETAB: u64 = 0x6ffffefe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | pub const DT_SYMINFO: u64 = 0x6ffffeff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_feff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:136:31 [INFO] [stderr] | [INFO] [stderr] 136 | pub const DT_ADDRRNGHI: u64 = 0x6ffffeff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_feff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:142:28 [INFO] [stderr] | [INFO] [stderr] 142 | pub const DT_VERSYM: u64 = 0x6ffffff0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:143:31 [INFO] [stderr] | [INFO] [stderr] 143 | pub const DT_RELACOUNT: u64 = 0x6ffffff9; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | pub const DT_RELCOUNT: u64 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:146:29 [INFO] [stderr] | [INFO] [stderr] 146 | pub const DT_FLAGS_1: u64 = 0x6ffffffb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:148:28 [INFO] [stderr] | [INFO] [stderr] 148 | pub const DT_VERDEF: u64 = 0x6ffffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:150:31 [INFO] [stderr] | [INFO] [stderr] 150 | pub const DT_VERDEFNUM: u64 = 0x6ffffffd; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:152:29 [INFO] [stderr] | [INFO] [stderr] 152 | pub const DT_VERNEED: u64 = 0x6ffffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:154:32 [INFO] [stderr] | [INFO] [stderr] 154 | pub const DT_VERNEEDNUM: u64 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:213:28 [INFO] [stderr] | [INFO] [stderr] 213 | pub const DF_ORIGIN: u64 = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:215:30 [INFO] [stderr] | [INFO] [stderr] 215 | pub const DF_SYMBOLIC: u64 = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:217:29 [INFO] [stderr] | [INFO] [stderr] 217 | pub const DF_TEXTREL: u64 = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:219:30 [INFO] [stderr] | [INFO] [stderr] 219 | pub const DF_BIND_NOW: u64 = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:221:32 [INFO] [stderr] | [INFO] [stderr] 221 | pub const DF_STATIC_TLS: u64 = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:227:27 [INFO] [stderr] | [INFO] [stderr] 227 | pub const DF_1_NOW: u64 = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:229:30 [INFO] [stderr] | [INFO] [stderr] 229 | pub const DF_1_GLOBAL: u64 = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:231:29 [INFO] [stderr] | [INFO] [stderr] 231 | pub const DF_1_GROUP: u64 = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:233:32 [INFO] [stderr] | [INFO] [stderr] 233 | pub const DF_1_NODELETE: u64 = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:235:32 [INFO] [stderr] | [INFO] [stderr] 235 | pub const DF_1_LOADFLTR: u64 = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:237:33 [INFO] [stderr] | [INFO] [stderr] 237 | pub const DF_1_INITFIRST: u64 = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:239:30 [INFO] [stderr] | [INFO] [stderr] 239 | pub const DF_1_NOOPEN: u64 = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:241:30 [INFO] [stderr] | [INFO] [stderr] 241 | pub const DF_1_ORIGIN: u64 = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:243:30 [INFO] [stderr] | [INFO] [stderr] 243 | pub const DF_1_DIRECT: u64 = 0x00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:244:29 [INFO] [stderr] | [INFO] [stderr] 244 | pub const DF_1_TRANS: u64 = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:246:33 [INFO] [stderr] | [INFO] [stderr] 246 | pub const DF_1_INTERPOSE: u64 = 0x00000400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:248:32 [INFO] [stderr] | [INFO] [stderr] 248 | pub const DF_1_NODEFLIB: u64 = 0x00000800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:250:30 [INFO] [stderr] | [INFO] [stderr] 250 | pub const DF_1_NODUMP: u64 = 0x00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:252:31 [INFO] [stderr] | [INFO] [stderr] 252 | pub const DF_1_CONFALT: u64 = 0x00002000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:254:33 [INFO] [stderr] | [INFO] [stderr] 254 | pub const DF_1_ENDFILTEE: u64 = 0x00004000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:256:34 [INFO] [stderr] | [INFO] [stderr] 256 | pub const DF_1_DISPRELDNE: u64 = 0x00008000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:258:34 [INFO] [stderr] | [INFO] [stderr] 258 | pub const DF_1_DISPRELPND: u64 = 0x00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:260:32 [INFO] [stderr] | [INFO] [stderr] 260 | pub const DF_1_NODIRECT: u64 = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:261:33 [INFO] [stderr] | [INFO] [stderr] 261 | pub const DF_1_IGNMULDEF: u64 = 0x00040000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:262:31 [INFO] [stderr] | [INFO] [stderr] 262 | pub const DF_1_NOKSYMS: u64 = 0x00080000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:263:29 [INFO] [stderr] | [INFO] [stderr] 263 | pub const DF_1_NOHDR: u64 = 0x00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:265:30 [INFO] [stderr] | [INFO] [stderr] 265 | pub const DF_1_EDITED: u64 = 0x00200000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:266:31 [INFO] [stderr] | [INFO] [stderr] 266 | pub const DF_1_NORELOC: u64 = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:268:34 [INFO] [stderr] | [INFO] [stderr] 268 | pub const DF_1_SYMINTPOSE: u64 = 0x00800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:270:33 [INFO] [stderr] | [INFO] [stderr] 270 | pub const DF_1_GLOBAUDIT: u64 = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:272:33 [INFO] [stderr] | [INFO] [stderr] 272 | pub const DF_1_SINGLETON: u64 = 0x02000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/reloc.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | (info & 0xffffffff) as u32 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | pub const MH_NO_REEXPORTED_DYLIBS: u32 = 0x100000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | pub const MH_PIE: u32 = 0x200000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | pub const MH_DEAD_STRIPPABLE_DYLIB: u32 = 0x400000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:69:41 [INFO] [stderr] | [INFO] [stderr] 69 | pub const MH_HAS_TLV_DESCRIPTORS: u32 = 0x800000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | pub const MH_NO_HEAP_EXECUTION: u32 = 0x1000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:76:40 [INFO] [stderr] | [INFO] [stderr] 76 | pub const MH_APP_EXTENSION_SAFE: u32 = 0x2000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:112:27 [INFO] [stderr] | [INFO] [stderr] 112 | pub const MH_MAGIC: u32 = 0xfeedface; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfeed_face` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:113:27 [INFO] [stderr] | [INFO] [stderr] 113 | pub const MH_CIGAM: u32 = 0xcefaedfe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcefa_edfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | pub const MH_MAGIC_64: u32 = 0xfeedfacf; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfeed_facf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:116:30 [INFO] [stderr] | [INFO] [stderr] 116 | pub const MH_CIGAM_64: u32 = 0xcffaedfe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcffa_edfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:3:43 [INFO] [stderr] | [INFO] [stderr] 3 | pub const DYLD_MACOSX_VERSION_10_4: u32 = 0x000A0400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:4:43 [INFO] [stderr] | [INFO] [stderr] 4 | pub const DYLD_MACOSX_VERSION_10_5: u32 = 0x000A0500; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:5:43 [INFO] [stderr] | [INFO] [stderr] 5 | pub const DYLD_MACOSX_VERSION_10_6: u32 = 0x000A0600; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:6:43 [INFO] [stderr] | [INFO] [stderr] 6 | pub const DYLD_MACOSX_VERSION_10_7: u32 = 0x000A0700; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0700` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:7:43 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DYLD_MACOSX_VERSION_10_8: u32 = 0x000A0800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:8:43 [INFO] [stderr] | [INFO] [stderr] 8 | pub const DYLD_MACOSX_VERSION_10_9: u32 = 0x000A0900; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:9:44 [INFO] [stderr] | [INFO] [stderr] 9 | pub const DYLD_MACOSX_VERSION_10_10: u32 = 0x000A0A00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0A00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:10:44 [INFO] [stderr] | [INFO] [stderr] 10 | pub const DYLD_MACOSX_VERSION_10_11: u32 = 0x000A0B00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0B00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | pub const DYLD_MACOSX_VERSION_10_12: u32 = 0x000A0C00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0C00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:12:44 [INFO] [stderr] | [INFO] [stderr] 12 | pub const DYLD_MACOSX_VERSION_10_13: u32 = 0x000A0D00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0D00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:14:39 [INFO] [stderr] | [INFO] [stderr] 14 | pub const DYLD_IOS_VERSION_2_0: u32 = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:15:39 [INFO] [stderr] | [INFO] [stderr] 15 | pub const DYLD_IOS_VERSION_2_1: u32 = 0x00020100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:16:39 [INFO] [stderr] | [INFO] [stderr] 16 | pub const DYLD_IOS_VERSION_2_2: u32 = 0x00020200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:17:39 [INFO] [stderr] | [INFO] [stderr] 17 | pub const DYLD_IOS_VERSION_3_0: u32 = 0x00030000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:18:39 [INFO] [stderr] | [INFO] [stderr] 18 | pub const DYLD_IOS_VERSION_3_1: u32 = 0x00030100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:19:39 [INFO] [stderr] | [INFO] [stderr] 19 | pub const DYLD_IOS_VERSION_3_2: u32 = 0x00030200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:20:39 [INFO] [stderr] | [INFO] [stderr] 20 | pub const DYLD_IOS_VERSION_4_0: u32 = 0x00040000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | pub const DYLD_IOS_VERSION_4_1: u32 = 0x00040100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:22:39 [INFO] [stderr] | [INFO] [stderr] 22 | pub const DYLD_IOS_VERSION_4_2: u32 = 0x00040200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:23:39 [INFO] [stderr] | [INFO] [stderr] 23 | pub const DYLD_IOS_VERSION_4_3: u32 = 0x00040300; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0300` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub const DYLD_IOS_VERSION_5_0: u32 = 0x00050000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0005_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | pub const DYLD_IOS_VERSION_5_1: u32 = 0x00050100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0005_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | pub const DYLD_IOS_VERSION_6_0: u32 = 0x00060000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0006_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub const DYLD_IOS_VERSION_6_1: u32 = 0x00060100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0006_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | pub const DYLD_IOS_VERSION_7_0: u32 = 0x00070000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | pub const DYLD_IOS_VERSION_7_1: u32 = 0x00070100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:30:39 [INFO] [stderr] | [INFO] [stderr] 30 | pub const DYLD_IOS_VERSION_8_0: u32 = 0x00080000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | pub const DYLD_IOS_VERSION_9_0: u32 = 0x00090000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0009_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | pub const DYLD_IOS_VERSION_10_0: u32 = 0x000A0000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:33:40 [INFO] [stderr] | [INFO] [stderr] 33 | pub const DYLD_IOS_VERSION_11_0: u32 = 0x000B0000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000B_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | pub const SECTION_TYPE: u32 = 0x000000ff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | pub const SECTION_ATTRIBUTES: u32 = 0xffffff00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:109:41 [INFO] [stderr] | [INFO] [stderr] 109 | pub const SECTION_ATTRIBUTES_USR: u32 = 0xff000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:111:43 [INFO] [stderr] | [INFO] [stderr] 111 | pub const S_ATTR_PURE_INSTRUCTIONS: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:113:32 [INFO] [stderr] | [INFO] [stderr] 113 | pub const S_ATTR_NO_TOC: u32 = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:115:43 [INFO] [stderr] | [INFO] [stderr] 115 | pub const S_ATTR_STRIP_STATIC_SYMS: u32 = 0x20000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:117:39 [INFO] [stderr] | [INFO] [stderr] 117 | pub const S_ATTR_NO_DEAD_STRIP: u32 = 0x10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:119:38 [INFO] [stderr] | [INFO] [stderr] 119 | pub const S_ATTR_LIVE_SUPPORT: u32 = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:121:45 [INFO] [stderr] | [INFO] [stderr] 121 | pub const S_ATTR_SELF_MODIFYING_CODE: u32 = 0x04000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:131:31 [INFO] [stderr] | [INFO] [stderr] 131 | pub const S_ATTR_DEBUG: u32 = 0x02000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:133:41 [INFO] [stderr] | [INFO] [stderr] 133 | pub const SECTION_ATTRIBUTES_SYS: u32 = 0x00ffff00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:135:43 [INFO] [stderr] | [INFO] [stderr] 135 | pub const S_ATTR_SOME_INSTRUCTIONS: u32 = 0x00000400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | pub const S_ATTR_EXT_RELOC: u32 = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | pub const S_ATTR_LOC_RELOC: u32 = 0x00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:153:26 [INFO] [stderr] | [INFO] [stderr] 153 | pub const SEG_PAGEZERO: &'static str = "__PAGEZERO"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:155:22 [INFO] [stderr] | [INFO] [stderr] 155 | pub const SEG_TEXT: &'static str = "__TEXT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | pub const SECT_TEXT: &'static str = "__text"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:159:31 [INFO] [stderr] | [INFO] [stderr] 159 | pub const SECT_FVMLIB_INIT0: &'static str = "__fvmlib_init0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:161:31 [INFO] [stderr] | [INFO] [stderr] 161 | pub const SECT_FVMLIB_INIT1: &'static str = "__fvmlib_init1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | pub const SEG_DATA: &'static str = "__DATA"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:165:23 [INFO] [stderr] | [INFO] [stderr] 165 | pub const SECT_DATA: &'static str = "__data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | pub const SECT_BSS: &'static str = "__bss"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:169:25 [INFO] [stderr] | [INFO] [stderr] 169 | pub const SECT_COMMON: &'static str = "__common"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | pub const SEG_OBJC: &'static str = "__OBJC"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:173:31 [INFO] [stderr] | [INFO] [stderr] 173 | pub const SECT_OBJC_SYMBOLS: &'static str = "__symbol_table"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:175:31 [INFO] [stderr] | [INFO] [stderr] 175 | pub const SECT_OBJC_MODULES: &'static str = "__module_info"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:177:31 [INFO] [stderr] | [INFO] [stderr] 177 | pub const SECT_OBJC_STRINGS: &'static str = "__selector_strs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:179:28 [INFO] [stderr] | [INFO] [stderr] 179 | pub const SECT_OBJC_REFS: &'static str = "__selector_refs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | pub const SEG_ICON: &'static str = "__ICON"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:183:30 [INFO] [stderr] | [INFO] [stderr] 183 | pub const SECT_ICON_HEADER: &'static str = "__header"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:185:28 [INFO] [stderr] | [INFO] [stderr] 185 | pub const SECT_ICON_TIFF: &'static str = "__tiff"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | pub const SEG_LINKEDIT: &'static str = "__LINKEDIT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:189:27 [INFO] [stderr] | [INFO] [stderr] 189 | pub const SEG_UNIXSTACK: &'static str = "__UNIXSTACK"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:191:24 [INFO] [stderr] | [INFO] [stderr] 191 | pub const SEG_IMPORT: &'static str = "__IMPORT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:201:39 [INFO] [stderr] | [INFO] [stderr] 201 | pub const CPU_SUBTYPE_MASK: u32 = 0xff000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:203:40 [INFO] [stderr] | [INFO] [stderr] 203 | pub const CPU_ARCH_MASK: CpuType = 0xff000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:205:41 [INFO] [stderr] | [INFO] [stderr] 205 | pub const CPU_ARCH_ABI64: CpuType = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/fat.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | pub const FAT_MAGIC: u32 = 0xcafebabe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcafe_babe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/fat.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | pub const FAT_CIGAM: u32 = 0xbebafeca; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbeba_feca` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/load_command.rs:1153:30 [INFO] [stderr] | [INFO] [stderr] 1153 | pub const LC_REQ_DYLD: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mach/symbols.rs:340:35 [INFO] [stderr] | [INFO] [stderr] 340 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Err(e.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mach/symbols.rs:343:27 [INFO] [stderr] | [INFO] [stderr] 343 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Err(e.into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/header.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | pub const COFF_MAGIC: u32 = 0x00004550; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4550` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:94:40 [INFO] [stderr] | [INFO] [stderr] 94 | pub const IMAGE_SCN_TYPE_NO_PAD: u32 = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:96:37 [INFO] [stderr] | [INFO] [stderr] 96 | pub const IMAGE_SCN_CNT_CODE: u32 = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:98:49 [INFO] [stderr] | [INFO] [stderr] 98 | pub const IMAGE_SCN_CNT_INITIALIZED_DATA: u32 = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:100:51 [INFO] [stderr] | [INFO] [stderr] 100 | pub const IMAGE_SCN_CNT_UNINITIALIZED_DATA: u32 = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | pub const IMAGE_SCN_LNK_OTHER: u32 = 0x00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | pub const IMAGE_SCN_LNK_INFO: u32 = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:106:39 [INFO] [stderr] | [INFO] [stderr] 106 | pub const IMAGE_SCN_LNK_REMOVE: u32 = 0x00000800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:108:39 [INFO] [stderr] | [INFO] [stderr] 108 | pub const IMAGE_SCN_LNK_COMDAT: u32 = 0x00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:110:34 [INFO] [stderr] | [INFO] [stderr] 110 | pub const IMAGE_SCN_GPREL: u32 = 0x00008000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:111:42 [INFO] [stderr] | [INFO] [stderr] 111 | pub const IMAGE_SCN_MEM_PURGEABLE: u32 = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:112:38 [INFO] [stderr] | [INFO] [stderr] 112 | pub const IMAGE_SCN_MEM_16BIT: u32 = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:113:39 [INFO] [stderr] | [INFO] [stderr] 113 | pub const IMAGE_SCN_MEM_LOCKED: u32 = 0x00040000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | pub const IMAGE_SCN_MEM_PRELOAD: u32 = 0x00080000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:116:41 [INFO] [stderr] | [INFO] [stderr] 116 | pub const IMAGE_SCN_ALIGN_1BYTES: u32 = 0x00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:117:41 [INFO] [stderr] | [INFO] [stderr] 117 | pub const IMAGE_SCN_ALIGN_2BYTES: u32 = 0x00200000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:118:41 [INFO] [stderr] | [INFO] [stderr] 118 | pub const IMAGE_SCN_ALIGN_4BYTES: u32 = 0x00300000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0030_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:119:41 [INFO] [stderr] | [INFO] [stderr] 119 | pub const IMAGE_SCN_ALIGN_8BYTES: u32 = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:120:42 [INFO] [stderr] | [INFO] [stderr] 120 | pub const IMAGE_SCN_ALIGN_16BYTES: u32 = 0x00500000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0050_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:121:42 [INFO] [stderr] | [INFO] [stderr] 121 | pub const IMAGE_SCN_ALIGN_32BYTES: u32 = 0x00600000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0060_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:122:42 [INFO] [stderr] | [INFO] [stderr] 122 | pub const IMAGE_SCN_ALIGN_64BYTES: u32 = 0x00700000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0070_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:123:43 [INFO] [stderr] | [INFO] [stderr] 123 | pub const IMAGE_SCN_ALIGN_128BYTES: u32 = 0x00800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:124:43 [INFO] [stderr] | [INFO] [stderr] 124 | pub const IMAGE_SCN_ALIGN_256BYTES: u32 = 0x00900000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0090_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:125:43 [INFO] [stderr] | [INFO] [stderr] 125 | pub const IMAGE_SCN_ALIGN_512BYTES: u32 = 0x00A00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00A0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:126:44 [INFO] [stderr] | [INFO] [stderr] 126 | pub const IMAGE_SCN_ALIGN_1024BYTES: u32 = 0x00B00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00B0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:127:44 [INFO] [stderr] | [INFO] [stderr] 127 | pub const IMAGE_SCN_ALIGN_2048BYTES: u32 = 0x00C00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00C0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:128:44 [INFO] [stderr] | [INFO] [stderr] 128 | pub const IMAGE_SCN_ALIGN_4096BYTES: u32 = 0x00D00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00D0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:129:44 [INFO] [stderr] | [INFO] [stderr] 129 | pub const IMAGE_SCN_ALIGN_8192BYTES: u32 = 0x00E00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00E0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:130:39 [INFO] [stderr] | [INFO] [stderr] 130 | pub const IMAGE_SCN_ALIGN_MASK: u32 = 0x00F00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00F0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:133:44 [INFO] [stderr] | [INFO] [stderr] 133 | pub const IMAGE_SCN_LNK_NRELOC_OVFL: u32 = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:135:44 [INFO] [stderr] | [INFO] [stderr] 135 | pub const IMAGE_SCN_MEM_DISCARDABLE: u32 = 0x02000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:137:43 [INFO] [stderr] | [INFO] [stderr] 137 | pub const IMAGE_SCN_MEM_NOT_CACHED: u32 = 0x04000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:139:42 [INFO] [stderr] | [INFO] [stderr] 139 | pub const IMAGE_SCN_MEM_NOT_PAGED: u32 = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:141:39 [INFO] [stderr] | [INFO] [stderr] 141 | pub const IMAGE_SCN_MEM_SHARED: u32 = 0x10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:143:40 [INFO] [stderr] | [INFO] [stderr] 143 | pub const IMAGE_SCN_MEM_EXECUTE: u32 = 0x20000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:145:37 [INFO] [stderr] | [INFO] [stderr] 145 | pub const IMAGE_SCN_MEM_READ: u32 = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:147:38 [INFO] [stderr] | [INFO] [stderr] 147 | pub const IMAGE_SCN_MEM_WRITE: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/debug.rs:65:39 [INFO] [stderr] | [INFO] [stderr] 65 | pub const CODEVIEW_PDB70_MAGIC: u32 = 0x53445352; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5344_5352` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/debug.rs:66:39 [INFO] [stderr] | [INFO] [stderr] 66 | pub const CODEVIEW_PDB20_MAGIC: u32 = 0x3031424e; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3031_424e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/debug.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | pub const CODEVIEW_CV50_MAGIC: u32 = 0x3131424e; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3131_424e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/debug.rs:68:38 [INFO] [stderr] | [INFO] [stderr] 68 | pub const CODEVIEW_CV41_MAGIC: u32 = 0x3930424e; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3930_424e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | pub const MAGIC: &'static [u8; SIZEOF_MAGIC] = b"!\x0A"; [INFO] [stderr] | -^^^^^^^------------------- help: consider removing `'static`: `&[u8; SIZEOF_MAGIC]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:189:20 [INFO] [stderr] | [INFO] [stderr] 189 | const INDEX_NAME: &'static str = "/ "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | const NAME_INDEX_NAME: &'static str = "// "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:193:25 [INFO] [stderr] | [INFO] [stderr] 193 | const BSD_SYMDEF_NAME: &'static str = "__.SYMDEF"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:194:32 [INFO] [stderr] | [INFO] [stderr] 194 | const BSD_SYMDEF_SORTED_NAME: &'static str = "__.SYMDEF SORTED"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/archive/mod.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | return Err(Error::Malformed(format!("Could not find {:?} in index", name).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::Malformed(format!("Could not find {:?} in index", name).into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/archive/mod.rs:321:17 [INFO] [stderr] | [INFO] [stderr] 321 | return Err(Error::Malformed(format!("Bad name index {:?} in index", name).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::Malformed(format!("Bad name index {:?} in index", name).into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/elf/header.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | pub const ELFMAG: &'static [u8; 4] = b"\x7FELF"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/elf/header.rs:327:68 [INFO] [stderr] | [INFO] [stderr] 327 | fn into_ctx(self, bytes: &mut [u8], ctx: ::container::Ctx) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | pub const PT_LOOS: u32 = 0x60000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | pub const PT_GNU_EH_FRAME: u32 = 0x6474e550; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e550` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | pub const PT_GNU_STACK: u32 = 0x6474e551; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e551` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | pub const PT_GNU_RELRO: u32 = 0x6474e552; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e552` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub const PT_LOSUNW: u32 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | pub const PT_SUNWBSS: u32 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | pub const PT_SUNWSTACK: u32 = 0x6ffffffb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | pub const PT_HISUNW: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:36:26 [INFO] [stderr] | [INFO] [stderr] 36 | pub const PT_HIOS: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | pub const PT_LOPROC: u32 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:40:31 [INFO] [stderr] | [INFO] [stderr] 40 | pub const PT_ARM_EXIDX: u32 = 0x70000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/program_header.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | pub const PT_HIPROC: u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | pub const SHT_LOOS: u32 = 0x60000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:121:37 [INFO] [stderr] | [INFO] [stderr] 121 | pub const SHT_GNU_ATTRIBUTES: u32 = 0x6ffffff5; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:123:31 [INFO] [stderr] | [INFO] [stderr] 123 | pub const SHT_GNU_HASH: u32 = 0x6ffffff6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:125:34 [INFO] [stderr] | [INFO] [stderr] 125 | pub const SHT_GNU_LIBLIST: u32 = 0x6ffffff7; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | pub const SHT_CHECKSUM: u32 = 0x6ffffff8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | pub const SHT_LOSUNW: u32 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:130:32 [INFO] [stderr] | [INFO] [stderr] 130 | pub const SHT_SUNW_MOVE: u32 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:131:34 [INFO] [stderr] | [INFO] [stderr] 131 | pub const SHT_SUNW_COMDAT: u32 = 0x6ffffffb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:132:35 [INFO] [stderr] | [INFO] [stderr] 132 | pub const SHT_SUNW_SYMINFO: u32 = 0x6ffffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:134:33 [INFO] [stderr] | [INFO] [stderr] 134 | pub const SHT_GNU_VERDEF: u32 = 0x6ffffffd; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:136:34 [INFO] [stderr] | [INFO] [stderr] 136 | pub const SHT_GNU_VERNEED: u32 = 0x6ffffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | pub const SHT_GNU_VERSYM: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | pub const SHT_HISUNW: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:142:27 [INFO] [stderr] | [INFO] [stderr] 142 | pub const SHT_HIOS: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:144:29 [INFO] [stderr] | [INFO] [stderr] 144 | pub const SHT_LOPROC: u32 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:146:29 [INFO] [stderr] | [INFO] [stderr] 146 | pub const SHT_HIPROC: u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:148:29 [INFO] [stderr] | [INFO] [stderr] 148 | pub const SHT_LOUSER: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:150:29 [INFO] [stderr] | [INFO] [stderr] 150 | pub const SHT_HIUSER: u32 = 0x8fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:176:29 [INFO] [stderr] | [INFO] [stderr] 176 | pub const SHF_MASKOS: u32 = 0x0ff00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0ff0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/section_header.rs:178:31 [INFO] [stderr] | [INFO] [stderr] 178 | pub const SHF_MASKPROC: u32 = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/compression_header.rs:22:35 [INFO] [stderr] | [INFO] [stderr] 22 | pub const ELFCOMPRESS_LOOS: u32 = 0x60000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/compression_header.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | pub const ELFCOMPRESS_HIOS: u32 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/compression_header.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | pub const ELFCOMPRESS_LOPROC: u32 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/compression_header.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | pub const ELFCOMPRESS_HIPROC: u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | pub const DT_LOOS: u64 = 0x6000000d; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_000d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | pub const DT_HIOS: u64 = 0x6ffff000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:101:28 [INFO] [stderr] | [INFO] [stderr] 101 | pub const DT_LOPROC: u64 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | pub const DT_HIPROC: u64 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | pub const DT_ADDRRNGLO: u64 = 0x6ffffe00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fe00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:114:30 [INFO] [stderr] | [INFO] [stderr] 114 | pub const DT_GNU_HASH: u64 = 0x6ffffef5; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:116:33 [INFO] [stderr] | [INFO] [stderr] 116 | pub const DT_TLSDESC_PLT: u64 = 0x6ffffef6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:118:33 [INFO] [stderr] | [INFO] [stderr] 118 | pub const DT_TLSDESC_GOT: u64 = 0x6ffffef7; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:120:34 [INFO] [stderr] | [INFO] [stderr] 120 | pub const DT_GNU_CONFLICT: u64 = 0x6ffffef8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:122:33 [INFO] [stderr] | [INFO] [stderr] 122 | pub const DT_GNU_LIBLIST: u64 = 0x6ffffef9; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | pub const DT_CONFIG: u64 = 0x6ffffefa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:126:30 [INFO] [stderr] | [INFO] [stderr] 126 | pub const DT_DEPAUDIT: u64 = 0x6ffffefb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:128:27 [INFO] [stderr] | [INFO] [stderr] 128 | pub const DT_AUDIT: u64 = 0x6ffffefc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | pub const DT_PLTPAD: u64 = 0x6ffffefd; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:132:29 [INFO] [stderr] | [INFO] [stderr] 132 | pub const DT_MOVETAB: u64 = 0x6ffffefe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | pub const DT_SYMINFO: u64 = 0x6ffffeff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_feff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:136:31 [INFO] [stderr] | [INFO] [stderr] 136 | pub const DT_ADDRRNGHI: u64 = 0x6ffffeff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_feff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:142:28 [INFO] [stderr] | [INFO] [stderr] 142 | pub const DT_VERSYM: u64 = 0x6ffffff0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:143:31 [INFO] [stderr] | [INFO] [stderr] 143 | pub const DT_RELACOUNT: u64 = 0x6ffffff9; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | pub const DT_RELCOUNT: u64 = 0x6ffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:146:29 [INFO] [stderr] | [INFO] [stderr] 146 | pub const DT_FLAGS_1: u64 = 0x6ffffffb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:148:28 [INFO] [stderr] | [INFO] [stderr] 148 | pub const DT_VERDEF: u64 = 0x6ffffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:150:31 [INFO] [stderr] | [INFO] [stderr] 150 | pub const DT_VERDEFNUM: u64 = 0x6ffffffd; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:152:29 [INFO] [stderr] | [INFO] [stderr] 152 | pub const DT_VERNEED: u64 = 0x6ffffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:154:32 [INFO] [stderr] | [INFO] [stderr] 154 | pub const DT_VERNEEDNUM: u64 = 0x6fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:213:28 [INFO] [stderr] | [INFO] [stderr] 213 | pub const DF_ORIGIN: u64 = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:215:30 [INFO] [stderr] | [INFO] [stderr] 215 | pub const DF_SYMBOLIC: u64 = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:217:29 [INFO] [stderr] | [INFO] [stderr] 217 | pub const DF_TEXTREL: u64 = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:219:30 [INFO] [stderr] | [INFO] [stderr] 219 | pub const DF_BIND_NOW: u64 = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:221:32 [INFO] [stderr] | [INFO] [stderr] 221 | pub const DF_STATIC_TLS: u64 = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:227:27 [INFO] [stderr] | [INFO] [stderr] 227 | pub const DF_1_NOW: u64 = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:229:30 [INFO] [stderr] | [INFO] [stderr] 229 | pub const DF_1_GLOBAL: u64 = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:231:29 [INFO] [stderr] | [INFO] [stderr] 231 | pub const DF_1_GROUP: u64 = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:233:32 [INFO] [stderr] | [INFO] [stderr] 233 | pub const DF_1_NODELETE: u64 = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:235:32 [INFO] [stderr] | [INFO] [stderr] 235 | pub const DF_1_LOADFLTR: u64 = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:237:33 [INFO] [stderr] | [INFO] [stderr] 237 | pub const DF_1_INITFIRST: u64 = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:239:30 [INFO] [stderr] | [INFO] [stderr] 239 | pub const DF_1_NOOPEN: u64 = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:241:30 [INFO] [stderr] | [INFO] [stderr] 241 | pub const DF_1_ORIGIN: u64 = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:243:30 [INFO] [stderr] | [INFO] [stderr] 243 | pub const DF_1_DIRECT: u64 = 0x00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:244:29 [INFO] [stderr] | [INFO] [stderr] 244 | pub const DF_1_TRANS: u64 = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:246:33 [INFO] [stderr] | [INFO] [stderr] 246 | pub const DF_1_INTERPOSE: u64 = 0x00000400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:248:32 [INFO] [stderr] | [INFO] [stderr] 248 | pub const DF_1_NODEFLIB: u64 = 0x00000800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:250:30 [INFO] [stderr] | [INFO] [stderr] 250 | pub const DF_1_NODUMP: u64 = 0x00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:252:31 [INFO] [stderr] | [INFO] [stderr] 252 | pub const DF_1_CONFALT: u64 = 0x00002000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:254:33 [INFO] [stderr] | [INFO] [stderr] 254 | pub const DF_1_ENDFILTEE: u64 = 0x00004000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:256:34 [INFO] [stderr] | [INFO] [stderr] 256 | pub const DF_1_DISPRELDNE: u64 = 0x00008000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:258:34 [INFO] [stderr] | [INFO] [stderr] 258 | pub const DF_1_DISPRELPND: u64 = 0x00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:260:32 [INFO] [stderr] | [INFO] [stderr] 260 | pub const DF_1_NODIRECT: u64 = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:261:33 [INFO] [stderr] | [INFO] [stderr] 261 | pub const DF_1_IGNMULDEF: u64 = 0x00040000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:262:31 [INFO] [stderr] | [INFO] [stderr] 262 | pub const DF_1_NOKSYMS: u64 = 0x00080000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:263:29 [INFO] [stderr] | [INFO] [stderr] 263 | pub const DF_1_NOHDR: u64 = 0x00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:265:30 [INFO] [stderr] | [INFO] [stderr] 265 | pub const DF_1_EDITED: u64 = 0x00200000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:266:31 [INFO] [stderr] | [INFO] [stderr] 266 | pub const DF_1_NORELOC: u64 = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:268:34 [INFO] [stderr] | [INFO] [stderr] 268 | pub const DF_1_SYMINTPOSE: u64 = 0x00800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:270:33 [INFO] [stderr] | [INFO] [stderr] 270 | pub const DF_1_GLOBAUDIT: u64 = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/dyn.rs:272:33 [INFO] [stderr] | [INFO] [stderr] 272 | pub const DF_1_SINGLETON: u64 = 0x02000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf/reloc.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | (info & 0xffffffff) as u32 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | pub const MH_NO_REEXPORTED_DYLIBS: u32 = 0x100000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | pub const MH_PIE: u32 = 0x200000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | pub const MH_DEAD_STRIPPABLE_DYLIB: u32 = 0x400000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:69:41 [INFO] [stderr] | [INFO] [stderr] 69 | pub const MH_HAS_TLV_DESCRIPTORS: u32 = 0x800000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | pub const MH_NO_HEAP_EXECUTION: u32 = 0x1000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:76:40 [INFO] [stderr] | [INFO] [stderr] 76 | pub const MH_APP_EXTENSION_SAFE: u32 = 0x2000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:112:27 [INFO] [stderr] | [INFO] [stderr] 112 | pub const MH_MAGIC: u32 = 0xfeedface; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfeed_face` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:113:27 [INFO] [stderr] | [INFO] [stderr] 113 | pub const MH_CIGAM: u32 = 0xcefaedfe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcefa_edfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:115:30 [INFO] [stderr] | [INFO] [stderr] 115 | pub const MH_MAGIC_64: u32 = 0xfeedfacf; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfeed_facf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/header.rs:116:30 [INFO] [stderr] | [INFO] [stderr] 116 | pub const MH_CIGAM_64: u32 = 0xcffaedfe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcffa_edfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:3:43 [INFO] [stderr] | [INFO] [stderr] 3 | pub const DYLD_MACOSX_VERSION_10_4: u32 = 0x000A0400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:4:43 [INFO] [stderr] | [INFO] [stderr] 4 | pub const DYLD_MACOSX_VERSION_10_5: u32 = 0x000A0500; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:5:43 [INFO] [stderr] | [INFO] [stderr] 5 | pub const DYLD_MACOSX_VERSION_10_6: u32 = 0x000A0600; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:6:43 [INFO] [stderr] | [INFO] [stderr] 6 | pub const DYLD_MACOSX_VERSION_10_7: u32 = 0x000A0700; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0700` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:7:43 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DYLD_MACOSX_VERSION_10_8: u32 = 0x000A0800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:8:43 [INFO] [stderr] | [INFO] [stderr] 8 | pub const DYLD_MACOSX_VERSION_10_9: u32 = 0x000A0900; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:9:44 [INFO] [stderr] | [INFO] [stderr] 9 | pub const DYLD_MACOSX_VERSION_10_10: u32 = 0x000A0A00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0A00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:10:44 [INFO] [stderr] | [INFO] [stderr] 10 | pub const DYLD_MACOSX_VERSION_10_11: u32 = 0x000A0B00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0B00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | pub const DYLD_MACOSX_VERSION_10_12: u32 = 0x000A0C00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0C00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:12:44 [INFO] [stderr] | [INFO] [stderr] 12 | pub const DYLD_MACOSX_VERSION_10_13: u32 = 0x000A0D00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0D00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:14:39 [INFO] [stderr] | [INFO] [stderr] 14 | pub const DYLD_IOS_VERSION_2_0: u32 = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:15:39 [INFO] [stderr] | [INFO] [stderr] 15 | pub const DYLD_IOS_VERSION_2_1: u32 = 0x00020100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:16:39 [INFO] [stderr] | [INFO] [stderr] 16 | pub const DYLD_IOS_VERSION_2_2: u32 = 0x00020200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:17:39 [INFO] [stderr] | [INFO] [stderr] 17 | pub const DYLD_IOS_VERSION_3_0: u32 = 0x00030000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:18:39 [INFO] [stderr] | [INFO] [stderr] 18 | pub const DYLD_IOS_VERSION_3_1: u32 = 0x00030100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:19:39 [INFO] [stderr] | [INFO] [stderr] 19 | pub const DYLD_IOS_VERSION_3_2: u32 = 0x00030200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:20:39 [INFO] [stderr] | [INFO] [stderr] 20 | pub const DYLD_IOS_VERSION_4_0: u32 = 0x00040000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | pub const DYLD_IOS_VERSION_4_1: u32 = 0x00040100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:22:39 [INFO] [stderr] | [INFO] [stderr] 22 | pub const DYLD_IOS_VERSION_4_2: u32 = 0x00040200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:23:39 [INFO] [stderr] | [INFO] [stderr] 23 | pub const DYLD_IOS_VERSION_4_3: u32 = 0x00040300; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0300` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub const DYLD_IOS_VERSION_5_0: u32 = 0x00050000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0005_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | pub const DYLD_IOS_VERSION_5_1: u32 = 0x00050100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0005_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | pub const DYLD_IOS_VERSION_6_0: u32 = 0x00060000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0006_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub const DYLD_IOS_VERSION_6_1: u32 = 0x00060100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0006_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | pub const DYLD_IOS_VERSION_7_0: u32 = 0x00070000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:29:39 [INFO] [stderr] | [INFO] [stderr] 29 | pub const DYLD_IOS_VERSION_7_1: u32 = 0x00070100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:30:39 [INFO] [stderr] | [INFO] [stderr] 30 | pub const DYLD_IOS_VERSION_8_0: u32 = 0x00080000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | pub const DYLD_IOS_VERSION_9_0: u32 = 0x00090000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0009_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | pub const DYLD_IOS_VERSION_10_0: u32 = 0x000A0000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000A_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:33:40 [INFO] [stderr] | [INFO] [stderr] 33 | pub const DYLD_IOS_VERSION_11_0: u32 = 0x000B0000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000B_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | pub const SECTION_TYPE: u32 = 0x000000ff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | pub const SECTION_ATTRIBUTES: u32 = 0xffffff00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:109:41 [INFO] [stderr] | [INFO] [stderr] 109 | pub const SECTION_ATTRIBUTES_USR: u32 = 0xff000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:111:43 [INFO] [stderr] | [INFO] [stderr] 111 | pub const S_ATTR_PURE_INSTRUCTIONS: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:113:32 [INFO] [stderr] | [INFO] [stderr] 113 | pub const S_ATTR_NO_TOC: u32 = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:115:43 [INFO] [stderr] | [INFO] [stderr] 115 | pub const S_ATTR_STRIP_STATIC_SYMS: u32 = 0x20000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:117:39 [INFO] [stderr] | [INFO] [stderr] 117 | pub const S_ATTR_NO_DEAD_STRIP: u32 = 0x10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:119:38 [INFO] [stderr] | [INFO] [stderr] 119 | pub const S_ATTR_LIVE_SUPPORT: u32 = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:121:45 [INFO] [stderr] | [INFO] [stderr] 121 | pub const S_ATTR_SELF_MODIFYING_CODE: u32 = 0x04000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:131:31 [INFO] [stderr] | [INFO] [stderr] 131 | pub const S_ATTR_DEBUG: u32 = 0x02000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:133:41 [INFO] [stderr] | [INFO] [stderr] 133 | pub const SECTION_ATTRIBUTES_SYS: u32 = 0x00ffff00; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:135:43 [INFO] [stderr] | [INFO] [stderr] 135 | pub const S_ATTR_SOME_INSTRUCTIONS: u32 = 0x00000400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | pub const S_ATTR_EXT_RELOC: u32 = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | pub const S_ATTR_LOC_RELOC: u32 = 0x00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:153:26 [INFO] [stderr] | [INFO] [stderr] 153 | pub const SEG_PAGEZERO: &'static str = "__PAGEZERO"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:155:22 [INFO] [stderr] | [INFO] [stderr] 155 | pub const SEG_TEXT: &'static str = "__TEXT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | pub const SECT_TEXT: &'static str = "__text"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:159:31 [INFO] [stderr] | [INFO] [stderr] 159 | pub const SECT_FVMLIB_INIT0: &'static str = "__fvmlib_init0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:161:31 [INFO] [stderr] | [INFO] [stderr] 161 | pub const SECT_FVMLIB_INIT1: &'static str = "__fvmlib_init1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | pub const SEG_DATA: &'static str = "__DATA"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:165:23 [INFO] [stderr] | [INFO] [stderr] 165 | pub const SECT_DATA: &'static str = "__data"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | pub const SECT_BSS: &'static str = "__bss"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:169:25 [INFO] [stderr] | [INFO] [stderr] 169 | pub const SECT_COMMON: &'static str = "__common"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | pub const SEG_OBJC: &'static str = "__OBJC"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:173:31 [INFO] [stderr] | [INFO] [stderr] 173 | pub const SECT_OBJC_SYMBOLS: &'static str = "__symbol_table"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:175:31 [INFO] [stderr] | [INFO] [stderr] 175 | pub const SECT_OBJC_MODULES: &'static str = "__module_info"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:177:31 [INFO] [stderr] | [INFO] [stderr] 177 | pub const SECT_OBJC_STRINGS: &'static str = "__selector_strs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:179:28 [INFO] [stderr] | [INFO] [stderr] 179 | pub const SECT_OBJC_REFS: &'static str = "__selector_refs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | pub const SEG_ICON: &'static str = "__ICON"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:183:30 [INFO] [stderr] | [INFO] [stderr] 183 | pub const SECT_ICON_HEADER: &'static str = "__header"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:185:28 [INFO] [stderr] | [INFO] [stderr] 185 | pub const SECT_ICON_TIFF: &'static str = "__tiff"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | pub const SEG_LINKEDIT: &'static str = "__LINKEDIT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:189:27 [INFO] [stderr] | [INFO] [stderr] 189 | pub const SEG_UNIXSTACK: &'static str = "__UNIXSTACK"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mach/constants.rs:191:24 [INFO] [stderr] | [INFO] [stderr] 191 | pub const SEG_IMPORT: &'static str = "__IMPORT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:201:39 [INFO] [stderr] | [INFO] [stderr] 201 | pub const CPU_SUBTYPE_MASK: u32 = 0xff000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:203:40 [INFO] [stderr] | [INFO] [stderr] 203 | pub const CPU_ARCH_MASK: CpuType = 0xff000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/constants.rs:205:41 [INFO] [stderr] | [INFO] [stderr] 205 | pub const CPU_ARCH_ABI64: CpuType = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/fat.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | pub const FAT_MAGIC: u32 = 0xcafebabe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcafe_babe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/fat.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | pub const FAT_CIGAM: u32 = 0xbebafeca; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbeba_feca` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mach/load_command.rs:1153:30 [INFO] [stderr] | [INFO] [stderr] 1153 | pub const LC_REQ_DYLD: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mach/symbols.rs:340:35 [INFO] [stderr] | [INFO] [stderr] 340 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Err(e.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mach/symbols.rs:343:27 [INFO] [stderr] | [INFO] [stderr] 343 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Err(e.into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/header.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | pub const COFF_MAGIC: u32 = 0x00004550; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4550` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:94:40 [INFO] [stderr] | [INFO] [stderr] 94 | pub const IMAGE_SCN_TYPE_NO_PAD: u32 = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:96:37 [INFO] [stderr] | [INFO] [stderr] 96 | pub const IMAGE_SCN_CNT_CODE: u32 = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:98:49 [INFO] [stderr] | [INFO] [stderr] 98 | pub const IMAGE_SCN_CNT_INITIALIZED_DATA: u32 = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:100:51 [INFO] [stderr] | [INFO] [stderr] 100 | pub const IMAGE_SCN_CNT_UNINITIALIZED_DATA: u32 = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | pub const IMAGE_SCN_LNK_OTHER: u32 = 0x00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | pub const IMAGE_SCN_LNK_INFO: u32 = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:106:39 [INFO] [stderr] | [INFO] [stderr] 106 | pub const IMAGE_SCN_LNK_REMOVE: u32 = 0x00000800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:108:39 [INFO] [stderr] | [INFO] [stderr] 108 | pub const IMAGE_SCN_LNK_COMDAT: u32 = 0x00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:110:34 [INFO] [stderr] | [INFO] [stderr] 110 | pub const IMAGE_SCN_GPREL: u32 = 0x00008000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:111:42 [INFO] [stderr] | [INFO] [stderr] 111 | pub const IMAGE_SCN_MEM_PURGEABLE: u32 = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:112:38 [INFO] [stderr] | [INFO] [stderr] 112 | pub const IMAGE_SCN_MEM_16BIT: u32 = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:113:39 [INFO] [stderr] | [INFO] [stderr] 113 | pub const IMAGE_SCN_MEM_LOCKED: u32 = 0x00040000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | pub const IMAGE_SCN_MEM_PRELOAD: u32 = 0x00080000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:116:41 [INFO] [stderr] | [INFO] [stderr] 116 | pub const IMAGE_SCN_ALIGN_1BYTES: u32 = 0x00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:117:41 [INFO] [stderr] | [INFO] [stderr] 117 | pub const IMAGE_SCN_ALIGN_2BYTES: u32 = 0x00200000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:118:41 [INFO] [stderr] | [INFO] [stderr] 118 | pub const IMAGE_SCN_ALIGN_4BYTES: u32 = 0x00300000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0030_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:119:41 [INFO] [stderr] | [INFO] [stderr] 119 | pub const IMAGE_SCN_ALIGN_8BYTES: u32 = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:120:42 [INFO] [stderr] | [INFO] [stderr] 120 | pub const IMAGE_SCN_ALIGN_16BYTES: u32 = 0x00500000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0050_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:121:42 [INFO] [stderr] | [INFO] [stderr] 121 | pub const IMAGE_SCN_ALIGN_32BYTES: u32 = 0x00600000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0060_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:122:42 [INFO] [stderr] | [INFO] [stderr] 122 | pub const IMAGE_SCN_ALIGN_64BYTES: u32 = 0x00700000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0070_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:123:43 [INFO] [stderr] | [INFO] [stderr] 123 | pub const IMAGE_SCN_ALIGN_128BYTES: u32 = 0x00800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:124:43 [INFO] [stderr] | [INFO] [stderr] 124 | pub const IMAGE_SCN_ALIGN_256BYTES: u32 = 0x00900000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0090_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:125:43 [INFO] [stderr] | [INFO] [stderr] 125 | pub const IMAGE_SCN_ALIGN_512BYTES: u32 = 0x00A00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00A0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:126:44 [INFO] [stderr] | [INFO] [stderr] 126 | pub const IMAGE_SCN_ALIGN_1024BYTES: u32 = 0x00B00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00B0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:127:44 [INFO] [stderr] | [INFO] [stderr] 127 | pub const IMAGE_SCN_ALIGN_2048BYTES: u32 = 0x00C00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00C0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:128:44 [INFO] [stderr] | [INFO] [stderr] 128 | pub const IMAGE_SCN_ALIGN_4096BYTES: u32 = 0x00D00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00D0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:129:44 [INFO] [stderr] | [INFO] [stderr] 129 | pub const IMAGE_SCN_ALIGN_8192BYTES: u32 = 0x00E00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00E0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:130:39 [INFO] [stderr] | [INFO] [stderr] 130 | pub const IMAGE_SCN_ALIGN_MASK: u32 = 0x00F00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00F0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:133:44 [INFO] [stderr] | [INFO] [stderr] 133 | pub const IMAGE_SCN_LNK_NRELOC_OVFL: u32 = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:135:44 [INFO] [stderr] | [INFO] [stderr] 135 | pub const IMAGE_SCN_MEM_DISCARDABLE: u32 = 0x02000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:137:43 [INFO] [stderr] | [INFO] [stderr] 137 | pub const IMAGE_SCN_MEM_NOT_CACHED: u32 = 0x04000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:139:42 [INFO] [stderr] | [INFO] [stderr] 139 | pub const IMAGE_SCN_MEM_NOT_PAGED: u32 = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:141:39 [INFO] [stderr] | [INFO] [stderr] 141 | pub const IMAGE_SCN_MEM_SHARED: u32 = 0x10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:143:40 [INFO] [stderr] | [INFO] [stderr] 143 | pub const IMAGE_SCN_MEM_EXECUTE: u32 = 0x20000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:145:37 [INFO] [stderr] | [INFO] [stderr] 145 | pub const IMAGE_SCN_MEM_READ: u32 = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/section_table.rs:147:38 [INFO] [stderr] | [INFO] [stderr] 147 | pub const IMAGE_SCN_MEM_WRITE: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/debug.rs:65:39 [INFO] [stderr] | [INFO] [stderr] 65 | pub const CODEVIEW_PDB70_MAGIC: u32 = 0x53445352; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5344_5352` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/debug.rs:66:39 [INFO] [stderr] | [INFO] [stderr] 66 | pub const CODEVIEW_PDB20_MAGIC: u32 = 0x3031424e; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3031_424e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/debug.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | pub const CODEVIEW_CV50_MAGIC: u32 = 0x3131424e; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3131_424e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pe/debug.rs:68:38 [INFO] [stderr] | [INFO] [stderr] 68 | pub const CODEVIEW_CV41_MAGIC: u32 = 0x3930424e; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3930_424e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | pub const MAGIC: &'static [u8; SIZEOF_MAGIC] = b"!\x0A"; [INFO] [stderr] | -^^^^^^^------------------- help: consider removing `'static`: `&[u8; SIZEOF_MAGIC]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:189:20 [INFO] [stderr] | [INFO] [stderr] 189 | const INDEX_NAME: &'static str = "/ "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:191:25 [INFO] [stderr] | [INFO] [stderr] 191 | const NAME_INDEX_NAME: &'static str = "// "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:193:25 [INFO] [stderr] | [INFO] [stderr] 193 | const BSD_SYMDEF_NAME: &'static str = "__.SYMDEF"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive/mod.rs:194:32 [INFO] [stderr] | [INFO] [stderr] 194 | const BSD_SYMDEF_SORTED_NAME: &'static str = "__.SYMDEF SORTED"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/archive/mod.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | return Err(Error::Malformed(format!("Could not find {:?} in index", name).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::Malformed(format!("Could not find {:?} in index", name).into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/archive/mod.rs:321:17 [INFO] [stderr] | [INFO] [stderr] 321 | return Err(Error::Malformed(format!("Bad name index {:?} in index", name).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::Malformed(format!("Bad name index {:?} in index", name).into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/strtab.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn to_vec(self) -> error::Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn is_big(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:176:23 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn is_big(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:180:33 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn is_little_endian(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn size(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:275:53 [INFO] [stderr] | [INFO] [stderr] 275 | Err(error::Error::Malformed(format!("Correct mach magic {:#x} does not have a matching parsing context!", magic).into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Correct mach magic {:#x} does not have a matching parsing context!", magic)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:299:9 [INFO] [stderr] | [INFO] [stderr] 299 | Elf(elf::Elf<'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 299 | Elf(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elf/header.rs:171:26 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn size(ctx: &Ctx) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elf/header.rs:293:28 [INFO] [stderr] | [INFO] [stderr] 293 | return Err(error::Error::BadMagic(magic).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `error::Error::BadMagic(magic)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elf/header.rs:304:25 [INFO] [stderr] | [INFO] [stderr] 304 | Err(error::Error::Malformed(format!("invalid ELF class {:x}", class)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `error::Error::Malformed(format!("invalid ELF class {:x}", class))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/header.rs:387:34 [INFO] [stderr] | [INFO] [stderr] 387 | e_entry: eh.e_entry as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(eh.e_entry)` [INFO] [stderr] ... [INFO] [stderr] 573 | elf_header_std_impl!(SIZEOF_EHDR, u32); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/header.rs:388:34 [INFO] [stderr] | [INFO] [stderr] 388 | e_phoff: eh.e_phoff as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(eh.e_phoff)` [INFO] [stderr] ... [INFO] [stderr] 573 | elf_header_std_impl!(SIZEOF_EHDR, u32); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/header.rs:389:34 [INFO] [stderr] | [INFO] [stderr] 389 | e_shoff: eh.e_shoff as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(eh.e_shoff)` [INFO] [stderr] ... [INFO] [stderr] 573 | elf_header_std_impl!(SIZEOF_EHDR, u32); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/header.rs:469:21 [INFO] [stderr] | [INFO] [stderr] 469 | bytes.read(&mut elf_header)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 573 | elf_header_std_impl!(SIZEOF_EHDR, u32); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/header.rs:469:21 [INFO] [stderr] | [INFO] [stderr] 469 | bytes.read(&mut elf_header)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 584 | elf_header_std_impl!(SIZEOF_EHDR, u64); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/elf/program_header.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | pub const PF_X: u32 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elf/program_header.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn size(ctx: &Ctx) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:263:32 [INFO] [stderr] | [INFO] [stderr] 263 | p_offset : ph.p_offset as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_offset)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:264:32 [INFO] [stderr] | [INFO] [stderr] 264 | p_vaddr : ph.p_vaddr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_vaddr)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:265:32 [INFO] [stderr] | [INFO] [stderr] 265 | p_paddr : ph.p_paddr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_paddr)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:266:32 [INFO] [stderr] | [INFO] [stderr] 266 | p_filesz : ph.p_filesz as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_filesz)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:267:32 [INFO] [stderr] | [INFO] [stderr] 267 | p_memsz : ph.p_memsz as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_memsz)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:268:32 [INFO] [stderr] | [INFO] [stderr] 268 | p_align : ph.p_align as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_align)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/program_header.rs:372:5 [INFO] [stderr] | [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/program_header.rs:408:5 [INFO] [stderr] | [INFO] [stderr] 408 | elf_program_header_std_impl!(u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:289:31 [INFO] [stderr] | [INFO] [stderr] 289 | sh_flags: sh.sh_flags as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_flags)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:290:30 [INFO] [stderr] | [INFO] [stderr] 290 | sh_addr: sh.sh_addr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_addr)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:291:32 [INFO] [stderr] | [INFO] [stderr] 291 | sh_offset: sh.sh_offset as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_offset)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:292:30 [INFO] [stderr] | [INFO] [stderr] 292 | sh_size: sh.sh_size as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_size)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:295:35 [INFO] [stderr] | [INFO] [stderr] 295 | sh_addralign: sh.sh_addralign as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_addralign)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:296:33 [INFO] [stderr] | [INFO] [stderr] 296 | sh_entsize: sh.sh_entsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_entsize)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/section_header.rs:345:5 [INFO] [stderr] | [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/section_header.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | elf_section_header_std_impl!(u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elf/section_header.rs:403:26 [INFO] [stderr] | [INFO] [stderr] 403 | pub fn size(ctx: &Ctx) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:411:27 [INFO] [stderr] | [INFO] [stderr] 411 | sh_flags: SHF_ALLOC as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_ALLOC)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/compression_header.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | ch_size: ch.ch_size as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch.ch_size)` [INFO] [stderr] ... [INFO] [stderr] 105 | elf_compression_header_std_impl!(u32); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/compression_header.rs:59:35 [INFO] [stderr] | [INFO] [stderr] 59 | ch_addralign: ch.ch_addralign as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch.ch_addralign)` [INFO] [stderr] ... [INFO] [stderr] 105 | elf_compression_header_std_impl!(u32); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/compression_header.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | elf_compression_header_std_impl!(u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/compression_header.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | elf_compression_header_std_impl!(u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elf/compression_header.rs:183:26 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn size(ctx: &Ctx) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/sym.rs:156:38 [INFO] [stderr] | [INFO] [stderr] 156 | st_value: sym.st_value as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sym.st_value)` [INFO] [stderr] ... [INFO] [stderr] 240 | elf_sym_std_impl!(u32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/sym.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | st_size: sym.st_size as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sym.st_size)` [INFO] [stderr] ... [INFO] [stderr] 240 | elf_sym_std_impl!(u32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/sym.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | elf_sym_std_impl!(u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/sym.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | elf_sym_std_impl!(u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: item `elf::sym::Symtab<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/elf/sym.rs:445:5 [INFO] [stderr] | [INFO] [stderr] 445 | / impl<'a> Symtab<'a> { [INFO] [stderr] 446 | | /// Parse a table of `count` ELF symbols from `offset`. [INFO] [stderr] 447 | | pub fn parse(bytes: &'a [u8], offset: usize, count: usize, ctx: Ctx) -> Result> { [INFO] [stderr] 448 | | let size = count * Sym::size_with(&ctx); [INFO] [stderr] ... | [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elf/dyn.rs:397:21 [INFO] [stderr] | [INFO] [stderr] 397 | / match strtab.get(dyn.d_val as usize) { [INFO] [stderr] 398 | | Some(Ok(lib)) => needed.push(lib), [INFO] [stderr] 399 | | // FIXME: warn! here [INFO] [stderr] 400 | | _ => (), [INFO] [stderr] 401 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(Ok(lib)) = strtab.get(dyn.d_val as usize) { needed.push(lib) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:449:32 [INFO] [stderr] | [INFO] [stderr] 449 | d_tag: dyn.d_tag as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(dyn.d_tag)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:450:32 [INFO] [stderr] | [INFO] [stderr] 450 | d_val: dyn.d_val as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(dyn.d_val)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:459:39 [INFO] [stderr] | [INFO] [stderr] 459 | tag_to_str(self.d_tag as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.d_tag)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:472:44 [INFO] [stderr] | [INFO] [stderr] 472 | try!(fd.seek(Start(phdr.p_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(phdr.p_offset)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/dyn.rs:666:5 [INFO] [stderr] | [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:487:23 [INFO] [stderr] | [INFO] [stderr] 487 | while (*dynp.offset(idx)).d_tag as u64 != DT_NULL { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((*dynp.offset(idx)).d_tag)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:510:24 [INFO] [stderr] | [INFO] [stderr] 510 | if dyn.d_tag as u64 == DT_NEEDED { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(dyn.d_tag)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:576:23 [INFO] [stderr] | [INFO] [stderr] 576 | match dyn.d_tag as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(dyn.d_tag)` [INFO] [stderr] ... [INFO] [stderr] 667 | elf_dynamic_info_std_impl!(u32, ::elf::program_header::program_header32::ProgramHeader); [INFO] [stderr] | ---------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/dyn.rs:677:5 [INFO] [stderr] | [INFO] [stderr] 677 | elf_dyn_std_impl!(u64, ::elf64::program_header::ProgramHeader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:123:35 [INFO] [stderr] | [INFO] [stderr] 123 | r_offset: rela.r_offset as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rela.r_offset)` [INFO] [stderr] ... [INFO] [stderr] 222 | elf_rela_std_impl!(u32, i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:124:40 [INFO] [stderr] | [INFO] [stderr] 124 | r_addend: Some(rela.r_addend as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(rela.r_addend)` [INFO] [stderr] ... [INFO] [stderr] 222 | elf_rela_std_impl!(u32, i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:134:35 [INFO] [stderr] | [INFO] [stderr] 134 | r_offset: rel.r_offset as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rel.r_offset)` [INFO] [stderr] ... [INFO] [stderr] 222 | elf_rela_std_impl!(u32, i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/reloc.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | fd.read(plain::as_mut_bytes(&mut *relocs))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 222 | elf_rela_std_impl!(u32, i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:144:62 [INFO] [stderr] | [INFO] [stderr] 144 | let r_info = r_info(rela.r_sym as $size, rela.r_type as $size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rela.r_type)` [INFO] [stderr] ... [INFO] [stderr] 249 | elf_rela_std_impl!(u64, i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:155:61 [INFO] [stderr] | [INFO] [stderr] 155 | let r_info = r_info(rel.r_sym as $size, rel.r_type as $size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rel.r_type)` [INFO] [stderr] ... [INFO] [stderr] 249 | elf_rela_std_impl!(u64, i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/reloc.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | fd.read(plain::as_mut_bytes(&mut *relocs))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 249 | elf_rela_std_impl!(u64, i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: item `elf::reloc::RelocSection<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/elf/reloc.rs:406:5 [INFO] [stderr] | [INFO] [stderr] 406 | / impl<'a> RelocSection<'a> { [INFO] [stderr] 407 | | #[cfg(feature = "endian_fd")] [INFO] [stderr] 408 | | /// Parse a REL or RELA section of size `filesz` from `offset`. [INFO] [stderr] 409 | | pub fn parse(bytes: &'a [u8], offset: usize, filesz: usize, is_rela: bool, ctx: Ctx) -> ::error::Result> { [INFO] [stderr] ... | [INFO] [stderr] 445 | | } [INFO] [stderr] 446 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elf/note.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | Err(e) => Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elf/mod.rs:212:28 [INFO] [stderr] | [INFO] [stderr] 212 | return Err(error::Error::Malformed(format!("Unknown values in ELF ident header: class: {} endianness: {}", [INFO] [stderr] | ____________________________^ [INFO] [stderr] 213 | | class, [INFO] [stderr] 214 | | header.e_ident[header::EI_DATA])).into()); [INFO] [stderr] | |___________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 212 | return Err(error::Error::Malformed(format!("Unknown values in ELF ident header: class: {} endianness: {}", [INFO] [stderr] 213 | class, [INFO] [stderr] 214 | header.e_ident[header::EI_DATA]))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/elf/gnu_hash.rs:31:59 [INFO] [stderr] | [INFO] [stderr] 31 | hash = hash.wrapping_mul(32).wrapping_add(*b as u32).wrapping_add(hash); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | elf_gnu_hash_impl!(u32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/elf/gnu_hash.rs:55:35 [INFO] [stderr] | [INFO] [stderr] 55 | let buckets_ptr = bloomwords_ptr.offset(maskwords as isize) as *const u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bloomwords_ptr.add(maskwords)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | elf_gnu_hash_impl!(u32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/elf/gnu_hash.rs:31:59 [INFO] [stderr] | [INFO] [stderr] 31 | hash = hash.wrapping_mul(32).wrapping_add(*b as u32).wrapping_add(hash); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | elf_gnu_hash_impl!(u64); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u32` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/elf/gnu_hash.rs:54:38 [INFO] [stderr] | [INFO] [stderr] 54 | let bloomwords_ptr = hashtab.offset(4) as *const $size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | elf_gnu_hash_impl!(u64); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/elf/gnu_hash.rs:55:35 [INFO] [stderr] | [INFO] [stderr] 55 | let buckets_ptr = bloomwords_ptr.offset(maskwords as isize) as *const u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bloomwords_ptr.add(maskwords)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | elf_gnu_hash_impl!(u64); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/header.rs:323:21 [INFO] [stderr] | [INFO] [stderr] 323 | pub fn new(ctx: &container::Ctx) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `container::Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mach/header.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | / match container { [INFO] [stderr] 360 | | &Container::Little => { [INFO] [stderr] 361 | | SIZEOF_HEADER_32 [INFO] [stderr] 362 | | }, [INFO] [stderr] ... | [INFO] [stderr] 365 | | }, [INFO] [stderr] 366 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 359 | match *container { [INFO] [stderr] 360 | Container::Little => { [INFO] [stderr] 361 | SIZEOF_HEADER_32 [INFO] [stderr] 362 | }, [INFO] [stderr] 363 | Container::Big => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/mach/header.rs:376:49 [INFO] [stderr] | [INFO] [stderr] 376 | let error = error::Error::Malformed(format!("bytes size is smaller than a Mach-o header")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytes size is smaller than a Mach-o header".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/fat.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn from_bytes(bytes: &[u8; SIZEOF_FAT_HEADER]) -> FatHeader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[u8; SIZEOF_FAT_HEADER]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/mach/fat.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | try!(fd.read(&mut header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:421:20 [INFO] [stderr] | [INFO] [stderr] 421 | Ok(eip as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(eip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:448:24 [INFO] [stderr] | [INFO] [stderr] 448 | (self.thread_state[32] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:449:24 [INFO] [stderr] | [INFO] [stderr] 449 | | ((self.thread_state[33] as u64) << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[33])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:461:20 [INFO] [stderr] | [INFO] [stderr] 461 | Ok(pc as u64) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:474:24 [INFO] [stderr] | [INFO] [stderr] 474 | (self.thread_state[64] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[64])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:475:24 [INFO] [stderr] | [INFO] [stderr] 475 | | ((self.thread_state[65] as u64) << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[65])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:481:20 [INFO] [stderr] | [INFO] [stderr] 481 | Ok(self.thread_state[0] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `thread_state` [INFO] [stderr] --> src/mach/load_command.rs:522:18 [INFO] [stderr] | [INFO] [stderr] 522 | for i in 0..count as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 522 | for (i, ) in thread_state.iter_mut().enumerate().take(count as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mach::load_command::SymtabCommand` [INFO] [stderr] --> src/mach/load_command.rs:611:5 [INFO] [stderr] | [INFO] [stderr] 611 | / pub fn new() -> Self { [INFO] [stderr] 612 | | SymtabCommand { [INFO] [stderr] 613 | | cmd: LC_SYMTAB, [INFO] [stderr] 614 | | cmdsize: SIZEOF_SYMTAB_COMMAND as u32, [INFO] [stderr] ... | [INFO] [stderr] 619 | | } [INFO] [stderr] 620 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 601 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mach::load_command::DysymtabCommand` [INFO] [stderr] --> src/mach/load_command.rs:707:5 [INFO] [stderr] | [INFO] [stderr] 707 | / pub fn new() -> Self { [INFO] [stderr] 708 | | DysymtabCommand { [INFO] [stderr] 709 | | cmd: LC_DYSYMTAB, [INFO] [stderr] 710 | | cmdsize: SIZEOF_DYSYMTAB_COMMAND as u32, [INFO] [stderr] ... | [INFO] [stderr] 729 | | } [INFO] [stderr] 730 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 665 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/mach/load_command.rs:1268:5 [INFO] [stderr] | [INFO] [stderr] 1268 | Unixthread (ThreadCommand), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 1268 | Unixthread (Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mach/load_command.rs:1370:138 [INFO] [stderr] | [INFO] [stderr] 1370 | _ => Ok((Unimplemented (lc.clone()), size)), [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `lc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/symbols.rs:213:22 [INFO] [stderr] | [INFO] [stderr] 213 | n_value: nlist.n_value as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(nlist.n_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mach/symbols.rs:343:43 [INFO] [stderr] | [INFO] [stderr] 343 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/mach/exports.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn to_str(kind: SymbolKind) -> &'static str { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mach/exports.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | let offset = &mut start.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mach/exports.rs:236:22 [INFO] [stderr] | [INFO] [stderr] 236 | let offset = self.location.start.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.location.start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/mach/exports.rs:248:19 [INFO] [stderr] | [INFO] [stderr] 248 | data: bytes.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/mach/imports.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | data: bytes.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/imports.rs:144:81 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn imports(&self, libs: &[&'a str], segments: &[segment::Segment], ctx: &container::Ctx) -> error::Result>>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `container::Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/imports.rs:150:88 [INFO] [stderr] | [INFO] [stderr] 150 | fn run(&self, is_lazy: bool, libs: &[&'a str], segments: &[segment::Segment], ctx: &container::Ctx, imports: &mut Vec>) -> error::Result<()>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `container::Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mach/imports.rs:158:27 [INFO] [stderr] | [INFO] [stderr] 158 | let offset = &mut location.start.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `location.start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/imports.rs:247:72 [INFO] [stderr] | [INFO] [stderr] 247 | let seg_offset = bind_info.seg_offset.wrapping_add(scale as u64 * size).wrapping_add(size); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn r_symbolnum(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn r_pcrel(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn r_length(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn r_extern(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn r_type(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn is_extern(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn is_pic(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:78:19 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn to_str(&self, cputype: mach::cputype::CpuType) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | addr: section.addr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section.addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | size: section.size as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mach/segment.rs:258:36 [INFO] [stderr] | [INFO] [stderr] 258 | Err(e) => Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:430:23 [INFO] [stderr] | [INFO] [stderr] 430 | vmaddr: segment.vmaddr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.vmaddr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:431:23 [INFO] [stderr] | [INFO] [stderr] 431 | vmsize: segment.vmsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.vmsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:432:23 [INFO] [stderr] | [INFO] [stderr] 432 | fileoff: segment.fileoff as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.fileoff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:433:23 [INFO] [stderr] | [INFO] [stderr] 433 | filesize: segment.filesize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.filesize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/mach/mod.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / if let &Some(ref symbols) = &self.symbols { [INFO] [stderr] 101 | | symbols.into_iter() [INFO] [stderr] 102 | | } else { [INFO] [stderr] 103 | | symbols::SymbolIterator::default() [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | if let Some(ref symbols) = self.symbols { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/mod.rs:139:97 [INFO] [stderr] | [INFO] [stderr] 139 | let ctx = if let Some(ctx) = maybe_ctx { ctx } else { return Err(error::Error::BadMagic(magic as u64)) }; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(magic)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mach/mod.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | *offset = *offset + header::Header::size_with(&ctx.container); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*offset += header::Header::size_with(&ctx.container)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mach/mod.rs:345:48 [INFO] [stderr] | [INFO] [stderr] 345 | return Err(error::Error::Malformed(format!("Requested the {}-th binary, but there are only {} architectures in this container", index, self.narches).into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Requested the {}-th binary, but there are only {} architectures in this container", index, self.narches)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/mach/mod.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | Binary(MachO<'a>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 386 | Binary(Box>) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/mach/mod.rs:395:40 [INFO] [stderr] | [INFO] [stderr] 395 | format!("size is smaller than a magical number")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"size is smaller than a magical number".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | size_of_code: fields.size_of_code as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:66:39 [INFO] [stderr] | [INFO] [stderr] 66 | size_of_initialized_data: fields.size_of_initialized_data as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_initialized_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | size_of_uninitialized_data: fields.size_of_uninitialized_data as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_uninitialized_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:68:37 [INFO] [stderr] | [INFO] [stderr] 68 | address_of_entry_point: fields.address_of_entry_point as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.address_of_entry_point)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | base_of_code: fields.base_of_code as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.base_of_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:81:27 [INFO] [stderr] | [INFO] [stderr] 81 | size_of_code: fields.size_of_code as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:82:39 [INFO] [stderr] | [INFO] [stderr] 82 | size_of_initialized_data: fields.size_of_initialized_data as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_initialized_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | size_of_uninitialized_data: fields.size_of_uninitialized_data as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_uninitialized_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:84:37 [INFO] [stderr] | [INFO] [stderr] 84 | address_of_entry_point: fields.address_of_entry_point as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.address_of_entry_point)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:85:27 [INFO] [stderr] | [INFO] [stderr] 85 | base_of_code: fields.base_of_code as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.base_of_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | image_base: windows.image_base as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.image_base)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:200:36 [INFO] [stderr] | [INFO] [stderr] 200 | size_of_stack_reserve: windows.size_of_stack_reserve as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.size_of_stack_reserve)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:201:35 [INFO] [stderr] | [INFO] [stderr] 201 | size_of_stack_commit: windows.size_of_stack_commit as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.size_of_stack_commit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:202:35 [INFO] [stderr] | [INFO] [stderr] 202 | size_of_heap_reserve: windows.size_of_heap_reserve as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.size_of_heap_reserve)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:203:34 [INFO] [stderr] | [INFO] [stderr] 203 | size_of_heap_commit: windows.size_of_heap_commit as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.size_of_heap_commit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:257:44 [INFO] [stderr] | [INFO] [stderr] 257 | Err(error::Error::BadMagic(magic as u64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(magic)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:280:52 [INFO] [stderr] | [INFO] [stderr] 280 | _ => return Err(error::Error::BadMagic(magic as u64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(magic)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `c - b'A'` [INFO] [stderr] --> src/pe/section_table.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | c - b'A' + 00 // 00..=25 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `name`. [INFO] [stderr] --> src/pe/section_table.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 53 | for in &mut name { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `data_directories`. [INFO] [stderr] --> src/pe/data_directories.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 31 | for in data_directories.iter_mut().take(count) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pe/export.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn parse(bytes: &'a [u8], dd: &data_directories::DataDirectory, sections: &[section_table::SectionTable], file_alignment: u32) -> error::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `data_directories::DataDirectory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/pe/export.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / match c { [INFO] [stderr] 159 | | // '.' [INFO] [stderr] 160 | | 0x2e => { [INFO] [stderr] 161 | | let i = o - 1; [INFO] [stderr] ... | [INFO] [stderr] 184 | | _ => {} [INFO] [stderr] 185 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 158 | if let 0x2e = c { [INFO] [stderr] 159 | let i = o - 1; [INFO] [stderr] 160 | let dll: &'a str = bytes.pread_with(0, ::scroll::ctx::StrCtx::Length(i))?; [INFO] [stderr] 161 | debug!("dll: {:?}", &dll); [INFO] [stderr] 162 | let len = reexport_len - i - 1; [INFO] [stderr] 163 | let rest: &'a [u8] = bytes.pread_with(o, len)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/pe/export.rs:224:20 [INFO] [stderr] | [INFO] [stderr] 224 | let name = utils::find_offset(ptr as usize, sections, file_alignment).map_or(None, |offset| bytes.pread::<&str>(offset).ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `utils::find_offset(ptr as usize, sections, file_alignment).and_then(|offset| bytes.pread::<&str>(offset).ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pe/import.rs:160:151 [INFO] [stderr] | [INFO] [stderr] 160 | let import_address_table_offset = &mut utils::find_offset(import_directory_entry.import_address_table_rva as usize, sections, file_alignment).ok_or(error::Error::Malformed(format!("Cannot map import_address_table_rva {:#x} into offset for {}", import_directory_entry.import_address_table_rva, name)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::Error::Malformed(format!("Cannot map import_address_table_rva {:#x} into offset for {}", import_directory_entry.import_address_table_rva, name)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pe/import.rs:182:55 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn parse>(bytes: &'a[u8], dd: &data_directories::DataDirectory, sections: &[section_table::SectionTable], file_alignment: u32) -> error::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `data_directories::DataDirectory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pe/import.rs:185:100 [INFO] [stderr] | [INFO] [stderr] 185 | let offset = &mut utils::find_offset(import_directory_table_rva, sections, file_alignment).ok_or(error::Error::Malformed(format!("Cannot create ImportData; cannot map import_directory_table_rva {:#x} into offset", import_directory_table_rva)))?;; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::Error::Malformed(format!("Cannot create ImportData; cannot map import_directory_table_rva {:#x} into offset", import_directory_table_rva)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pe/import.rs:227:25 [INFO] [stderr] | [INFO] [stderr] 227 | / match entry { [INFO] [stderr] 228 | | &HintNameTableRVA ((rva, ref hint_entry)) => { [INFO] [stderr] 229 | | // if hint_entry.name = "" && hint_entry.hint = 0 { [INFO] [stderr] 230 | | // println!(" warning hint/name table rva from {} without hint {:#x}", dll, rva); [INFO] [stderr] ... | [INFO] [stderr] 237 | | }, [INFO] [stderr] 238 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 227 | match *entry { [INFO] [stderr] 228 | HintNameTableRVA ((rva, ref hint_entry)) => { [INFO] [stderr] 229 | // if hint_entry.name = "" && hint_entry.hint = 0 { [INFO] [stderr] 230 | // println!(" warning hint/name table rva from {} without hint {:#x}", dll, rva); [INFO] [stderr] 231 | // } [INFO] [stderr] 232 | (rva, Cow::Borrowed(hint_entry.name), hint_entry.hint.clone()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pe/import.rs:232:71 [INFO] [stderr] | [INFO] [stderr] 232 | (rva, Cow::Borrowed(hint_entry.name), hint_entry.hint.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `hint_entry.hint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pe/debug.rs:15:39 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn parse(bytes: &'a [u8], dd: &data_directories::DataDirectory, sections: &[section_table::SectionTable], file_alignment: u32) -> error::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `data_directories::DataDirectory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pe/debug.rs:57:32 [INFO] [stderr] | [INFO] [stderr] 57 | fn parse(bytes: &[u8], dd: &data_directories::DataDirectory, sections: &[section_table::SectionTable], file_alignment: u32) -> error::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `data_directories::DataDirectory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pe/debug.rs:59:72 [INFO] [stderr] | [INFO] [stderr] 59 | let offset = utils::find_offset(rva, sections, file_alignment).ok_or(error::Error::Malformed(format!("Cannot map ImageDebugDirectory rva {:#x} into offset", rva)))?;; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::Error::Malformed(format!("Cannot map ImageDebugDirectory rva {:#x} into offset", rva)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `signature`. [INFO] [stderr] --> src/pe/debug.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for in &mut signature { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pe/utils.rs:64:48 [INFO] [stderr] | [INFO] [stderr] 64 | find_offset(rva, sections, file_alignment).ok_or(error::Error::Malformed(msg.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::Error::Malformed(msg.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pe/mod.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | / if let &Some(export_table) = optional_header.data_directories.get_export_table() { [INFO] [stderr] 90 | | if let Ok(ed) = export::ExportData::parse(bytes, &export_table, §ions, file_alignment) { [INFO] [stderr] 91 | | debug!("export data {:#?}", ed); [INFO] [stderr] 92 | | exports = export::Export::parse(bytes, &ed, §ions, file_alignment)?; [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | if let Some(export_table) = *optional_header.data_directories.get_export_table() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pe/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | / if let &Some(import_table) = optional_header.data_directories.get_import_table() { [INFO] [stderr] 100 | | let id = if is_64 { [INFO] [stderr] 101 | | import::ImportData::parse::(bytes, &import_table, §ions, file_alignment)? [INFO] [stderr] 102 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 114 | | import_data = Some(id); [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | if let Some(import_table) = *optional_header.data_directories.get_import_table() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pe/mod.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / if let &Some(debug_table) = optional_header.data_directories.get_debug_table() { [INFO] [stderr] 118 | | debug_data = Some(debug::DebugData::parse(bytes, &debug_table, §ions, file_alignment)?); [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | if let Some(debug_table) = *optional_header.data_directories.get_debug_table() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/strtab.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn to_vec(self) -> error::Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/strtab.rs:135:73 [INFO] [stderr] | [INFO] [stderr] 135 | let strtab = unsafe { Strtab::from_raw(bytes.as_ptr(), bytes.len(), '\n' as u8) }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn is_big(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/archive/mod.rs:297:76 [INFO] [stderr] | [INFO] [stderr] 297 | let strtab = strtab::Strtab::parse(buffer, *offset-1, hacked_size, '\n' as u8)?; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:176:23 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn is_big(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:180:33 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn is_little_endian(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn size(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/archive/mod.rs:317:49 [INFO] [stderr] | [INFO] [stderr] 317 | return Err(Error::Malformed(format!("Could not find {:?} in index", name).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Could not find {:?} in index", name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/archive/mod.rs:321:45 [INFO] [stderr] | [INFO] [stderr] 321 | return Err(Error::Malformed(format!("Bad name index {:?} in index", name).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Bad name index {:?} in index", name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:275:53 [INFO] [stderr] | [INFO] [stderr] 275 | Err(error::Error::Malformed(format!("Correct mach magic {:#x} does not have a matching parsing context!", magic).into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Correct mach magic {:#x} does not have a matching parsing context!", magic)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/archive/mod.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | return Err(Error::BadMagic(magic.pread(0)?).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::BadMagic(magic.pread(0)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:299:9 [INFO] [stderr] | [INFO] [stderr] 299 | Elf(elf::Elf<'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 299 | Elf(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/archive/mod.rs:406:24 [INFO] [stderr] | [INFO] [stderr] 406 | let name = name.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 406 | let name = &(*name).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 406 | let name = &str::clone(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/archive/mod.rs:437:34 [INFO] [stderr] | [INFO] [stderr] 437 | Err(Error::Malformed(format!("Cannot extract member {:?}", member).into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Cannot extract member {:?}", member)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/archive/mod.rs:460:9 [INFO] [stderr] | [INFO] [stderr] 460 | self.members.keys().map(|s| *s).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.members.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elf/header.rs:171:26 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn size(ctx: &Ctx) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elf/header.rs:293:28 [INFO] [stderr] | [INFO] [stderr] 293 | return Err(error::Error::BadMagic(magic).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `error::Error::BadMagic(magic)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elf/header.rs:304:25 [INFO] [stderr] | [INFO] [stderr] 304 | Err(error::Error::Malformed(format!("invalid ELF class {:x}", class)).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `error::Error::Malformed(format!("invalid ELF class {:x}", class))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/header.rs:387:34 [INFO] [stderr] | [INFO] [stderr] 387 | e_entry: eh.e_entry as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(eh.e_entry)` [INFO] [stderr] ... [INFO] [stderr] 573 | elf_header_std_impl!(SIZEOF_EHDR, u32); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/header.rs:388:34 [INFO] [stderr] | [INFO] [stderr] 388 | e_phoff: eh.e_phoff as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(eh.e_phoff)` [INFO] [stderr] ... [INFO] [stderr] 573 | elf_header_std_impl!(SIZEOF_EHDR, u32); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/header.rs:389:34 [INFO] [stderr] | [INFO] [stderr] 389 | e_shoff: eh.e_shoff as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(eh.e_shoff)` [INFO] [stderr] ... [INFO] [stderr] 573 | elf_header_std_impl!(SIZEOF_EHDR, u32); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/header.rs:469:21 [INFO] [stderr] | [INFO] [stderr] 469 | bytes.read(&mut elf_header)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 573 | elf_header_std_impl!(SIZEOF_EHDR, u32); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 17 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `goblin`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/header.rs:469:21 [INFO] [stderr] | [INFO] [stderr] 469 | bytes.read(&mut elf_header)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 584 | elf_header_std_impl!(SIZEOF_EHDR, u64); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/elf/program_header.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | pub const PF_X: u32 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elf/program_header.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn size(ctx: &Ctx) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:263:32 [INFO] [stderr] | [INFO] [stderr] 263 | p_offset : ph.p_offset as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_offset)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:264:32 [INFO] [stderr] | [INFO] [stderr] 264 | p_vaddr : ph.p_vaddr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_vaddr)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:265:32 [INFO] [stderr] | [INFO] [stderr] 265 | p_paddr : ph.p_paddr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_paddr)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:266:32 [INFO] [stderr] | [INFO] [stderr] 266 | p_filesz : ph.p_filesz as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_filesz)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:267:32 [INFO] [stderr] | [INFO] [stderr] 267 | p_memsz : ph.p_memsz as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_memsz)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/program_header.rs:268:32 [INFO] [stderr] | [INFO] [stderr] 268 | p_align : ph.p_align as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ph.p_align)` [INFO] [stderr] ... [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/program_header.rs:372:5 [INFO] [stderr] | [INFO] [stderr] 372 | elf_program_header_std_impl!(u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/program_header.rs:408:5 [INFO] [stderr] | [INFO] [stderr] 408 | elf_program_header_std_impl!(u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:289:31 [INFO] [stderr] | [INFO] [stderr] 289 | sh_flags: sh.sh_flags as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_flags)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:290:30 [INFO] [stderr] | [INFO] [stderr] 290 | sh_addr: sh.sh_addr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_addr)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:291:32 [INFO] [stderr] | [INFO] [stderr] 291 | sh_offset: sh.sh_offset as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_offset)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:292:30 [INFO] [stderr] | [INFO] [stderr] 292 | sh_size: sh.sh_size as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_size)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:295:35 [INFO] [stderr] | [INFO] [stderr] 295 | sh_addralign: sh.sh_addralign as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_addralign)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:296:33 [INFO] [stderr] | [INFO] [stderr] 296 | sh_entsize: sh.sh_entsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sh.sh_entsize)` [INFO] [stderr] ... [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/section_header.rs:345:5 [INFO] [stderr] | [INFO] [stderr] 345 | elf_section_header_std_impl!(u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/section_header.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | elf_section_header_std_impl!(u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elf/section_header.rs:403:26 [INFO] [stderr] | [INFO] [stderr] 403 | pub fn size(ctx: &Ctx) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/section_header.rs:411:27 [INFO] [stderr] | [INFO] [stderr] 411 | sh_flags: SHF_ALLOC as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_ALLOC)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/compression_header.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | ch_size: ch.ch_size as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch.ch_size)` [INFO] [stderr] ... [INFO] [stderr] 105 | elf_compression_header_std_impl!(u32); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/compression_header.rs:59:35 [INFO] [stderr] | [INFO] [stderr] 59 | ch_addralign: ch.ch_addralign as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch.ch_addralign)` [INFO] [stderr] ... [INFO] [stderr] 105 | elf_compression_header_std_impl!(u32); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/compression_header.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | elf_compression_header_std_impl!(u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/compression_header.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | elf_compression_header_std_impl!(u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elf/compression_header.rs:183:26 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn size(ctx: &Ctx) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/sym.rs:156:38 [INFO] [stderr] | [INFO] [stderr] 156 | st_value: sym.st_value as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sym.st_value)` [INFO] [stderr] ... [INFO] [stderr] 240 | elf_sym_std_impl!(u32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/sym.rs:157:38 [INFO] [stderr] | [INFO] [stderr] 157 | st_size: sym.st_size as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sym.st_size)` [INFO] [stderr] ... [INFO] [stderr] 240 | elf_sym_std_impl!(u32); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/sym.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | elf_sym_std_impl!(u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/sym.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | elf_sym_std_impl!(u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: item `elf::sym::Symtab<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/elf/sym.rs:445:5 [INFO] [stderr] | [INFO] [stderr] 445 | / impl<'a> Symtab<'a> { [INFO] [stderr] 446 | | /// Parse a table of `count` ELF symbols from `offset`. [INFO] [stderr] 447 | | pub fn parse(bytes: &'a [u8], offset: usize, count: usize, ctx: Ctx) -> Result> { [INFO] [stderr] 448 | | let size = count * Sym::size_with(&ctx); [INFO] [stderr] ... | [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elf/dyn.rs:397:21 [INFO] [stderr] | [INFO] [stderr] 397 | / match strtab.get(dyn.d_val as usize) { [INFO] [stderr] 398 | | Some(Ok(lib)) => needed.push(lib), [INFO] [stderr] 399 | | // FIXME: warn! here [INFO] [stderr] 400 | | _ => (), [INFO] [stderr] 401 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(Ok(lib)) = strtab.get(dyn.d_val as usize) { needed.push(lib) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:449:32 [INFO] [stderr] | [INFO] [stderr] 449 | d_tag: dyn.d_tag as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(dyn.d_tag)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:450:32 [INFO] [stderr] | [INFO] [stderr] 450 | d_val: dyn.d_val as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(dyn.d_val)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:459:39 [INFO] [stderr] | [INFO] [stderr] 459 | tag_to_str(self.d_tag as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.d_tag)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:472:44 [INFO] [stderr] | [INFO] [stderr] 472 | try!(fd.seek(Start(phdr.p_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(phdr.p_offset)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/dyn.rs:666:5 [INFO] [stderr] | [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:487:23 [INFO] [stderr] | [INFO] [stderr] 487 | while (*dynp.offset(idx)).d_tag as u64 != DT_NULL { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((*dynp.offset(idx)).d_tag)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:510:24 [INFO] [stderr] | [INFO] [stderr] 510 | if dyn.d_tag as u64 == DT_NEEDED { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(dyn.d_tag)` [INFO] [stderr] ... [INFO] [stderr] 666 | elf_dyn_std_impl!(u32, ::elf32::program_header::ProgramHeader); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/dyn.rs:576:23 [INFO] [stderr] | [INFO] [stderr] 576 | match dyn.d_tag as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(dyn.d_tag)` [INFO] [stderr] ... [INFO] [stderr] 667 | elf_dynamic_info_std_impl!(u32, ::elf::program_header::program_header32::ProgramHeader); [INFO] [stderr] | ---------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/dyn.rs:677:5 [INFO] [stderr] | [INFO] [stderr] 677 | elf_dyn_std_impl!(u64, ::elf64::program_header::ProgramHeader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:123:35 [INFO] [stderr] | [INFO] [stderr] 123 | r_offset: rela.r_offset as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rela.r_offset)` [INFO] [stderr] ... [INFO] [stderr] 222 | elf_rela_std_impl!(u32, i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:124:40 [INFO] [stderr] | [INFO] [stderr] 124 | r_addend: Some(rela.r_addend as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(rela.r_addend)` [INFO] [stderr] ... [INFO] [stderr] 222 | elf_rela_std_impl!(u32, i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:134:35 [INFO] [stderr] | [INFO] [stderr] 134 | r_offset: rel.r_offset as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rel.r_offset)` [INFO] [stderr] ... [INFO] [stderr] 222 | elf_rela_std_impl!(u32, i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/reloc.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | fd.read(plain::as_mut_bytes(&mut *relocs))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 222 | elf_rela_std_impl!(u32, i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:144:62 [INFO] [stderr] | [INFO] [stderr] 144 | let r_info = r_info(rela.r_sym as $size, rela.r_type as $size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rela.r_type)` [INFO] [stderr] ... [INFO] [stderr] 249 | elf_rela_std_impl!(u64, i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf/reloc.rs:155:61 [INFO] [stderr] | [INFO] [stderr] 155 | let r_info = r_info(rel.r_sym as $size, rel.r_type as $size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rel.r_type)` [INFO] [stderr] ... [INFO] [stderr] 249 | elf_rela_std_impl!(u64, i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/elf/reloc.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | fd.read(plain::as_mut_bytes(&mut *relocs))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 249 | elf_rela_std_impl!(u64, i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: item `elf::reloc::RelocSection<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/elf/reloc.rs:406:5 [INFO] [stderr] | [INFO] [stderr] 406 | / impl<'a> RelocSection<'a> { [INFO] [stderr] 407 | | #[cfg(feature = "endian_fd")] [INFO] [stderr] 408 | | /// Parse a REL or RELA section of size `filesz` from `offset`. [INFO] [stderr] 409 | | pub fn parse(bytes: &'a [u8], offset: usize, filesz: usize, is_rela: bool, ctx: Ctx) -> ::error::Result> { [INFO] [stderr] ... | [INFO] [stderr] 445 | | } [INFO] [stderr] 446 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elf/note.rs:83:40 [INFO] [stderr] | [INFO] [stderr] 83 | Err(e) => Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/elf/mod.rs:212:28 [INFO] [stderr] | [INFO] [stderr] 212 | return Err(error::Error::Malformed(format!("Unknown values in ELF ident header: class: {} endianness: {}", [INFO] [stderr] | ____________________________^ [INFO] [stderr] 213 | | class, [INFO] [stderr] 214 | | header.e_ident[header::EI_DATA])).into()); [INFO] [stderr] | |___________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 212 | return Err(error::Error::Malformed(format!("Unknown values in ELF ident header: class: {} endianness: {}", [INFO] [stderr] 213 | class, [INFO] [stderr] 214 | header.e_ident[header::EI_DATA]))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elf/mod.rs:417:25 [INFO] [stderr] | [INFO] [stderr] 417 | assert!(binary.section_headers.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!binary.section_headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &syms.enumerate()` or similar iterators [INFO] [stderr] --> src/elf/mod.rs:418:28 [INFO] [stderr] | [INFO] [stderr] 418 | for sym in &syms { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elf/mod.rs:427:25 [INFO] [stderr] | [INFO] [stderr] 427 | assert!(syms.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!syms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elf/mod.rs:448:25 [INFO] [stderr] | [INFO] [stderr] 448 | assert!(binary.section_headers.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!binary.section_headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &syms.enumerate()` or similar iterators [INFO] [stderr] --> src/elf/mod.rs:449:28 [INFO] [stderr] | [INFO] [stderr] 449 | for sym in &syms { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elf/mod.rs:458:25 [INFO] [stderr] | [INFO] [stderr] 458 | assert!(syms.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!syms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/elf/gnu_hash.rs:31:59 [INFO] [stderr] | [INFO] [stderr] 31 | hash = hash.wrapping_mul(32).wrapping_add(*b as u32).wrapping_add(hash); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | elf_gnu_hash_impl!(u32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/elf/gnu_hash.rs:55:35 [INFO] [stderr] | [INFO] [stderr] 55 | let buckets_ptr = bloomwords_ptr.offset(maskwords as isize) as *const u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bloomwords_ptr.add(maskwords)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | elf_gnu_hash_impl!(u32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/elf/gnu_hash.rs:31:59 [INFO] [stderr] | [INFO] [stderr] 31 | hash = hash.wrapping_mul(32).wrapping_add(*b as u32).wrapping_add(hash); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | elf_gnu_hash_impl!(u64); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u32` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/elf/gnu_hash.rs:54:38 [INFO] [stderr] | [INFO] [stderr] 54 | let bloomwords_ptr = hashtab.offset(4) as *const $size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | elf_gnu_hash_impl!(u64); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/elf/gnu_hash.rs:55:35 [INFO] [stderr] | [INFO] [stderr] 55 | let buckets_ptr = bloomwords_ptr.offset(maskwords as isize) as *const u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bloomwords_ptr.add(maskwords)` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | elf_gnu_hash_impl!(u64); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/header.rs:323:21 [INFO] [stderr] | [INFO] [stderr] 323 | pub fn new(ctx: &container::Ctx) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `container::Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mach/header.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | / match container { [INFO] [stderr] 360 | | &Container::Little => { [INFO] [stderr] 361 | | SIZEOF_HEADER_32 [INFO] [stderr] 362 | | }, [INFO] [stderr] ... | [INFO] [stderr] 365 | | }, [INFO] [stderr] 366 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 359 | match *container { [INFO] [stderr] 360 | Container::Little => { [INFO] [stderr] 361 | SIZEOF_HEADER_32 [INFO] [stderr] 362 | }, [INFO] [stderr] 363 | Container::Big => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/mach/header.rs:376:49 [INFO] [stderr] | [INFO] [stderr] 376 | let error = error::Error::Malformed(format!("bytes size is smaller than a Mach-o header")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bytes size is smaller than a Mach-o header".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/fat.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn from_bytes(bytes: &[u8; SIZEOF_FAT_HEADER]) -> FatHeader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[u8; SIZEOF_FAT_HEADER]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/mach/fat.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | try!(fd.read(&mut header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:421:20 [INFO] [stderr] | [INFO] [stderr] 421 | Ok(eip as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(eip)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:448:24 [INFO] [stderr] | [INFO] [stderr] 448 | (self.thread_state[32] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:449:24 [INFO] [stderr] | [INFO] [stderr] 449 | | ((self.thread_state[33] as u64) << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[33])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:461:20 [INFO] [stderr] | [INFO] [stderr] 461 | Ok(pc as u64) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:474:24 [INFO] [stderr] | [INFO] [stderr] 474 | (self.thread_state[64] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[64])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:475:24 [INFO] [stderr] | [INFO] [stderr] 475 | | ((self.thread_state[65] as u64) << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[65])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/load_command.rs:481:20 [INFO] [stderr] | [INFO] [stderr] 481 | Ok(self.thread_state[0] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.thread_state[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `thread_state` [INFO] [stderr] --> src/mach/load_command.rs:522:18 [INFO] [stderr] | [INFO] [stderr] 522 | for i in 0..count as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 522 | for (i, ) in thread_state.iter_mut().enumerate().take(count as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mach::load_command::SymtabCommand` [INFO] [stderr] --> src/mach/load_command.rs:611:5 [INFO] [stderr] | [INFO] [stderr] 611 | / pub fn new() -> Self { [INFO] [stderr] 612 | | SymtabCommand { [INFO] [stderr] 613 | | cmd: LC_SYMTAB, [INFO] [stderr] 614 | | cmdsize: SIZEOF_SYMTAB_COMMAND as u32, [INFO] [stderr] ... | [INFO] [stderr] 619 | | } [INFO] [stderr] 620 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 601 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mach::load_command::DysymtabCommand` [INFO] [stderr] --> src/mach/load_command.rs:707:5 [INFO] [stderr] | [INFO] [stderr] 707 | / pub fn new() -> Self { [INFO] [stderr] 708 | | DysymtabCommand { [INFO] [stderr] 709 | | cmd: LC_DYSYMTAB, [INFO] [stderr] 710 | | cmdsize: SIZEOF_DYSYMTAB_COMMAND as u32, [INFO] [stderr] ... | [INFO] [stderr] 729 | | } [INFO] [stderr] 730 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 665 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/mach/load_command.rs:1268:5 [INFO] [stderr] | [INFO] [stderr] 1268 | Unixthread (ThreadCommand), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 1268 | Unixthread (Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mach/load_command.rs:1370:138 [INFO] [stderr] | [INFO] [stderr] 1370 | _ => Ok((Unimplemented (lc.clone()), size)), [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `lc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/symbols.rs:213:22 [INFO] [stderr] | [INFO] [stderr] 213 | n_value: nlist.n_value as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(nlist.n_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mach/symbols.rs:343:43 [INFO] [stderr] | [INFO] [stderr] 343 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/mach/exports.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn to_str(kind: SymbolKind) -> &'static str { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mach/exports.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | let offset = &mut start.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mach/exports.rs:236:22 [INFO] [stderr] | [INFO] [stderr] 236 | let offset = self.location.start.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.location.start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/mach/exports.rs:248:19 [INFO] [stderr] | [INFO] [stderr] 248 | data: bytes.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/mach/imports.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | data: bytes.as_ref(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/imports.rs:144:81 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn imports(&self, libs: &[&'a str], segments: &[segment::Segment], ctx: &container::Ctx) -> error::Result>>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `container::Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/imports.rs:150:88 [INFO] [stderr] | [INFO] [stderr] 150 | fn run(&self, is_lazy: bool, libs: &[&'a str], segments: &[segment::Segment], ctx: &container::Ctx, imports: &mut Vec>) -> error::Result<()>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider passing by value instead: `container::Ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mach/imports.rs:158:27 [INFO] [stderr] | [INFO] [stderr] 158 | let offset = &mut location.start.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `location.start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/imports.rs:247:72 [INFO] [stderr] | [INFO] [stderr] 247 | let seg_offset = bind_info.seg_offset.wrapping_add(scale as u64 * size).wrapping_add(size); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn r_symbolnum(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn r_pcrel(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn r_length(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn r_extern(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn r_type(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn is_extern(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn is_pic(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mach/relocation.rs:78:19 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn to_str(&self, cputype: mach::cputype::CpuType) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | addr: section.addr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section.addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | size: section.size as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mach/segment.rs:258:36 [INFO] [stderr] | [INFO] [stderr] 258 | Err(e) => Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:430:23 [INFO] [stderr] | [INFO] [stderr] 430 | vmaddr: segment.vmaddr as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.vmaddr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:431:23 [INFO] [stderr] | [INFO] [stderr] 431 | vmsize: segment.vmsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.vmsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:432:23 [INFO] [stderr] | [INFO] [stderr] 432 | fileoff: segment.fileoff as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.fileoff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/segment.rs:433:23 [INFO] [stderr] | [INFO] [stderr] 433 | filesize: segment.filesize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.filesize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/mach/mod.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / if let &Some(ref symbols) = &self.symbols { [INFO] [stderr] 101 | | symbols.into_iter() [INFO] [stderr] 102 | | } else { [INFO] [stderr] 103 | | symbols::SymbolIterator::default() [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | if let Some(ref symbols) = self.symbols { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/mach/mod.rs:139:97 [INFO] [stderr] | [INFO] [stderr] 139 | let ctx = if let Some(ctx) = maybe_ctx { ctx } else { return Err(error::Error::BadMagic(magic as u64)) }; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(magic)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mach/mod.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | *offset = *offset + header::Header::size_with(&ctx.container); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*offset += header::Header::size_with(&ctx.container)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mach/mod.rs:345:48 [INFO] [stderr] | [INFO] [stderr] 345 | return Err(error::Error::Malformed(format!("Requested the {}-th binary, but there are only {} architectures in this container", index, self.narches).into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Requested the {}-th binary, but there are only {} architectures in this container", index, self.narches)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/mach/mod.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | Binary(MachO<'a>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 386 | Binary(Box>) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/mach/mod.rs:395:40 [INFO] [stderr] | [INFO] [stderr] 395 | format!("size is smaller than a magical number")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"size is smaller than a magical number".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | size_of_code: fields.size_of_code as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:66:39 [INFO] [stderr] | [INFO] [stderr] 66 | size_of_initialized_data: fields.size_of_initialized_data as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_initialized_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | size_of_uninitialized_data: fields.size_of_uninitialized_data as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_uninitialized_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:68:37 [INFO] [stderr] | [INFO] [stderr] 68 | address_of_entry_point: fields.address_of_entry_point as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.address_of_entry_point)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | base_of_code: fields.base_of_code as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.base_of_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:81:27 [INFO] [stderr] | [INFO] [stderr] 81 | size_of_code: fields.size_of_code as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:82:39 [INFO] [stderr] | [INFO] [stderr] 82 | size_of_initialized_data: fields.size_of_initialized_data as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_initialized_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:83:41 [INFO] [stderr] | [INFO] [stderr] 83 | size_of_uninitialized_data: fields.size_of_uninitialized_data as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.size_of_uninitialized_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:84:37 [INFO] [stderr] | [INFO] [stderr] 84 | address_of_entry_point: fields.address_of_entry_point as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.address_of_entry_point)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:85:27 [INFO] [stderr] | [INFO] [stderr] 85 | base_of_code: fields.base_of_code as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fields.base_of_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | image_base: windows.image_base as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.image_base)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:200:36 [INFO] [stderr] | [INFO] [stderr] 200 | size_of_stack_reserve: windows.size_of_stack_reserve as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.size_of_stack_reserve)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:201:35 [INFO] [stderr] | [INFO] [stderr] 201 | size_of_stack_commit: windows.size_of_stack_commit as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.size_of_stack_commit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:202:35 [INFO] [stderr] | [INFO] [stderr] 202 | size_of_heap_reserve: windows.size_of_heap_reserve as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.size_of_heap_reserve)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:203:34 [INFO] [stderr] | [INFO] [stderr] 203 | size_of_heap_commit: windows.size_of_heap_commit as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(windows.size_of_heap_commit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:257:44 [INFO] [stderr] | [INFO] [stderr] 257 | Err(error::Error::BadMagic(magic as u64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(magic)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/pe/optional_header.rs:280:52 [INFO] [stderr] | [INFO] [stderr] 280 | _ => return Err(error::Error::BadMagic(magic as u64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(magic)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `c - b'A'` [INFO] [stderr] --> src/pe/section_table.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | c - b'A' + 00 // 00..=25 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `name`. [INFO] [stderr] --> src/pe/section_table.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 53 | for in &mut name { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `data_directories`. [INFO] [stderr] --> src/pe/data_directories.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 31 | for in data_directories.iter_mut().take(count) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pe/export.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn parse(bytes: &'a [u8], dd: &data_directories::DataDirectory, sections: &[section_table::SectionTable], file_alignment: u32) -> error::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `data_directories::DataDirectory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/pe/export.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / match c { [INFO] [stderr] 159 | | // '.' [INFO] [stderr] 160 | | 0x2e => { [INFO] [stderr] 161 | | let i = o - 1; [INFO] [stderr] ... | [INFO] [stderr] 184 | | _ => {} [INFO] [stderr] 185 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 158 | if let 0x2e = c { [INFO] [stderr] 159 | let i = o - 1; [INFO] [stderr] 160 | let dll: &'a str = bytes.pread_with(0, ::scroll::ctx::StrCtx::Length(i))?; [INFO] [stderr] 161 | debug!("dll: {:?}", &dll); [INFO] [stderr] 162 | let len = reexport_len - i - 1; [INFO] [stderr] 163 | let rest: &'a [u8] = bytes.pread_with(o, len)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/pe/export.rs:224:20 [INFO] [stderr] | [INFO] [stderr] 224 | let name = utils::find_offset(ptr as usize, sections, file_alignment).map_or(None, |offset| bytes.pread::<&str>(offset).ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `utils::find_offset(ptr as usize, sections, file_alignment).and_then(|offset| bytes.pread::<&str>(offset).ok())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pe/import.rs:160:151 [INFO] [stderr] | [INFO] [stderr] 160 | let import_address_table_offset = &mut utils::find_offset(import_directory_entry.import_address_table_rva as usize, sections, file_alignment).ok_or(error::Error::Malformed(format!("Cannot map import_address_table_rva {:#x} into offset for {}", import_directory_entry.import_address_table_rva, name)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::Error::Malformed(format!("Cannot map import_address_table_rva {:#x} into offset for {}", import_directory_entry.import_address_table_rva, name)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pe/import.rs:182:55 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn parse>(bytes: &'a[u8], dd: &data_directories::DataDirectory, sections: &[section_table::SectionTable], file_alignment: u32) -> error::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `data_directories::DataDirectory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pe/import.rs:185:100 [INFO] [stderr] | [INFO] [stderr] 185 | let offset = &mut utils::find_offset(import_directory_table_rva, sections, file_alignment).ok_or(error::Error::Malformed(format!("Cannot create ImportData; cannot map import_directory_table_rva {:#x} into offset", import_directory_table_rva)))?;; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::Error::Malformed(format!("Cannot create ImportData; cannot map import_directory_table_rva {:#x} into offset", import_directory_table_rva)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pe/import.rs:227:25 [INFO] [stderr] | [INFO] [stderr] 227 | / match entry { [INFO] [stderr] 228 | | &HintNameTableRVA ((rva, ref hint_entry)) => { [INFO] [stderr] 229 | | // if hint_entry.name = "" && hint_entry.hint = 0 { [INFO] [stderr] 230 | | // println!(" warning hint/name table rva from {} without hint {:#x}", dll, rva); [INFO] [stderr] ... | [INFO] [stderr] 237 | | }, [INFO] [stderr] 238 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 227 | match *entry { [INFO] [stderr] 228 | HintNameTableRVA ((rva, ref hint_entry)) => { [INFO] [stderr] 229 | // if hint_entry.name = "" && hint_entry.hint = 0 { [INFO] [stderr] 230 | // println!(" warning hint/name table rva from {} without hint {:#x}", dll, rva); [INFO] [stderr] 231 | // } [INFO] [stderr] 232 | (rva, Cow::Borrowed(hint_entry.name), hint_entry.hint.clone()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/pe/import.rs:232:71 [INFO] [stderr] | [INFO] [stderr] 232 | (rva, Cow::Borrowed(hint_entry.name), hint_entry.hint.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `hint_entry.hint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pe/debug.rs:15:39 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn parse(bytes: &'a [u8], dd: &data_directories::DataDirectory, sections: &[section_table::SectionTable], file_alignment: u32) -> error::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `data_directories::DataDirectory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pe/debug.rs:57:32 [INFO] [stderr] | [INFO] [stderr] 57 | fn parse(bytes: &[u8], dd: &data_directories::DataDirectory, sections: &[section_table::SectionTable], file_alignment: u32) -> error::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `data_directories::DataDirectory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pe/debug.rs:59:72 [INFO] [stderr] | [INFO] [stderr] 59 | let offset = utils::find_offset(rva, sections, file_alignment).ok_or(error::Error::Malformed(format!("Cannot map ImageDebugDirectory rva {:#x} into offset", rva)))?;; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::Error::Malformed(format!("Cannot map ImageDebugDirectory rva {:#x} into offset", rva)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `signature`. [INFO] [stderr] --> src/pe/debug.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for in &mut signature { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/pe/utils.rs:64:48 [INFO] [stderr] | [INFO] [stderr] 64 | find_offset(rva, sections, file_alignment).ok_or(error::Error::Malformed(msg.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::Error::Malformed(msg.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pe/mod.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | / if let &Some(export_table) = optional_header.data_directories.get_export_table() { [INFO] [stderr] 90 | | if let Ok(ed) = export::ExportData::parse(bytes, &export_table, §ions, file_alignment) { [INFO] [stderr] 91 | | debug!("export data {:#?}", ed); [INFO] [stderr] 92 | | exports = export::Export::parse(bytes, &ed, §ions, file_alignment)?; [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | if let Some(export_table) = *optional_header.data_directories.get_export_table() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pe/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | / if let &Some(import_table) = optional_header.data_directories.get_import_table() { [INFO] [stderr] 100 | | let id = if is_64 { [INFO] [stderr] 101 | | import::ImportData::parse::(bytes, &import_table, §ions, file_alignment)? [INFO] [stderr] 102 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 114 | | import_data = Some(id); [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | if let Some(import_table) = *optional_header.data_directories.get_import_table() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pe/mod.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / if let &Some(debug_table) = optional_header.data_directories.get_debug_table() { [INFO] [stderr] 118 | | debug_data = Some(debug::DebugData::parse(bytes, &debug_table, §ions, file_alignment)?); [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | if let Some(debug_table) = *optional_header.data_directories.get_debug_table() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/archive/mod.rs:297:76 [INFO] [stderr] | [INFO] [stderr] 297 | let strtab = strtab::Strtab::parse(buffer, *offset-1, hacked_size, '\n' as u8)?; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/archive/mod.rs:317:49 [INFO] [stderr] | [INFO] [stderr] 317 | return Err(Error::Malformed(format!("Could not find {:?} in index", name).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Could not find {:?} in index", name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/archive/mod.rs:321:45 [INFO] [stderr] | [INFO] [stderr] 321 | return Err(Error::Malformed(format!("Bad name index {:?} in index", name).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Bad name index {:?} in index", name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/archive/mod.rs:351:24 [INFO] [stderr] | [INFO] [stderr] 351 | return Err(Error::BadMagic(magic.pread(0)?).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::BadMagic(magic.pread(0)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/archive/mod.rs:406:24 [INFO] [stderr] | [INFO] [stderr] 406 | let name = name.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 406 | let name = &(*name).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 406 | let name = &str::clone(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/archive/mod.rs:437:34 [INFO] [stderr] | [INFO] [stderr] 437 | Err(Error::Malformed(format!("Cannot extract member {:?}", member).into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Cannot extract member {:?}", member)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/archive/mod.rs:460:9 [INFO] [stderr] | [INFO] [stderr] 460 | self.members.keys().map(|s| *s).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.members.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to 17 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `goblin`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ff96d7f306a850a85fbc393c470a979b232a9e80641260cfae03a6b64083a1b4"` [INFO] running `"docker" "rm" "-f" "ff96d7f306a850a85fbc393c470a979b232a9e80641260cfae03a6b64083a1b4"` [INFO] [stdout] ff96d7f306a850a85fbc393c470a979b232a9e80641260cfae03a6b64083a1b4