[INFO] crate gobject-subclass 0.2.1 is already in cache [INFO] extracting crate gobject-subclass 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/gobject-subclass/0.2.1 [INFO] extracting crate gobject-subclass 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gobject-subclass/0.2.1 [INFO] validating manifest of gobject-subclass-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gobject-subclass-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gobject-subclass-0.2.1 [INFO] finished frobbing gobject-subclass-0.2.1 [INFO] frobbed toml for gobject-subclass-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/gobject-subclass/0.2.1/Cargo.toml [INFO] started frobbing gobject-subclass-0.2.1 [INFO] finished frobbing gobject-subclass-0.2.1 [INFO] frobbed toml for gobject-subclass-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gobject-subclass/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gobject-subclass-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gobject-subclass/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 96936b8334decd7040386ad5391451e45865d6b59d705c89e25e648e0130ce14 [INFO] running `"docker" "start" "-a" "96936b8334decd7040386ad5391451e45865d6b59d705c89e25e648e0130ce14"` [INFO] [stderr] Checking gobject-subclass v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&&(dyn for<'r, 's> std::ops::Fn(&'r mut glib::Value, &'s glib::Value) -> bool + std::marker::Sync + std::marker::Send + 'static)`) [INFO] [stderr] --> src/object.rs:252:50 [INFO] [stderr] | [INFO] [stderr] 252 | + 'static) = mem::transmute(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(data as *const &(dyn for<'r, 's> std::ops::Fn(&'r mut glib::Value, &'s glib::Value) -> bool + std::marker::Sync + std::marker::Send + 'static))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/object.rs:337:5 [INFO] [stderr] | [INFO] [stderr] 337 | parent_klass.finalize.map(|f| f(obj)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = parent_klass.finalize { f(obj) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/object.rs:515:13 [INFO] [stderr] | [INFO] [stderr] 515 | / (*parent_klass) [INFO] [stderr] 516 | | .constructed [INFO] [stderr] 517 | | .map(|f| f(self.to_glib_none().0));; [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 515 | if let Some(f) = (*parent_klass) [INFO] [stderr] 516 | .constructed { f(self.to_glib_none().0) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/object.rs:522:1 [INFO] [stderr] | [INFO] [stderr] 522 | / glib_wrapper! { [INFO] [stderr] 523 | | pub struct Object(Object>); [INFO] [stderr] 524 | | [INFO] [stderr] 525 | | match fn { [INFO] [stderr] 526 | | get_type => || get_type::(), [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/object.rs:522:1 [INFO] [stderr] | [INFO] [stderr] 522 | / glib_wrapper! { [INFO] [stderr] 523 | | pub struct Object(Object>); [INFO] [stderr] 524 | | [INFO] [stderr] 525 | | match fn { [INFO] [stderr] 526 | | get_type => || get_type::(), [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/object.rs:522:1 [INFO] [stderr] | [INFO] [stderr] 522 | / glib_wrapper! { [INFO] [stderr] 523 | | pub struct Object(Object>); [INFO] [stderr] 524 | | [INFO] [stderr] 525 | | match fn { [INFO] [stderr] 526 | | get_type => || get_type::(), [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/object.rs:522:1 [INFO] [stderr] | [INFO] [stderr] 522 | / glib_wrapper! { [INFO] [stderr] 523 | | pub struct Object(Object>); [INFO] [stderr] 524 | | [INFO] [stderr] 525 | | match fn { [INFO] [stderr] 526 | | get_type => || get_type::(), [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&&(dyn for<'r, 's> std::ops::Fn(&'r mut glib::Value, &'s glib::Value) -> bool + std::marker::Sync + std::marker::Send + 'static)`) [INFO] [stderr] --> src/object.rs:252:50 [INFO] [stderr] | [INFO] [stderr] 252 | + 'static) = mem::transmute(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(data as *const &(dyn for<'r, 's> std::ops::Fn(&'r mut glib::Value, &'s glib::Value) -> bool + std::marker::Sync + std::marker::Send + 'static))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/object.rs:337:5 [INFO] [stderr] | [INFO] [stderr] 337 | parent_klass.finalize.map(|f| f(obj)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(f) = parent_klass.finalize { f(obj) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/object.rs:515:13 [INFO] [stderr] | [INFO] [stderr] 515 | / (*parent_klass) [INFO] [stderr] 516 | | .constructed [INFO] [stderr] 517 | | .map(|f| f(self.to_glib_none().0));; [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 515 | if let Some(f) = (*parent_klass) [INFO] [stderr] 516 | .constructed { f(self.to_glib_none().0) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/object.rs:522:1 [INFO] [stderr] | [INFO] [stderr] 522 | / glib_wrapper! { [INFO] [stderr] 523 | | pub struct Object(Object>); [INFO] [stderr] 524 | | [INFO] [stderr] 525 | | match fn { [INFO] [stderr] 526 | | get_type => || get_type::(), [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/object.rs:522:1 [INFO] [stderr] | [INFO] [stderr] 522 | / glib_wrapper! { [INFO] [stderr] 523 | | pub struct Object(Object>); [INFO] [stderr] 524 | | [INFO] [stderr] 525 | | match fn { [INFO] [stderr] 526 | | get_type => || get_type::(), [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/object.rs:522:1 [INFO] [stderr] | [INFO] [stderr] 522 | / glib_wrapper! { [INFO] [stderr] 523 | | pub struct Object(Object>); [INFO] [stderr] 524 | | [INFO] [stderr] 525 | | match fn { [INFO] [stderr] 526 | | get_type => || get_type::(), [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/object.rs:522:1 [INFO] [stderr] | [INFO] [stderr] 522 | / glib_wrapper! { [INFO] [stderr] 523 | | pub struct Object(Object>); [INFO] [stderr] 524 | | [INFO] [stderr] 525 | | match fn { [INFO] [stderr] 526 | | get_type => || get_type::(), [INFO] [stderr] 527 | | } [INFO] [stderr] 528 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> tests/simple_object.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / fn new(&self, obj: &Object) -> Box> { [INFO] [stderr] 119 | | SimpleObject::init(obj) [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> tests/simple_object.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / glib_wrapper! { [INFO] [stderr] 129 | | pub struct SimpleObject(Object): [INFO] [stderr] 130 | | [Object => InstanceStruct]; [INFO] [stderr] 131 | | [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> tests/simple_object.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / glib_wrapper! { [INFO] [stderr] 129 | | pub struct SimpleObject(Object): [INFO] [stderr] 130 | | [Object => InstanceStruct]; [INFO] [stderr] 131 | | [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> tests/simple_object.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / glib_wrapper! { [INFO] [stderr] 129 | | pub struct SimpleObject(Object): [INFO] [stderr] 130 | | [Object => InstanceStruct]; [INFO] [stderr] 131 | | [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> tests/simple_object.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / glib_wrapper! { [INFO] [stderr] 129 | | pub struct SimpleObject(Object): [INFO] [stderr] 130 | | [Object => InstanceStruct]; [INFO] [stderr] 131 | | [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.43s [INFO] running `"docker" "inspect" "96936b8334decd7040386ad5391451e45865d6b59d705c89e25e648e0130ce14"` [INFO] running `"docker" "rm" "-f" "96936b8334decd7040386ad5391451e45865d6b59d705c89e25e648e0130ce14"` [INFO] [stdout] 96936b8334decd7040386ad5391451e45865d6b59d705c89e25e648e0130ce14