[INFO] crate glutin 0.19.0 is already in cache [INFO] extracting crate glutin 0.19.0 into work/ex/clippy-test-run/sources/stable/reg/glutin/0.19.0 [INFO] extracting crate glutin 0.19.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glutin/0.19.0 [INFO] validating manifest of glutin-0.19.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of glutin-0.19.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing glutin-0.19.0 [INFO] finished frobbing glutin-0.19.0 [INFO] frobbed toml for glutin-0.19.0 written to work/ex/clippy-test-run/sources/stable/reg/glutin/0.19.0/Cargo.toml [INFO] started frobbing glutin-0.19.0 [INFO] finished frobbing glutin-0.19.0 [INFO] frobbed toml for glutin-0.19.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/glutin/0.19.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting glutin-0.19.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/glutin/0.19.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35368e4b33f0dece86a90e334a7672881384b341b546f6366fac261d43240cdb [INFO] running `"docker" "start" "-a" "35368e4b33f0dece86a90e334a7672881384b341b546f6366fac261d43240cdb"` [INFO] [stderr] Compiling glutin v0.19.0 (/opt/crater/workdir) [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/caca/mod.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | libcaca: libcaca, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `libcaca` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/caca/mod.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/caca/mod.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | opengl: opengl, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opengl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/caca/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | dither: dither, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `dither` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | opengl: opengl, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opengl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | egl: egl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `egl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | egl_version: egl_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `egl_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | config_id: config_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | pixel_format: pixel_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:498:13 [INFO] [stderr] | [INFO] [stderr] 498 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/make_current_guard.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | previous_hdc: previous_hdc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_hdc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/make_current_guard.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | previous_hglrc: previous_hglrc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_hglrc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/mod.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | hdc: hdc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `hdc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/mod.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | gl_library: gl_library, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gl_library` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/mod.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | pixel_format: pixel_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/wayland.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/x11.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | glx: glx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `glx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/x11.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | egl: egl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `egl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/caca/mod.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | libcaca: libcaca, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `libcaca` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/caca/mod.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/caca/mod.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | opengl: opengl, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opengl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/caca/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | dither: dither, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `dither` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | opengl: opengl, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opengl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | egl: egl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `egl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | egl_version: egl_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `egl_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | config_id: config_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | pixel_format: pixel_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/egl/mod.rs:498:13 [INFO] [stderr] | [INFO] [stderr] 498 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/make_current_guard.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | previous_hdc: previous_hdc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_hdc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/make_current_guard.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | previous_hglrc: previous_hglrc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_hglrc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/mod.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | hdc: hdc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `hdc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/mod.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | gl_library: gl_library, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gl_library` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/wgl/mod.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | pixel_format: pixel_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/wayland.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | context: context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/x11.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | glx: glx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `glx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/x11.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | egl: egl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `egl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/api/caca/mod.rs:47:69 [INFO] [stderr] | [INFO] [stderr] 47 | fn get_masks() -> (u32, u32, u32, u32) { (0xff, 0xff00, 0xff0000, 0xff000000) } [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/api/caca/mod.rs:47:79 [INFO] [stderr] | [INFO] [stderr] 47 | fn get_masks() -> (u32, u32, u32, u32) { (0xff, 0xff00, 0xff0000, 0xff000000) } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:126:114 [INFO] [stderr] | [INFO] [stderr] 126 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_COMPATIBILITY_PROFILE_BIT: types::EGLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:127:118 [INFO] [stderr] | [INFO] [stderr] 127 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_COMPATIBILITY_PROFILE_BIT_KHR: types::EGLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:128:105 [INFO] [stderr] | [INFO] [stderr] 128 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_CORE_PROFILE_BIT: types::EGLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:129:109 [INFO] [stderr] | [INFO] [stderr] 129 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR: types::EGLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:131:102 [INFO] [stderr] | [INFO] [stderr] 131 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_DEBUG_BIT_KHR: types::EGLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:133:115 [INFO] [stderr] | [INFO] [stderr] 133 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR: types::EGLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:141:110 [INFO] [stderr] | [INFO] [stderr] 141 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR: types::EGLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:151:86 [INFO] [stderr] | [INFO] [stderr] 151 | #[allow(dead_code, non_upper_case_globals)] pub const FOREVER: types::EGLuint64KHR = 0xFFFFFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:207:88 [INFO] [stderr] | [INFO] [stderr] 207 | #[allow(dead_code, non_upper_case_globals)] pub const OPENGL_ES3_BIT: types::EGLenum = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:208:92 [INFO] [stderr] | [INFO] [stderr] 208 | #[allow(dead_code, non_upper_case_globals)] pub const OPENGL_ES3_BIT_KHR: types::EGLenum = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/api/egl/mod.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | / if egl_version >= (1, 2) { [INFO] [stderr] 225 | | if egl.BindAPI(ffi::egl::OPENGL_ES_API) == 0 { [INFO] [stderr] 226 | | return Err(CreationError::OpenGlVersionNotSupported); [INFO] [stderr] 227 | | } [INFO] [stderr] 228 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 224 | if egl_version >= (1, 2) && egl.BindAPI(ffi::egl::OPENGL_ES_API) == 0 { [INFO] [stderr] 225 | return Err(CreationError::OpenGlVersionNotSupported); [INFO] [stderr] 226 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/egl/mod.rs:279:43 [INFO] [stderr] | [INFO] [stderr] 279 | ffi::egl::CONTEXT_LOST => return Err(ContextError::ContextLost), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ContextError::ContextLost)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/egl/mod.rs:313:43 [INFO] [stderr] | [INFO] [stderr] 313 | ffi::egl::CONTEXT_LOST => return Err(ContextError::ContextLost), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ContextError::ContextLost)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/api/egl/mod.rs:471:20 [INFO] [stderr] | [INFO] [stderr] 471 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 472 | | if let Ok(ctxt) = create_context(&self.egl, self.display, &self.egl_version, [INFO] [stderr] 473 | | &self.extensions, self.api, (3, 2), self.config_id, [INFO] [stderr] 474 | | self.opengl.debug, self.opengl.robustness) [INFO] [stderr] ... | [INFO] [stderr] 491 | | } [INFO] [stderr] 492 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 471 | } else if let Ok(ctxt) = create_context(&self.egl, self.display, &self.egl_version, [INFO] [stderr] 472 | &self.extensions, self.api, (3, 2), self.config_id, [INFO] [stderr] 473 | self.opengl.debug, self.opengl.robustness) [INFO] [stderr] 474 | { [INFO] [stderr] 475 | ctxt [INFO] [stderr] 476 | } else if let Ok(ctxt) = create_context(&self.egl, self.display, &self.egl_version, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/api/egl/mod.rs:741:9 [INFO] [stderr] | [INFO] [stderr] 741 | / if gl_debug { [INFO] [stderr] 742 | | if egl_version >= &(1, 5) { [INFO] [stderr] 743 | | context_attributes.push(ffi::egl::CONTEXT_OPENGL_DEBUG as i32); [INFO] [stderr] 744 | | context_attributes.push(ffi::egl::TRUE as i32); [INFO] [stderr] ... | [INFO] [stderr] 751 | | //flags = flags | ffi::egl::CONTEXT_OPENGL_DEBUG_BIT_KHR as i32; [INFO] [stderr] 752 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 741 | if gl_debug && egl_version >= &(1, 5) { [INFO] [stderr] 742 | context_attributes.push(ffi::egl::CONTEXT_OPENGL_DEBUG as i32); [INFO] [stderr] 743 | context_attributes.push(ffi::egl::TRUE as i32); [INFO] [stderr] 744 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:253:89 [INFO] [stderr] | [INFO] [stderr] 253 | #[allow(dead_code, non_upper_case_globals)] pub const ACCUM_BUFFER_BIT: types::GLenum = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:258:88 [INFO] [stderr] | [INFO] [stderr] 258 | #[allow(dead_code, non_upper_case_globals)] pub const AUX_BUFFERS_BIT: types::GLenum = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:259:93 [INFO] [stderr] | [INFO] [stderr] 259 | #[allow(dead_code, non_upper_case_globals)] pub const BACK_LEFT_BUFFER_BIT: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:260:94 [INFO] [stderr] | [INFO] [stderr] 260 | #[allow(dead_code, non_upper_case_globals)] pub const BACK_RIGHT_BUFFER_BIT: types::GLenum = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:270:88 [INFO] [stderr] | [INFO] [stderr] 270 | #[allow(dead_code, non_upper_case_globals)] pub const COLOR_INDEX_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:274:89 [INFO] [stderr] | [INFO] [stderr] 274 | #[allow(dead_code, non_upper_case_globals)] pub const DEPTH_BUFFER_BIT: types::GLenum = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:277:82 [INFO] [stderr] | [INFO] [stderr] 277 | #[allow(dead_code, non_upper_case_globals)] pub const DONT_CARE: types::GLenum = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:282:72 [INFO] [stderr] | [INFO] [stderr] 282 | #[allow(dead_code, non_upper_case_globals)] pub const EXTENSION_NAME: &'static str = "GLX"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:284:94 [INFO] [stderr] | [INFO] [stderr] 284 | #[allow(dead_code, non_upper_case_globals)] pub const FRONT_LEFT_BUFFER_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:285:95 [INFO] [stderr] | [INFO] [stderr] 285 | #[allow(dead_code, non_upper_case_globals)] pub const FRONT_RIGHT_BUFFER_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:298:84 [INFO] [stderr] | [INFO] [stderr] 298 | #[allow(dead_code, non_upper_case_globals)] pub const PBUFFER_BIT: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:299:93 [INFO] [stderr] | [INFO] [stderr] 299 | #[allow(dead_code, non_upper_case_globals)] pub const PBUFFER_CLOBBER_MASK: types::GLenum = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:302:83 [INFO] [stderr] | [INFO] [stderr] 302 | #[allow(dead_code, non_upper_case_globals)] pub const PIXMAP_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:309:81 [INFO] [stderr] | [INFO] [stderr] 309 | #[allow(dead_code, non_upper_case_globals)] pub const RGBA_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:311:80 [INFO] [stderr] | [INFO] [stderr] 311 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLES: types::GLenum = 100001; [INFO] [stderr] | ^^^^^^ help: consider: `100_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:312:87 [INFO] [stderr] | [INFO] [stderr] 312 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLE_BUFFERS: types::GLenum = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:318:91 [INFO] [stderr] | [INFO] [stderr] 318 | #[allow(dead_code, non_upper_case_globals)] pub const STENCIL_BUFFER_BIT: types::GLenum = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:336:83 [INFO] [stderr] | [INFO] [stderr] 336 | #[allow(dead_code, non_upper_case_globals)] pub const WINDOW_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:495:164 [INFO] [stderr] | [INFO] [stderr] 495 | #[inline] pub unsafe fn CopyContext(&self, dpy: *mut types::Display, src: types::GLXContext, dst: types::GLXContext, mask: __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXContext, types::GLXContext, __gl_imports::raw::c_ulong) -> ()>(self.CopyContext.f)(dpy, src, dst, mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:509:109 [INFO] [stderr] | [INFO] [stderr] 509 | #[inline] pub unsafe fn DestroyContext(&self, dpy: *mut types::Display, ctx: types::GLXContext) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXContext) -> ()>(self.DestroyContext.f)(dpy, ctx) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:511:113 [INFO] [stderr] | [INFO] [stderr] 511 | #[inline] pub unsafe fn DestroyGLXPixmap(&self, dpy: *mut types::Display, pixmap: types::GLXPixmap) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPixmap) -> ()>(self.DestroyGLXPixmap.f)(dpy, pixmap) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:513:110 [INFO] [stderr] | [INFO] [stderr] 513 | #[inline] pub unsafe fn DestroyPbuffer(&self, dpy: *mut types::Display, pbuf: types::GLXPbuffer) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPbuffer) -> ()>(self.DestroyPbuffer.f)(dpy, pbuf) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:515:110 [INFO] [stderr] | [INFO] [stderr] 515 | #[inline] pub unsafe fn DestroyPixmap(&self, dpy: *mut types::Display, pixmap: types::GLXPixmap) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPixmap) -> ()>(self.DestroyPixmap.f)(dpy, pixmap) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:517:107 [INFO] [stderr] | [INFO] [stderr] 517 | #[inline] pub unsafe fn DestroyWindow(&self, dpy: *mut types::Display, win: types::GLXWindow) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXWindow) -> ()>(self.DestroyWindow.f)(dpy, win) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:537:158 [INFO] [stderr] | [INFO] [stderr] 537 | #[inline] pub unsafe fn GetSelectedEvent(&self, dpy: *mut types::Display, draw: types::GLXDrawable, event_mask: *mut __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, *mut __gl_imports::raw::c_ulong) -> ()>(self.GetSelectedEvent.f)(dpy, draw, event_mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:549:186 [INFO] [stderr] | [INFO] [stderr] 549 | #[inline] pub unsafe fn QueryDrawable(&self, dpy: *mut types::Display, draw: types::GLXDrawable, attribute: __gl_imports::raw::c_int, value: *mut __gl_imports::raw::c_uint) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_int, *mut __gl_imports::raw::c_uint) -> ()>(self.QueryDrawable.f)(dpy, draw, attribute, value) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:559:148 [INFO] [stderr] | [INFO] [stderr] 559 | #[inline] pub unsafe fn SelectEvent(&self, dpy: *mut types::Display, draw: types::GLXDrawable, event_mask: __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_ulong) -> ()>(self.SelectEvent.f)(dpy, draw, event_mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:561:112 [INFO] [stderr] | [INFO] [stderr] 561 | #[inline] pub unsafe fn SwapBuffers(&self, dpy: *mut types::Display, drawable: types::GLXDrawable) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable) -> ()>(self.SwapBuffers.f)(dpy, drawable) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:563:170 [INFO] [stderr] | [INFO] [stderr] 563 | #[inline] pub unsafe fn UseXFont(&self, font: types::Font, first: __gl_imports::raw::c_int, count: __gl_imports::raw::c_int, list: __gl_imports::raw::c_int) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(types::Font, __gl_imports::raw::c_int, __gl_imports::raw::c_int, __gl_imports::raw::c_int) -> ()>(self.UseXFont.f)(font, first, count, list) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:565:53 [INFO] [stderr] | [INFO] [stderr] 565 | #[inline] pub unsafe fn WaitGL(&self, ) -> () { __gl_imports::mem::transmute::<_, extern "system" fn() -> ()>(self.WaitGL.f)() } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:567:52 [INFO] [stderr] | [INFO] [stderr] 567 | #[inline] pub unsafe fn WaitX(&self, ) -> () { __gl_imports::mem::transmute::<_, extern "system" fn() -> ()>(self.WaitX.f)() } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:253:89 [INFO] [stderr] | [INFO] [stderr] 253 | #[allow(dead_code, non_upper_case_globals)] pub const ACCUM_BUFFER_BIT: types::GLenum = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:258:88 [INFO] [stderr] | [INFO] [stderr] 258 | #[allow(dead_code, non_upper_case_globals)] pub const AUX_BUFFERS_BIT: types::GLenum = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:259:93 [INFO] [stderr] | [INFO] [stderr] 259 | #[allow(dead_code, non_upper_case_globals)] pub const BACK_LEFT_BUFFER_BIT: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:260:94 [INFO] [stderr] | [INFO] [stderr] 260 | #[allow(dead_code, non_upper_case_globals)] pub const BACK_RIGHT_BUFFER_BIT: types::GLenum = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:270:88 [INFO] [stderr] | [INFO] [stderr] 270 | #[allow(dead_code, non_upper_case_globals)] pub const COLOR_INDEX_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:273:110 [INFO] [stderr] | [INFO] [stderr] 273 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_COMPATIBILITY_PROFILE_BIT_ARB: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:274:101 [INFO] [stderr] | [INFO] [stderr] 274 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_CORE_PROFILE_BIT_ARB: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:275:94 [INFO] [stderr] | [INFO] [stderr] 275 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_DEBUG_BIT_ARB: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:277:107 [INFO] [stderr] | [INFO] [stderr] 277 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_FORWARD_COMPATIBLE_BIT_ARB: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:285:102 [INFO] [stderr] | [INFO] [stderr] 285 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_ROBUST_ACCESS_BIT_ARB: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:287:89 [INFO] [stderr] | [INFO] [stderr] 287 | #[allow(dead_code, non_upper_case_globals)] pub const DEPTH_BUFFER_BIT: types::GLenum = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:290:82 [INFO] [stderr] | [INFO] [stderr] 290 | #[allow(dead_code, non_upper_case_globals)] pub const DONT_CARE: types::GLenum = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:295:72 [INFO] [stderr] | [INFO] [stderr] 295 | #[allow(dead_code, non_upper_case_globals)] pub const EXTENSION_NAME: &'static str = "GLX"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:299:94 [INFO] [stderr] | [INFO] [stderr] 299 | #[allow(dead_code, non_upper_case_globals)] pub const FRONT_LEFT_BUFFER_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:300:95 [INFO] [stderr] | [INFO] [stderr] 300 | #[allow(dead_code, non_upper_case_globals)] pub const FRONT_RIGHT_BUFFER_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:316:84 [INFO] [stderr] | [INFO] [stderr] 316 | #[allow(dead_code, non_upper_case_globals)] pub const PBUFFER_BIT: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:317:93 [INFO] [stderr] | [INFO] [stderr] 317 | #[allow(dead_code, non_upper_case_globals)] pub const PBUFFER_CLOBBER_MASK: types::GLenum = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:320:83 [INFO] [stderr] | [INFO] [stderr] 320 | #[allow(dead_code, non_upper_case_globals)] pub const PIXMAP_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:327:81 [INFO] [stderr] | [INFO] [stderr] 327 | #[allow(dead_code, non_upper_case_globals)] pub const RGBA_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:328:91 [INFO] [stderr] | [INFO] [stderr] 328 | #[allow(dead_code, non_upper_case_globals)] pub const RGBA_FLOAT_BIT_ARB: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:331:80 [INFO] [stderr] | [INFO] [stderr] 331 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLES: types::GLenum = 100001; [INFO] [stderr] | ^^^^^^ help: consider: `100_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:332:84 [INFO] [stderr] | [INFO] [stderr] 332 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLES_ARB: types::GLenum = 100001; [INFO] [stderr] | ^^^^^^ help: consider: `100_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:333:87 [INFO] [stderr] | [INFO] [stderr] 333 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLE_BUFFERS: types::GLenum = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:334:91 [INFO] [stderr] | [INFO] [stderr] 334 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLE_BUFFERS_ARB: types::GLenum = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:340:91 [INFO] [stderr] | [INFO] [stderr] 340 | #[allow(dead_code, non_upper_case_globals)] pub const STENCIL_BUFFER_BIT: types::GLenum = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:359:83 [INFO] [stderr] | [INFO] [stderr] 359 | #[allow(dead_code, non_upper_case_globals)] pub const WINDOW_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:524:164 [INFO] [stderr] | [INFO] [stderr] 524 | #[inline] pub unsafe fn CopyContext(&self, dpy: *mut types::Display, src: types::GLXContext, dst: types::GLXContext, mask: __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXContext, types::GLXContext, __gl_imports::raw::c_ulong) -> ()>(self.CopyContext.f)(dpy, src, dst, mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:540:109 [INFO] [stderr] | [INFO] [stderr] 540 | #[inline] pub unsafe fn DestroyContext(&self, dpy: *mut types::Display, ctx: types::GLXContext) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXContext) -> ()>(self.DestroyContext.f)(dpy, ctx) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:542:113 [INFO] [stderr] | [INFO] [stderr] 542 | #[inline] pub unsafe fn DestroyGLXPixmap(&self, dpy: *mut types::Display, pixmap: types::GLXPixmap) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPixmap) -> ()>(self.DestroyGLXPixmap.f)(dpy, pixmap) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:544:110 [INFO] [stderr] | [INFO] [stderr] 544 | #[inline] pub unsafe fn DestroyPbuffer(&self, dpy: *mut types::Display, pbuf: types::GLXPbuffer) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPbuffer) -> ()>(self.DestroyPbuffer.f)(dpy, pbuf) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:546:110 [INFO] [stderr] | [INFO] [stderr] 546 | #[inline] pub unsafe fn DestroyPixmap(&self, dpy: *mut types::Display, pixmap: types::GLXPixmap) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPixmap) -> ()>(self.DestroyPixmap.f)(dpy, pixmap) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:548:107 [INFO] [stderr] | [INFO] [stderr] 548 | #[inline] pub unsafe fn DestroyWindow(&self, dpy: *mut types::Display, win: types::GLXWindow) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXWindow) -> ()>(self.DestroyWindow.f)(dpy, win) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:568:158 [INFO] [stderr] | [INFO] [stderr] 568 | #[inline] pub unsafe fn GetSelectedEvent(&self, dpy: *mut types::Display, draw: types::GLXDrawable, event_mask: *mut __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, *mut __gl_imports::raw::c_ulong) -> ()>(self.GetSelectedEvent.f)(dpy, draw, event_mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:580:186 [INFO] [stderr] | [INFO] [stderr] 580 | #[inline] pub unsafe fn QueryDrawable(&self, dpy: *mut types::Display, draw: types::GLXDrawable, attribute: __gl_imports::raw::c_int, value: *mut __gl_imports::raw::c_uint) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_int, *mut __gl_imports::raw::c_uint) -> ()>(self.QueryDrawable.f)(dpy, draw, attribute, value) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:590:148 [INFO] [stderr] | [INFO] [stderr] 590 | #[inline] pub unsafe fn SelectEvent(&self, dpy: *mut types::Display, draw: types::GLXDrawable, event_mask: __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_ulong) -> ()>(self.SelectEvent.f)(dpy, draw, event_mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:592:112 [INFO] [stderr] | [INFO] [stderr] 592 | #[inline] pub unsafe fn SwapBuffers(&self, dpy: *mut types::Display, drawable: types::GLXDrawable) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable) -> ()>(self.SwapBuffers.f)(dpy, drawable) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:594:152 [INFO] [stderr] | [INFO] [stderr] 594 | #[inline] pub unsafe fn SwapIntervalEXT(&self, dpy: *mut types::Display, drawable: types::GLXDrawable, interval: __gl_imports::raw::c_int) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_int) -> ()>(self.SwapIntervalEXT.f)(dpy, drawable, interval) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:598:170 [INFO] [stderr] | [INFO] [stderr] 598 | #[inline] pub unsafe fn UseXFont(&self, font: types::Font, first: __gl_imports::raw::c_int, count: __gl_imports::raw::c_int, list: __gl_imports::raw::c_int) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(types::Font, __gl_imports::raw::c_int, __gl_imports::raw::c_int, __gl_imports::raw::c_int) -> ()>(self.UseXFont.f)(font, first, count, list) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:600:53 [INFO] [stderr] | [INFO] [stderr] 600 | #[inline] pub unsafe fn WaitGL(&self, ) -> () { __gl_imports::mem::transmute::<_, extern "system" fn() -> ()>(self.WaitGL.f)() } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:602:52 [INFO] [stderr] | [INFO] [stderr] 602 | #[inline] pub unsafe fn WaitX(&self, ) -> () { __gl_imports::mem::transmute::<_, extern "system" fn() -> ()>(self.WaitX.f)() } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/platform/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod platform; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/api/caca/mod.rs:47:69 [INFO] [stderr] | [INFO] [stderr] 47 | fn get_masks() -> (u32, u32, u32, u32) { (0xff, 0xff00, 0xff0000, 0xff000000) } [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/api/caca/mod.rs:47:79 [INFO] [stderr] | [INFO] [stderr] 47 | fn get_masks() -> (u32, u32, u32, u32) { (0xff, 0xff00, 0xff0000, 0xff000000) } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:126:114 [INFO] [stderr] | [INFO] [stderr] 126 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_COMPATIBILITY_PROFILE_BIT: types::EGLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:127:118 [INFO] [stderr] | [INFO] [stderr] 127 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_COMPATIBILITY_PROFILE_BIT_KHR: types::EGLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:128:105 [INFO] [stderr] | [INFO] [stderr] 128 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_CORE_PROFILE_BIT: types::EGLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:129:109 [INFO] [stderr] | [INFO] [stderr] 129 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR: types::EGLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:131:102 [INFO] [stderr] | [INFO] [stderr] 131 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_DEBUG_BIT_KHR: types::EGLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:133:115 [INFO] [stderr] | [INFO] [stderr] 133 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR: types::EGLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:141:110 [INFO] [stderr] | [INFO] [stderr] 141 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR: types::EGLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:151:86 [INFO] [stderr] | [INFO] [stderr] 151 | #[allow(dead_code, non_upper_case_globals)] pub const FOREVER: types::EGLuint64KHR = 0xFFFFFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:207:88 [INFO] [stderr] | [INFO] [stderr] 207 | #[allow(dead_code, non_upper_case_globals)] pub const OPENGL_ES3_BIT: types::EGLenum = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/egl_bindings.rs:208:92 [INFO] [stderr] | [INFO] [stderr] 208 | #[allow(dead_code, non_upper_case_globals)] pub const OPENGL_ES3_BIT_KHR: types::EGLenum = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/api/egl/mod.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | / if egl_version >= (1, 2) { [INFO] [stderr] 225 | | if egl.BindAPI(ffi::egl::OPENGL_ES_API) == 0 { [INFO] [stderr] 226 | | return Err(CreationError::OpenGlVersionNotSupported); [INFO] [stderr] 227 | | } [INFO] [stderr] 228 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 224 | if egl_version >= (1, 2) && egl.BindAPI(ffi::egl::OPENGL_ES_API) == 0 { [INFO] [stderr] 225 | return Err(CreationError::OpenGlVersionNotSupported); [INFO] [stderr] 226 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/egl/mod.rs:279:43 [INFO] [stderr] | [INFO] [stderr] 279 | ffi::egl::CONTEXT_LOST => return Err(ContextError::ContextLost), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ContextError::ContextLost)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/egl/mod.rs:313:43 [INFO] [stderr] | [INFO] [stderr] 313 | ffi::egl::CONTEXT_LOST => return Err(ContextError::ContextLost), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ContextError::ContextLost)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/api/egl/mod.rs:471:20 [INFO] [stderr] | [INFO] [stderr] 471 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 472 | | if let Ok(ctxt) = create_context(&self.egl, self.display, &self.egl_version, [INFO] [stderr] 473 | | &self.extensions, self.api, (3, 2), self.config_id, [INFO] [stderr] 474 | | self.opengl.debug, self.opengl.robustness) [INFO] [stderr] ... | [INFO] [stderr] 491 | | } [INFO] [stderr] 492 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 471 | } else if let Ok(ctxt) = create_context(&self.egl, self.display, &self.egl_version, [INFO] [stderr] 472 | &self.extensions, self.api, (3, 2), self.config_id, [INFO] [stderr] 473 | self.opengl.debug, self.opengl.robustness) [INFO] [stderr] 474 | { [INFO] [stderr] 475 | ctxt [INFO] [stderr] 476 | } else if let Ok(ctxt) = create_context(&self.egl, self.display, &self.egl_version, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/api/egl/mod.rs:741:9 [INFO] [stderr] | [INFO] [stderr] 741 | / if gl_debug { [INFO] [stderr] 742 | | if egl_version >= &(1, 5) { [INFO] [stderr] 743 | | context_attributes.push(ffi::egl::CONTEXT_OPENGL_DEBUG as i32); [INFO] [stderr] 744 | | context_attributes.push(ffi::egl::TRUE as i32); [INFO] [stderr] ... | [INFO] [stderr] 751 | | //flags = flags | ffi::egl::CONTEXT_OPENGL_DEBUG_BIT_KHR as i32; [INFO] [stderr] 752 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 741 | if gl_debug && egl_version >= &(1, 5) { [INFO] [stderr] 742 | context_attributes.push(ffi::egl::CONTEXT_OPENGL_DEBUG as i32); [INFO] [stderr] 743 | context_attributes.push(ffi::egl::TRUE as i32); [INFO] [stderr] 744 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:253:89 [INFO] [stderr] | [INFO] [stderr] 253 | #[allow(dead_code, non_upper_case_globals)] pub const ACCUM_BUFFER_BIT: types::GLenum = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:258:88 [INFO] [stderr] | [INFO] [stderr] 258 | #[allow(dead_code, non_upper_case_globals)] pub const AUX_BUFFERS_BIT: types::GLenum = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:259:93 [INFO] [stderr] | [INFO] [stderr] 259 | #[allow(dead_code, non_upper_case_globals)] pub const BACK_LEFT_BUFFER_BIT: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:260:94 [INFO] [stderr] | [INFO] [stderr] 260 | #[allow(dead_code, non_upper_case_globals)] pub const BACK_RIGHT_BUFFER_BIT: types::GLenum = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:270:88 [INFO] [stderr] | [INFO] [stderr] 270 | #[allow(dead_code, non_upper_case_globals)] pub const COLOR_INDEX_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:274:89 [INFO] [stderr] | [INFO] [stderr] 274 | #[allow(dead_code, non_upper_case_globals)] pub const DEPTH_BUFFER_BIT: types::GLenum = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:277:82 [INFO] [stderr] | [INFO] [stderr] 277 | #[allow(dead_code, non_upper_case_globals)] pub const DONT_CARE: types::GLenum = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:282:72 [INFO] [stderr] | [INFO] [stderr] 282 | #[allow(dead_code, non_upper_case_globals)] pub const EXTENSION_NAME: &'static str = "GLX"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:284:94 [INFO] [stderr] | [INFO] [stderr] 284 | #[allow(dead_code, non_upper_case_globals)] pub const FRONT_LEFT_BUFFER_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:285:95 [INFO] [stderr] | [INFO] [stderr] 285 | #[allow(dead_code, non_upper_case_globals)] pub const FRONT_RIGHT_BUFFER_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:298:84 [INFO] [stderr] | [INFO] [stderr] 298 | #[allow(dead_code, non_upper_case_globals)] pub const PBUFFER_BIT: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:299:93 [INFO] [stderr] | [INFO] [stderr] 299 | #[allow(dead_code, non_upper_case_globals)] pub const PBUFFER_CLOBBER_MASK: types::GLenum = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:302:83 [INFO] [stderr] | [INFO] [stderr] 302 | #[allow(dead_code, non_upper_case_globals)] pub const PIXMAP_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:309:81 [INFO] [stderr] | [INFO] [stderr] 309 | #[allow(dead_code, non_upper_case_globals)] pub const RGBA_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:311:80 [INFO] [stderr] | [INFO] [stderr] 311 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLES: types::GLenum = 100001; [INFO] [stderr] | ^^^^^^ help: consider: `100_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:312:87 [INFO] [stderr] | [INFO] [stderr] 312 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLE_BUFFERS: types::GLenum = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:318:91 [INFO] [stderr] | [INFO] [stderr] 318 | #[allow(dead_code, non_upper_case_globals)] pub const STENCIL_BUFFER_BIT: types::GLenum = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:336:83 [INFO] [stderr] | [INFO] [stderr] 336 | #[allow(dead_code, non_upper_case_globals)] pub const WINDOW_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:495:164 [INFO] [stderr] | [INFO] [stderr] 495 | #[inline] pub unsafe fn CopyContext(&self, dpy: *mut types::Display, src: types::GLXContext, dst: types::GLXContext, mask: __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXContext, types::GLXContext, __gl_imports::raw::c_ulong) -> ()>(self.CopyContext.f)(dpy, src, dst, mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:509:109 [INFO] [stderr] | [INFO] [stderr] 509 | #[inline] pub unsafe fn DestroyContext(&self, dpy: *mut types::Display, ctx: types::GLXContext) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXContext) -> ()>(self.DestroyContext.f)(dpy, ctx) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:511:113 [INFO] [stderr] | [INFO] [stderr] 511 | #[inline] pub unsafe fn DestroyGLXPixmap(&self, dpy: *mut types::Display, pixmap: types::GLXPixmap) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPixmap) -> ()>(self.DestroyGLXPixmap.f)(dpy, pixmap) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:513:110 [INFO] [stderr] | [INFO] [stderr] 513 | #[inline] pub unsafe fn DestroyPbuffer(&self, dpy: *mut types::Display, pbuf: types::GLXPbuffer) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPbuffer) -> ()>(self.DestroyPbuffer.f)(dpy, pbuf) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:515:110 [INFO] [stderr] | [INFO] [stderr] 515 | #[inline] pub unsafe fn DestroyPixmap(&self, dpy: *mut types::Display, pixmap: types::GLXPixmap) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPixmap) -> ()>(self.DestroyPixmap.f)(dpy, pixmap) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:517:107 [INFO] [stderr] | [INFO] [stderr] 517 | #[inline] pub unsafe fn DestroyWindow(&self, dpy: *mut types::Display, win: types::GLXWindow) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXWindow) -> ()>(self.DestroyWindow.f)(dpy, win) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:537:158 [INFO] [stderr] | [INFO] [stderr] 537 | #[inline] pub unsafe fn GetSelectedEvent(&self, dpy: *mut types::Display, draw: types::GLXDrawable, event_mask: *mut __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, *mut __gl_imports::raw::c_ulong) -> ()>(self.GetSelectedEvent.f)(dpy, draw, event_mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:549:186 [INFO] [stderr] | [INFO] [stderr] 549 | #[inline] pub unsafe fn QueryDrawable(&self, dpy: *mut types::Display, draw: types::GLXDrawable, attribute: __gl_imports::raw::c_int, value: *mut __gl_imports::raw::c_uint) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_int, *mut __gl_imports::raw::c_uint) -> ()>(self.QueryDrawable.f)(dpy, draw, attribute, value) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:559:148 [INFO] [stderr] | [INFO] [stderr] 559 | #[inline] pub unsafe fn SelectEvent(&self, dpy: *mut types::Display, draw: types::GLXDrawable, event_mask: __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_ulong) -> ()>(self.SelectEvent.f)(dpy, draw, event_mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:561:112 [INFO] [stderr] | [INFO] [stderr] 561 | #[inline] pub unsafe fn SwapBuffers(&self, dpy: *mut types::Display, drawable: types::GLXDrawable) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable) -> ()>(self.SwapBuffers.f)(dpy, drawable) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:563:170 [INFO] [stderr] | [INFO] [stderr] 563 | #[inline] pub unsafe fn UseXFont(&self, font: types::Font, first: __gl_imports::raw::c_int, count: __gl_imports::raw::c_int, list: __gl_imports::raw::c_int) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(types::Font, __gl_imports::raw::c_int, __gl_imports::raw::c_int, __gl_imports::raw::c_int) -> ()>(self.UseXFont.f)(font, first, count, list) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:565:53 [INFO] [stderr] | [INFO] [stderr] 565 | #[inline] pub unsafe fn WaitGL(&self, ) -> () { __gl_imports::mem::transmute::<_, extern "system" fn() -> ()>(self.WaitGL.f)() } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_bindings.rs:567:52 [INFO] [stderr] | [INFO] [stderr] 567 | #[inline] pub unsafe fn WaitX(&self, ) -> () { __gl_imports::mem::transmute::<_, extern "system" fn() -> ()>(self.WaitX.f)() } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:253:89 [INFO] [stderr] | [INFO] [stderr] 253 | #[allow(dead_code, non_upper_case_globals)] pub const ACCUM_BUFFER_BIT: types::GLenum = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:258:88 [INFO] [stderr] | [INFO] [stderr] 258 | #[allow(dead_code, non_upper_case_globals)] pub const AUX_BUFFERS_BIT: types::GLenum = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:259:93 [INFO] [stderr] | [INFO] [stderr] 259 | #[allow(dead_code, non_upper_case_globals)] pub const BACK_LEFT_BUFFER_BIT: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:260:94 [INFO] [stderr] | [INFO] [stderr] 260 | #[allow(dead_code, non_upper_case_globals)] pub const BACK_RIGHT_BUFFER_BIT: types::GLenum = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:270:88 [INFO] [stderr] | [INFO] [stderr] 270 | #[allow(dead_code, non_upper_case_globals)] pub const COLOR_INDEX_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:273:110 [INFO] [stderr] | [INFO] [stderr] 273 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_COMPATIBILITY_PROFILE_BIT_ARB: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:274:101 [INFO] [stderr] | [INFO] [stderr] 274 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_CORE_PROFILE_BIT_ARB: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:275:94 [INFO] [stderr] | [INFO] [stderr] 275 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_DEBUG_BIT_ARB: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:277:107 [INFO] [stderr] | [INFO] [stderr] 277 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_FORWARD_COMPATIBLE_BIT_ARB: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:285:102 [INFO] [stderr] | [INFO] [stderr] 285 | #[allow(dead_code, non_upper_case_globals)] pub const CONTEXT_ROBUST_ACCESS_BIT_ARB: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:287:89 [INFO] [stderr] | [INFO] [stderr] 287 | #[allow(dead_code, non_upper_case_globals)] pub const DEPTH_BUFFER_BIT: types::GLenum = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:290:82 [INFO] [stderr] | [INFO] [stderr] 290 | #[allow(dead_code, non_upper_case_globals)] pub const DONT_CARE: types::GLenum = 0xFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:295:72 [INFO] [stderr] | [INFO] [stderr] 295 | #[allow(dead_code, non_upper_case_globals)] pub const EXTENSION_NAME: &'static str = "GLX"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:299:94 [INFO] [stderr] | [INFO] [stderr] 299 | #[allow(dead_code, non_upper_case_globals)] pub const FRONT_LEFT_BUFFER_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:300:95 [INFO] [stderr] | [INFO] [stderr] 300 | #[allow(dead_code, non_upper_case_globals)] pub const FRONT_RIGHT_BUFFER_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:316:84 [INFO] [stderr] | [INFO] [stderr] 316 | #[allow(dead_code, non_upper_case_globals)] pub const PBUFFER_BIT: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:317:93 [INFO] [stderr] | [INFO] [stderr] 317 | #[allow(dead_code, non_upper_case_globals)] pub const PBUFFER_CLOBBER_MASK: types::GLenum = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:320:83 [INFO] [stderr] | [INFO] [stderr] 320 | #[allow(dead_code, non_upper_case_globals)] pub const PIXMAP_BIT: types::GLenum = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:327:81 [INFO] [stderr] | [INFO] [stderr] 327 | #[allow(dead_code, non_upper_case_globals)] pub const RGBA_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:328:91 [INFO] [stderr] | [INFO] [stderr] 328 | #[allow(dead_code, non_upper_case_globals)] pub const RGBA_FLOAT_BIT_ARB: types::GLenum = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:331:80 [INFO] [stderr] | [INFO] [stderr] 331 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLES: types::GLenum = 100001; [INFO] [stderr] | ^^^^^^ help: consider: `100_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:332:84 [INFO] [stderr] | [INFO] [stderr] 332 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLES_ARB: types::GLenum = 100001; [INFO] [stderr] | ^^^^^^ help: consider: `100_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:333:87 [INFO] [stderr] | [INFO] [stderr] 333 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLE_BUFFERS: types::GLenum = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:334:91 [INFO] [stderr] | [INFO] [stderr] 334 | #[allow(dead_code, non_upper_case_globals)] pub const SAMPLE_BUFFERS_ARB: types::GLenum = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:340:91 [INFO] [stderr] | [INFO] [stderr] 340 | #[allow(dead_code, non_upper_case_globals)] pub const STENCIL_BUFFER_BIT: types::GLenum = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:359:83 [INFO] [stderr] | [INFO] [stderr] 359 | #[allow(dead_code, non_upper_case_globals)] pub const WINDOW_BIT: types::GLenum = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:524:164 [INFO] [stderr] | [INFO] [stderr] 524 | #[inline] pub unsafe fn CopyContext(&self, dpy: *mut types::Display, src: types::GLXContext, dst: types::GLXContext, mask: __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXContext, types::GLXContext, __gl_imports::raw::c_ulong) -> ()>(self.CopyContext.f)(dpy, src, dst, mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:540:109 [INFO] [stderr] | [INFO] [stderr] 540 | #[inline] pub unsafe fn DestroyContext(&self, dpy: *mut types::Display, ctx: types::GLXContext) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXContext) -> ()>(self.DestroyContext.f)(dpy, ctx) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:542:113 [INFO] [stderr] | [INFO] [stderr] 542 | #[inline] pub unsafe fn DestroyGLXPixmap(&self, dpy: *mut types::Display, pixmap: types::GLXPixmap) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPixmap) -> ()>(self.DestroyGLXPixmap.f)(dpy, pixmap) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:544:110 [INFO] [stderr] | [INFO] [stderr] 544 | #[inline] pub unsafe fn DestroyPbuffer(&self, dpy: *mut types::Display, pbuf: types::GLXPbuffer) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPbuffer) -> ()>(self.DestroyPbuffer.f)(dpy, pbuf) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:546:110 [INFO] [stderr] | [INFO] [stderr] 546 | #[inline] pub unsafe fn DestroyPixmap(&self, dpy: *mut types::Display, pixmap: types::GLXPixmap) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXPixmap) -> ()>(self.DestroyPixmap.f)(dpy, pixmap) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:548:107 [INFO] [stderr] | [INFO] [stderr] 548 | #[inline] pub unsafe fn DestroyWindow(&self, dpy: *mut types::Display, win: types::GLXWindow) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXWindow) -> ()>(self.DestroyWindow.f)(dpy, win) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:568:158 [INFO] [stderr] | [INFO] [stderr] 568 | #[inline] pub unsafe fn GetSelectedEvent(&self, dpy: *mut types::Display, draw: types::GLXDrawable, event_mask: *mut __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, *mut __gl_imports::raw::c_ulong) -> ()>(self.GetSelectedEvent.f)(dpy, draw, event_mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:580:186 [INFO] [stderr] | [INFO] [stderr] 580 | #[inline] pub unsafe fn QueryDrawable(&self, dpy: *mut types::Display, draw: types::GLXDrawable, attribute: __gl_imports::raw::c_int, value: *mut __gl_imports::raw::c_uint) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_int, *mut __gl_imports::raw::c_uint) -> ()>(self.QueryDrawable.f)(dpy, draw, attribute, value) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:590:148 [INFO] [stderr] | [INFO] [stderr] 590 | #[inline] pub unsafe fn SelectEvent(&self, dpy: *mut types::Display, draw: types::GLXDrawable, event_mask: __gl_imports::raw::c_ulong) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_ulong) -> ()>(self.SelectEvent.f)(dpy, draw, event_mask) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:592:112 [INFO] [stderr] | [INFO] [stderr] 592 | #[inline] pub unsafe fn SwapBuffers(&self, dpy: *mut types::Display, drawable: types::GLXDrawable) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable) -> ()>(self.SwapBuffers.f)(dpy, drawable) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:594:152 [INFO] [stderr] | [INFO] [stderr] 594 | #[inline] pub unsafe fn SwapIntervalEXT(&self, dpy: *mut types::Display, drawable: types::GLXDrawable, interval: __gl_imports::raw::c_int) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(*mut types::Display, types::GLXDrawable, __gl_imports::raw::c_int) -> ()>(self.SwapIntervalEXT.f)(dpy, drawable, interval) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:598:170 [INFO] [stderr] | [INFO] [stderr] 598 | #[inline] pub unsafe fn UseXFont(&self, font: types::Font, first: __gl_imports::raw::c_int, count: __gl_imports::raw::c_int, list: __gl_imports::raw::c_int) -> () { __gl_imports::mem::transmute::<_, extern "system" fn(types::Font, __gl_imports::raw::c_int, __gl_imports::raw::c_int, __gl_imports::raw::c_int) -> ()>(self.UseXFont.f)(font, first, count, list) } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:600:53 [INFO] [stderr] | [INFO] [stderr] 600 | #[inline] pub unsafe fn WaitGL(&self, ) -> () { __gl_imports::mem::transmute::<_, extern "system" fn() -> ()>(self.WaitGL.f)() } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> /opt/crater/target/debug/build/glutin-282291866f9907e1/out/glx_extra_bindings.rs:602:52 [INFO] [stderr] | [INFO] [stderr] 602 | #[inline] pub unsafe fn WaitX(&self, ) -> () { __gl_imports::mem::transmute::<_, extern "system" fn() -> ()>(self.WaitX.f)() } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/platform/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod platform; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: method is never used: `finish_pbuffer` [INFO] [stderr] --> src/api/egl/mod.rs:427:5 [INFO] [stderr] | [INFO] [stderr] 427 | pub fn finish_pbuffer(self, dimensions: (u32, u32)) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/api/caca/ffi.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / shared_library!(LibCaca, "libcaca.so.0", [INFO] [stderr] 10 | | pub fn caca_create_display(cv: *mut caca_canvas_t) -> *mut caca_display_t, [INFO] [stderr] 11 | | pub fn caca_free_display(dp: *mut caca_display_t) -> libc::c_int, [INFO] [stderr] 12 | | pub fn caca_get_canvas(dp: *mut caca_display_t) -> *mut caca_canvas_t, [INFO] [stderr] ... | [INFO] [stderr] 22 | | pub fn caca_get_canvas_height(cv: *mut caca_canvas_t) -> libc::c_int, [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:70:84 [INFO] [stderr] | [INFO] [stderr] 70 | let list = String::from_utf8(p.to_bytes().to_vec()).unwrap_or_else(|_| format!("")); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/egl/mod.rs:75:38 [INFO] [stderr] | [INFO] [stderr] 75 | let has_dp_extension = |e: &str| dp_extensions.iter().find(|s| s == &e).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|s| s == &e).is_some()` with `any(|s| s == &e)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/api/egl/mod.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / pub fn new<'a>( [INFO] [stderr] 168 | | egl: ffi::egl::Egl, [INFO] [stderr] 169 | | pf_reqs: &PixelFormatRequirements, [INFO] [stderr] 170 | | opengl: &'a GlAttributes<&'a Context>, [INFO] [stderr] ... | [INFO] [stderr] 271 | | }) [INFO] [stderr] 272 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:190:51 [INFO] [stderr] | [INFO] [stderr] 190 | return Err(CreationError::OsError(format!("eglInitialize failed"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"eglInitialize failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:200:84 [INFO] [stderr] | [INFO] [stderr] 200 | let list = String::from_utf8(p.to_bytes().to_vec()).unwrap_or_else(|_| format!("")); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:419:51 [INFO] [stderr] | [INFO] [stderr] 419 | return Err(CreationError::OsError(format!("eglCreateWindowSurface failed"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"eglCreateWindowSurface failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:438:51 [INFO] [stderr] | [INFO] [stderr] 438 | return Err(CreationError::OsError(format!("eglCreatePbufferSurface failed"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"eglCreatePbufferSurface failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api/egl/mod.rs:509:40 [INFO] [stderr] | [INFO] [stderr] 509 | egl_version: &(ffi::egl::types::EGLint, ffi::egl::types::EGLint), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `(ffi::egl::types::EGLint, ffi::egl::types::EGLint)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:516:12 [INFO] [stderr] | [INFO] [stderr] 516 | if egl_version >= &(1, 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:528:20 [INFO] [stderr] | [INFO] [stderr] 528 | if egl_version < &(1, 3) { return Err(CreationError::NoAvailablePixelFormat); } [INFO] [stderr] | ^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:535:20 [INFO] [stderr] | [INFO] [stderr] 535 | if egl_version < &(1, 3) { return Err(CreationError::NoAvailablePixelFormat); } [INFO] [stderr] | ^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:542:20 [INFO] [stderr] | [INFO] [stderr] 542 | if egl_version >= &(1, 3) { [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:551:20 [INFO] [stderr] | [INFO] [stderr] 551 | if egl_version < &(1, 3) { return Err(CreationError::NoAvailablePixelFormat); } [INFO] [stderr] | ^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:571:22 [INFO] [stderr] | [INFO] [stderr] 571 | out.push((color / 3) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:573:22 [INFO] [stderr] | [INFO] [stderr] 573 | out.push((color / 3 + if color % 3 != 0 { 1 } else { 0 }) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3 + if color % 3 != 0 { 1 } else { 0 })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:575:22 [INFO] [stderr] | [INFO] [stderr] 575 | out.push((color / 3 + if color % 3 == 2 { 1 } else { 0 }) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3 + if color % 3 == 2 { 1 } else { 0 })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:580:22 [INFO] [stderr] | [INFO] [stderr] 580 | out.push(alpha as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:585:22 [INFO] [stderr] | [INFO] [stderr] 585 | out.push(depth as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:590:22 [INFO] [stderr] | [INFO] [stderr] 590 | out.push(stencil as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(stencil)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:599:22 [INFO] [stderr] | [INFO] [stderr] 599 | out.push(multisampling as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(multisampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:624:43 [INFO] [stderr] | [INFO] [stderr] 624 | return Err(CreationError::OsError(format!("eglChooseConfig failed"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"eglChooseConfig failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/api/egl/mod.rs:666:1 [INFO] [stderr] | [INFO] [stderr] 666 | / unsafe fn create_context(egl: &ffi::egl::Egl, display: ffi::egl::types::EGLDisplay, [INFO] [stderr] 667 | | egl_version: &(ffi::egl::types::EGLint, ffi::egl::types::EGLint), [INFO] [stderr] 668 | | extensions: &[String], api: Api, version: (u8, u8), [INFO] [stderr] 669 | | config_id: ffi::egl::types::EGLConfig, gl_debug: bool, [INFO] [stderr] ... | [INFO] [stderr] 788 | | Ok(context) [INFO] [stderr] 789 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api/egl/mod.rs:667:39 [INFO] [stderr] | [INFO] [stderr] 667 | egl_version: &(ffi::egl::types::EGLint, ffi::egl::types::EGLint), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `(ffi::egl::types::EGLint, ffi::egl::types::EGLint)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:676:8 [INFO] [stderr] | [INFO] [stderr] 676 | if egl_version >= &(1, 5) || extensions.iter().find(|s| s == &"EGL_KHR_create_context") [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/egl/mod.rs:676:34 [INFO] [stderr] | [INFO] [stderr] 676 | if egl_version >= &(1, 5) || extensions.iter().find(|s| s == &"EGL_KHR_create_context") [INFO] [stderr] | __________________________________^ [INFO] [stderr] 677 | | .is_some() [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|s| s == &"EGL_KHR_create_context").is_some()` with `any(|s| s == &"EGL_KHR_create_context")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:680:33 [INFO] [stderr] | [INFO] [stderr] 680 | context_attributes.push(version.0 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(version.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:682:33 [INFO] [stderr] | [INFO] [stderr] 682 | context_attributes.push(version.1 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(version.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:685:35 [INFO] [stderr] | [INFO] [stderr] 685 | let supports_robustness = egl_version >= &(1, 5) || [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/egl/mod.rs:686:35 [INFO] [stderr] | [INFO] [stderr] 686 | / extensions.iter() [INFO] [stderr] 687 | | .find(|s| s == &"EGL_EXT_create_context_robustness") [INFO] [stderr] 688 | | .is_some(); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|s| s == &"EGL_EXT_create_context_robustness").is_some()` with `any(|s| s == &"EGL_EXT_create_context_robustness")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/egl/mod.rs:694:20 [INFO] [stderr] | [INFO] [stderr] 694 | if extensions.iter().find(|s| s == &"EGL_KHR_create_context_no_error").is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|s| s == &"EGL_KHR_create_context_no_error").is_some()` with `any(|s| s == &"EGL_KHR_create_context_no_error")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/egl/mod.rs:705:21 [INFO] [stderr] | [INFO] [stderr] 705 | flags = flags | ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/egl/mod.rs:716:21 [INFO] [stderr] | [INFO] [stderr] 716 | flags = flags | ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/egl/mod.rs:725:21 [INFO] [stderr] | [INFO] [stderr] 725 | flags = flags | ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/egl/mod.rs:736:21 [INFO] [stderr] | [INFO] [stderr] 736 | flags = flags | ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:742:16 [INFO] [stderr] | [INFO] [stderr] 742 | if egl_version >= &(1, 5) { [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:762:15 [INFO] [stderr] | [INFO] [stderr] 762 | } else if egl_version >= &(1, 3) && api == Api::OpenGlEs { [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:772:33 [INFO] [stderr] | [INFO] [stderr] 772 | context_attributes.push(version.0 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(version.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/api/glx/mod.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new<'a>( [INFO] [stderr] 49 | | glx: ffi::glx::Glx, [INFO] [stderr] 50 | | xconn: Arc, [INFO] [stderr] 51 | | pf_reqs: &PixelFormatRequirements, [INFO] [stderr] ... | [INFO] [stderr] 113 | | }) [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/glx/mod.rs:73:51 [INFO] [stderr] | [INFO] [stderr] 73 | return Err(CreationError::OsError(format!("`glXQueryExtensionsString` found no glX extensions"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"`glXQueryExtensionsString` found no glX extensions".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/glx/mod.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | format!("`glXGetVisualFromFBConfig` failed: invalid `GLXFBConfig`") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"`glXGetVisualFromFBConfig` failed: invalid `GLXFBConfig`".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/api/glx/mod.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | / 'outer: loop [INFO] [stderr] 215 | | { [INFO] [stderr] 216 | | // Try all OpenGL versions in descending order because some non-compliant [INFO] [stderr] 217 | | // drivers don't return the latest supported version but the one requested [INFO] [stderr] ... | [INFO] [stderr] 236 | | break; [INFO] [stderr] 237 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/api/glx/mod.rs:316:1 [INFO] [stderr] | [INFO] [stderr] 316 | / fn create_context(glx: &ffi::glx::Glx, extra_functions: &ffi::glx_extra::Glx, extensions: &str, xlib: &ffi::Xlib, [INFO] [stderr] 317 | | version: (u8, u8), profile: Option, debug: bool, [INFO] [stderr] 318 | | robustness: Robustness, share: ffi::GLXContext, display: *mut ffi::Display, [INFO] [stderr] 319 | | fb_config: ffi::glx::types::GLXFBConfig, [INFO] [stderr] ... | [INFO] [stderr] 401 | | } [INFO] [stderr] 402 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:329:29 [INFO] [stderr] | [INFO] [stderr] 329 | attributes.push(version.0 as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(version.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:331:29 [INFO] [stderr] | [INFO] [stderr] 331 | attributes.push(version.1 as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(version.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/glx/mod.rs:354:29 [INFO] [stderr] | [INFO] [stderr] 354 | flags = flags | ffi::glx_extra::CONTEXT_ROBUST_ACCESS_BIT_ARB as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::glx_extra::CONTEXT_ROBUST_ACCESS_BIT_ARB as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/glx/mod.rs:359:29 [INFO] [stderr] | [INFO] [stderr] 359 | flags = flags | ffi::glx_extra::CONTEXT_ROBUST_ACCESS_BIT_ARB as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::glx_extra::CONTEXT_ROBUST_ACCESS_BIT_ARB as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/glx/mod.rs:374:21 [INFO] [stderr] | [INFO] [stderr] 374 | flags = flags | ffi::glx_extra::CONTEXT_DEBUG_BIT_ARB as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::glx_extra::CONTEXT_DEBUG_BIT_ARB as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/glx/mod.rs:397:47 [INFO] [stderr] | [INFO] [stderr] 397 | return Err(CreationError::OsError(format!("GL context creation failed"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"GL context creation failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:435:22 [INFO] [stderr] | [INFO] [stderr] 435 | out.push((color / 3) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:437:22 [INFO] [stderr] | [INFO] [stderr] 437 | out.push((color / 3 + if color % 3 != 0 { 1 } else { 0 }) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3 + if color % 3 != 0 { 1 } else { 0 })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:439:22 [INFO] [stderr] | [INFO] [stderr] 439 | out.push((color / 3 + if color % 3 == 2 { 1 } else { 0 }) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3 + if color % 3 == 2 { 1 } else { 0 })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:444:22 [INFO] [stderr] | [INFO] [stderr] 444 | out.push(alpha as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:449:22 [INFO] [stderr] | [INFO] [stderr] 449 | out.push(depth as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:454:22 [INFO] [stderr] | [INFO] [stderr] 454 | out.push(stencil as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(stencil)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:466:26 [INFO] [stderr] | [INFO] [stderr] 466 | out.push(multisampling as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(multisampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/glx/mod.rs:568:5 [INFO] [stderr] | [INFO] [stderr] 568 | extensions.split(' ').find(|&s| s == ext).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&s| s == ext).is_some()` with `any(|&s| s == ext)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/api/osmesa/mod.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | return Err(CreationError::RobustnessNotSupported.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `CreationError::RobustnessNotSupported` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/osmesa/mod.rs:110:30 [INFO] [stderr] | [INFO] [stderr] 110 | attribs.push(major as libc::c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(major)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/osmesa/mod.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | attribs.push(minor as libc::c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(minor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/osmesa/mod.rs:119:30 [INFO] [stderr] | [INFO] [stderr] 119 | attribs.push(major as libc::c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(major)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/osmesa/mod.rs:121:30 [INFO] [stderr] | [INFO] [stderr] 121 | attribs.push(minor as libc::c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(minor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`*const i8`) to itself [INFO] [stderr] --> src/api/osmesa/mod.rs:177:61 [INFO] [stderr] | [INFO] [stderr] 177 | mem::transmute(osmesa_sys::OSMesaGetProcAddress(mem::transmute(c_str.as_ptr()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/platform/linux/x11.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | Egl(EglContext), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 87 | Egl(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux/x11.rs:184:38 [INFO] [stderr] | [INFO] [stderr] 184 | Prototype::Glx(ref p) => p.get_visual_infos().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*p.get_visual_infos()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: method is never used: `finish_pbuffer` [INFO] [stderr] --> src/api/egl/mod.rs:427:5 [INFO] [stderr] | [INFO] [stderr] 427 | pub fn finish_pbuffer(self, dimensions: (u32, u32)) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/platform/linux/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | HeadlessX11(winit::Window, x11::Context), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/platform/linux/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | HeadlessX11(winit::Window, x11::Context), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/platform/linux/mod.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | fn is_compatible(c: &Option<&Context>, ct: ContextType) -> Result<(), CreationError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&Context>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:85:62 [INFO] [stderr] | [INFO] [stderr] 85 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 86 | | &Context::WindowedWayland(ref ctxt) | &Context::HeadlessWayland(_, ref ctxt) => ctxt, [INFO] [stderr] 87 | | _ => unreachable!(), [INFO] [stderr] 88 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 86 | Context::WindowedWayland(ref ctxt) | Context::HeadlessWayland(_, ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:93:62 [INFO] [stderr] | [INFO] [stderr] 93 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 94 | | &Context::WindowedX11(ref ctxt) | &Context::HeadlessX11(_, ref ctxt) => ctxt, [INFO] [stderr] 95 | | _ => unreachable!(), [INFO] [stderr] 96 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 94 | Context::WindowedX11(ref ctxt) | Context::HeadlessX11(_, ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:115:66 [INFO] [stderr] | [INFO] [stderr] 115 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 116 | | &Context::WindowedWayland(ref ctxt) | &Context::HeadlessWayland(_, ref ctxt) => ctxt, [INFO] [stderr] 117 | | _ => unreachable!(), [INFO] [stderr] 118 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 116 | Context::WindowedWayland(ref ctxt) | Context::HeadlessWayland(_, ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:123:66 [INFO] [stderr] | [INFO] [stderr] 123 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 124 | | &Context::WindowedX11(ref ctxt) | &Context::HeadlessX11(_, ref ctxt) => ctxt, [INFO] [stderr] 125 | | _ => unreachable!(), [INFO] [stderr] 126 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 124 | Context::WindowedX11(ref ctxt) | Context::HeadlessX11(_, ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:132:62 [INFO] [stderr] | [INFO] [stderr] 132 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 133 | | &Context::OsMesa(ref ctxt) => ctxt, [INFO] [stderr] 134 | | _ => unreachable!(), [INFO] [stderr] 135 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 133 | Context::OsMesa(ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platform/linux/mod.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | .map(|context| Context::OsMesa(context)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Context::OsMesa` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/api/caca/ffi.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / shared_library!(LibCaca, "libcaca.so.0", [INFO] [stderr] 10 | | pub fn caca_create_display(cv: *mut caca_canvas_t) -> *mut caca_display_t, [INFO] [stderr] 11 | | pub fn caca_free_display(dp: *mut caca_display_t) -> libc::c_int, [INFO] [stderr] 12 | | pub fn caca_get_canvas(dp: *mut caca_display_t) -> *mut caca_canvas_t, [INFO] [stderr] ... | [INFO] [stderr] 22 | | pub fn caca_get_canvas_height(cv: *mut caca_canvas_t) -> libc::c_int, [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ContextBuilder<'a>` [INFO] [stderr] --> src/lib.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / pub fn new() -> Self { [INFO] [stderr] 187 | | ContextBuilder { [INFO] [stderr] 188 | | pf_reqs: std::default::Default::default(), [INFO] [stderr] 189 | | gl_attr: std::default::Default::default(), [INFO] [stderr] 190 | | } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:633:9 [INFO] [stderr] | [INFO] [stderr] 633 | / if let &CreationError::NotSupported(msg) = self { [INFO] [stderr] 634 | | write!(formatter, ": {}", msg)?; [INFO] [stderr] 635 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 633 | if let CreationError::NotSupported(msg) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:741:26 [INFO] [stderr] | [INFO] [stderr] 741 | pub fn to_gl_version(&self) -> Option<(u8, u8)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:742:9 [INFO] [stderr] | [INFO] [stderr] 742 | / match self { [INFO] [stderr] 743 | | &GlRequest::Specific(Api::OpenGl, version) => Some(version), [INFO] [stderr] 744 | | &GlRequest::GlThenGles { opengl_version: version, .. } => Some(version), [INFO] [stderr] 745 | | _ => None, [INFO] [stderr] 746 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 742 | match *self { [INFO] [stderr] 743 | GlRequest::Specific(Api::OpenGl, version) => Some(version), [INFO] [stderr] 744 | GlRequest::GlThenGles { opengl_version: version, .. } => Some(version), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:70:84 [INFO] [stderr] | [INFO] [stderr] 70 | let list = String::from_utf8(p.to_bytes().to_vec()).unwrap_or_else(|_| format!("")); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/egl/mod.rs:75:38 [INFO] [stderr] | [INFO] [stderr] 75 | let has_dp_extension = |e: &str| dp_extensions.iter().find(|s| s == &e).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|s| s == &e).is_some()` with `any(|s| s == &e)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/api/egl/mod.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / pub fn new<'a>( [INFO] [stderr] 168 | | egl: ffi::egl::Egl, [INFO] [stderr] 169 | | pf_reqs: &PixelFormatRequirements, [INFO] [stderr] 170 | | opengl: &'a GlAttributes<&'a Context>, [INFO] [stderr] ... | [INFO] [stderr] 271 | | }) [INFO] [stderr] 272 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:190:51 [INFO] [stderr] | [INFO] [stderr] 190 | return Err(CreationError::OsError(format!("eglInitialize failed"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"eglInitialize failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:200:84 [INFO] [stderr] | [INFO] [stderr] 200 | let list = String::from_utf8(p.to_bytes().to_vec()).unwrap_or_else(|_| format!("")); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: Could not compile `glutin`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:419:51 [INFO] [stderr] | [INFO] [stderr] 419 | return Err(CreationError::OsError(format!("eglCreateWindowSurface failed"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"eglCreateWindowSurface failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:438:51 [INFO] [stderr] | [INFO] [stderr] 438 | return Err(CreationError::OsError(format!("eglCreatePbufferSurface failed"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"eglCreatePbufferSurface failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api/egl/mod.rs:509:40 [INFO] [stderr] | [INFO] [stderr] 509 | egl_version: &(ffi::egl::types::EGLint, ffi::egl::types::EGLint), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `(ffi::egl::types::EGLint, ffi::egl::types::EGLint)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:516:12 [INFO] [stderr] | [INFO] [stderr] 516 | if egl_version >= &(1, 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:528:20 [INFO] [stderr] | [INFO] [stderr] 528 | if egl_version < &(1, 3) { return Err(CreationError::NoAvailablePixelFormat); } [INFO] [stderr] | ^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:535:20 [INFO] [stderr] | [INFO] [stderr] 535 | if egl_version < &(1, 3) { return Err(CreationError::NoAvailablePixelFormat); } [INFO] [stderr] | ^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:542:20 [INFO] [stderr] | [INFO] [stderr] 542 | if egl_version >= &(1, 3) { [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:551:20 [INFO] [stderr] | [INFO] [stderr] 551 | if egl_version < &(1, 3) { return Err(CreationError::NoAvailablePixelFormat); } [INFO] [stderr] | ^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:571:22 [INFO] [stderr] | [INFO] [stderr] 571 | out.push((color / 3) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:573:22 [INFO] [stderr] | [INFO] [stderr] 573 | out.push((color / 3 + if color % 3 != 0 { 1 } else { 0 }) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3 + if color % 3 != 0 { 1 } else { 0 })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:575:22 [INFO] [stderr] | [INFO] [stderr] 575 | out.push((color / 3 + if color % 3 == 2 { 1 } else { 0 }) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3 + if color % 3 == 2 { 1 } else { 0 })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:580:22 [INFO] [stderr] | [INFO] [stderr] 580 | out.push(alpha as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:585:22 [INFO] [stderr] | [INFO] [stderr] 585 | out.push(depth as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:590:22 [INFO] [stderr] | [INFO] [stderr] 590 | out.push(stencil as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(stencil)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:599:22 [INFO] [stderr] | [INFO] [stderr] 599 | out.push(multisampling as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(multisampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/egl/mod.rs:624:43 [INFO] [stderr] | [INFO] [stderr] 624 | return Err(CreationError::OsError(format!("eglChooseConfig failed"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"eglChooseConfig failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/api/egl/mod.rs:666:1 [INFO] [stderr] | [INFO] [stderr] 666 | / unsafe fn create_context(egl: &ffi::egl::Egl, display: ffi::egl::types::EGLDisplay, [INFO] [stderr] 667 | | egl_version: &(ffi::egl::types::EGLint, ffi::egl::types::EGLint), [INFO] [stderr] 668 | | extensions: &[String], api: Api, version: (u8, u8), [INFO] [stderr] 669 | | config_id: ffi::egl::types::EGLConfig, gl_debug: bool, [INFO] [stderr] ... | [INFO] [stderr] 788 | | Ok(context) [INFO] [stderr] 789 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api/egl/mod.rs:667:39 [INFO] [stderr] | [INFO] [stderr] 667 | egl_version: &(ffi::egl::types::EGLint, ffi::egl::types::EGLint), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `(ffi::egl::types::EGLint, ffi::egl::types::EGLint)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:676:8 [INFO] [stderr] | [INFO] [stderr] 676 | if egl_version >= &(1, 5) || extensions.iter().find(|s| s == &"EGL_KHR_create_context") [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/egl/mod.rs:676:34 [INFO] [stderr] | [INFO] [stderr] 676 | if egl_version >= &(1, 5) || extensions.iter().find(|s| s == &"EGL_KHR_create_context") [INFO] [stderr] | __________________________________^ [INFO] [stderr] 677 | | .is_some() [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|s| s == &"EGL_KHR_create_context").is_some()` with `any(|s| s == &"EGL_KHR_create_context")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:680:33 [INFO] [stderr] | [INFO] [stderr] 680 | context_attributes.push(version.0 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(version.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:682:33 [INFO] [stderr] | [INFO] [stderr] 682 | context_attributes.push(version.1 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(version.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:685:35 [INFO] [stderr] | [INFO] [stderr] 685 | let supports_robustness = egl_version >= &(1, 5) || [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/egl/mod.rs:686:35 [INFO] [stderr] | [INFO] [stderr] 686 | / extensions.iter() [INFO] [stderr] 687 | | .find(|s| s == &"EGL_EXT_create_context_robustness") [INFO] [stderr] 688 | | .is_some(); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|s| s == &"EGL_EXT_create_context_robustness").is_some()` with `any(|s| s == &"EGL_EXT_create_context_robustness")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/egl/mod.rs:694:20 [INFO] [stderr] | [INFO] [stderr] 694 | if extensions.iter().find(|s| s == &"EGL_KHR_create_context_no_error").is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|s| s == &"EGL_KHR_create_context_no_error").is_some()` with `any(|s| s == &"EGL_KHR_create_context_no_error")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/egl/mod.rs:705:21 [INFO] [stderr] | [INFO] [stderr] 705 | flags = flags | ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/egl/mod.rs:716:21 [INFO] [stderr] | [INFO] [stderr] 716 | flags = flags | ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/egl/mod.rs:725:21 [INFO] [stderr] | [INFO] [stderr] 725 | flags = flags | ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/egl/mod.rs:736:21 [INFO] [stderr] | [INFO] [stderr] 736 | flags = flags | ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::egl::CONTEXT_OPENGL_ROBUST_ACCESS as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:742:16 [INFO] [stderr] | [INFO] [stderr] 742 | if egl_version >= &(1, 5) { [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/api/egl/mod.rs:762:15 [INFO] [stderr] | [INFO] [stderr] 762 | } else if egl_version >= &(1, 3) && api == Api::OpenGlEs { [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `(1, 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/egl/mod.rs:772:33 [INFO] [stderr] | [INFO] [stderr] 772 | context_attributes.push(version.0 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(version.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/api/glx/mod.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new<'a>( [INFO] [stderr] 49 | | glx: ffi::glx::Glx, [INFO] [stderr] 50 | | xconn: Arc, [INFO] [stderr] 51 | | pf_reqs: &PixelFormatRequirements, [INFO] [stderr] ... | [INFO] [stderr] 113 | | }) [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/glx/mod.rs:73:51 [INFO] [stderr] | [INFO] [stderr] 73 | return Err(CreationError::OsError(format!("`glXQueryExtensionsString` found no glX extensions"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"`glXQueryExtensionsString` found no glX extensions".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/glx/mod.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | format!("`glXGetVisualFromFBConfig` failed: invalid `GLXFBConfig`") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"`glXGetVisualFromFBConfig` failed: invalid `GLXFBConfig`".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/api/glx/mod.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | / 'outer: loop [INFO] [stderr] 215 | | { [INFO] [stderr] 216 | | // Try all OpenGL versions in descending order because some non-compliant [INFO] [stderr] 217 | | // drivers don't return the latest supported version but the one requested [INFO] [stderr] ... | [INFO] [stderr] 236 | | break; [INFO] [stderr] 237 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/api/glx/mod.rs:316:1 [INFO] [stderr] | [INFO] [stderr] 316 | / fn create_context(glx: &ffi::glx::Glx, extra_functions: &ffi::glx_extra::Glx, extensions: &str, xlib: &ffi::Xlib, [INFO] [stderr] 317 | | version: (u8, u8), profile: Option, debug: bool, [INFO] [stderr] 318 | | robustness: Robustness, share: ffi::GLXContext, display: *mut ffi::Display, [INFO] [stderr] 319 | | fb_config: ffi::glx::types::GLXFBConfig, [INFO] [stderr] ... | [INFO] [stderr] 401 | | } [INFO] [stderr] 402 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:329:29 [INFO] [stderr] | [INFO] [stderr] 329 | attributes.push(version.0 as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(version.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:331:29 [INFO] [stderr] | [INFO] [stderr] 331 | attributes.push(version.1 as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(version.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/glx/mod.rs:354:29 [INFO] [stderr] | [INFO] [stderr] 354 | flags = flags | ffi::glx_extra::CONTEXT_ROBUST_ACCESS_BIT_ARB as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::glx_extra::CONTEXT_ROBUST_ACCESS_BIT_ARB as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/glx/mod.rs:359:29 [INFO] [stderr] | [INFO] [stderr] 359 | flags = flags | ffi::glx_extra::CONTEXT_ROBUST_ACCESS_BIT_ARB as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::glx_extra::CONTEXT_ROBUST_ACCESS_BIT_ARB as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/api/glx/mod.rs:374:21 [INFO] [stderr] | [INFO] [stderr] 374 | flags = flags | ffi::glx_extra::CONTEXT_DEBUG_BIT_ARB as c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= ffi::glx_extra::CONTEXT_DEBUG_BIT_ARB as c_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/api/glx/mod.rs:397:47 [INFO] [stderr] | [INFO] [stderr] 397 | return Err(CreationError::OsError(format!("GL context creation failed"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"GL context creation failed".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:435:22 [INFO] [stderr] | [INFO] [stderr] 435 | out.push((color / 3) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:437:22 [INFO] [stderr] | [INFO] [stderr] 437 | out.push((color / 3 + if color % 3 != 0 { 1 } else { 0 }) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3 + if color % 3 != 0 { 1 } else { 0 })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:439:22 [INFO] [stderr] | [INFO] [stderr] 439 | out.push((color / 3 + if color % 3 == 2 { 1 } else { 0 }) as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(color / 3 + if color % 3 == 2 { 1 } else { 0 })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:444:22 [INFO] [stderr] | [INFO] [stderr] 444 | out.push(alpha as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:449:22 [INFO] [stderr] | [INFO] [stderr] 449 | out.push(depth as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:454:22 [INFO] [stderr] | [INFO] [stderr] 454 | out.push(stencil as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(stencil)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/glx/mod.rs:466:26 [INFO] [stderr] | [INFO] [stderr] 466 | out.push(multisampling as c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(multisampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/api/glx/mod.rs:568:5 [INFO] [stderr] | [INFO] [stderr] 568 | extensions.split(' ').find(|&s| s == ext).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&s| s == ext).is_some()` with `any(|&s| s == ext)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/api/osmesa/mod.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | return Err(CreationError::RobustnessNotSupported.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `CreationError::RobustnessNotSupported` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/osmesa/mod.rs:110:30 [INFO] [stderr] | [INFO] [stderr] 110 | attribs.push(major as libc::c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(major)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/osmesa/mod.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | attribs.push(minor as libc::c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(minor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/osmesa/mod.rs:119:30 [INFO] [stderr] | [INFO] [stderr] 119 | attribs.push(major as libc::c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(major)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/api/osmesa/mod.rs:121:30 [INFO] [stderr] | [INFO] [stderr] 121 | attribs.push(minor as libc::c_int); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(minor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`*const i8`) to itself [INFO] [stderr] --> src/api/osmesa/mod.rs:177:61 [INFO] [stderr] | [INFO] [stderr] 177 | mem::transmute(osmesa_sys::OSMesaGetProcAddress(mem::transmute(c_str.as_ptr()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/platform/linux/x11.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | Egl(EglContext), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 87 | Egl(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/platform/linux/x11.rs:184:38 [INFO] [stderr] | [INFO] [stderr] 184 | Prototype::Glx(ref p) => p.get_visual_infos().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*p.get_visual_infos()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/platform/linux/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | HeadlessX11(winit::Window, x11::Context), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/platform/linux/mod.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | HeadlessX11(winit::Window, x11::Context), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/platform/linux/mod.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | fn is_compatible(c: &Option<&Context>, ct: ContextType) -> Result<(), CreationError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option<&Context>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:85:62 [INFO] [stderr] | [INFO] [stderr] 85 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 86 | | &Context::WindowedWayland(ref ctxt) | &Context::HeadlessWayland(_, ref ctxt) => ctxt, [INFO] [stderr] 87 | | _ => unreachable!(), [INFO] [stderr] 88 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 86 | Context::WindowedWayland(ref ctxt) | Context::HeadlessWayland(_, ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:93:62 [INFO] [stderr] | [INFO] [stderr] 93 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 94 | | &Context::WindowedX11(ref ctxt) | &Context::HeadlessX11(_, ref ctxt) => ctxt, [INFO] [stderr] 95 | | _ => unreachable!(), [INFO] [stderr] 96 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 94 | Context::WindowedX11(ref ctxt) | Context::HeadlessX11(_, ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:115:66 [INFO] [stderr] | [INFO] [stderr] 115 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 116 | | &Context::WindowedWayland(ref ctxt) | &Context::HeadlessWayland(_, ref ctxt) => ctxt, [INFO] [stderr] 117 | | _ => unreachable!(), [INFO] [stderr] 118 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 116 | Context::WindowedWayland(ref ctxt) | Context::HeadlessWayland(_, ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:123:66 [INFO] [stderr] | [INFO] [stderr] 123 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 124 | | &Context::WindowedX11(ref ctxt) | &Context::HeadlessX11(_, ref ctxt) => ctxt, [INFO] [stderr] 125 | | _ => unreachable!(), [INFO] [stderr] 126 | | }); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 124 | Context::WindowedX11(ref ctxt) | Context::HeadlessX11(_, ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/platform/linux/mod.rs:132:62 [INFO] [stderr] | [INFO] [stderr] 132 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match ctxt { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 133 | | &Context::OsMesa(ref ctxt) => ctxt, [INFO] [stderr] 134 | | _ => unreachable!(), [INFO] [stderr] 135 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | let gl_attr = gl_attr.clone().map_sharing(|ctxt| match *ctxt { [INFO] [stderr] 133 | Context::OsMesa(ref ctxt) => ctxt, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/platform/linux/mod.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | .map(|context| Context::OsMesa(context)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Context::OsMesa` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ContextBuilder<'a>` [INFO] [stderr] --> src/lib.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / pub fn new() -> Self { [INFO] [stderr] 187 | | ContextBuilder { [INFO] [stderr] 188 | | pf_reqs: std::default::Default::default(), [INFO] [stderr] 189 | | gl_attr: std::default::Default::default(), [INFO] [stderr] 190 | | } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:633:9 [INFO] [stderr] | [INFO] [stderr] 633 | / if let &CreationError::NotSupported(msg) = self { [INFO] [stderr] 634 | | write!(formatter, ": {}", msg)?; [INFO] [stderr] 635 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 633 | if let CreationError::NotSupported(msg) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:741:26 [INFO] [stderr] | [INFO] [stderr] 741 | pub fn to_gl_version(&self) -> Option<(u8, u8)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:742:9 [INFO] [stderr] | [INFO] [stderr] 742 | / match self { [INFO] [stderr] 743 | | &GlRequest::Specific(Api::OpenGl, version) => Some(version), [INFO] [stderr] 744 | | &GlRequest::GlThenGles { opengl_version: version, .. } => Some(version), [INFO] [stderr] 745 | | _ => None, [INFO] [stderr] 746 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 742 | match *self { [INFO] [stderr] 743 | GlRequest::Specific(Api::OpenGl, version) => Some(version), [INFO] [stderr] 744 | GlRequest::GlThenGles { opengl_version: version, .. } => Some(version), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `glutin`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "35368e4b33f0dece86a90e334a7672881384b341b546f6366fac261d43240cdb"` [INFO] running `"docker" "rm" "-f" "35368e4b33f0dece86a90e334a7672881384b341b546f6366fac261d43240cdb"` [INFO] [stdout] 35368e4b33f0dece86a90e334a7672881384b341b546f6366fac261d43240cdb