[INFO] crate gluster 1.0.5 is already in cache [INFO] extracting crate gluster 1.0.5 into work/ex/clippy-test-run/sources/stable/reg/gluster/1.0.5 [INFO] extracting crate gluster 1.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gluster/1.0.5 [INFO] validating manifest of gluster-1.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gluster-1.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gluster-1.0.5 [INFO] finished frobbing gluster-1.0.5 [INFO] frobbed toml for gluster-1.0.5 written to work/ex/clippy-test-run/sources/stable/reg/gluster/1.0.5/Cargo.toml [INFO] started frobbing gluster-1.0.5 [INFO] finished frobbing gluster-1.0.5 [INFO] frobbed toml for gluster-1.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gluster/1.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gluster-1.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gluster/1.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2d48a006ce18c320ddfcb6d5680515a33a74ab9aa011aef2958bcfa7a225d54 [INFO] running `"docker" "start" "-a" "a2d48a006ce18c320ddfcb6d5680515a33a74ab9aa011aef2958bcfa7a225d54"` [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking gluster v1.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer.rs:279:17 [INFO] [stderr] | [INFO] [stderr] 279 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer.rs:280:17 [INFO] [stderr] | [INFO] [stderr] 280 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:440:56 [INFO] [stderr] | [INFO] [stderr] 440 | let quota_request = super::GlusterCliRequest { dict: dict }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:606:39 [INFO] [stderr] | [INFO] [stderr] 606 | return Ok(GlusterCliRequest { dict: dict }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:652:13 [INFO] [stderr] | [INFO] [stderr] 652 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:653:13 [INFO] [stderr] | [INFO] [stderr] 653 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:654:13 [INFO] [stderr] | [INFO] [stderr] 654 | op_errstr: op_errstr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errstr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:655:13 [INFO] [stderr] | [INFO] [stderr] 655 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:691:13 [INFO] [stderr] | [INFO] [stderr] 691 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:692:13 [INFO] [stderr] | [INFO] [stderr] 692 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:734:13 [INFO] [stderr] | [INFO] [stderr] 734 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:735:13 [INFO] [stderr] | [INFO] [stderr] 735 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:736:13 [INFO] [stderr] | [INFO] [stderr] 736 | friends: friends, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `friends` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:763:45 [INFO] [stderr] | [INFO] [stderr] 763 | return Ok(GlusterCliFsmLogRequest { name: name }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:801:13 [INFO] [stderr] | [INFO] [stderr] 801 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:802:13 [INFO] [stderr] | [INFO] [stderr] 802 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:803:13 [INFO] [stderr] | [INFO] [stderr] 803 | op_errstr: op_errstr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errstr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:804:13 [INFO] [stderr] | [INFO] [stderr] 804 | fsm_log: fsm_log, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fsm_log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:829:44 [INFO] [stderr] | [INFO] [stderr] 829 | return Ok(GlusterCliGetwdRequest { unused: unused }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `unused` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:863:13 [INFO] [stderr] | [INFO] [stderr] 863 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:864:13 [INFO] [stderr] | [INFO] [stderr] 864 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:865:13 [INFO] [stderr] | [INFO] [stderr] 865 | wd: wd, [INFO] [stderr] | ^^^^^^ help: replace it with: `wd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:901:13 [INFO] [stderr] | [INFO] [stderr] 901 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:902:13 [INFO] [stderr] | [INFO] [stderr] 902 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:937:13 [INFO] [stderr] | [INFO] [stderr] 937 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:938:13 [INFO] [stderr] | [INFO] [stderr] 938 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:939:13 [INFO] [stderr] | [INFO] [stderr] 939 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:971:13 [INFO] [stderr] | [INFO] [stderr] 971 | lazy: lazy, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lazy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:972:13 [INFO] [stderr] | [INFO] [stderr] 972 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:1002:13 [INFO] [stderr] | [INFO] [stderr] 1002 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:1003:13 [INFO] [stderr] | [INFO] [stderr] 1003 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/rpc.rs:1298:5 [INFO] [stderr] | [INFO] [stderr] 1298 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:502:9 [INFO] [stderr] | [INFO] [stderr] 502 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:505:9 [INFO] [stderr] | [INFO] [stderr] 505 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:507:9 [INFO] [stderr] | [INFO] [stderr] 507 | bricks: bricks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bricks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:508:9 [INFO] [stderr] | [INFO] [stderr] 508 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:622:21 [INFO] [stderr] | [INFO] [stderr] 622 | peer: peer, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:643:9 [INFO] [stderr] | [INFO] [stderr] 643 | vol_type: vol_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vol_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:644:9 [INFO] [stderr] | [INFO] [stderr] 644 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:645:9 [INFO] [stderr] | [INFO] [stderr] 645 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:646:9 [INFO] [stderr] | [INFO] [stderr] 646 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:647:9 [INFO] [stderr] | [INFO] [stderr] 647 | bricks: bricks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bricks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:738:50 [INFO] [stderr] | [INFO] [stderr] 738 | let quota_request = rpc::GlusterCliRequest { dict: dict }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:1108:21 [INFO] [stderr] | [INFO] [stderr] 1108 | peer: peer, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:1119:21 [INFO] [stderr] | [INFO] [stderr] 1119 | brick: brick, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `brick` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:1122:21 [INFO] [stderr] | [INFO] [stderr] 1122 | online: online, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `online` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer.rs:279:17 [INFO] [stderr] | [INFO] [stderr] 279 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer.rs:280:17 [INFO] [stderr] | [INFO] [stderr] 280 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:440:56 [INFO] [stderr] | [INFO] [stderr] 440 | let quota_request = super::GlusterCliRequest { dict: dict }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:606:39 [INFO] [stderr] | [INFO] [stderr] 606 | return Ok(GlusterCliRequest { dict: dict }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:652:13 [INFO] [stderr] | [INFO] [stderr] 652 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:653:13 [INFO] [stderr] | [INFO] [stderr] 653 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:654:13 [INFO] [stderr] | [INFO] [stderr] 654 | op_errstr: op_errstr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errstr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:655:13 [INFO] [stderr] | [INFO] [stderr] 655 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:691:13 [INFO] [stderr] | [INFO] [stderr] 691 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:692:13 [INFO] [stderr] | [INFO] [stderr] 692 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:734:13 [INFO] [stderr] | [INFO] [stderr] 734 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:735:13 [INFO] [stderr] | [INFO] [stderr] 735 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:736:13 [INFO] [stderr] | [INFO] [stderr] 736 | friends: friends, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `friends` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:763:45 [INFO] [stderr] | [INFO] [stderr] 763 | return Ok(GlusterCliFsmLogRequest { name: name }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:801:13 [INFO] [stderr] | [INFO] [stderr] 801 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:802:13 [INFO] [stderr] | [INFO] [stderr] 802 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:803:13 [INFO] [stderr] | [INFO] [stderr] 803 | op_errstr: op_errstr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errstr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:804:13 [INFO] [stderr] | [INFO] [stderr] 804 | fsm_log: fsm_log, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fsm_log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:829:44 [INFO] [stderr] | [INFO] [stderr] 829 | return Ok(GlusterCliGetwdRequest { unused: unused }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `unused` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:863:13 [INFO] [stderr] | [INFO] [stderr] 863 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:864:13 [INFO] [stderr] | [INFO] [stderr] 864 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:865:13 [INFO] [stderr] | [INFO] [stderr] 865 | wd: wd, [INFO] [stderr] | ^^^^^^ help: replace it with: `wd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:901:13 [INFO] [stderr] | [INFO] [stderr] 901 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:902:13 [INFO] [stderr] | [INFO] [stderr] 902 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:937:13 [INFO] [stderr] | [INFO] [stderr] 937 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:938:13 [INFO] [stderr] | [INFO] [stderr] 938 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:939:13 [INFO] [stderr] | [INFO] [stderr] 939 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:971:13 [INFO] [stderr] | [INFO] [stderr] 971 | lazy: lazy, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lazy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:972:13 [INFO] [stderr] | [INFO] [stderr] 972 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:1002:13 [INFO] [stderr] | [INFO] [stderr] 1002 | op_ret: op_ret, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `op_ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:1003:13 [INFO] [stderr] | [INFO] [stderr] 1003 | op_errno: op_errno, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `op_errno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/rpc.rs:1298:5 [INFO] [stderr] | [INFO] [stderr] 1298 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:502:9 [INFO] [stderr] | [INFO] [stderr] 502 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:505:9 [INFO] [stderr] | [INFO] [stderr] 505 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:507:9 [INFO] [stderr] | [INFO] [stderr] 507 | bricks: bricks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bricks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:508:9 [INFO] [stderr] | [INFO] [stderr] 508 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:622:21 [INFO] [stderr] | [INFO] [stderr] 622 | peer: peer, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:643:9 [INFO] [stderr] | [INFO] [stderr] 643 | vol_type: vol_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vol_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:644:9 [INFO] [stderr] | [INFO] [stderr] 644 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:645:9 [INFO] [stderr] | [INFO] [stderr] 645 | status: status, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:646:9 [INFO] [stderr] | [INFO] [stderr] 646 | transport: transport, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:647:9 [INFO] [stderr] | [INFO] [stderr] 647 | bricks: bricks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bricks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:738:50 [INFO] [stderr] | [INFO] [stderr] 738 | let quota_request = rpc::GlusterCliRequest { dict: dict }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:1108:21 [INFO] [stderr] | [INFO] [stderr] 1108 | peer: peer, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:1119:21 [INFO] [stderr] | [INFO] [stderr] 1119 | brick: brick, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `brick` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/volume.rs:1122:21 [INFO] [stderr] | [INFO] [stderr] 1122 | online: online, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `online` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / return Err(GlusterError::new(format!( [INFO] [stderr] 161 | | "Unable to find peer by hostname: {}", [INFO] [stderr] 162 | | hostname [INFO] [stderr] 163 | | ))); [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 160 | Err(GlusterError::new(format!( [INFO] [stderr] 161 | "Unable to find peer by hostname: {}", [INFO] [stderr] 162 | hostname [INFO] [stderr] 163 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return Ok(peers); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(peers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | return parse_peer_status(&output_str); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_peer_status(&output_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | return Ok(peers); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(peers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | pub const GLUSTER_CLI_PROGRAM_NUMBER: i32 = 1238463; [INFO] [stderr] | ^^^^^^^ help: consider: `1_238_463` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:21:41 [INFO] [stderr] | [INFO] [stderr] 21 | pub const GLUSTER_V2_CRED_FLAVOR: i32 = 390039; [INFO] [stderr] | ^^^^^^ help: consider: `390_039` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:24:47 [INFO] [stderr] | [INFO] [stderr] 24 | pub const GLUSTER_QUOTA_PROGRAM_NUMBER: i32 = 29852134; [INFO] [stderr] | ^^^^^^^^ help: consider: `29_852_134` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::unix_socket::UnixStream` [INFO] [stderr] --> src/rpc.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | use self::unix_socket::UnixStream; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/rpc.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:521:5 [INFO] [stderr] | [INFO] [stderr] 521 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:530:5 [INFO] [stderr] | [INFO] [stderr] 530 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:548:5 [INFO] [stderr] | [INFO] [stderr] 548 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:591:9 [INFO] [stderr] | [INFO] [stderr] 591 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:606:9 [INFO] [stderr] | [INFO] [stderr] 606 | return Ok(GlusterCliRequest { dict: dict }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterCliRequest { dict: dict })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:631:9 [INFO] [stderr] | [INFO] [stderr] 631 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:651:9 [INFO] [stderr] | [INFO] [stderr] 651 | / return Ok(GlusterCliResponse { [INFO] [stderr] 652 | | op_ret: op_ret, [INFO] [stderr] 653 | | op_errno: op_errno, [INFO] [stderr] 654 | | op_errstr: op_errstr, [INFO] [stderr] 655 | | dict: dict, [INFO] [stderr] 656 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 651 | Ok(GlusterCliResponse { [INFO] [stderr] 652 | op_ret: op_ret, [INFO] [stderr] 653 | op_errno: op_errno, [INFO] [stderr] 654 | op_errstr: op_errstr, [INFO] [stderr] 655 | dict: dict, [INFO] [stderr] 656 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:675:9 [INFO] [stderr] | [INFO] [stderr] 675 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:690:9 [INFO] [stderr] | [INFO] [stderr] 690 | / return Ok(GlusterCliPeerListRequest { [INFO] [stderr] 691 | | flags: flags, [INFO] [stderr] 692 | | dict: dict, [INFO] [stderr] 693 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 690 | Ok(GlusterCliPeerListRequest { [INFO] [stderr] 691 | flags: flags, [INFO] [stderr] 692 | dict: dict, [INFO] [stderr] 693 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:717:9 [INFO] [stderr] | [INFO] [stderr] 717 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:733:9 [INFO] [stderr] | [INFO] [stderr] 733 | / return Ok(GlusterCliPeerListResponse { [INFO] [stderr] 734 | | op_ret: op_ret, [INFO] [stderr] 735 | | op_errno: op_errno, [INFO] [stderr] 736 | | friends: friends, [INFO] [stderr] 737 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 733 | Ok(GlusterCliPeerListResponse { [INFO] [stderr] 734 | op_ret: op_ret, [INFO] [stderr] 735 | op_errno: op_errno, [INFO] [stderr] 736 | friends: friends, [INFO] [stderr] 737 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:752:9 [INFO] [stderr] | [INFO] [stderr] 752 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:763:9 [INFO] [stderr] | [INFO] [stderr] 763 | return Ok(GlusterCliFsmLogRequest { name: name }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterCliFsmLogRequest { name: name })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:784:9 [INFO] [stderr] | [INFO] [stderr] 784 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:800:9 [INFO] [stderr] | [INFO] [stderr] 800 | / return Ok(GlusterCliFsmLogReponse { [INFO] [stderr] 801 | | op_ret: op_ret, [INFO] [stderr] 802 | | op_errno: op_errno, [INFO] [stderr] 803 | | op_errstr: op_errstr, [INFO] [stderr] 804 | | fsm_log: fsm_log, [INFO] [stderr] 805 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 800 | Ok(GlusterCliFsmLogReponse { [INFO] [stderr] 801 | op_ret: op_ret, [INFO] [stderr] 802 | op_errno: op_errno, [INFO] [stderr] 803 | op_errstr: op_errstr, [INFO] [stderr] 804 | fsm_log: fsm_log, [INFO] [stderr] 805 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:820:9 [INFO] [stderr] | [INFO] [stderr] 820 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:829:9 [INFO] [stderr] | [INFO] [stderr] 829 | return Ok(GlusterCliGetwdRequest { unused: unused }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterCliGetwdRequest { unused: unused })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:848:9 [INFO] [stderr] | [INFO] [stderr] 848 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:862:9 [INFO] [stderr] | [INFO] [stderr] 862 | / return Ok(GlusterCliGetwdResponse { [INFO] [stderr] 863 | | op_ret: op_ret, [INFO] [stderr] 864 | | op_errno: op_errno, [INFO] [stderr] 865 | | wd: wd, [INFO] [stderr] 866 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 862 | Ok(GlusterCliGetwdResponse { [INFO] [stderr] 863 | op_ret: op_ret, [INFO] [stderr] 864 | op_errno: op_errno, [INFO] [stderr] 865 | wd: wd, [INFO] [stderr] 866 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:884:9 [INFO] [stderr] | [INFO] [stderr] 884 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:900:9 [INFO] [stderr] | [INFO] [stderr] 900 | / return Ok(GlusterCliMountRequest { [INFO] [stderr] 901 | | label: label, [INFO] [stderr] 902 | | dict: dict, [INFO] [stderr] 903 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 900 | Ok(GlusterCliMountRequest { [INFO] [stderr] 901 | label: label, [INFO] [stderr] 902 | dict: dict, [INFO] [stderr] 903 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:922:9 [INFO] [stderr] | [INFO] [stderr] 922 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:936:9 [INFO] [stderr] | [INFO] [stderr] 936 | / return Ok(GlusterCliMountResponse { [INFO] [stderr] 937 | | op_ret: op_ret, [INFO] [stderr] 938 | | op_errno: op_errno, [INFO] [stderr] 939 | | path: path, [INFO] [stderr] 940 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 936 | Ok(GlusterCliMountResponse { [INFO] [stderr] 937 | op_ret: op_ret, [INFO] [stderr] 938 | op_errno: op_errno, [INFO] [stderr] 939 | path: path, [INFO] [stderr] 940 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:957:9 [INFO] [stderr] | [INFO] [stderr] 957 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:970:9 [INFO] [stderr] | [INFO] [stderr] 970 | / return Ok(GlusterCliUmountRequest { [INFO] [stderr] 971 | | lazy: lazy, [INFO] [stderr] 972 | | path: path, [INFO] [stderr] 973 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 970 | Ok(GlusterCliUmountRequest { [INFO] [stderr] 971 | lazy: lazy, [INFO] [stderr] 972 | path: path, [INFO] [stderr] 973 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:990:9 [INFO] [stderr] | [INFO] [stderr] 990 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1001:9 [INFO] [stderr] | [INFO] [stderr] 1001 | / return Ok(GlusterCliUmountResponse { [INFO] [stderr] 1002 | | op_ret: op_ret, [INFO] [stderr] 1003 | | op_errno: op_errno, [INFO] [stderr] 1004 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1001 | Ok(GlusterCliUmountResponse { [INFO] [stderr] 1002 | op_ret: op_ret, [INFO] [stderr] 1003 | op_errno: op_errno, [INFO] [stderr] 1004 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1052:9 [INFO] [stderr] | [INFO] [stderr] 1052 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1081:9 [INFO] [stderr] | [INFO] [stderr] 1081 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1095:5 [INFO] [stderr] | [INFO] [stderr] 1095 | return pack_callheader(xid, prog, vers, proc_num as u32, cred_flavor, verf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pack_callheader(xid, prog, vers, proc_num as u32, cred_flavor, verf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1108:5 [INFO] [stderr] | [INFO] [stderr] 1108 | return pack_callheader(xid, prog, vers, proc_num as u32, cred_flavor, verf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pack_callheader(xid, prog, vers, proc_num as u32, cred_flavor, verf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1136:5 [INFO] [stderr] | [INFO] [stderr] 1136 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1141:5 [INFO] [stderr] | [INFO] [stderr] 1141 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1203:17 [INFO] [stderr] | [INFO] [stderr] 1203 | / return Err(super::GlusterError::new( [INFO] [stderr] 1204 | | "call failed PROG_UNAVAIL".to_string(), [INFO] [stderr] 1205 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1203 | Err(super::GlusterError::new( [INFO] [stderr] 1204 | "call failed PROG_UNAVAIL".to_string(), [INFO] [stderr] 1205 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1210:17 [INFO] [stderr] | [INFO] [stderr] 1210 | / return Err(super::GlusterError::new(format!( [INFO] [stderr] 1211 | | "Call failed: PROG_MISMATCH low: \ [INFO] [stderr] 1212 | | {} high: {}", [INFO] [stderr] 1213 | | low, high [INFO] [stderr] 1214 | | ))); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1210 | Err(super::GlusterError::new(format!( [INFO] [stderr] 1211 | "Call failed: PROG_MISMATCH low: \ [INFO] [stderr] 1212 | {} high: {}", [INFO] [stderr] 1213 | low, high [INFO] [stderr] 1214 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1217:17 [INFO] [stderr] | [INFO] [stderr] 1217 | / return Err(super::GlusterError::new( [INFO] [stderr] 1218 | | "call failed PROC_UNAVAIL".to_string(), [INFO] [stderr] 1219 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1217 | Err(super::GlusterError::new( [INFO] [stderr] 1218 | "call failed PROC_UNAVAIL".to_string(), [INFO] [stderr] 1219 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1222:17 [INFO] [stderr] | [INFO] [stderr] 1222 | / return Err(super::GlusterError::new( [INFO] [stderr] 1223 | | "call failed GARBAGE_ARGS".to_string(), [INFO] [stderr] 1224 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1222 | Err(super::GlusterError::new( [INFO] [stderr] 1223 | "call failed GARBAGE_ARGS".to_string(), [INFO] [stderr] 1224 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1227:17 [INFO] [stderr] | [INFO] [stderr] 1227 | return Ok((xid, rpc_auth)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((xid, rpc_auth))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1230:17 [INFO] [stderr] | [INFO] [stderr] 1230 | / return Err(super::GlusterError::new(format!( [INFO] [stderr] 1231 | | "Call failed: {}", [INFO] [stderr] 1232 | | accept_message [INFO] [stderr] 1233 | | ))); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1230 | Err(super::GlusterError::new(format!( [INFO] [stderr] 1231 | "Call failed: {}", [INFO] [stderr] 1232 | accept_message [INFO] [stderr] 1233 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1237:9 [INFO] [stderr] | [INFO] [stderr] 1237 | / return Err(super::GlusterError::new(format!( [INFO] [stderr] 1238 | | "MSG neither denied or accepted: {}", [INFO] [stderr] 1239 | | stat [INFO] [stderr] 1240 | | ))); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1237 | Err(super::GlusterError::new(format!( [INFO] [stderr] 1238 | "MSG neither denied or accepted: {}", [INFO] [stderr] 1239 | stat [INFO] [stderr] 1240 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1279:5 [INFO] [stderr] | [INFO] [stderr] 1279 | return Ok(bytes_written); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bytes_written)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:1254:31 [INFO] [stderr] | [INFO] [stderr] 1254 | let mut header = length & 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:1257:27 [INFO] [stderr] | [INFO] [stderr] 1257 | header = length | 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1286:5 [INFO] [stderr] | [INFO] [stderr] 1286 | return Ok(send_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(send_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1331:5 [INFO] [stderr] | [INFO] [stderr] 1331 | return Ok((last, fragment)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((last, fragment))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:1318:26 [INFO] [stderr] | [INFO] [stderr] 1318 | let last = (header & 0x80000000) != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:1321:26 [INFO] [stderr] | [INFO] [stderr] 1321 | let mut n = header & 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1351:5 [INFO] [stderr] | [INFO] [stderr] 1351 | return Ok(record); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(record)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1419:5 [INFO] [stderr] | [INFO] [stderr] 1419 | return Ok(s.trim_matches('\0').to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s.trim_matches('\0').to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1435:5 [INFO] [stderr] | [INFO] [stderr] 1435 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1474:5 [INFO] [stderr] | [INFO] [stderr] 1474 | return Ok(ret_string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret_string)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1491:5 [INFO] [stderr] | [INFO] [stderr] 1491 | return Ok(map); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | / return Err(GlusterError::new(format!( [INFO] [stderr] 161 | | "Unable to find peer by hostname: {}", [INFO] [stderr] 162 | | hostname [INFO] [stderr] 163 | | ))); [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 160 | Err(GlusterError::new(format!( [INFO] [stderr] 161 | "Unable to find peer by hostname: {}", [INFO] [stderr] 162 | hostname [INFO] [stderr] 163 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return Ok(peers); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(peers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | return parse_peer_status(&output_str); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_peer_status(&output_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | return Ok(peers); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(peers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/peer.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | pub const GLUSTER_CLI_PROGRAM_NUMBER: i32 = 1238463; [INFO] [stderr] | ^^^^^^^ help: consider: `1_238_463` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:21:41 [INFO] [stderr] | [INFO] [stderr] 21 | pub const GLUSTER_V2_CRED_FLAVOR: i32 = 390039; [INFO] [stderr] | ^^^^^^ help: consider: `390_039` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:24:47 [INFO] [stderr] | [INFO] [stderr] 24 | pub const GLUSTER_QUOTA_PROGRAM_NUMBER: i32 = 29852134; [INFO] [stderr] | ^^^^^^^^ help: consider: `29_852_134` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:521:5 [INFO] [stderr] | [INFO] [stderr] 521 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:530:5 [INFO] [stderr] | [INFO] [stderr] 530 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:548:5 [INFO] [stderr] | [INFO] [stderr] 548 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:591:9 [INFO] [stderr] | [INFO] [stderr] 591 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:606:9 [INFO] [stderr] | [INFO] [stderr] 606 | return Ok(GlusterCliRequest { dict: dict }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterCliRequest { dict: dict })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:631:9 [INFO] [stderr] | [INFO] [stderr] 631 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:651:9 [INFO] [stderr] | [INFO] [stderr] 651 | / return Ok(GlusterCliResponse { [INFO] [stderr] 652 | | op_ret: op_ret, [INFO] [stderr] 653 | | op_errno: op_errno, [INFO] [stderr] 654 | | op_errstr: op_errstr, [INFO] [stderr] 655 | | dict: dict, [INFO] [stderr] 656 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 651 | Ok(GlusterCliResponse { [INFO] [stderr] 652 | op_ret: op_ret, [INFO] [stderr] 653 | op_errno: op_errno, [INFO] [stderr] 654 | op_errstr: op_errstr, [INFO] [stderr] 655 | dict: dict, [INFO] [stderr] 656 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:675:9 [INFO] [stderr] | [INFO] [stderr] 675 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:690:9 [INFO] [stderr] | [INFO] [stderr] 690 | / return Ok(GlusterCliPeerListRequest { [INFO] [stderr] 691 | | flags: flags, [INFO] [stderr] 692 | | dict: dict, [INFO] [stderr] 693 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 690 | Ok(GlusterCliPeerListRequest { [INFO] [stderr] 691 | flags: flags, [INFO] [stderr] 692 | dict: dict, [INFO] [stderr] 693 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:717:9 [INFO] [stderr] | [INFO] [stderr] 717 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:733:9 [INFO] [stderr] | [INFO] [stderr] 733 | / return Ok(GlusterCliPeerListResponse { [INFO] [stderr] 734 | | op_ret: op_ret, [INFO] [stderr] 735 | | op_errno: op_errno, [INFO] [stderr] 736 | | friends: friends, [INFO] [stderr] 737 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 733 | Ok(GlusterCliPeerListResponse { [INFO] [stderr] 734 | op_ret: op_ret, [INFO] [stderr] 735 | op_errno: op_errno, [INFO] [stderr] 736 | friends: friends, [INFO] [stderr] 737 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:752:9 [INFO] [stderr] | [INFO] [stderr] 752 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:763:9 [INFO] [stderr] | [INFO] [stderr] 763 | return Ok(GlusterCliFsmLogRequest { name: name }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterCliFsmLogRequest { name: name })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:784:9 [INFO] [stderr] | [INFO] [stderr] 784 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:800:9 [INFO] [stderr] | [INFO] [stderr] 800 | / return Ok(GlusterCliFsmLogReponse { [INFO] [stderr] 801 | | op_ret: op_ret, [INFO] [stderr] 802 | | op_errno: op_errno, [INFO] [stderr] 803 | | op_errstr: op_errstr, [INFO] [stderr] 804 | | fsm_log: fsm_log, [INFO] [stderr] 805 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 800 | Ok(GlusterCliFsmLogReponse { [INFO] [stderr] 801 | op_ret: op_ret, [INFO] [stderr] 802 | op_errno: op_errno, [INFO] [stderr] 803 | op_errstr: op_errstr, [INFO] [stderr] 804 | fsm_log: fsm_log, [INFO] [stderr] 805 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:820:9 [INFO] [stderr] | [INFO] [stderr] 820 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:829:9 [INFO] [stderr] | [INFO] [stderr] 829 | return Ok(GlusterCliGetwdRequest { unused: unused }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterCliGetwdRequest { unused: unused })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:848:9 [INFO] [stderr] | [INFO] [stderr] 848 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:862:9 [INFO] [stderr] | [INFO] [stderr] 862 | / return Ok(GlusterCliGetwdResponse { [INFO] [stderr] 863 | | op_ret: op_ret, [INFO] [stderr] 864 | | op_errno: op_errno, [INFO] [stderr] 865 | | wd: wd, [INFO] [stderr] 866 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 862 | Ok(GlusterCliGetwdResponse { [INFO] [stderr] 863 | op_ret: op_ret, [INFO] [stderr] 864 | op_errno: op_errno, [INFO] [stderr] 865 | wd: wd, [INFO] [stderr] 866 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:884:9 [INFO] [stderr] | [INFO] [stderr] 884 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:900:9 [INFO] [stderr] | [INFO] [stderr] 900 | / return Ok(GlusterCliMountRequest { [INFO] [stderr] 901 | | label: label, [INFO] [stderr] 902 | | dict: dict, [INFO] [stderr] 903 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 900 | Ok(GlusterCliMountRequest { [INFO] [stderr] 901 | label: label, [INFO] [stderr] 902 | dict: dict, [INFO] [stderr] 903 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:922:9 [INFO] [stderr] | [INFO] [stderr] 922 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:936:9 [INFO] [stderr] | [INFO] [stderr] 936 | / return Ok(GlusterCliMountResponse { [INFO] [stderr] 937 | | op_ret: op_ret, [INFO] [stderr] 938 | | op_errno: op_errno, [INFO] [stderr] 939 | | path: path, [INFO] [stderr] 940 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 936 | Ok(GlusterCliMountResponse { [INFO] [stderr] 937 | op_ret: op_ret, [INFO] [stderr] 938 | op_errno: op_errno, [INFO] [stderr] 939 | path: path, [INFO] [stderr] 940 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:957:9 [INFO] [stderr] | [INFO] [stderr] 957 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:970:9 [INFO] [stderr] | [INFO] [stderr] 970 | / return Ok(GlusterCliUmountRequest { [INFO] [stderr] 971 | | lazy: lazy, [INFO] [stderr] 972 | | path: path, [INFO] [stderr] 973 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 970 | Ok(GlusterCliUmountRequest { [INFO] [stderr] 971 | lazy: lazy, [INFO] [stderr] 972 | path: path, [INFO] [stderr] 973 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:990:9 [INFO] [stderr] | [INFO] [stderr] 990 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1001:9 [INFO] [stderr] | [INFO] [stderr] 1001 | / return Ok(GlusterCliUmountResponse { [INFO] [stderr] 1002 | | op_ret: op_ret, [INFO] [stderr] 1003 | | op_errno: op_errno, [INFO] [stderr] 1004 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1001 | Ok(GlusterCliUmountResponse { [INFO] [stderr] 1002 | op_ret: op_ret, [INFO] [stderr] 1003 | op_errno: op_errno, [INFO] [stderr] 1004 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1052:9 [INFO] [stderr] | [INFO] [stderr] 1052 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1081:9 [INFO] [stderr] | [INFO] [stderr] 1081 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1095:5 [INFO] [stderr] | [INFO] [stderr] 1095 | return pack_callheader(xid, prog, vers, proc_num as u32, cred_flavor, verf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pack_callheader(xid, prog, vers, proc_num as u32, cred_flavor, verf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1108:5 [INFO] [stderr] | [INFO] [stderr] 1108 | return pack_callheader(xid, prog, vers, proc_num as u32, cred_flavor, verf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pack_callheader(xid, prog, vers, proc_num as u32, cred_flavor, verf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1136:5 [INFO] [stderr] | [INFO] [stderr] 1136 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1141:5 [INFO] [stderr] | [INFO] [stderr] 1141 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1203:17 [INFO] [stderr] | [INFO] [stderr] 1203 | / return Err(super::GlusterError::new( [INFO] [stderr] 1204 | | "call failed PROG_UNAVAIL".to_string(), [INFO] [stderr] 1205 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1203 | Err(super::GlusterError::new( [INFO] [stderr] 1204 | "call failed PROG_UNAVAIL".to_string(), [INFO] [stderr] 1205 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1210:17 [INFO] [stderr] | [INFO] [stderr] 1210 | / return Err(super::GlusterError::new(format!( [INFO] [stderr] 1211 | | "Call failed: PROG_MISMATCH low: \ [INFO] [stderr] 1212 | | {} high: {}", [INFO] [stderr] 1213 | | low, high [INFO] [stderr] 1214 | | ))); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1210 | Err(super::GlusterError::new(format!( [INFO] [stderr] 1211 | "Call failed: PROG_MISMATCH low: \ [INFO] [stderr] 1212 | {} high: {}", [INFO] [stderr] 1213 | low, high [INFO] [stderr] 1214 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1217:17 [INFO] [stderr] | [INFO] [stderr] 1217 | / return Err(super::GlusterError::new( [INFO] [stderr] 1218 | | "call failed PROC_UNAVAIL".to_string(), [INFO] [stderr] 1219 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1217 | Err(super::GlusterError::new( [INFO] [stderr] 1218 | "call failed PROC_UNAVAIL".to_string(), [INFO] [stderr] 1219 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1222:17 [INFO] [stderr] | [INFO] [stderr] 1222 | / return Err(super::GlusterError::new( [INFO] [stderr] 1223 | | "call failed GARBAGE_ARGS".to_string(), [INFO] [stderr] 1224 | | )); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1222 | Err(super::GlusterError::new( [INFO] [stderr] 1223 | "call failed GARBAGE_ARGS".to_string(), [INFO] [stderr] 1224 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1227:17 [INFO] [stderr] | [INFO] [stderr] 1227 | return Ok((xid, rpc_auth)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((xid, rpc_auth))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1230:17 [INFO] [stderr] | [INFO] [stderr] 1230 | / return Err(super::GlusterError::new(format!( [INFO] [stderr] 1231 | | "Call failed: {}", [INFO] [stderr] 1232 | | accept_message [INFO] [stderr] 1233 | | ))); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1230 | Err(super::GlusterError::new(format!( [INFO] [stderr] 1231 | "Call failed: {}", [INFO] [stderr] 1232 | accept_message [INFO] [stderr] 1233 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1237:9 [INFO] [stderr] | [INFO] [stderr] 1237 | / return Err(super::GlusterError::new(format!( [INFO] [stderr] 1238 | | "MSG neither denied or accepted: {}", [INFO] [stderr] 1239 | | stat [INFO] [stderr] 1240 | | ))); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1237 | Err(super::GlusterError::new(format!( [INFO] [stderr] 1238 | "MSG neither denied or accepted: {}", [INFO] [stderr] 1239 | stat [INFO] [stderr] 1240 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/volume.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/volume.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | return Some(volume_names); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(volume_names)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:650:5 [INFO] [stderr] | [INFO] [stderr] 650 | return Ok(vol_info); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vol_info)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1279:5 [INFO] [stderr] | [INFO] [stderr] 1279 | return Ok(bytes_written); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bytes_written)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:677:5 [INFO] [stderr] | [INFO] [stderr] 677 | return parse_volume_info(&volume, output_str); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_volume_info(&volume, output_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:775:5 [INFO] [stderr] | [INFO] [stderr] 775 | return Ok(usage); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(usage)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:1254:31 [INFO] [stderr] | [INFO] [stderr] 1254 | let mut header = length & 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:1257:27 [INFO] [stderr] | [INFO] [stderr] 1257 | header = length | 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1286:5 [INFO] [stderr] | [INFO] [stderr] 1286 | return Ok(send_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(send_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:902:5 [INFO] [stderr] | [INFO] [stderr] 902 | return quota_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `quota_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1331:5 [INFO] [stderr] | [INFO] [stderr] 1331 | return Ok((last, fragment)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((last, fragment))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:910:5 [INFO] [stderr] | [INFO] [stderr] 910 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:918:5 [INFO] [stderr] | [INFO] [stderr] 918 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:1318:26 [INFO] [stderr] | [INFO] [stderr] 1318 | let last = (header & 0x80000000) != 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:932:5 [INFO] [stderr] | [INFO] [stderr] 932 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rpc.rs:1321:26 [INFO] [stderr] | [INFO] [stderr] 1321 | let mut n = header & 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:940:5 [INFO] [stderr] | [INFO] [stderr] 940 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:952:17 [INFO] [stderr] | [INFO] [stderr] 952 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:954:17 [INFO] [stderr] | [INFO] [stderr] 954 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:957:17 [INFO] [stderr] | [INFO] [stderr] 957 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1351:5 [INFO] [stderr] | [INFO] [stderr] 1351 | return Ok(record); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(record)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:969:5 [INFO] [stderr] | [INFO] [stderr] 969 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:978:5 [INFO] [stderr] | [INFO] [stderr] 978 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:996:5 [INFO] [stderr] | [INFO] [stderr] 996 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1419:5 [INFO] [stderr] | [INFO] [stderr] 1419 | return Ok(s.trim_matches('\0').to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s.trim_matches('\0').to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1435:5 [INFO] [stderr] | [INFO] [stderr] 1435 | return Ok(buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buffer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1474:5 [INFO] [stderr] | [INFO] [stderr] 1474 | return Ok(ret_string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ret_string)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rpc.rs:1491:5 [INFO] [stderr] | [INFO] [stderr] 1491 | return Ok(map); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1050:5 [INFO] [stderr] | [INFO] [stderr] 1050 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1130:5 [INFO] [stderr] | [INFO] [stderr] 1130 | return Ok(bricks); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bricks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1191:5 [INFO] [stderr] | [INFO] [stderr] 1191 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1221:5 [INFO] [stderr] | [INFO] [stderr] 1221 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1234:5 [INFO] [stderr] | [INFO] [stderr] 1234 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1246:5 [INFO] [stderr] | [INFO] [stderr] 1246 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1255:5 [INFO] [stderr] | [INFO] [stderr] 1255 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1306:5 [INFO] [stderr] | [INFO] [stderr] 1306 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1318:5 [INFO] [stderr] | [INFO] [stderr] 1318 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1341:5 [INFO] [stderr] | [INFO] [stderr] 1341 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1357:5 [INFO] [stderr] | [INFO] [stderr] 1357 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1377:5 [INFO] [stderr] | [INFO] [stderr] 1377 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1393:5 [INFO] [stderr] | [INFO] [stderr] 1393 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1411:5 [INFO] [stderr] | [INFO] [stderr] 1411 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1425:5 [INFO] [stderr] | [INFO] [stderr] 1425 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1443:5 [INFO] [stderr] | [INFO] [stderr] 1443 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `regex::Regex` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use regex::Regex; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:599:17 [INFO] [stderr] | [INFO] [stderr] 599 | return Ok(GlusterOption::AuthAllow(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::AuthAllow(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:602:17 [INFO] [stderr] | [INFO] [stderr] 602 | return Ok(GlusterOption::AuthReject(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::AuthReject(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:605:17 [INFO] [stderr] | [INFO] [stderr] 605 | return Ok(GlusterOption::SslAllow(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::SslAllow(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:609:17 [INFO] [stderr] | [INFO] [stderr] 609 | return Ok(GlusterOption::ClientSsl(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClientSsl(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:613:17 [INFO] [stderr] | [INFO] [stderr] 613 | return Ok(GlusterOption::FavoriteChildPolicy(policy)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::FavoriteChildPolicy(policy))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:617:17 [INFO] [stderr] | [INFO] [stderr] 617 | return Ok(GlusterOption::ClientGraceTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClientGraceTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:621:17 [INFO] [stderr] | [INFO] [stderr] 621 | return Ok(GlusterOption::ClusterSelfHealWindowSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterSelfHealWindowSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:625:17 [INFO] [stderr] | [INFO] [stderr] 625 | return Ok(GlusterOption::ClusterDataSelfHealAlgorithm(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterDataSelfHealAlgorithm(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:629:17 [INFO] [stderr] | [INFO] [stderr] 629 | return Ok(GlusterOption::ClusterMinFreeDisk(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterMinFreeDisk(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | return Ok(GlusterOption::ClusterStripeBlockSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterStripeBlockSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:637:17 [INFO] [stderr] | [INFO] [stderr] 637 | return Ok(GlusterOption::ClusterSelfHealDaemon(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterSelfHealDaemon(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:641:17 [INFO] [stderr] | [INFO] [stderr] 641 | return Ok(GlusterOption::ClusterEnsureDurability(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterEnsureDurability(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:645:17 [INFO] [stderr] | [INFO] [stderr] 645 | return Ok(GlusterOption::DiagnosticsBrickLevel(l)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsBrickLevel(l))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:649:17 [INFO] [stderr] | [INFO] [stderr] 649 | return Ok(GlusterOption::DiagnosticsClientLevel(l)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsClientLevel(l))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:653:17 [INFO] [stderr] | [INFO] [stderr] 653 | return Ok(GlusterOption::DiagnosticsLatencyMeasurement(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsLatencyMeasurement(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:657:17 [INFO] [stderr] | [INFO] [stderr] 657 | return Ok(GlusterOption::DiagnosticsCountFopHits(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsCountFopHits(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:661:17 [INFO] [stderr] | [INFO] [stderr] 661 | return Ok(GlusterOption::DiagnosticsStatsDumpInterval(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsStatsDumpInterval(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:665:17 [INFO] [stderr] | [INFO] [stderr] 665 | return Ok(GlusterOption::DiagnosticsFopSampleBufSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsFopSampleBufSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:669:17 [INFO] [stderr] | [INFO] [stderr] 669 | return Ok(GlusterOption::DiagnosticsFopSampleInterval(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsFopSampleInterval(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:673:17 [INFO] [stderr] | [INFO] [stderr] 673 | return Ok(GlusterOption::DiagnosticsStatsDnscacheTtlSec(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsStatsDnscacheTtlSec(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:677:17 [INFO] [stderr] | [INFO] [stderr] 677 | return Ok(GlusterOption::DiagnosticsDumpFdStats(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsDumpFdStats(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:681:17 [INFO] [stderr] | [INFO] [stderr] 681 | return Ok(GlusterOption::FeaturesReadOnly(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::FeaturesReadOnly(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:685:17 [INFO] [stderr] | [INFO] [stderr] 685 | return Ok(GlusterOption::FeaturesLockHeal(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::FeaturesLockHeal(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:689:17 [INFO] [stderr] | [INFO] [stderr] 689 | return Ok(GlusterOption::FeaturesQuotaTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::FeaturesQuotaTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:693:17 [INFO] [stderr] | [INFO] [stderr] 693 | return Ok(GlusterOption::GeoReplicationIndexing(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::GeoReplicationIndexing(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:697:17 [INFO] [stderr] | [INFO] [stderr] 697 | return Ok(GlusterOption::NetworkFrameTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NetworkFrameTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:701:17 [INFO] [stderr] | [INFO] [stderr] 701 | return Ok(GlusterOption::NfsEnableIno32(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsEnableIno32(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:705:17 [INFO] [stderr] | [INFO] [stderr] 705 | return Ok(GlusterOption::NfsVolumeAccess(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsVolumeAccess(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:709:17 [INFO] [stderr] | [INFO] [stderr] 709 | return Ok(GlusterOption::NfsTrustedWrite(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsTrustedWrite(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:713:17 [INFO] [stderr] | [INFO] [stderr] 713 | return Ok(GlusterOption::NfsTrustedSync(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsTrustedSync(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:716:17 [INFO] [stderr] | [INFO] [stderr] 716 | return Ok(GlusterOption::NfsExportDir(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsExportDir(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:720:17 [INFO] [stderr] | [INFO] [stderr] 720 | return Ok(GlusterOption::NfsExportVolumes(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsExportVolumes(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:724:17 [INFO] [stderr] | [INFO] [stderr] 724 | return Ok(GlusterOption::NfsRpcAuthUnix(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsRpcAuthUnix(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:728:17 [INFO] [stderr] | [INFO] [stderr] 728 | return Ok(GlusterOption::NfsRpcAuthNull(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsRpcAuthNull(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:732:17 [INFO] [stderr] | [INFO] [stderr] 732 | return Ok(GlusterOption::NfsPortsInsecure(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsPortsInsecure(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:736:17 [INFO] [stderr] | [INFO] [stderr] 736 | return Ok(GlusterOption::NfsAddrNamelookup(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsAddrNamelookup(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:740:17 [INFO] [stderr] | [INFO] [stderr] 740 | return Ok(GlusterOption::NfsRegisterWithPortmap(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsRegisterWithPortmap(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:744:17 [INFO] [stderr] | [INFO] [stderr] 744 | return Ok(GlusterOption::NfsDisable(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsDisable(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:748:17 [INFO] [stderr] | [INFO] [stderr] 748 | return Ok(GlusterOption::PerformanceWriteBehindWindowSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceWriteBehindWindowSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:752:17 [INFO] [stderr] | [INFO] [stderr] 752 | return Ok(GlusterOption::PerformanceIoThreadCount(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceIoThreadCount(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:756:17 [INFO] [stderr] | [INFO] [stderr] 756 | return Ok(GlusterOption::PerformanceFlushBehind(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceFlushBehind(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:760:17 [INFO] [stderr] | [INFO] [stderr] 760 | return Ok(GlusterOption::PerformanceCacheMaxFileSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceCacheMaxFileSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:764:17 [INFO] [stderr] | [INFO] [stderr] 764 | return Ok(GlusterOption::PerformanceCacheMinFileSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceCacheMinFileSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:768:17 [INFO] [stderr] | [INFO] [stderr] 768 | return Ok(GlusterOption::PerformanceCacheRefreshTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceCacheRefreshTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:772:17 [INFO] [stderr] | [INFO] [stderr] 772 | return Ok(GlusterOption::PerformanceCacheSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceCacheSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:776:17 [INFO] [stderr] | [INFO] [stderr] 776 | return Ok(GlusterOption::PerformanceReadDirAhead(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceReadDirAhead(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:780:17 [INFO] [stderr] | [INFO] [stderr] 780 | return Ok(GlusterOption::PerformanceReadDirAhead(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceReadDirAhead(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | return Some(volume_names); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(volume_names)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:650:5 [INFO] [stderr] | [INFO] [stderr] 650 | return Ok(vol_info); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vol_info)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:677:5 [INFO] [stderr] | [INFO] [stderr] 677 | return parse_volume_info(&volume, output_str); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_volume_info(&volume, output_str)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:775:5 [INFO] [stderr] | [INFO] [stderr] 775 | return Ok(usage); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(usage)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:784:17 [INFO] [stderr] | [INFO] [stderr] 784 | return Ok(GlusterOption::PerformanceReadDirAheadCacheLimit(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceReadDirAheadCacheLimit(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:788:17 [INFO] [stderr] | [INFO] [stderr] 788 | return Ok(GlusterOption::ServerSsl(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ServerSsl(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:792:17 [INFO] [stderr] | [INFO] [stderr] 792 | return Ok(GlusterOption::ServerAllowInsecure(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ServerAllowInsecure(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:796:17 [INFO] [stderr] | [INFO] [stderr] 796 | return Ok(GlusterOption::ServerGraceTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ServerGraceTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:800:17 [INFO] [stderr] | [INFO] [stderr] 800 | return Ok(GlusterOption::ServerStatedumpPath(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ServerStatedumpPath(p))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:804:17 [INFO] [stderr] | [INFO] [stderr] 804 | return Ok(GlusterOption::SslCertificateDepth(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::SslCertificateDepth(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:807:17 [INFO] [stderr] | [INFO] [stderr] 807 | return Ok(GlusterOption::SslCipherList(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::SslCipherList(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:811:17 [INFO] [stderr] | [INFO] [stderr] 811 | return Ok(GlusterOption::StorageHealthCheckInterval(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::StorageHealthCheckInterval(i))` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:902:5 [INFO] [stderr] | [INFO] [stderr] 902 | return quota_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `quota_list` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:814:17 [INFO] [stderr] | [INFO] [stderr] 814 | return Err(GlusterError::new(format!("Unknown option: {}", s))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(GlusterError::new(format!("Unknown option: {}", s)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:910:5 [INFO] [stderr] | [INFO] [stderr] 910 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:918:5 [INFO] [stderr] | [INFO] [stderr] 918 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:932:5 [INFO] [stderr] | [INFO] [stderr] 932 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:940:5 [INFO] [stderr] | [INFO] [stderr] 940 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:952:17 [INFO] [stderr] | [INFO] [stderr] 952 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:954:17 [INFO] [stderr] | [INFO] [stderr] 954 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:957:17 [INFO] [stderr] | [INFO] [stderr] 957 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:969:5 [INFO] [stderr] | [INFO] [stderr] 969 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:978:5 [INFO] [stderr] | [INFO] [stderr] 978 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:996:5 [INFO] [stderr] | [INFO] [stderr] 996 | return process_output(run_command("gluster", &arg_list, true, false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, false))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1050:5 [INFO] [stderr] | [INFO] [stderr] 1050 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:937:9 [INFO] [stderr] | [INFO] [stderr] 937 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:939:9 [INFO] [stderr] | [INFO] [stderr] 939 | return Err(GlusterError::new(try!(String::from_utf8(output.stderr)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(GlusterError::new(try!(String::from_utf8(output.stderr))))` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1130:5 [INFO] [stderr] | [INFO] [stderr] 1130 | return Ok(bricks); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bricks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1191:5 [INFO] [stderr] | [INFO] [stderr] 1191 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1221:5 [INFO] [stderr] | [INFO] [stderr] 1221 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1234:5 [INFO] [stderr] | [INFO] [stderr] 1234 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1246:5 [INFO] [stderr] | [INFO] [stderr] 1246 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1255:5 [INFO] [stderr] | [INFO] [stderr] 1255 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1306:5 [INFO] [stderr] | [INFO] [stderr] 1306 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1318:5 [INFO] [stderr] | [INFO] [stderr] 1318 | return process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_output(run_command("gluster", &arg_list, true, true))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1341:5 [INFO] [stderr] | [INFO] [stderr] 1341 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1357:5 [INFO] [stderr] | [INFO] [stderr] 1357 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1377:5 [INFO] [stderr] | [INFO] [stderr] 1377 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1393:5 [INFO] [stderr] | [INFO] [stderr] 1393 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1411:5 [INFO] [stderr] | [INFO] [stderr] 1411 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1425:5 [INFO] [stderr] | [INFO] [stderr] 1425 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/volume.rs:1443:5 [INFO] [stderr] | [INFO] [stderr] 1443 | return volume_create(volume, volume_translators, &transport, bricks, force); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `volume_create(volume, volume_translators, &transport, bricks, force)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `regex::Regex` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use regex::Regex; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:966:9 [INFO] [stderr] | [INFO] [stderr] 966 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:979:9 [INFO] [stderr] | [INFO] [stderr] 979 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1047:9 [INFO] [stderr] | [INFO] [stderr] 1047 | return Ok(trimmed.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(trimmed.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1049:9 [INFO] [stderr] | [INFO] [stderr] 1049 | / return Err(try!( [INFO] [stderr] 1050 | | String::from_utf8(output.stderr).map_err(|e| e.to_string()) [INFO] [stderr] 1051 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1049 | Err(try!( [INFO] [stderr] 1050 | String::from_utf8(output.stderr).map_err(|e| e.to_string()) [INFO] [stderr] 1051 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1060:5 [INFO] [stderr] | [INFO] [stderr] 1060 | return Ok(s.trim().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s.trim().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1084:22 [INFO] [stderr] | [INFO] [stderr] 1084 | Ok(n) => return Some(n * k * k * k * k * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k * k * k * k * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1085:23 [INFO] [stderr] | [INFO] [stderr] 1085 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1089:22 [INFO] [stderr] | [INFO] [stderr] 1089 | Ok(n) => return Some(n * k * k * k * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k * k * k * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1090:23 [INFO] [stderr] | [INFO] [stderr] 1090 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1094:22 [INFO] [stderr] | [INFO] [stderr] 1094 | Ok(n) => return Some(n * k * k * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k * k * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1095:23 [INFO] [stderr] | [INFO] [stderr] 1095 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1099:22 [INFO] [stderr] | [INFO] [stderr] 1099 | Ok(n) => return Some(n * k * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1100:23 [INFO] [stderr] | [INFO] [stderr] 1100 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1104:22 [INFO] [stderr] | [INFO] [stderr] 1104 | Ok(n) => return Some(n * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1105:23 [INFO] [stderr] | [INFO] [stderr] 1105 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1109:22 [INFO] [stderr] | [INFO] [stderr] 1109 | Ok(n) => return Some(n), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1110:23 [INFO] [stderr] | [INFO] [stderr] 1110 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1113:9 [INFO] [stderr] | [INFO] [stderr] 1113 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:599:17 [INFO] [stderr] | [INFO] [stderr] 599 | return Ok(GlusterOption::AuthAllow(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::AuthAllow(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:602:17 [INFO] [stderr] | [INFO] [stderr] 602 | return Ok(GlusterOption::AuthReject(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::AuthReject(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:605:17 [INFO] [stderr] | [INFO] [stderr] 605 | return Ok(GlusterOption::SslAllow(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::SslAllow(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:609:17 [INFO] [stderr] | [INFO] [stderr] 609 | return Ok(GlusterOption::ClientSsl(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClientSsl(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:613:17 [INFO] [stderr] | [INFO] [stderr] 613 | return Ok(GlusterOption::FavoriteChildPolicy(policy)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::FavoriteChildPolicy(policy))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:617:17 [INFO] [stderr] | [INFO] [stderr] 617 | return Ok(GlusterOption::ClientGraceTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClientGraceTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:621:17 [INFO] [stderr] | [INFO] [stderr] 621 | return Ok(GlusterOption::ClusterSelfHealWindowSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterSelfHealWindowSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:625:17 [INFO] [stderr] | [INFO] [stderr] 625 | return Ok(GlusterOption::ClusterDataSelfHealAlgorithm(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterDataSelfHealAlgorithm(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:629:17 [INFO] [stderr] | [INFO] [stderr] 629 | return Ok(GlusterOption::ClusterMinFreeDisk(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterMinFreeDisk(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:633:17 [INFO] [stderr] | [INFO] [stderr] 633 | return Ok(GlusterOption::ClusterStripeBlockSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterStripeBlockSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:637:17 [INFO] [stderr] | [INFO] [stderr] 637 | return Ok(GlusterOption::ClusterSelfHealDaemon(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterSelfHealDaemon(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:641:17 [INFO] [stderr] | [INFO] [stderr] 641 | return Ok(GlusterOption::ClusterEnsureDurability(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ClusterEnsureDurability(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:645:17 [INFO] [stderr] | [INFO] [stderr] 645 | return Ok(GlusterOption::DiagnosticsBrickLevel(l)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsBrickLevel(l))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:649:17 [INFO] [stderr] | [INFO] [stderr] 649 | return Ok(GlusterOption::DiagnosticsClientLevel(l)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsClientLevel(l))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:653:17 [INFO] [stderr] | [INFO] [stderr] 653 | return Ok(GlusterOption::DiagnosticsLatencyMeasurement(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsLatencyMeasurement(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:657:17 [INFO] [stderr] | [INFO] [stderr] 657 | return Ok(GlusterOption::DiagnosticsCountFopHits(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsCountFopHits(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:661:17 [INFO] [stderr] | [INFO] [stderr] 661 | return Ok(GlusterOption::DiagnosticsStatsDumpInterval(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsStatsDumpInterval(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:665:17 [INFO] [stderr] | [INFO] [stderr] 665 | return Ok(GlusterOption::DiagnosticsFopSampleBufSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsFopSampleBufSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:669:17 [INFO] [stderr] | [INFO] [stderr] 669 | return Ok(GlusterOption::DiagnosticsFopSampleInterval(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsFopSampleInterval(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:673:17 [INFO] [stderr] | [INFO] [stderr] 673 | return Ok(GlusterOption::DiagnosticsStatsDnscacheTtlSec(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsStatsDnscacheTtlSec(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:677:17 [INFO] [stderr] | [INFO] [stderr] 677 | return Ok(GlusterOption::DiagnosticsDumpFdStats(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::DiagnosticsDumpFdStats(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:681:17 [INFO] [stderr] | [INFO] [stderr] 681 | return Ok(GlusterOption::FeaturesReadOnly(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::FeaturesReadOnly(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:685:17 [INFO] [stderr] | [INFO] [stderr] 685 | return Ok(GlusterOption::FeaturesLockHeal(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::FeaturesLockHeal(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:689:17 [INFO] [stderr] | [INFO] [stderr] 689 | return Ok(GlusterOption::FeaturesQuotaTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::FeaturesQuotaTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:693:17 [INFO] [stderr] | [INFO] [stderr] 693 | return Ok(GlusterOption::GeoReplicationIndexing(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::GeoReplicationIndexing(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:697:17 [INFO] [stderr] | [INFO] [stderr] 697 | return Ok(GlusterOption::NetworkFrameTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NetworkFrameTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:701:17 [INFO] [stderr] | [INFO] [stderr] 701 | return Ok(GlusterOption::NfsEnableIno32(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsEnableIno32(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:705:17 [INFO] [stderr] | [INFO] [stderr] 705 | return Ok(GlusterOption::NfsVolumeAccess(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsVolumeAccess(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:709:17 [INFO] [stderr] | [INFO] [stderr] 709 | return Ok(GlusterOption::NfsTrustedWrite(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsTrustedWrite(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:713:17 [INFO] [stderr] | [INFO] [stderr] 713 | return Ok(GlusterOption::NfsTrustedSync(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsTrustedSync(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:716:17 [INFO] [stderr] | [INFO] [stderr] 716 | return Ok(GlusterOption::NfsExportDir(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsExportDir(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:720:17 [INFO] [stderr] | [INFO] [stderr] 720 | return Ok(GlusterOption::NfsExportVolumes(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsExportVolumes(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:724:17 [INFO] [stderr] | [INFO] [stderr] 724 | return Ok(GlusterOption::NfsRpcAuthUnix(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsRpcAuthUnix(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:728:17 [INFO] [stderr] | [INFO] [stderr] 728 | return Ok(GlusterOption::NfsRpcAuthNull(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsRpcAuthNull(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:732:17 [INFO] [stderr] | [INFO] [stderr] 732 | return Ok(GlusterOption::NfsPortsInsecure(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsPortsInsecure(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:736:17 [INFO] [stderr] | [INFO] [stderr] 736 | return Ok(GlusterOption::NfsAddrNamelookup(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsAddrNamelookup(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:740:17 [INFO] [stderr] | [INFO] [stderr] 740 | return Ok(GlusterOption::NfsRegisterWithPortmap(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsRegisterWithPortmap(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:744:17 [INFO] [stderr] | [INFO] [stderr] 744 | return Ok(GlusterOption::NfsDisable(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::NfsDisable(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:748:17 [INFO] [stderr] | [INFO] [stderr] 748 | return Ok(GlusterOption::PerformanceWriteBehindWindowSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceWriteBehindWindowSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:752:17 [INFO] [stderr] | [INFO] [stderr] 752 | return Ok(GlusterOption::PerformanceIoThreadCount(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceIoThreadCount(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:756:17 [INFO] [stderr] | [INFO] [stderr] 756 | return Ok(GlusterOption::PerformanceFlushBehind(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceFlushBehind(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:760:17 [INFO] [stderr] | [INFO] [stderr] 760 | return Ok(GlusterOption::PerformanceCacheMaxFileSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceCacheMaxFileSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:764:17 [INFO] [stderr] | [INFO] [stderr] 764 | return Ok(GlusterOption::PerformanceCacheMinFileSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceCacheMinFileSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:768:17 [INFO] [stderr] | [INFO] [stderr] 768 | return Ok(GlusterOption::PerformanceCacheRefreshTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceCacheRefreshTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:772:17 [INFO] [stderr] | [INFO] [stderr] 772 | return Ok(GlusterOption::PerformanceCacheSize(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceCacheSize(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:776:17 [INFO] [stderr] | [INFO] [stderr] 776 | return Ok(GlusterOption::PerformanceReadDirAhead(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceReadDirAhead(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:780:17 [INFO] [stderr] | [INFO] [stderr] 780 | return Ok(GlusterOption::PerformanceReadDirAhead(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceReadDirAhead(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:784:17 [INFO] [stderr] | [INFO] [stderr] 784 | return Ok(GlusterOption::PerformanceReadDirAheadCacheLimit(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::PerformanceReadDirAheadCacheLimit(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:788:17 [INFO] [stderr] | [INFO] [stderr] 788 | return Ok(GlusterOption::ServerSsl(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ServerSsl(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:792:17 [INFO] [stderr] | [INFO] [stderr] 792 | return Ok(GlusterOption::ServerAllowInsecure(t)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ServerAllowInsecure(t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:796:17 [INFO] [stderr] | [INFO] [stderr] 796 | return Ok(GlusterOption::ServerGraceTimeout(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ServerGraceTimeout(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:800:17 [INFO] [stderr] | [INFO] [stderr] 800 | return Ok(GlusterOption::ServerStatedumpPath(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::ServerStatedumpPath(p))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:804:17 [INFO] [stderr] | [INFO] [stderr] 804 | return Ok(GlusterOption::SslCertificateDepth(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::SslCertificateDepth(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:807:17 [INFO] [stderr] | [INFO] [stderr] 807 | return Ok(GlusterOption::SslCipherList(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::SslCipherList(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:811:17 [INFO] [stderr] | [INFO] [stderr] 811 | return Ok(GlusterOption::StorageHealthCheckInterval(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(GlusterOption::StorageHealthCheckInterval(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:814:17 [INFO] [stderr] | [INFO] [stderr] 814 | return Err(GlusterError::new(format!("Unknown option: {}", s))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(GlusterError::new(format!("Unknown option: {}", s)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:937:9 [INFO] [stderr] | [INFO] [stderr] 937 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:939:9 [INFO] [stderr] | [INFO] [stderr] 939 | return Err(GlusterError::new(try!(String::from_utf8(output.stderr)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(GlusterError::new(try!(String::from_utf8(output.stderr))))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:966:9 [INFO] [stderr] | [INFO] [stderr] 966 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:979:9 [INFO] [stderr] | [INFO] [stderr] 979 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1047:9 [INFO] [stderr] | [INFO] [stderr] 1047 | return Ok(trimmed.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(trimmed.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1049:9 [INFO] [stderr] | [INFO] [stderr] 1049 | / return Err(try!( [INFO] [stderr] 1050 | | String::from_utf8(output.stderr).map_err(|e| e.to_string()) [INFO] [stderr] 1051 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1049 | Err(try!( [INFO] [stderr] 1050 | String::from_utf8(output.stderr).map_err(|e| e.to_string()) [INFO] [stderr] 1051 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1060:5 [INFO] [stderr] | [INFO] [stderr] 1060 | return Ok(s.trim().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s.trim().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1084:22 [INFO] [stderr] | [INFO] [stderr] 1084 | Ok(n) => return Some(n * k * k * k * k * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k * k * k * k * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1085:23 [INFO] [stderr] | [INFO] [stderr] 1085 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1089:22 [INFO] [stderr] | [INFO] [stderr] 1089 | Ok(n) => return Some(n * k * k * k * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k * k * k * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1090:23 [INFO] [stderr] | [INFO] [stderr] 1090 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1094:22 [INFO] [stderr] | [INFO] [stderr] 1094 | Ok(n) => return Some(n * k * k * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k * k * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1095:23 [INFO] [stderr] | [INFO] [stderr] 1095 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1099:22 [INFO] [stderr] | [INFO] [stderr] 1099 | Ok(n) => return Some(n * k * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1100:23 [INFO] [stderr] | [INFO] [stderr] 1100 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1104:22 [INFO] [stderr] | [INFO] [stderr] 1104 | Ok(n) => return Some(n * k), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n * k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1105:23 [INFO] [stderr] | [INFO] [stderr] 1105 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1109:22 [INFO] [stderr] | [INFO] [stderr] 1109 | Ok(n) => return Some(n), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1110:23 [INFO] [stderr] | [INFO] [stderr] 1110 | Err(_) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1113:9 [INFO] [stderr] | [INFO] [stderr] 1113 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num` [INFO] [stderr] --> src/rpc.rs:1140:10 [INFO] [stderr] | [INFO] [stderr] 1140 | fn htonl(num: u32) -> u32 { [INFO] [stderr] | ^^^ help: consider using `_num` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vol_type` [INFO] [stderr] --> src/volume.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | let mut vol_type = String::new(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_vol_type` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `send_bytes` [INFO] [stderr] --> src/volume.rs:748:9 [INFO] [stderr] | [INFO] [stderr] 748 | let send_bytes = try!(rpc::sendrecord(&mut sock, &call_bytes)); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_send_bytes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bricks` [INFO] [stderr] --> src/volume.rs:1046:9 [INFO] [stderr] | [INFO] [stderr] 1046 | let bricks = try!(parse_volume_status(output_str)); [INFO] [stderr] | ^^^^^^ help: consider using `_bricks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `brick` [INFO] [stderr] --> src/volume.rs:1035:35 [INFO] [stderr] | [INFO] [stderr] 1035 | pub fn ok_to_remove(volume: &str, brick: &Brick) -> Result { [INFO] [stderr] | ^^^^^ help: consider using `_brick` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tcp_port` [INFO] [stderr] --> src/volume.rs:1090:21 [INFO] [stderr] | [INFO] [stderr] 1090 | let tcp_port = match result.name("tcp") { [INFO] [stderr] | ^^^^^^^^ help: consider using `_tcp_port` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/volume.rs:1184:17 [INFO] [stderr] | [INFO] [stderr] 1184 | let status = process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `volume` [INFO] [stderr] --> src/volume.rs:1262:25 [INFO] [stderr] | [INFO] [stderr] 1262 | pub fn volume_rebalance(volume: &str) { [INFO] [stderr] | ^^^^^^ help: consider using `_volume` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num` [INFO] [stderr] --> src/rpc.rs:1140:10 [INFO] [stderr] | [INFO] [stderr] 1140 | fn htonl(num: u32) -> u32 { [INFO] [stderr] | ^^^ help: consider using `_num` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vol_type` [INFO] [stderr] --> src/volume.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | let mut vol_type = String::new(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_vol_type` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `send_bytes` [INFO] [stderr] --> src/volume.rs:748:9 [INFO] [stderr] | [INFO] [stderr] 748 | let send_bytes = try!(rpc::sendrecord(&mut sock, &call_bytes)); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_send_bytes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bricks` [INFO] [stderr] --> src/volume.rs:1046:9 [INFO] [stderr] | [INFO] [stderr] 1046 | let bricks = try!(parse_volume_status(output_str)); [INFO] [stderr] | ^^^^^^ help: consider using `_bricks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `brick` [INFO] [stderr] --> src/volume.rs:1035:35 [INFO] [stderr] | [INFO] [stderr] 1035 | pub fn ok_to_remove(volume: &str, brick: &Brick) -> Result { [INFO] [stderr] | ^^^^^ help: consider using `_brick` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tcp_port` [INFO] [stderr] --> src/volume.rs:1090:21 [INFO] [stderr] | [INFO] [stderr] 1090 | let tcp_port = match result.name("tcp") { [INFO] [stderr] | ^^^^^^^^ help: consider using `_tcp_port` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `status` [INFO] [stderr] --> src/volume.rs:1184:17 [INFO] [stderr] | [INFO] [stderr] 1184 | let status = process_output(run_command("gluster", &arg_list, true, true)); [INFO] [stderr] | ^^^^^^ help: consider using `_status` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `volume` [INFO] [stderr] --> src/volume.rs:1262:25 [INFO] [stderr] | [INFO] [stderr] 1262 | pub fn volume_rebalance(volume: &str) { [INFO] [stderr] | ^^^^^^ help: consider using `_volume` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `reply_header` [INFO] [stderr] --> src/rpc.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | let reply_header = super::unpack_replyheader(&mut cursor).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_reply_header` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `test_data` [INFO] [stderr] --> src/volume.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | let test_data = r#" [INFO] [stderr] | ^^^^^^^^^ help: consider using `_test_data` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:485:9 [INFO] [stderr] | [INFO] [stderr] 485 | let mut f = File::open(p)?; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:488:9 [INFO] [stderr] | [INFO] [stderr] 488 | let mut name = String::new(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | let mut status = String::new(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | let mut vol_type = String::new(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:492:9 [INFO] [stderr] | [INFO] [stderr] 492 | let mut options: BTreeMap = BTreeMap::new(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:493:9 [INFO] [stderr] | [INFO] [stderr] 493 | let mut bricks: Vec = Vec::new(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:758:9 [INFO] [stderr] | [INFO] [stderr] 758 | let mut quota_size_bytes = match cli_response.dict.get_mut("trusted.glusterfs.quota.size") { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_string` [INFO] [stderr] --> src/fop.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | fn to_string(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_fop_sample` [INFO] [stderr] --> src/fop.rs:231:1 [INFO] [stderr] | [INFO] [stderr] 231 | fn parse_fop_sample(input: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GLUSTER_CLI_PROGRAM_NUMBER` [INFO] [stderr] --> src/rpc.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub const GLUSTER_CLI_PROGRAM_NUMBER: i32 = 1238463; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `pack_cli_callheader` [INFO] [stderr] --> src/rpc.rs:1100:1 [INFO] [stderr] | [INFO] [stderr] 1100 | / pub fn pack_cli_callheader( [INFO] [stderr] 1101 | | xid: u32, [INFO] [stderr] 1102 | | prog: i32, [INFO] [stderr] 1103 | | vers: u32, [INFO] [stderr] ... | [INFO] [stderr] 1108 | | return pack_callheader(xid, prog, vers, proc_num as u32, cred_flavor, verf); [INFO] [stderr] 1109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `htonl` [INFO] [stderr] --> src/rpc.rs:1140:1 [INFO] [stderr] | [INFO] [stderr] 1140 | fn htonl(num: u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_fragment` [INFO] [stderr] --> src/rpc.rs:1291:1 [INFO] [stderr] | [INFO] [stderr] 1291 | pub fn print_fragment(frag: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterAggregatorNull` [INFO] [stderr] --> src/rpc.rs:1357:5 [INFO] [stderr] | [INFO] [stderr] 1357 | GlusterAggregatorNull = 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterAggregatorLookup` [INFO] [stderr] --> src/rpc.rs:1358:5 [INFO] [stderr] | [INFO] [stderr] 1358 | GlusterAggregatorLookup = 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterAggregatorMaxvalue` [INFO] [stderr] --> src/rpc.rs:1360:5 [INFO] [stderr] | [INFO] [stderr] 1360 | GlusterAggregatorMaxvalue = 3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `GlusterCliCommand` [INFO] [stderr] --> src/rpc.rs:1366:1 [INFO] [stderr] | [INFO] [stderr] 1366 | pub enum GlusterCliCommand { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_volume_info2` [INFO] [stderr] --> src/volume.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | fn parse_volume_info2(volume: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fop.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / match self { [INFO] [stderr] 144 | | &GlusterFOP::Unknown => "UNKNOWN".to_string(), [INFO] [stderr] 145 | | &GlusterFOP::GfFopNull => "NULL".to_string(), [INFO] [stderr] 146 | | &GlusterFOP::GfFopStat => "STAT".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 195 | | &GlusterFOP::GfFopMaxValue => "MAXVALUE".to_string(), [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 143 | match *self { [INFO] [stderr] 144 | GlusterFOP::Unknown => "UNKNOWN".to_string(), [INFO] [stderr] 145 | GlusterFOP::GfFopNull => "NULL".to_string(), [INFO] [stderr] 146 | GlusterFOP::GfFopStat => "STAT".to_string(), [INFO] [stderr] 147 | GlusterFOP::GfFopReadlink => "READLINK".to_string(), [INFO] [stderr] 148 | GlusterFOP::GfFopMknod => "MKNOD".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fop.rs:232:40 [INFO] [stderr] | [INFO] [stderr] 232 | let parts: Vec<&str> = input.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/peer.rs:143:27 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn get_peer(hostname: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/peer.rs:166:28 [INFO] [stderr] | [INFO] [stderr] 166 | fn parse_peer_status(line: &String) -> Result, GlusterError> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/peer.rs:175:45 [INFO] [stderr] | [INFO] [stderr] 175 | let hostname = cap.name("hostname").ok_or(GlusterError::new(format!( [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 176 | | "Invalid hostname for peer: {}", [INFO] [stderr] 177 | | line [INFO] [stderr] 178 | | )))?; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | let hostname = cap.name("hostname").ok_or_else(|| GlusterError::new(format!( [INFO] [stderr] 176 | "Invalid hostname for peer: {}", [INFO] [stderr] 177 | line [INFO] [stderr] 178 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/peer.rs:180:37 [INFO] [stderr] | [INFO] [stderr] 180 | let uuid = cap.name("uuid").ok_or(GlusterError::new(format!( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 181 | | "Invalid uuid for peer: {}", [INFO] [stderr] 182 | | line [INFO] [stderr] 183 | | )))?; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 180 | let uuid = cap.name("uuid").ok_or_else(|| GlusterError::new(format!( [INFO] [stderr] 181 | "Invalid uuid for peer: {}", [INFO] [stderr] 182 | line [INFO] [stderr] 183 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/peer.rs:185:54 [INFO] [stderr] | [INFO] [stderr] 185 | let state_details = cap.name("state_detail").ok_or(GlusterError::new(format!( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 186 | | "Invalid state for peer: {}", [INFO] [stderr] 187 | | line [INFO] [stderr] 188 | | )))?; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 185 | let state_details = cap.name("state_detail").ok_or_else(|| GlusterError::new(format!( [INFO] [stderr] 186 | "Invalid state for peer: {}", [INFO] [stderr] 187 | line [INFO] [stderr] 188 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/peer.rs:292:29 [INFO] [stderr] | [INFO] [stderr] 292 | pub fn peer_probe(hostname: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/peer.rs:312:30 [INFO] [stderr] | [INFO] [stderr] 312 | pub fn peer_remove(hostname: &String, force: bool) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rpc.rs:533:29 [INFO] [stderr] | [INFO] [stderr] 533 | fn pack_string(s: &String, buffer: &mut T) -> Result<(), super::GlusterError> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/rpc.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | let mut quota_size_bytes = cli_response [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rpc.rs:1249:15 [INFO] [stderr] | [INFO] [stderr] 1249 | fragment: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rpc.rs:1284:50 [INFO] [stderr] | [INFO] [stderr] 1284 | pub fn sendrecord(sock: &mut UnixStream, record: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rpc.rs:1291:29 [INFO] [stderr] | [INFO] [stderr] 1291 | pub fn print_fragment(frag: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rpc.rs:1326:47 [INFO] [stderr] | [INFO] [stderr] 1326 | let mut handle = socket.by_ref().take(n as u64); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/rpc.rs:1328:13 [INFO] [stderr] | [INFO] [stderr] 1328 | n = n - n; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rpc.rs:1456:8 [INFO] [stderr] | [INFO] [stderr] 1456 | if dict.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dict.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/volume.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/volume.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/volume.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / pub fn from_str(vol_type: &str) -> VolumeType { [INFO] [stderr] 167 | | match vol_type { [INFO] [stderr] 168 | | "Arbiter" => VolumeType::Arbiter, [INFO] [stderr] 169 | | "Distribute" => VolumeType::Distribute, [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/volume.rs:184:22 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:485:9 [INFO] [stderr] | [INFO] [stderr] 485 | let mut f = File::open(p)?; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:488:9 [INFO] [stderr] | [INFO] [stderr] 488 | let mut name = String::new(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | let mut status = String::new(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | let mut vol_type = String::new(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:492:9 [INFO] [stderr] | [INFO] [stderr] 492 | let mut options: BTreeMap = BTreeMap::new(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:493:9 [INFO] [stderr] | [INFO] [stderr] 493 | let mut bricks: Vec = Vec::new(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/volume.rs:758:9 [INFO] [stderr] | [INFO] [stderr] 758 | let mut quota_size_bytes = match cli_response.dict.get_mut("trusted.glusterfs.quota.size") { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:498:36 [INFO] [stderr] | [INFO] [stderr] 498 | transport = line.split("=").collect::>()[1].to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/volume.rs:564:21 [INFO] [stderr] | [INFO] [stderr] 564 | let ref name = parts[0]; [INFO] [stderr] | ----^^^^^^^^------------ help: try: `let name = &parts[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/volume.rs:565:21 [INFO] [stderr] | [INFO] [stderr] 565 | let ref value = parts[1]; [INFO] [stderr] | ----^^^^^^^^^------------ help: try: `let value = &parts[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/volume.rs:590:21 [INFO] [stderr] | [INFO] [stderr] 590 | let ref value = parts[1]; [INFO] [stderr] | ----^^^^^^^^^------------ help: try: `let value = &parts[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:593:58 [INFO] [stderr] | [INFO] [stderr] 593 | let brick_parts: Vec<&str> = value.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_string` [INFO] [stderr] --> src/fop.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | fn to_string(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `htonl` [INFO] [stderr] --> src/rpc.rs:1140:1 [INFO] [stderr] | [INFO] [stderr] 1140 | fn htonl(num: u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_fragment` [INFO] [stderr] --> src/rpc.rs:1291:1 [INFO] [stderr] | [INFO] [stderr] 1291 | pub fn print_fragment(frag: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterAggregatorNull` [INFO] [stderr] --> src/rpc.rs:1357:5 [INFO] [stderr] | [INFO] [stderr] 1357 | GlusterAggregatorNull = 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterAggregatorLookup` [INFO] [stderr] --> src/rpc.rs:1358:5 [INFO] [stderr] | [INFO] [stderr] 1358 | GlusterAggregatorLookup = 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterAggregatorMaxvalue` [INFO] [stderr] --> src/rpc.rs:1360:5 [INFO] [stderr] | [INFO] [stderr] 1360 | GlusterAggregatorMaxvalue = 3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliNull` [INFO] [stderr] --> src/rpc.rs:1367:5 [INFO] [stderr] | [INFO] [stderr] 1367 | GlusterCliNull = 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliProbe` [INFO] [stderr] --> src/rpc.rs:1368:5 [INFO] [stderr] | [INFO] [stderr] 1368 | GlusterCliProbe = 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliDeprobe` [INFO] [stderr] --> src/rpc.rs:1369:5 [INFO] [stderr] | [INFO] [stderr] 1369 | GlusterCliDeprobe = 2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliCreateVolume` [INFO] [stderr] --> src/rpc.rs:1371:5 [INFO] [stderr] | [INFO] [stderr] 1371 | GlusterCliCreateVolume = 4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliGetVolume` [INFO] [stderr] --> src/rpc.rs:1372:5 [INFO] [stderr] | [INFO] [stderr] 1372 | GlusterCliGetVolume = 5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliGetNextVolume` [INFO] [stderr] --> src/rpc.rs:1373:5 [INFO] [stderr] | [INFO] [stderr] 1373 | GlusterCliGetNextVolume = 6, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliDeleteVolume` [INFO] [stderr] --> src/rpc.rs:1374:5 [INFO] [stderr] | [INFO] [stderr] 1374 | GlusterCliDeleteVolume = 7, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliStartVolume` [INFO] [stderr] --> src/rpc.rs:1375:5 [INFO] [stderr] | [INFO] [stderr] 1375 | GlusterCliStartVolume = 8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliStopVolume` [INFO] [stderr] --> src/rpc.rs:1376:5 [INFO] [stderr] | [INFO] [stderr] 1376 | GlusterCliStopVolume = 9, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliRenameVolume` [INFO] [stderr] --> src/rpc.rs:1377:5 [INFO] [stderr] | [INFO] [stderr] 1377 | GlusterCliRenameVolume = 10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliDefragVolume` [INFO] [stderr] --> src/rpc.rs:1378:5 [INFO] [stderr] | [INFO] [stderr] 1378 | GlusterCliDefragVolume = 11, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliSetVolume` [INFO] [stderr] --> src/rpc.rs:1379:5 [INFO] [stderr] | [INFO] [stderr] 1379 | GlusterCliSetVolume = 12, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliAddBrick` [INFO] [stderr] --> src/rpc.rs:1380:5 [INFO] [stderr] | [INFO] [stderr] 1380 | GlusterCliAddBrick = 13, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliRemoveBrick` [INFO] [stderr] --> src/rpc.rs:1381:5 [INFO] [stderr] | [INFO] [stderr] 1381 | GlusterCliRemoveBrick = 14, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliBrick` [INFO] [stderr] --> src/rpc.rs:1382:5 [INFO] [stderr] | [INFO] [stderr] 1382 | GlusterCliBrick = 15, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliLogRotate` [INFO] [stderr] --> src/rpc.rs:1383:5 [INFO] [stderr] | [INFO] [stderr] 1383 | GlusterCliLogRotate = 16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliGetspec` [INFO] [stderr] --> src/rpc.rs:1384:5 [INFO] [stderr] | [INFO] [stderr] 1384 | GlusterCliGetspec = 17, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliPmapPortbybrick` [INFO] [stderr] --> src/rpc.rs:1385:5 [INFO] [stderr] | [INFO] [stderr] 1385 | GlusterCliPmapPortbybrick = 18, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliSyncVolume` [INFO] [stderr] --> src/rpc.rs:1386:5 [INFO] [stderr] | [INFO] [stderr] 1386 | GlusterCliSyncVolume = 19, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliResetVolume` [INFO] [stderr] --> src/rpc.rs:1387:5 [INFO] [stderr] | [INFO] [stderr] 1387 | GlusterCliResetVolume = 20, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliFsmLog` [INFO] [stderr] --> src/rpc.rs:1388:5 [INFO] [stderr] | [INFO] [stderr] 1388 | GlusterCliFsmLog = 21, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliGsyncSet` [INFO] [stderr] --> src/rpc.rs:1389:5 [INFO] [stderr] | [INFO] [stderr] 1389 | GlusterCliGsyncSet = 22, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliProfileVolume` [INFO] [stderr] --> src/rpc.rs:1390:5 [INFO] [stderr] | [INFO] [stderr] 1390 | GlusterCliProfileVolume = 23, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliQuota` [INFO] [stderr] --> src/rpc.rs:1391:5 [INFO] [stderr] | [INFO] [stderr] 1391 | GlusterCliQuota = 24, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliTopVolume` [INFO] [stderr] --> src/rpc.rs:1392:5 [INFO] [stderr] | [INFO] [stderr] 1392 | GlusterCliTopVolume = 25, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliGetwd` [INFO] [stderr] --> src/rpc.rs:1393:5 [INFO] [stderr] | [INFO] [stderr] 1393 | GlusterCliGetwd = 26, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliStatusVolume` [INFO] [stderr] --> src/rpc.rs:1394:5 [INFO] [stderr] | [INFO] [stderr] 1394 | GlusterCliStatusVolume = 27, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliStatusAll` [INFO] [stderr] --> src/rpc.rs:1395:5 [INFO] [stderr] | [INFO] [stderr] 1395 | GlusterCliStatusAll = 28, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliMount` [INFO] [stderr] --> src/rpc.rs:1396:5 [INFO] [stderr] | [INFO] [stderr] 1396 | GlusterCliMount = 29, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:873:29 [INFO] [stderr] | [INFO] [stderr] 873 | if line.starts_with(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] warning: variant is never constructed: `GlusterCliUmount` [INFO] [stderr] --> src/rpc.rs:1397:5 [INFO] [stderr] | [INFO] [stderr] 1397 | GlusterCliUmount = 30, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliHealVolume` [INFO] [stderr] --> src/rpc.rs:1398:5 [INFO] [stderr] | [INFO] [stderr] 1398 | GlusterCliHealVolume = 31, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliStatedumpVolume` [INFO] [stderr] --> src/rpc.rs:1399:5 [INFO] [stderr] | [INFO] [stderr] 1399 | GlusterCliStatedumpVolume = 32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliListVolume` [INFO] [stderr] --> src/rpc.rs:1400:5 [INFO] [stderr] | [INFO] [stderr] 1400 | GlusterCliListVolume = 33, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:876:29 [INFO] [stderr] | [INFO] [stderr] 876 | if line.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] warning: variant is never constructed: `GlusterCliClrlocksVolume` [INFO] [stderr] --> src/rpc.rs:1401:5 [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 1401 | GlusterCliClrlocksVolume = 34, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliUuidReset` [INFO] [stderr] --> src/rpc.rs:1402:5 [INFO] [stderr] | [INFO] [stderr] 1402 | GlusterCliUuidReset = 35, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliUuidGet` [INFO] [stderr] --> src/rpc.rs:1403:5 [INFO] [stderr] | [INFO] [stderr] 1403 | GlusterCliUuidGet = 36, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliCopyFile` [INFO] [stderr] --> src/rpc.rs:1404:5 [INFO] [stderr] | [INFO] [stderr] 1404 | GlusterCliCopyFile = 37, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:880:43 [INFO] [stderr] | [INFO] [stderr] 880 | let parts: Vec<&str> = line.split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] warning: variant is never constructed: `GlusterCliSysExec` [INFO] [stderr] --> src/rpc.rs:1405:5 [INFO] [stderr] | [INFO] [stderr] 1405 | GlusterCliSysExec = 38, [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliSnap` [INFO] [stderr] --> src/rpc.rs:1406:5 [INFO] [stderr] | [INFO] [stderr] 1406 | GlusterCliSnap = 39, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliBarrierVolume` [INFO] [stderr] --> src/rpc.rs:1407:5 [INFO] [stderr] | [INFO] [stderr] 1407 | GlusterCliBarrierVolume = 40, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliGetVolOpt` [INFO] [stderr] --> src/rpc.rs:1408:5 [INFO] [stderr] | [INFO] [stderr] 1408 | GlusterCliGetVolOpt = 41, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliGanesha` [INFO] [stderr] --> src/rpc.rs:1409:5 [INFO] [stderr] | [INFO] [stderr] 1409 | GlusterCliGanesha = 42, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliBitrot` [INFO] [stderr] --> src/rpc.rs:1410:5 [INFO] [stderr] | [INFO] [stderr] 1410 | GlusterCliBitrot = 43, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliAttachTier` [INFO] [stderr] --> src/rpc.rs:1411:5 [INFO] [stderr] | [INFO] [stderr] 1411 | GlusterCliAttachTier = 44, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliDetachTier` [INFO] [stderr] --> src/rpc.rs:1412:5 [INFO] [stderr] | [INFO] [stderr] 1412 | GlusterCliDetachTier = 45, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GlusterCliMaxvalue` [INFO] [stderr] --> src/rpc.rs:1413:5 [INFO] [stderr] | [INFO] [stderr] 1413 | GlusterCliMaxvalue = 46, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_volume_info2` [INFO] [stderr] --> src/volume.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | fn parse_volume_info2(volume: &str) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:1081:29 [INFO] [stderr] | [INFO] [stderr] 1081 | if line.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/volume.rs:1088:9 [INFO] [stderr] | [INFO] [stderr] 1088 | / match brick_regex.captures(&line) { [INFO] [stderr] 1089 | | Some(result) => { [INFO] [stderr] 1090 | | let tcp_port = match result.name("tcp") { [INFO] [stderr] 1091 | | Some(port) => port, [INFO] [stderr] ... | [INFO] [stderr] 1127 | | None => {} [INFO] [stderr] 1128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1088 | if let Some(result) = brick_regex.captures(&line) { [INFO] [stderr] 1089 | let tcp_port = match result.name("tcp") { [INFO] [stderr] 1090 | Some(port) => port, [INFO] [stderr] 1091 | None => { [INFO] [stderr] 1092 | return Err(GlusterError::new( [INFO] [stderr] 1093 | "Unable to find tcp port in gluster vol \ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fop.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / match self { [INFO] [stderr] 144 | | &GlusterFOP::Unknown => "UNKNOWN".to_string(), [INFO] [stderr] 145 | | &GlusterFOP::GfFopNull => "NULL".to_string(), [INFO] [stderr] 146 | | &GlusterFOP::GfFopStat => "STAT".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 195 | | &GlusterFOP::GfFopMaxValue => "MAXVALUE".to_string(), [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 143 | match *self { [INFO] [stderr] 144 | GlusterFOP::Unknown => "UNKNOWN".to_string(), [INFO] [stderr] 145 | GlusterFOP::GfFopNull => "NULL".to_string(), [INFO] [stderr] 146 | GlusterFOP::GfFopStat => "STAT".to_string(), [INFO] [stderr] 147 | GlusterFOP::GfFopReadlink => "READLINK".to_string(), [INFO] [stderr] 148 | GlusterFOP::GfFopMknod => "MKNOD".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fop.rs:232:40 [INFO] [stderr] | [INFO] [stderr] 232 | let parts: Vec<&str> = input.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/volume.rs:1337:8 [INFO] [stderr] | [INFO] [stderr] 1337 | if error_list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!error_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &SelfHealAlgorithm::Full => "full".to_string(), [INFO] [stderr] 67 | | &SelfHealAlgorithm::Diff => "diff".to_string(), [INFO] [stderr] 68 | | &SelfHealAlgorithm::Reset => "reset".to_string(), [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | SelfHealAlgorithm::Full => "full".to_string(), [INFO] [stderr] 67 | SelfHealAlgorithm::Diff => "diff".to_string(), [INFO] [stderr] 68 | SelfHealAlgorithm::Reset => "reset".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self { [INFO] [stderr] 92 | | &SplitBrainPolicy::Ctime => "ctime".to_string(), [INFO] [stderr] 93 | | &SplitBrainPolicy::Disable => "none".to_string(), [INFO] [stderr] 94 | | &SplitBrainPolicy::Majority => "majority".to_string(), [INFO] [stderr] 95 | | &SplitBrainPolicy::Mtime => "mtime".to_string(), [INFO] [stderr] 96 | | &SplitBrainPolicy::Size => "size".to_string(), [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *self { [INFO] [stderr] 92 | SplitBrainPolicy::Ctime => "ctime".to_string(), [INFO] [stderr] 93 | SplitBrainPolicy::Disable => "none".to_string(), [INFO] [stderr] 94 | SplitBrainPolicy::Majority => "majority".to_string(), [INFO] [stderr] 95 | SplitBrainPolicy::Mtime => "mtime".to_string(), [INFO] [stderr] 96 | SplitBrainPolicy::Size => "size".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 100 | | match s { [INFO] [stderr] 101 | | "ctime" => Ok(SplitBrainPolicy::Ctime), [INFO] [stderr] 102 | | "none" => Ok(SplitBrainPolicy::Disable), [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / match self { [INFO] [stderr] 130 | | &AccessMode::ReadOnly => "read-only".to_string(), [INFO] [stderr] 131 | | &AccessMode::ReadWrite => "read-write".to_string(), [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 129 | match *self { [INFO] [stderr] 130 | AccessMode::ReadOnly => "read-only".to_string(), [INFO] [stderr] 131 | AccessMode::ReadWrite => "read-write".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn from_str(s: &str) -> AccessMode { [INFO] [stderr] 135 | | match s { [INFO] [stderr] 136 | | "read-only" => AccessMode::ReadOnly, [INFO] [stderr] 137 | | "read-write" => AccessMode::ReadWrite, [INFO] [stderr] 138 | | _ => AccessMode::ReadWrite, [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/peer.rs:143:27 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn get_peer(hostname: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / match self { [INFO] [stderr] 169 | | &Toggle::On => "On".to_string(), [INFO] [stderr] 170 | | &Toggle::Off => "Off".to_string(), [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 168 | match *self { [INFO] [stderr] 169 | Toggle::On => "On".to_string(), [INFO] [stderr] 170 | Toggle::Off => "Off".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn from_str(s: &str) -> Toggle { [INFO] [stderr] 174 | | match s { [INFO] [stderr] 175 | | "on" => Toggle::On, [INFO] [stderr] 176 | | "off" => Toggle::Off, [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | / match self { [INFO] [stderr] 194 | | &ScrubSchedule::Hourly => "hourly".to_string(), [INFO] [stderr] 195 | | &ScrubSchedule::Daily => "daily".to_string(), [INFO] [stderr] 196 | | &ScrubSchedule::Weekly => "weekly".to_string(), [INFO] [stderr] 197 | | &ScrubSchedule::BiWeekly => "biweekly".to_string(), [INFO] [stderr] 198 | | &ScrubSchedule::Monthly => "monthly".to_string(), [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 193 | match *self { [INFO] [stderr] 194 | ScrubSchedule::Hourly => "hourly".to_string(), [INFO] [stderr] 195 | ScrubSchedule::Daily => "daily".to_string(), [INFO] [stderr] 196 | ScrubSchedule::Weekly => "weekly".to_string(), [INFO] [stderr] 197 | ScrubSchedule::BiWeekly => "biweekly".to_string(), [INFO] [stderr] 198 | ScrubSchedule::Monthly => "monthly".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | / pub fn from_str(s: &str) -> ScrubSchedule { [INFO] [stderr] 202 | | match s { [INFO] [stderr] 203 | | "hourly" => ScrubSchedule::Hourly, [INFO] [stderr] 204 | | "daily" => ScrubSchedule::Daily, [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/peer.rs:166:28 [INFO] [stderr] | [INFO] [stderr] 166 | fn parse_peer_status(line: &String) -> Result, GlusterError> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | / match self { [INFO] [stderr] 220 | | &ScrubAggression::Aggressive => "aggressive".to_string(), [INFO] [stderr] 221 | | &ScrubAggression::Lazy => "lazy".to_string(), [INFO] [stderr] 222 | | &ScrubAggression::Normal => "normal".to_string(), [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 219 | match *self { [INFO] [stderr] 220 | ScrubAggression::Aggressive => "aggressive".to_string(), [INFO] [stderr] 221 | ScrubAggression::Lazy => "lazy".to_string(), [INFO] [stderr] 222 | ScrubAggression::Normal => "normal".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / pub fn from_str(s: &str) -> ScrubAggression { [INFO] [stderr] 226 | | match s { [INFO] [stderr] 227 | | "aggressive" => ScrubAggression::Aggressive, [INFO] [stderr] 228 | | "lazy" => ScrubAggression::Lazy, [INFO] [stderr] ... | [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | / match self { [INFO] [stderr] 245 | | &ScrubControl::Pause => "pause".to_string(), [INFO] [stderr] 246 | | &ScrubControl::Resume => "resume".to_string(), [INFO] [stderr] 247 | | &ScrubControl::Status => "status".to_string(), [INFO] [stderr] 248 | | &ScrubControl::OnDemand => "ondemand".to_string(), [INFO] [stderr] 249 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | match *self { [INFO] [stderr] 245 | ScrubControl::Pause => "pause".to_string(), [INFO] [stderr] 246 | ScrubControl::Resume => "resume".to_string(), [INFO] [stderr] 247 | ScrubControl::Status => "status".to_string(), [INFO] [stderr] 248 | ScrubControl::OnDemand => "ondemand".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | / match self { [INFO] [stderr] 275 | | &BitrotOption::ScrubThrottle(_) => "scrub-throttle".to_string(), [INFO] [stderr] 276 | | &BitrotOption::ScrubFrequency(_) => "scrub-frequency".to_string(), [INFO] [stderr] 277 | | &BitrotOption::Scrub(_) => "scrub".to_string(), [INFO] [stderr] 278 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 274 | match *self { [INFO] [stderr] 275 | BitrotOption::ScrubThrottle(_) => "scrub-throttle".to_string(), [INFO] [stderr] 276 | BitrotOption::ScrubFrequency(_) => "scrub-frequency".to_string(), [INFO] [stderr] 277 | BitrotOption::Scrub(_) => "scrub".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | / match self { [INFO] [stderr] 282 | | &BitrotOption::ScrubThrottle(ref val) => val.to_string(), [INFO] [stderr] 283 | | &BitrotOption::ScrubFrequency(ref val) => val.to_string(), [INFO] [stderr] 284 | | &BitrotOption::Scrub(ref val) => val.to_string(), [INFO] [stderr] 285 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 281 | match *self { [INFO] [stderr] 282 | BitrotOption::ScrubThrottle(ref val) => val.to_string(), [INFO] [stderr] 283 | BitrotOption::ScrubFrequency(ref val) => val.to_string(), [INFO] [stderr] 284 | BitrotOption::Scrub(ref val) => val.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/peer.rs:175:45 [INFO] [stderr] | [INFO] [stderr] 175 | let hostname = cap.name("hostname").ok_or(GlusterError::new(format!( [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 176 | | "Invalid hostname for peer: {}", [INFO] [stderr] 177 | | line [INFO] [stderr] 178 | | )))?; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | let hostname = cap.name("hostname").ok_or_else(|| GlusterError::new(format!( [INFO] [stderr] 176 | "Invalid hostname for peer: {}", [INFO] [stderr] 177 | line [INFO] [stderr] 178 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/peer.rs:180:37 [INFO] [stderr] | [INFO] [stderr] 180 | let uuid = cap.name("uuid").ok_or(GlusterError::new(format!( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 181 | | "Invalid uuid for peer: {}", [INFO] [stderr] 182 | | line [INFO] [stderr] 183 | | )))?; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 180 | let uuid = cap.name("uuid").ok_or_else(|| GlusterError::new(format!( [INFO] [stderr] 181 | "Invalid uuid for peer: {}", [INFO] [stderr] 182 | line [INFO] [stderr] 183 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/peer.rs:185:54 [INFO] [stderr] | [INFO] [stderr] 185 | let state_details = cap.name("state_detail").ok_or(GlusterError::new(format!( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 186 | | "Invalid state for peer: {}", [INFO] [stderr] 187 | | line [INFO] [stderr] 188 | | )))?; [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 185 | let state_details = cap.name("state_detail").ok_or_else(|| GlusterError::new(format!( [INFO] [stderr] 186 | "Invalid state for peer: {}", [INFO] [stderr] 187 | line [INFO] [stderr] 188 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:449:9 [INFO] [stderr] | [INFO] [stderr] 449 | / match self { [INFO] [stderr] 450 | | &GlusterOption::AuthAllow(_) => "auth.allow".to_string(), [INFO] [stderr] 451 | | &GlusterOption::AuthReject(_) => "auth.reject".to_string(), [INFO] [stderr] 452 | | &GlusterOption::ClientGraceTimeout(_) => "client.grace-timeout".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 534 | | } [INFO] [stderr] 535 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 449 | match *self { [INFO] [stderr] 450 | GlusterOption::AuthAllow(_) => "auth.allow".to_string(), [INFO] [stderr] 451 | GlusterOption::AuthReject(_) => "auth.reject".to_string(), [INFO] [stderr] 452 | GlusterOption::ClientGraceTimeout(_) => "client.grace-timeout".to_string(), [INFO] [stderr] 453 | GlusterOption::ClientSsl(_) => "client.ssl".to_string(), [INFO] [stderr] 454 | GlusterOption::ClusterSelfHealWindowSize(_) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:538:9 [INFO] [stderr] | [INFO] [stderr] 538 | / match self { [INFO] [stderr] 539 | | &GlusterOption::AuthAllow(ref val) => val.to_string(), [INFO] [stderr] 540 | | &GlusterOption::AuthReject(ref val) => val.to_string(), [INFO] [stderr] 541 | | &GlusterOption::ClientGraceTimeout(val) => val.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 593 | | &GlusterOption::StorageHealthCheckInterval(val) => val.to_string(), [INFO] [stderr] 594 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 538 | match *self { [INFO] [stderr] 539 | GlusterOption::AuthAllow(ref val) => val.to_string(), [INFO] [stderr] 540 | GlusterOption::AuthReject(ref val) => val.to_string(), [INFO] [stderr] 541 | GlusterOption::ClientGraceTimeout(val) => val.to_string(), [INFO] [stderr] 542 | GlusterOption::ClientSsl(ref val) => val.to_string(), [INFO] [stderr] 543 | GlusterOption::ClusterSelfHealWindowSize(val) => val.to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/peer.rs:292:29 [INFO] [stderr] | [INFO] [stderr] 292 | pub fn peer_probe(hostname: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/peer.rs:312:30 [INFO] [stderr] | [INFO] [stderr] 312 | pub fn peer_remove(hostname: &String, force: bool) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:946:15 [INFO] [stderr] | [INFO] [stderr] 946 | arg_list: &Vec, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rpc.rs:533:29 [INFO] [stderr] | [INFO] [stderr] 533 | fn pack_string(s: &String, buffer: &mut T) -> Result<(), super::GlusterError> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:1046:60 [INFO] [stderr] | [INFO] [stderr] 1046 | let trimmed = output_str.trim().trim_right_matches("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1121:30 [INFO] [stderr] | [INFO] [stderr] 1121 | let bricks: Vec = vol_info [INFO] [stderr] | ______________________________^ [INFO] [stderr] 1122 | | .bricks [INFO] [stderr] 1123 | | .iter() [INFO] [stderr] 1124 | | .filter(|brick| brick.peer.hostname == local_ip) [INFO] [stderr] 1125 | | .map(|brick| brick.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 1121 | let bricks: Vec = vol_info [INFO] [stderr] 1122 | .bricks [INFO] [stderr] 1123 | .iter() [INFO] [stderr] 1124 | .filter(|brick| brick.peer.hostname == local_ip).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gluster`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rpc.rs:1249:15 [INFO] [stderr] | [INFO] [stderr] 1249 | fragment: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rpc.rs:1284:50 [INFO] [stderr] | [INFO] [stderr] 1284 | pub fn sendrecord(sock: &mut UnixStream, record: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rpc.rs:1291:29 [INFO] [stderr] | [INFO] [stderr] 1291 | pub fn print_fragment(frag: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rpc.rs:1326:47 [INFO] [stderr] | [INFO] [stderr] 1326 | let mut handle = socket.by_ref().take(n as u64); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/rpc.rs:1328:13 [INFO] [stderr] | [INFO] [stderr] 1328 | n = n - n; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rpc.rs:1456:8 [INFO] [stderr] | [INFO] [stderr] 1456 | if dict.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dict.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/volume.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/volume.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/volume.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / pub fn from_str(vol_type: &str) -> VolumeType { [INFO] [stderr] 167 | | match vol_type { [INFO] [stderr] 168 | | "Arbiter" => VolumeType::Arbiter, [INFO] [stderr] 169 | | "Distribute" => VolumeType::Distribute, [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/volume.rs:184:22 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:498:36 [INFO] [stderr] | [INFO] [stderr] 498 | transport = line.split("=").collect::>()[1].to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/volume.rs:564:21 [INFO] [stderr] | [INFO] [stderr] 564 | let ref name = parts[0]; [INFO] [stderr] | ----^^^^^^^^------------ help: try: `let name = &parts[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/volume.rs:565:21 [INFO] [stderr] | [INFO] [stderr] 565 | let ref value = parts[1]; [INFO] [stderr] | ----^^^^^^^^^------------ help: try: `let value = &parts[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/volume.rs:590:21 [INFO] [stderr] | [INFO] [stderr] 590 | let ref value = parts[1]; [INFO] [stderr] | ----^^^^^^^^^------------ help: try: `let value = &parts[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:593:58 [INFO] [stderr] | [INFO] [stderr] 593 | let brick_parts: Vec<&str> = value.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:873:29 [INFO] [stderr] | [INFO] [stderr] 873 | if line.starts_with(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:876:29 [INFO] [stderr] | [INFO] [stderr] 876 | if line.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:880:43 [INFO] [stderr] | [INFO] [stderr] 880 | let parts: Vec<&str> = line.split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/volume.rs:1081:29 [INFO] [stderr] | [INFO] [stderr] 1081 | if line.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/volume.rs:1088:9 [INFO] [stderr] | [INFO] [stderr] 1088 | / match brick_regex.captures(&line) { [INFO] [stderr] 1089 | | Some(result) => { [INFO] [stderr] 1090 | | let tcp_port = match result.name("tcp") { [INFO] [stderr] 1091 | | Some(port) => port, [INFO] [stderr] ... | [INFO] [stderr] 1127 | | None => {} [INFO] [stderr] 1128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1088 | if let Some(result) = brick_regex.captures(&line) { [INFO] [stderr] 1089 | let tcp_port = match result.name("tcp") { [INFO] [stderr] 1090 | Some(port) => port, [INFO] [stderr] 1091 | None => { [INFO] [stderr] 1092 | return Err(GlusterError::new( [INFO] [stderr] 1093 | "Unable to find tcp port in gluster vol \ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/volume.rs:1337:8 [INFO] [stderr] | [INFO] [stderr] 1337 | if error_list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!error_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &SelfHealAlgorithm::Full => "full".to_string(), [INFO] [stderr] 67 | | &SelfHealAlgorithm::Diff => "diff".to_string(), [INFO] [stderr] 68 | | &SelfHealAlgorithm::Reset => "reset".to_string(), [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | SelfHealAlgorithm::Full => "full".to_string(), [INFO] [stderr] 67 | SelfHealAlgorithm::Diff => "diff".to_string(), [INFO] [stderr] 68 | SelfHealAlgorithm::Reset => "reset".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self { [INFO] [stderr] 92 | | &SplitBrainPolicy::Ctime => "ctime".to_string(), [INFO] [stderr] 93 | | &SplitBrainPolicy::Disable => "none".to_string(), [INFO] [stderr] 94 | | &SplitBrainPolicy::Majority => "majority".to_string(), [INFO] [stderr] 95 | | &SplitBrainPolicy::Mtime => "mtime".to_string(), [INFO] [stderr] 96 | | &SplitBrainPolicy::Size => "size".to_string(), [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *self { [INFO] [stderr] 92 | SplitBrainPolicy::Ctime => "ctime".to_string(), [INFO] [stderr] 93 | SplitBrainPolicy::Disable => "none".to_string(), [INFO] [stderr] 94 | SplitBrainPolicy::Majority => "majority".to_string(), [INFO] [stderr] 95 | SplitBrainPolicy::Mtime => "mtime".to_string(), [INFO] [stderr] 96 | SplitBrainPolicy::Size => "size".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 100 | | match s { [INFO] [stderr] 101 | | "ctime" => Ok(SplitBrainPolicy::Ctime), [INFO] [stderr] 102 | | "none" => Ok(SplitBrainPolicy::Disable), [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / match self { [INFO] [stderr] 130 | | &AccessMode::ReadOnly => "read-only".to_string(), [INFO] [stderr] 131 | | &AccessMode::ReadWrite => "read-write".to_string(), [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 129 | match *self { [INFO] [stderr] 130 | AccessMode::ReadOnly => "read-only".to_string(), [INFO] [stderr] 131 | AccessMode::ReadWrite => "read-write".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn from_str(s: &str) -> AccessMode { [INFO] [stderr] 135 | | match s { [INFO] [stderr] 136 | | "read-only" => AccessMode::ReadOnly, [INFO] [stderr] 137 | | "read-write" => AccessMode::ReadWrite, [INFO] [stderr] 138 | | _ => AccessMode::ReadWrite, [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / match self { [INFO] [stderr] 169 | | &Toggle::On => "On".to_string(), [INFO] [stderr] 170 | | &Toggle::Off => "Off".to_string(), [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 168 | match *self { [INFO] [stderr] 169 | Toggle::On => "On".to_string(), [INFO] [stderr] 170 | Toggle::Off => "Off".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn from_str(s: &str) -> Toggle { [INFO] [stderr] 174 | | match s { [INFO] [stderr] 175 | | "on" => Toggle::On, [INFO] [stderr] 176 | | "off" => Toggle::Off, [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | / match self { [INFO] [stderr] 194 | | &ScrubSchedule::Hourly => "hourly".to_string(), [INFO] [stderr] 195 | | &ScrubSchedule::Daily => "daily".to_string(), [INFO] [stderr] 196 | | &ScrubSchedule::Weekly => "weekly".to_string(), [INFO] [stderr] 197 | | &ScrubSchedule::BiWeekly => "biweekly".to_string(), [INFO] [stderr] 198 | | &ScrubSchedule::Monthly => "monthly".to_string(), [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 193 | match *self { [INFO] [stderr] 194 | ScrubSchedule::Hourly => "hourly".to_string(), [INFO] [stderr] 195 | ScrubSchedule::Daily => "daily".to_string(), [INFO] [stderr] 196 | ScrubSchedule::Weekly => "weekly".to_string(), [INFO] [stderr] 197 | ScrubSchedule::BiWeekly => "biweekly".to_string(), [INFO] [stderr] 198 | ScrubSchedule::Monthly => "monthly".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | / pub fn from_str(s: &str) -> ScrubSchedule { [INFO] [stderr] 202 | | match s { [INFO] [stderr] 203 | | "hourly" => ScrubSchedule::Hourly, [INFO] [stderr] 204 | | "daily" => ScrubSchedule::Daily, [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | / match self { [INFO] [stderr] 220 | | &ScrubAggression::Aggressive => "aggressive".to_string(), [INFO] [stderr] 221 | | &ScrubAggression::Lazy => "lazy".to_string(), [INFO] [stderr] 222 | | &ScrubAggression::Normal => "normal".to_string(), [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 219 | match *self { [INFO] [stderr] 220 | ScrubAggression::Aggressive => "aggressive".to_string(), [INFO] [stderr] 221 | ScrubAggression::Lazy => "lazy".to_string(), [INFO] [stderr] 222 | ScrubAggression::Normal => "normal".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / pub fn from_str(s: &str) -> ScrubAggression { [INFO] [stderr] 226 | | match s { [INFO] [stderr] 227 | | "aggressive" => ScrubAggression::Aggressive, [INFO] [stderr] 228 | | "lazy" => ScrubAggression::Lazy, [INFO] [stderr] ... | [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | / match self { [INFO] [stderr] 245 | | &ScrubControl::Pause => "pause".to_string(), [INFO] [stderr] 246 | | &ScrubControl::Resume => "resume".to_string(), [INFO] [stderr] 247 | | &ScrubControl::Status => "status".to_string(), [INFO] [stderr] 248 | | &ScrubControl::OnDemand => "ondemand".to_string(), [INFO] [stderr] 249 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | match *self { [INFO] [stderr] 245 | ScrubControl::Pause => "pause".to_string(), [INFO] [stderr] 246 | ScrubControl::Resume => "resume".to_string(), [INFO] [stderr] 247 | ScrubControl::Status => "status".to_string(), [INFO] [stderr] 248 | ScrubControl::OnDemand => "ondemand".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | / match self { [INFO] [stderr] 275 | | &BitrotOption::ScrubThrottle(_) => "scrub-throttle".to_string(), [INFO] [stderr] 276 | | &BitrotOption::ScrubFrequency(_) => "scrub-frequency".to_string(), [INFO] [stderr] 277 | | &BitrotOption::Scrub(_) => "scrub".to_string(), [INFO] [stderr] 278 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 274 | match *self { [INFO] [stderr] 275 | BitrotOption::ScrubThrottle(_) => "scrub-throttle".to_string(), [INFO] [stderr] 276 | BitrotOption::ScrubFrequency(_) => "scrub-frequency".to_string(), [INFO] [stderr] 277 | BitrotOption::Scrub(_) => "scrub".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | / match self { [INFO] [stderr] 282 | | &BitrotOption::ScrubThrottle(ref val) => val.to_string(), [INFO] [stderr] 283 | | &BitrotOption::ScrubFrequency(ref val) => val.to_string(), [INFO] [stderr] 284 | | &BitrotOption::Scrub(ref val) => val.to_string(), [INFO] [stderr] 285 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 281 | match *self { [INFO] [stderr] 282 | BitrotOption::ScrubThrottle(ref val) => val.to_string(), [INFO] [stderr] 283 | BitrotOption::ScrubFrequency(ref val) => val.to_string(), [INFO] [stderr] 284 | BitrotOption::Scrub(ref val) => val.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:449:9 [INFO] [stderr] | [INFO] [stderr] 449 | / match self { [INFO] [stderr] 450 | | &GlusterOption::AuthAllow(_) => "auth.allow".to_string(), [INFO] [stderr] 451 | | &GlusterOption::AuthReject(_) => "auth.reject".to_string(), [INFO] [stderr] 452 | | &GlusterOption::ClientGraceTimeout(_) => "client.grace-timeout".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 534 | | } [INFO] [stderr] 535 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 449 | match *self { [INFO] [stderr] 450 | GlusterOption::AuthAllow(_) => "auth.allow".to_string(), [INFO] [stderr] 451 | GlusterOption::AuthReject(_) => "auth.reject".to_string(), [INFO] [stderr] 452 | GlusterOption::ClientGraceTimeout(_) => "client.grace-timeout".to_string(), [INFO] [stderr] 453 | GlusterOption::ClientSsl(_) => "client.ssl".to_string(), [INFO] [stderr] 454 | GlusterOption::ClusterSelfHealWindowSize(_) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:538:9 [INFO] [stderr] | [INFO] [stderr] 538 | / match self { [INFO] [stderr] 539 | | &GlusterOption::AuthAllow(ref val) => val.to_string(), [INFO] [stderr] 540 | | &GlusterOption::AuthReject(ref val) => val.to_string(), [INFO] [stderr] 541 | | &GlusterOption::ClientGraceTimeout(val) => val.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 593 | | &GlusterOption::StorageHealthCheckInterval(val) => val.to_string(), [INFO] [stderr] 594 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 538 | match *self { [INFO] [stderr] 539 | GlusterOption::AuthAllow(ref val) => val.to_string(), [INFO] [stderr] 540 | GlusterOption::AuthReject(ref val) => val.to_string(), [INFO] [stderr] 541 | GlusterOption::ClientGraceTimeout(val) => val.to_string(), [INFO] [stderr] 542 | GlusterOption::ClientSsl(ref val) => val.to_string(), [INFO] [stderr] 543 | GlusterOption::ClusterSelfHealWindowSize(val) => val.to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:946:15 [INFO] [stderr] | [INFO] [stderr] 946 | arg_list: &Vec, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:1046:60 [INFO] [stderr] | [INFO] [stderr] 1046 | let trimmed = output_str.trim().trim_right_matches("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1121:30 [INFO] [stderr] | [INFO] [stderr] 1121 | let bricks: Vec = vol_info [INFO] [stderr] | ______________________________^ [INFO] [stderr] 1122 | | .bricks [INFO] [stderr] 1123 | | .iter() [INFO] [stderr] 1124 | | .filter(|brick| brick.peer.hostname == local_ip) [INFO] [stderr] 1125 | | .map(|brick| brick.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 1121 | let bricks: Vec = vol_info [INFO] [stderr] 1122 | .bricks [INFO] [stderr] 1123 | .iter() [INFO] [stderr] 1124 | .filter(|brick| brick.peer.hostname == local_ip).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gluster`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a2d48a006ce18c320ddfcb6d5680515a33a74ab9aa011aef2958bcfa7a225d54"` [INFO] running `"docker" "rm" "-f" "a2d48a006ce18c320ddfcb6d5680515a33a74ab9aa011aef2958bcfa7a225d54"` [INFO] [stdout] a2d48a006ce18c320ddfcb6d5680515a33a74ab9aa011aef2958bcfa7a225d54